169092 2017-03-02 13:03:19 -0800 Fix addressing mode for B3WasmAddress 2017-03-02 13:20:58 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keith_miller keith_miller commit-queue mark.lam msaboff saam oldest_to_newest 1282846 0 keith_miller 2017-03-02 13:03:19 -0800 Fix addressing mode for B3WasmAddress 1282849 1 303228 keith_miller 2017-03-02 13:14:21 -0800 Created attachment 303228 Patch 1282850 2 303228 mark.lam 2017-03-02 13:15:39 -0800 Comment on attachment 303228 Patch r=me 1282851 3 303228 fpizlo 2017-03-02 13:17:16 -0800 Comment on attachment 303228 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303228&action=review > Source/JavaScriptCore/ChangeLog:11 > + Fix the potential addressing modes for B3WasmAddress. ARM does not > + support a base + index*1 + offset addressing mode. I think when I > + read it the first time I assumed it would always work on both ARM > + and X86. While true for X86 it's not true for ARM. ARM totally supports base + index*1. 1282853 4 303228 fpizlo 2017-03-02 13:18:02 -0800 Comment on attachment 303228 Patch I get it now. 1282855 5 keith_miller 2017-03-02 13:20:58 -0800 Committed r213299: <http://trac.webkit.org/changeset/213299> 303228 2017-03-02 13:14:21 -0800 2017-03-02 13:18:02 -0800 Patch bug-169092-20170302131420.patch text/plain 1769 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzMjAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 MDQyNDM1NzEwZDliYjYxNDUxZDE4OWIzNzY5ZmU1YzRmZGMwYTUzLi5jYjU2MjJlMjY0MjNlM2Yw OTdmNzQ4OTc0N2QzM2U5ZmUzNzlhZGNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNy0wMy0wMiAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBGaXggYWRkcmVzc2luZyBtb2RlIGZvciBCM1dhc21BZGRyZXNzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjkwOTIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggdGhlIHBv dGVudGlhbCBhZGRyZXNzaW5nIG1vZGVzIGZvciBCM1dhc21BZGRyZXNzLiBBUk0gZG9lcyBub3QK KyAgICAgICAgc3VwcG9ydCBhIGJhc2UgKyBpbmRleCoxICsgb2Zmc2V0IGFkZHJlc3NpbmcgbW9k ZS4gSSB0aGluayB3aGVuIEkKKyAgICAgICAgcmVhZCBpdCB0aGUgZmlyc3QgdGltZSBJIGFzc3Vt ZWQgaXQgd291bGQgYWx3YXlzIHdvcmsgb24gYm90aCBBUk0KKyAgICAgICAgYW5kIFg4Ni4gV2hp bGUgdHJ1ZSBmb3IgWDg2IGl0J3Mgbm90IHRydWUgZm9yIEFSTS4KKworICAgICAgICAqIGIzL0Iz TG93ZXJUb0Fpci5jcHA6CisgICAgICAgIChKU0M6OkIzOjpBaXI6Okxvd2VyVG9BaXI6OmVmZmVj dGl2ZUFkZHIpOgorCiAyMDE3LTAyLTI4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4K IAogICAgICAgICBFbmFibGUgdGhlIFNpZ2lsbENyYXNoQW5hbHl6ZXIgYnkgZGVmYXVsdCBmb3Ig aU9TLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL0IzTG93ZXJUb0Fpci5j cHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvQjNMb3dlclRvQWlyLmNwcAppbmRleCA1MTdk MDg4NDhkZmFiOGNkNWIxYzBhOWU3OWZjZmFlNjZiZjIwZDllLi41Y2JjYzk3ZDRiYzljYmZjNDU1 MjQ4MjZiNThmZjZlN2U0MmQwYTM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv YjMvQjNMb3dlclRvQWlyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvQjNMb3dl clRvQWlyLmNwcApAQCAtNTEyLDggKzUxMiw3IEBAIHByaXZhdGU6CiAgICAgICAgIGNhc2UgV2Fz bUFkZHJlc3M6IHsKICAgICAgICAgICAgIFdhc21BZGRyZXNzVmFsdWUqIHdhc21BZGRyZXNzID0g YWRkcmVzcy0+YXM8V2FzbUFkZHJlc3NWYWx1ZT4oKTsKICAgICAgICAgICAgIFZhbHVlKiBwb2lu dGVyID0gd2FzbUFkZHJlc3MtPmNoaWxkKDApOwotICAgICAgICAgICAgQVNTRVJUKEFyZzo6aXNW YWxpZEluZGV4Rm9ybSgxLCBvZmZzZXQsIHdpZHRoKSk7Ci0gICAgICAgICAgICBpZiAobV9sb2Nr ZWQuY29udGFpbnMocG9pbnRlcikpCisgICAgICAgICAgICBpZiAoIUFyZzo6aXNWYWxpZEluZGV4 Rm9ybSgxLCBvZmZzZXQsIHdpZHRoKSB8fCBtX2xvY2tlZC5jb250YWlucyhwb2ludGVyKSkKICAg ICAgICAgICAgICAgICByZXR1cm4gZmFsbGJhY2soKTsKIAogICAgICAgICAgICAgLy8gRklYTUU6 IFdlIHNob3VsZCBzdXBwb3J0IEFSTTY0IExEUiAzMi1iaXQgYWRkcmVzc2luZywgd2hpY2ggd2ls bAo=