16908 2008-01-17 11:27:03 -0800 run-webkit-tests complains about missing FindSafari.exe 2008-01-17 11:52:03 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 ap ap aroben oldest_to_newest 67502 0 ap 2008-01-17 11:27:03 -0800 When in debug configuration, webkitdirs.pm should use FindSafari_debug.exe, Patch forthcoming. 67504 1 18505 ap 2008-01-17 11:30:12 -0800 Created attachment 18505 proposed fix 67507 2 18505 aroben 2008-01-17 11:46:17 -0800 Comment on attachment 18505 proposed fix r=me I think overall it would be better to make FindSafari.vcproj only have one build configuration, and to never put the suffix on the filename. 67509 3 ap 2008-01-17 11:52:03 -0800 Committed revision 29589. > I think overall it would be better to make FindSafari.vcproj only have one > build configuration, and to never put the suffix on the filename. I agree, but not enthusiastically enough to think it through and make a new fix :-) 18505 2008-01-17 11:30:12 -0800 2008-01-17 11:46:17 -0800 proposed fix FindSafari.txt text/plain 1360 ap SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI5NTg3KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDgtMDEtMTcgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2OTA4 CisgICAgICAgIHJ1bi13ZWJraXQtdGVzdHMgY29tcGxhaW5zIGFib3V0IG1pc3NpbmcgRmluZFNh ZmFyaS5leGUKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbTogQXBwZW5kIF9kZWJ1 ZyBhcyBhcHByb3ByaWF0ZS4KKwogMjAwOC0wMS0xNyAgU3RldmUgRmFsa2VuYnVyZyAgPHNmYWxr ZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlLWFkZCBERUJVR19XRUJLSVRfSEFTX1NVRkZJWC4K SW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHJldmlzaW9uIDI5NTM2KQorKysgV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCSh3b3JraW5nIGNvcHkpCkBAIC0zMTUsNyAr MzE1LDExIEBAIHN1YiBpbnN0YWxsZWRTYWZhcmlQYXRoCiAgICAgaWYgKGlzT1NYKCkpIHsKICAg ICAgICAgJHNhZmFyaUJ1bmRsZSA9ICIvQXBwbGljYXRpb25zL1NhZmFyaS5hcHAiOwogICAgIH0g ZWxzaWYgKGlzQ3lnd2luKCkpIHsKLSAgICAgICAgJHNhZmFyaUJ1bmRsZSA9IGAiJGNvbmZpZ3Vy YXRpb25Qcm9kdWN0RGlyL0ZpbmRTYWZhcmkuZXhlImA7CisgICAgICAgIG15ICRmaW5kU2FmYXJp TmFtZSA9ICJGaW5kU2FmYXJpIjsKKyAgICAgICAgJGZpbmRTYWZhcmlOYW1lIC49ICJfZGVidWci IGlmICRjb25maWd1cmF0aW9uIG5lICJSZWxlYXNlIjsKKyAgICAgICAgJGZpbmRTYWZhcmlOYW1l IC49ICIuZXhlIjsKKworICAgICAgICAkc2FmYXJpQnVuZGxlID0gYCIkY29uZmlndXJhdGlvblBy b2R1Y3REaXIvJGZpbmRTYWZhcmlOYW1lImA7CiAgICAgICAgICRzYWZhcmlCdW5kbGUgPX4gcy9b XHJcbl0rJC8vOwogICAgICAgICAkc2FmYXJpQnVuZGxlID0gYGN5Z3BhdGggLXUgJyRzYWZhcmlC dW5kbGUnYDsKICAgICAgICAgJHNhZmFyaUJ1bmRsZSA9fiBzL1tcclxuXSskLy87Cg==