169074 2017-03-02 04:00:02 -0800 Remote Inspector: Move updateTargetListing() methods to RemoteInspector.cpp 2017-03-02 22:48:54 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned bburg commit-queue inspector-bugzilla-changes joepeck keith_miller mark.lam msaboff saam oldest_to_newest 1282683 0 cgarcia 2017-03-02 04:00:02 -0800 They can be common. 1282684 1 303188 cgarcia 2017-03-02 04:02:24 -0800 Created attachment 303188 Patch 1283078 2 303188 joepeck 2017-03-02 20:50:02 -0800 Comment on attachment 303188 Patch r=me I apologize, I probably should have realized this when I added them recently. Or maybe I added these before this stuff landed in which case I didn't mess up! 1283099 3 cgarcia 2017-03-02 22:35:08 -0800 (In reply to comment #2) > Comment on attachment 303188 [details] > Patch > > r=me > > I apologize, I probably should have realized this when I added them > recently. Or maybe I added these before this stuff landed in which case I > didn't mess up! No problem, it's understandable, because right now Cocoa is the only implementation of the remote inspector, build would have broken if there were others. I'm close to finish an initial version of the GTK+ port implementation, so hopefully this will change soon. Thanks for the review. 1283100 4 303188 commit-queue 2017-03-02 22:48:49 -0800 Comment on attachment 303188 Patch Clearing flags on attachment: 303188 Committed r213356: <http://trac.webkit.org/changeset/213356> 1283101 5 commit-queue 2017-03-02 22:48:54 -0800 All reviewed patches have been landed. Closing bug. 303188 2017-03-02 04:02:24 -0800 2017-03-02 22:48:49 -0800 Patch remote-inspector.diff text/plain 3610 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDIwNzY3ZTAxM2MwLi45MzhkNTMwNTk4YSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTctMDMtMDIgIENhcmxv cyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFJlbW90ZSBJ bnNwZWN0b3I6IE1vdmUgdXBkYXRlVGFyZ2V0TGlzdGluZygpIG1ldGhvZHMgdG8gUmVtb3RlSW5z cGVjdG9yLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTY5MDc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhleSBhcmUgbm90IGFjdHVhbGx5IGNvY29hIHNwZWNpZmljLgorCisgICAgICAgICogaW5z cGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNwZWN0b3IuY3BwOgorICAgICAgICAoSW5zcGVjdG9yOjpS ZW1vdGVJbnNwZWN0b3I6OnVwZGF0ZVRhcmdldExpc3RpbmcpOgorICAgICAgICAqIGluc3BlY3Rv ci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yLmg6CisgICAgICAgICogaW5zcGVjdG9yL3JlbW90ZS9j b2NvYS9SZW1vdGVJbnNwZWN0b3JDb2NvYS5tbToKKwogMjAxNy0wMy0wMiAgVG9tYXMgUG9wZWxh ICA8dHBvcGVsYUByZWRoYXQuY29tPgogCiAgICAgICAgIEluY29ycmVjdCBSRUxFQVNFX0FTU0VS VCBpbiBKU0dsb2JhbE9iamVjdDo6YWRkU3RhdGljR2xvYmFscygpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNwZWN0b3IuY3BwIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yLmNw cAppbmRleCBhZjg4ZGMxM2UwMi4uODA5ZmY3MmNiMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3BlY3Rvci5jcHAKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yLmNwcApA QCAtMjA3LDYgKzIwNywyNiBAQCBUYXJnZXRMaXN0aW5nIFJlbW90ZUluc3BlY3Rvcjo6bGlzdGlu Z0ZvclRhcmdldChjb25zdCBSZW1vdGVDb250cm9sbGFibGVUYXJnZXQmCiAgICAgcmV0dXJuIG51 bGxwdHI7CiB9CiAKK3ZvaWQgUmVtb3RlSW5zcGVjdG9yOjp1cGRhdGVUYXJnZXRMaXN0aW5nKHVu c2lnbmVkIHRhcmdldElkZW50aWZpZXIpCit7CisgICAgYXV0byB0YXJnZXQgPSBtX3RhcmdldE1h cC5nZXQodGFyZ2V0SWRlbnRpZmllcik7CisgICAgaWYgKCF0YXJnZXQpCisgICAgICAgIHJldHVy bjsKKworICAgIHVwZGF0ZVRhcmdldExpc3RpbmcoKnRhcmdldCk7Cit9CisKK3ZvaWQgUmVtb3Rl SW5zcGVjdG9yOjp1cGRhdGVUYXJnZXRMaXN0aW5nKGNvbnN0IFJlbW90ZUNvbnRyb2xsYWJsZVRh cmdldCYgdGFyZ2V0KQoreworICAgIGF1dG8gdGFyZ2V0TGlzdGluZyA9IGxpc3RpbmdGb3JUYXJn ZXQodGFyZ2V0KTsKKyAgICBpZiAoIXRhcmdldExpc3RpbmcpCisgICAgICAgIHJldHVybjsKKwor ICAgIG1fdGFyZ2V0TGlzdGluZ01hcC5zZXQodGFyZ2V0LnRhcmdldElkZW50aWZpZXIoKSwgdGFy Z2V0TGlzdGluZyk7CisKKyAgICBwdXNoTGlzdGluZ3NTb29uKCk7Cit9CisKIHZvaWQgUmVtb3Rl SW5zcGVjdG9yOjp1cGRhdGVIYXNBY3RpdmVEZWJ1Z1Nlc3Npb24oKQogewogICAgIGJvb2wgaGFz QWN0aXZlRGVidWdnZXJTZXNzaW9uID0gIW1fdGFyZ2V0Q29ubmVjdGlvbk1hcC5pc0VtcHR5KCk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9SZW1v dGVJbnNwZWN0b3IuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1Jl bW90ZUluc3BlY3Rvci5oCmluZGV4IDUxMTg3ZjIzMjdmLi5iNWQwM2QzNjU5MyAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9y LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5z cGVjdG9yLmgKQEAgLTk0LDkgKzk0LDkgQEAgcHVibGljOgogICAgIFJldGFpblB0cjxDRkRhdGFS ZWY+IHBhcmVudFByb2Nlc3NBdWRpdERhdGEoKSBjb25zdCB7IHJldHVybiBtX3BhcmVudFByb2Nl c3NBdWRpdERhdGE7IH0KICAgICB2b2lkIHNldFBhcmVudFByb2Nlc3NJbmZvcm1hdGlvbihwaWRf dCwgUmV0YWluUHRyPENGRGF0YVJlZj4gYXVkaXREYXRhKTsKICAgICB2b2lkIHNldFBhcmVudFBy b2Nlc3NJbmZvbWF0aW9uSXNEZWxheWVkKCk7CisjZW5kaWYKIAogICAgIHZvaWQgdXBkYXRlVGFy Z2V0TGlzdGluZyh1bnNpZ25lZCB0YXJnZXRJZGVudGlmaWVyKTsKLSNlbmRpZgogCiBwcml2YXRl OgogICAgIFJlbW90ZUluc3BlY3RvcigpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2luc3BlY3Rvci9yZW1vdGUvY29jb2EvUmVtb3RlSW5zcGVjdG9yQ29jb2EubW0gYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9jb2NvYS9SZW1vdGVJbnNwZWN0b3JD b2NvYS5tbQppbmRleCAyNGU5Y2U1OGJkNi4uZDk3NjI0NjMxNTIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL2NvY29hL1JlbW90ZUluc3BlY3RvckNv Y29hLm1tCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL2NvY29h L1JlbW90ZUluc3BlY3RvckNvY29hLm1tCkBAIC00NDUsMjggKzQ0NSw2IEBAIHZvaWQgUmVtb3Rl SW5zcGVjdG9yOjpwdXNoTGlzdGluZ3NTb29uKCkKICAgICB9KTsKIH0KIAotI3ByYWdtYSBtYXJr IC0gVXBkYXRlIExpc3Rpbmcgd2l0aCBsb2NrCi0KLXZvaWQgUmVtb3RlSW5zcGVjdG9yOjp1cGRh dGVUYXJnZXRMaXN0aW5nKHVuc2lnbmVkIHRhcmdldElkZW50aWZpZXIpCi17Ci0gICAgYXV0byB0 YXJnZXQgPSBtX3RhcmdldE1hcC5nZXQodGFyZ2V0SWRlbnRpZmllcik7Ci0gICAgaWYgKCF0YXJn ZXQpCi0gICAgICAgIHJldHVybjsKLQotICAgIHVwZGF0ZVRhcmdldExpc3RpbmcoKnRhcmdldCk7 Ci19Ci0KLXZvaWQgUmVtb3RlSW5zcGVjdG9yOjp1cGRhdGVUYXJnZXRMaXN0aW5nKGNvbnN0IFJl bW90ZUNvbnRyb2xsYWJsZVRhcmdldCYgdGFyZ2V0KQotewotICAgIFJldGFpblB0cjxOU0RpY3Rp b25hcnk+IHRhcmdldExpc3RpbmcgPSBsaXN0aW5nRm9yVGFyZ2V0KHRhcmdldCk7Ci0gICAgaWYg KCF0YXJnZXRMaXN0aW5nKQotICAgICAgICByZXR1cm47Ci0KLSAgICBtX3RhcmdldExpc3RpbmdN YXAuc2V0KHRhcmdldC50YXJnZXRJZGVudGlmaWVyKCksIHRhcmdldExpc3RpbmcpOwotCi0gICAg cHVzaExpc3RpbmdzU29vbigpOwotfQotCiAjcHJhZ21hIG1hcmsgLSBSZWNlaXZlZCBYUEMgTWVz c2FnZXMKIAogdm9pZCBSZW1vdGVJbnNwZWN0b3I6OnJlY2VpdmVkU2V0dXBNZXNzYWdlKE5TRGlj dGlvbmFyeSAqdXNlckluZm8pCg==