16906 2008-01-17 06:45:12 -0800 [CURL] Crash below ResourceHandleManager::setupPOST when job->request().httpBody() is NULL 2008-03-15 07:19:02 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) PC Linux RESOLVED FIXED Curl P2 Normal --- 1 grzegorz.dabrowski jchaffraix zwarich oldest_to_newest 67482 0 grzegorz.dabrowski 2008-01-17 06:45:12 -0800 Sorry, I cannot add an URL for test case, because the page is from Intranet. Program received signal SIGSEGV, Segmentation fault. [Switching to Thread -1252783920 (LWP 29631)] Vector (this=0xbfaad424, other=@0x8) at ../JavaScriptCore/wtf/Vector.h:513 513 , m_impl(other.capacity()) Current language: auto; currently c++ (gdb) bt #0 Vector (this=0xbfaad424, other=@0x8) at ../JavaScriptCore/wtf/Vector.h:513 #1 0xb6421785 in WebCore::ResourceHandleManager::setupPOST (this=0x80d04a8, job=0x868c688, headers=0xbfaad54c) at ../WebCore/platform/network/curl/ResourceHandleManager.cpp:367 #2 0xb6422e45 in WebCore::ResourceHandleManager::startJob (this=0x80d04a8, job=0x868c688) at ../WebCore/platform/network/curl/ResourceHandleManager.cpp:575 #3 0xb6423704 in WebCore::ResourceHandleManager::startScheduledJobs (this=0x80d04a8) at ../WebCore/platform/network/curl/ResourceHandleManager.cpp:447 #4 0xb642453b in WebCore::ResourceHandleManager::downloadTimerCallback (this=0x80d04a8, timer=0x80d04a8) at ../WebCore/platform/network/curl/ResourceHandleManager.cpp:338 #5 0xb642481b in WebCore::Timer<WebCore::ResourceHandleManager>::fired (this=0x80d04a8) at ../WebCore/platform/Timer.h:98 #6 0xb631de54 in WebCore::TimerBase::fireTimers (fireTime=1200580262.381525, firingTimers=@0xbfaad97c) at ../WebCore/platform/Timer.cpp:336 #7 0xb631df5f in WebCore::TimerBase::sharedTimerFired () at ../WebCore/platform/Timer.cpp:357 #8 0xb64d119e in timeout_cb () at ../WebCore/platform/gtk/SharedTimerGtk.cpp:48 #9 0xb78bd8d6 in ?? () from /usr/lib/libglib-2.0.so.0 #10 0x00000000 in ?? () 67520 1 zwarich 2008-01-17 12:28:22 -0800 Can you reproduce this with the latest nightly build? It may have been fixed by r29542. 67524 2 grzegorz.dabrowski 2008-01-17 12:52:40 -0800 I was using at least r29554, so the problem still exists. 67577 3 mrowe 2008-01-17 23:02:04 -0800 This is unlikely to be a bug in Vector. Frame 0 in the backtrace is: #0 Vector (this=0xbfaad424, other=@0x8) at ../JavaScriptCore/wtf/Vector.h:513 which indicates a very low memory address, 0x8, is being passed to the copy constructor of Vector. Frame 1 in the backtrace is: #1 0xb6421785 in WebCore::ResourceHandleManager::setupPOST (this=0x80d04a8, job=0x868c688, headers=0xbfaad54c) at ../WebCore/platform/network/curl/ResourceHandleManager.cpp:367 Line 367 of ResourceHandleManager.cpp is the following: Vector<FormDataElement> elements = job->request().httpBody()->elements(); The httpBody() method of ResourceRequest returns a FormData*. If this return value is 0, then retrieving the m_elements member of it will result in a very small offset from 0, rather than a small offset from the address of the object. The bug here is either that job->request().httpBody() is returning 0, or that the code in setupPOST does not handle that case correctly. 67714 4 ddkilzer 2008-01-19 10:39:31 -0800 (In reply to comment #0) > Sorry, I cannot add an URL for test case, because the page is from Intranet. Can you post a reduced test case based on the original web page that reproduced the issue? Start by saving the web page "as source", then removing HTML and JavaScript until you're left with just enough of the original page to reproduce the bug. 67728 5 18545 grzegorz.dabrowski 2008-01-19 12:08:41 -0800 Created attachment 18545 Test case using jquery I've added a test case for this bug. It's not extracted from original Intranet page, but it has the same effect. 67782 6 18565 grzegorz.dabrowski 2008-01-20 10:10:19 -0800 Created attachment 18565 Simple test case I've added another test case without jquery. 73390 7 19680 jchaffraix 2008-03-11 15:42:48 -0700 Created attachment 19680 Add null checks for httpBody() Thanks for the 2 test cases ! 73446 8 zecke 2008-03-12 02:33:01 -0700 (In reply to comment #7) > Created an attachment (id=19680) [edit] > Add null checks for httpBody() > > Thanks for the 2 test cases ! > Yeah, you touched both cases. It would be appreciated if you could add the test cases to the LayoutTests and provide a result for it as well. It should be a simple if(layoutController) {layoutController.dumpAsText()} test result, there are many examples for crash fixes. We really need to get the regression test suite going for the Gtk+ port. 73759 9 19767 jchaffraix 2008-03-14 12:12:22 -0700 Created attachment 19767 Added test case Discussed with Zecke on IRC : Added the reduced test case for safety even thought LayoutTests/http/tests/xmlhttprequest/methods-async.html did reproduce the crash. 73821 10 19767 zecke 2008-03-15 07:18:10 -0700 Comment on attachment 19767 Added test case Thanks. 73822 11 zecke 2008-03-15 07:19:02 -0700 Landed in r31074. 18545 2008-01-19 12:08:41 -0800 2008-01-19 12:08:41 -0800 Test case using jquery ajax.html text/html 639 grzegorz.dabrowski PGh0bWw+CiAgICA8aGVhZD4KICAgICAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCIg c3JjPSJodHRwOi8vanF1ZXJ5anMuZ29vZ2xlY29kZS5jb20vZmlsZXMvanF1ZXJ5LTEuMi4yLmpz Ij48L3NjcmlwdD4KICAgICAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CiAgICAg ICAgICAgICQoZG9jdW1lbnQpLnJlYWR5KCBmdW5jdGlvbigpIHsKICAgICAgICAgICAgICAgICQu YWpheCh7CiAgICAgICAgICAgICAgICAgICAgLyogR0VUIHdvcmtzIGZpbmUgKi8KICAgICAgICAg ICAgICAgICAgICB0eXBlOiAiUE9TVCIsCiAgICAgICAgICAgICAgICAgICAgdXJsOiAiYW55cGFn ZWV2ZW5mYWtlLmh0bWwiLAogICAgICAgICAgICAgICAgICAgIHN1Y2Nlc3M6IGZ1bmN0aW9uKCkg ewogICAgICAgICAgICAgICAgICAgICAgICBhbGVydCgiT0siKTsKICAgICAgICAgICAgICAgICAg ICB9LAogICAgICAgICAgICAgICAgICAgIGVycm9yOiBmdW5jdGlvbigpIHsKICAgICAgICAgICAg ICAgICAgICAgICAgYWxlcnQoImVycm9yIik7CiAgICAgICAgICAgICAgICAgICAgfQogICAgICAg ICAgICAgICAgfSk7CgogICAgICAgICAgICB9ICk7CiAgICAgICAgPC9zY3JpcHQ+CiAgICA8L2hl YWQ+CjwvaHRtbD4K 18565 2008-01-20 10:10:19 -0800 2008-01-20 10:10:19 -0800 Simple test case ajax-simple.html text/html 194 grzegorz.dabrowski PGh0bWw+CiAgICA8aGVhZD4KICAgICAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+ CgkJdmFyIHhtbCA9IG5ldyBYTUxIdHRwUmVxdWVzdCgpOwoJCXhtbC5vcGVuKCJQT1NUIiwgImFu eXBhZ2VldmVuZmFrZS5odG1sIiwgdHJ1ZSk7CgkJeG1sLnNlbmQoKTsKICAgICAgICA8L3Njcmlw dD4KICAgIDwvaGVhZD4KPC9odG1sPgo= 19680 2008-03-11 15:42:48 -0700 2008-03-14 12:12:22 -0700 Add null checks for httpBody() bug16906-CL.patch text/plain 2091 jchaffraix ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NmU2OThjNS4uMWZmMWU3ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOC0wMy0xMSAgSnVsaWVuIENoYWZm cmFpeCAgPGp1bGllbi5jaGFmZnJhaXhAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDVVJMXSBDcmFzaCBiZWxvdyBSZXNvdXJjZUhh bmRsZU1hbmFnZXI6OnNldHVwUE9TVCB3aGVuIGpvYi0+cmVxdWVzdCgpLmh0dHBCb2R5KCkgaXMg TlVMTAorICAgICAgICBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjkw NgorCisgICAgICAgIEFkZCBudWxsIGNoZWNrcyBmb3IgaHR0cEJvZHkoKSB0byBtYXRjaCBvdGhl ciBwb3J0cy4KKworICAgICAgICBObyB0ZXN0IGNhc2UgYWRkZWQgYXMgd2UgYWxyZWFkeSBoYXZl IHNvbWUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVN YW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnJlYWRDYWxsYmFjayk6IEFkZCBudWxsIGNo ZWNrLgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGVNYW5hZ2VyOjpzZXR1cFBPU1Qp OiBEaXR0by4KKwogMjAwOC0wMy0xMCAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAK ICAgICAgICAgUGFydCBvZiBCdWcgMTcyMjQ6IERPTSBub2Rlcy9hdHRyaWJ1dGVzIHNob3VsZCBi ZSBlZGl0YWJsZQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVz b3VyY2VIYW5kbGVNYW5hZ2VyLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jl c291cmNlSGFuZGxlTWFuYWdlci5jcHAKaW5kZXggYjhmYTY5Ni4uZTlhNjMyYiAxMDA2NDQKLS0t IGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNw cAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZU1hbmFn ZXIuY3BwCkBAIC0yMTYsNyArMjE2LDEwIEBAIHNpemVfdCByZWFkQ2FsbGJhY2sodm9pZCogcHRy LCBzaXplX3Qgc2l6ZSwgc2l6ZV90IG5tZW1iLCB2b2lkKiBkYXRhKQogICAgIGlmICghdG9TZW5k KQogICAgICAgICByZXR1cm4gMDsKIAotICAgIFZlY3RvcjxGb3JtRGF0YUVsZW1lbnQ+IGVsZW1l bnRzID0gam9iLT5yZXF1ZXN0KCkuaHR0cEJvZHkoKS0+ZWxlbWVudHMoKTsKKyAgICBWZWN0b3I8 Rm9ybURhdGFFbGVtZW50PiBlbGVtZW50czsKKyAgICBpZiAoam9iLT5yZXF1ZXN0KCkuaHR0cEJv ZHkoKSkKKyAgICAgICAgZWxlbWVudHMgPSBqb2ItPnJlcXVlc3QoKS5odHRwQm9keSgpLT5lbGVt ZW50cygpOworCiAgICAgaWYgKGQtPm1fZm9ybURhdGFFbGVtZW50SW5kZXggPj0gZWxlbWVudHMu c2l6ZSgpKQogICAgICAgICByZXR1cm4gMDsKIApAQCAtMzc2LDcgKzM3OSwxMCBAQCB2b2lkIFJl c291cmNlSGFuZGxlTWFuYWdlcjo6c2V0dXBQVVQoUmVzb3VyY2VIYW5kbGUqLCBzdHJ1Y3QgY3Vy bF9zbGlzdCoqKQogdm9pZCBSZXNvdXJjZUhhbmRsZU1hbmFnZXI6OnNldHVwUE9TVChSZXNvdXJj ZUhhbmRsZSogam9iLCBzdHJ1Y3QgY3VybF9zbGlzdCoqIGhlYWRlcnMpCiB7CiAgICAgUmVzb3Vy Y2VIYW5kbGVJbnRlcm5hbCogZCA9IGpvYi0+Z2V0SW50ZXJuYWwoKTsKLSAgICBWZWN0b3I8Rm9y bURhdGFFbGVtZW50PiBlbGVtZW50cyA9IGpvYi0+cmVxdWVzdCgpLmh0dHBCb2R5KCktPmVsZW1l bnRzKCk7CisgICAgVmVjdG9yPEZvcm1EYXRhRWxlbWVudD4gZWxlbWVudHM7CisgICAgLy8gRml4 IGNyYXNoIHdoZW4gaHR0cEJvZHkgaXMgbnVsbCAoc2VlIGJ1ZyAjMTY5MDYpLgorICAgIGlmIChq b2ItPnJlcXVlc3QoKS5odHRwQm9keSgpKQorICAgICAgICBlbGVtZW50cyA9IGpvYi0+cmVxdWVz dCgpLmh0dHBCb2R5KCktPmVsZW1lbnRzKCk7CiAgICAgc2l6ZV90IG51bUVsZW1lbnRzID0gZWxl bWVudHMuc2l6ZSgpOwogCiAgICAgaWYgKCFudW1FbGVtZW50cykK 19767 2008-03-14 12:12:22 -0700 2008-03-15 07:18:10 -0700 Added test case bug16906-CL.patch text/plain 4380 jchaffraix ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxYzZkOWQ4Li4zZjgzMjYzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMDMt MTQgIEp1bGllbiBDaGFmZnJhaXggIDxqdWxpZW4uY2hhZmZyYWl4QGdtYWlsLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ1VSTF0gQ3Jhc2gg YmVsb3cgUmVzb3VyY2VIYW5kbGVNYW5hZ2VyOjpzZXR1cFBPU1Qgd2hlbiBqb2ItPnJlcXVlc3Qo KS5odHRwQm9keSgpIGlzIE5VTEwKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTY5MDYKKworICAgICAgICAqIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qv eG1saHR0cHJlcXVlc3QtcG9zdC1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QveG1saHR0cHJlcXVlc3QtcG9zdC1jcmFzaC5odG1s OiBBZGRlZC4KKwogMjAwOC0wMy0xMyAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWl0ei4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0 dHAvdGVzdHMveG1saHR0cHJlcXVlc3QveG1saHR0cHJlcXVlc3QtcG9zdC1jcmFzaC1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3htbGh0dHByZXF1 ZXN0LXBvc3QtY3Jhc2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAuLjJmODE0MWMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3Rz L3htbGh0dHByZXF1ZXN0L3htbGh0dHByZXF1ZXN0LXBvc3QtY3Jhc2gtZXhwZWN0ZWQudHh0CkBA IC0wLDAgKzEsNSBAQAorVGVzdCBjYXNlIGZvciBidWcgMTY5MDY6IFtDVVJMXSBDcmFzaCBiZWxv dyBSZXNvdXJjZUhhbmRsZU1hbmFnZXI6OnNldHVwUE9TVCB3aGVuIGpvYi0+cmVxdWVzdCgpLmh0 dHBCb2R5KCkgaXMgTlVMTAorCitUaGlzIHBhZ2Ugc2hvdWxkIG5vdCBjcmFzaCBhbmQgeW91IHNo b3VsZCBzZWUgUEFTUworCitQQVNTCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3Rz L3htbGh0dHByZXF1ZXN0L3htbGh0dHByZXF1ZXN0LXBvc3QtY3Jhc2guaHRtbCBiL0xheW91dFRl c3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QveG1saHR0cHJlcXVlc3QtcG9zdC1jcmFzaC5o dG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjcyMDBhZDMKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3htbGh0dHBy ZXF1ZXN0LXBvc3QtY3Jhc2guaHRtbApAQCAtMCwwICsxLDI5IEBACis8aHRtbD4KKzxoZWFkPgor PHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorCitpZiAod2luZG93LmxheW91dFRlc3RD b250cm9sbGVyKSB7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAg IGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKK30KKwordmFyIHhociA9IG5l dyBYTUxIdHRwUmVxdWVzdCgpOworCit4aHIub25yZWFkeXN0YXRlY2hhbmdlID0gZnVuY3Rpb24o KSB7CisgICAgaWYgKHhoci5yZWFkeVN0YXRlID09IDQpIHsKKyAgICAgICAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoInBhZ2UiKS50ZXh0Q29udGVudCA9ICJQQVNTIjsKKyAgICAgICAgaWYgKHdp bmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9s bGVyLm5vdGlmeURvbmUoKTsKKyAgICB9Cit9CisKK3hoci5vcGVuKCJQT1NUIiwgInJlc291cmNl cy8xMjUxLmh0bWwiLCB0cnVlKTsKK3hoci5zZW5kKG51bGwpOworPC9zY3JpcHQ+Cis8L2hlYWQ+ Cis8Ym9keT4KKzxwPiBUZXN0IGNhc2UgZm9yIDxhIGhyZWY9Imh0dHA6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2OTA2Ij5idWcgMTY5MDY8L2E+OiBbQ1VSTF0gQ3Jhc2ggYmVs b3cgUmVzb3VyY2VIYW5kbGVNYW5hZ2VyOjpzZXR1cFBPU1Qgd2hlbiBqb2ItPnJlcXVlc3QoKS5o dHRwQm9keSgpIGlzIE5VTEwgPC9wPgorPHA+IFRoaXMgcGFnZSBzaG91bGQgbm90IGNyYXNoIGFu ZCB5b3Ugc2hvdWxkIHNlZSBQQVNTPC9wPgorPGRpdiBpZD0icGFnZSIvPgorPC9ib2R5PgorPC9o dG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwpp bmRleCA0YTA2MjlhLi40OTE1NjJjIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDA4LTAzLTE0ICBKdWxpZW4g Q2hhZmZyYWl4ICA8anVsaWVuLmNoYWZmcmFpeEBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0NVUkxdIENyYXNoIGJlbG93IFJlc291 cmNlSGFuZGxlTWFuYWdlcjo6c2V0dXBQT1NUIHdoZW4gam9iLT5yZXF1ZXN0KCkuaHR0cEJvZHko KSBpcyBOVUxMCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE2OTA2CisKKyAgICAgICAgQWRkIG51bGwgY2hlY2tzIGZvciBodHRwQm9keSgpIHRvIG1hdGNo IG90aGVyIHBvcnRzLgorCisgICAgICAgIFRlc3Q6IGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qv eG1saHR0cHJlcXVlc3QtcG9zdC1jcmFzaC5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3 b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnJl YWRDYWxsYmFjayk6IEFkZCBudWxsIGNoZWNrLgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VI YW5kbGVNYW5hZ2VyOjpzZXR1cFBPU1QpOiBEaXR0by4KKwogMjAwOC0wMy0xMyAgRGFyaW4gQWRs ZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgKiBodG1sL1ByZWxvYWRTY2FubmVyLmg6 IENvcnJlY3RlZCBsaWNlbnNlLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHAKaW5kZXggYjhmYTY5Ni4uZTlhNjMyYiAx MDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVN YW5hZ2VyLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhh bmRsZU1hbmFnZXIuY3BwCkBAIC0yMTYsNyArMjE2LDEwIEBAIHNpemVfdCByZWFkQ2FsbGJhY2so dm9pZCogcHRyLCBzaXplX3Qgc2l6ZSwgc2l6ZV90IG5tZW1iLCB2b2lkKiBkYXRhKQogICAgIGlm ICghdG9TZW5kKQogICAgICAgICByZXR1cm4gMDsKIAotICAgIFZlY3RvcjxGb3JtRGF0YUVsZW1l bnQ+IGVsZW1lbnRzID0gam9iLT5yZXF1ZXN0KCkuaHR0cEJvZHkoKS0+ZWxlbWVudHMoKTsKKyAg ICBWZWN0b3I8Rm9ybURhdGFFbGVtZW50PiBlbGVtZW50czsKKyAgICBpZiAoam9iLT5yZXF1ZXN0 KCkuaHR0cEJvZHkoKSkKKyAgICAgICAgZWxlbWVudHMgPSBqb2ItPnJlcXVlc3QoKS5odHRwQm9k eSgpLT5lbGVtZW50cygpOworCiAgICAgaWYgKGQtPm1fZm9ybURhdGFFbGVtZW50SW5kZXggPj0g ZWxlbWVudHMuc2l6ZSgpKQogICAgICAgICByZXR1cm4gMDsKIApAQCAtMzc2LDcgKzM3OSwxMCBA QCB2b2lkIFJlc291cmNlSGFuZGxlTWFuYWdlcjo6c2V0dXBQVVQoUmVzb3VyY2VIYW5kbGUqLCBz dHJ1Y3QgY3VybF9zbGlzdCoqKQogdm9pZCBSZXNvdXJjZUhhbmRsZU1hbmFnZXI6OnNldHVwUE9T VChSZXNvdXJjZUhhbmRsZSogam9iLCBzdHJ1Y3QgY3VybF9zbGlzdCoqIGhlYWRlcnMpCiB7CiAg ICAgUmVzb3VyY2VIYW5kbGVJbnRlcm5hbCogZCA9IGpvYi0+Z2V0SW50ZXJuYWwoKTsKLSAgICBW ZWN0b3I8Rm9ybURhdGFFbGVtZW50PiBlbGVtZW50cyA9IGpvYi0+cmVxdWVzdCgpLmh0dHBCb2R5 KCktPmVsZW1lbnRzKCk7CisgICAgVmVjdG9yPEZvcm1EYXRhRWxlbWVudD4gZWxlbWVudHM7Cisg ICAgLy8gRml4IGNyYXNoIHdoZW4gaHR0cEJvZHkgaXMgbnVsbCAoc2VlIGJ1ZyAjMTY5MDYpLgor ICAgIGlmIChqb2ItPnJlcXVlc3QoKS5odHRwQm9keSgpKQorICAgICAgICBlbGVtZW50cyA9IGpv Yi0+cmVxdWVzdCgpLmh0dHBCb2R5KCktPmVsZW1lbnRzKCk7CiAgICAgc2l6ZV90IG51bUVsZW1l bnRzID0gZWxlbWVudHMuc2l6ZSgpOwogCiAgICAgaWYgKCFudW1FbGVtZW50cykK