169059 2017-03-01 14:36:38 -0800 Web Inspector: Annotators should not be enabled if the TextEditor is not visible 2017-03-01 15:58:55 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://webkit.org/ P2 Normal --- 1 hi hi commit-queue inspector-bugzilla-changes oldest_to_newest 1282456 0 hi 2017-03-01 14:36:38 -0800 ------- Inspected URL: https://webkit.org/ Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/604.1.8+ (KHTML, like Gecko) Uncaught Exceptions: - Annotators should not be enabled if the TextEditor is not visible (at SourceCodeTextEditor.js:2090:27) _basicBlockAnnotatorEnabled @ SourceCodeTextEditor.js:2090:27 _proceedPopulateWithContent @ SourceCodeTextEditor.js:471:17 _populateWithContent @ SourceCodeTextEditor.js:460:41 _contentAvailable @ SourceCodeTextEditor.js:548:34 _contentAvailable @ [native code] promiseReactionJob @ [native code] Additional Details: ------- * STEPS TO REPRODUCE 1. Navigate to a page with scripts 2. Open WebInspector 1282471 1 303126 hi 2017-03-01 14:47:43 -0800 Created attachment 303126 Patch 1282494 2 303126 joepeck 2017-03-01 15:12:33 -0800 Comment on attachment 303126 Patch r=me, sounds reasonable to me. 1282519 3 303126 commit-queue 2017-03-01 15:58:51 -0800 Comment on attachment 303126 Patch Clearing flags on attachment: 303126 Committed r213251: <http://trac.webkit.org/changeset/213251> 1282521 4 commit-queue 2017-03-01 15:58:55 -0800 All reviewed patches have been landed. Closing bug. 303126 2017-03-01 14:47:43 -0800 2017-03-01 15:58:51 -0800 Patch bug-169059-20170301144742.patch text/plain 2515 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGNhY2QwYWIwMjUwNjc3ZjUwZTZjZDk1NWVmNmYx N2Q5YTExNWUyNzUuLjNlNTgxMmI3NDgxN2FiZjQ1NjAyN2UxYjdjZjFkYWUxNmExZDc0ZTggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTAzLTAxICBEZXZp biBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IEFubm90YXRvcnMgc2hvdWxkIG5vdCBiZSBlbmFibGVkIGlmIHRoZSBUZXh0RWRpdG9y IGlzIG5vdCB2aXNpYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNjkwNTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRGVidWdnZXJTaWRlYmFyUGFuZWwuanM6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuRGVidWdnZXJTaWRlYmFyUGFuZWwucHJvdG90eXBlLl9hZGRS ZXNvdXJjZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRGVidWdnZXJTaWRlYmFyUGFuZWwucHJv dG90eXBlLl9hZGRTY3JpcHQpOgorICAgICAgICBPbmx5IGNhbGwgYHNob3dEZWZhdWx0Q29udGVu dFZpZXdGb3JUcmVlRWxlbWVudGAgaWYgdGhlIHBhbmVsIGhhcyBiZWVuIGFkZGVkIHRvIGEgc2lk ZWJhci4KKworICAgICAgICBJdCBpcyBub3QgdmFsaWQgdG8gc2ltcGx5IGNoZWNrIHdoZXRoZXIg dGhlIHBhbmVsIGlzIHZpc2libGUsIGFzIHRoZSBzaWRlYmFyIGNhbiBiZSBjb2xsYXBzZWQuCisg ICAgICAgIEluIHRoYXQgY2FzZSwgd2Ugc3RpbGwgd2FudCB0byBkaXNwbGF5IHRoZSBjb250ZW50 IHZpZXcsIHNvIHdlIGluc3RlYWQgY2hlY2sgdGhhdCB0aGUgcGFuZWwKKyAgICAgICAgaGFzIGJl ZW4gYWRkZWQgdG8gYSBzaWRlYmFyLCBtZWFuaW5nIHRoYXQgaXQgaXMgcmVhZHkgdG8gYmUgZGlz cGxheWVkIGluIHRoZSBjdXJyZW50IHRhYi4KKwogMjAxNy0wMi0yOCAgRGV2aW4gUm91c3NvICA8 ZGNyb3Vzc28rd2Via2l0QGdtYWlsLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSVEw6 IGV4cG9zZSB0aGUgTGF5b3V0IERpcmVjdGlvbiBzZXR0aW5nIGluIFByb2R1Y3Rpb24gYnVpbGRz LCBrZWVwIHVzaW5nIExUUiBieSBkZWZhdWx0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EZWJ1Z2dlclNpZGViYXJQYW5lbC5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVs LmpzCmluZGV4IGM2MzY1YThiYmNmYTQ5ZTc5ZDFhN2EyYWZiOGM3MDIwY2YzMDcyMjYuLjI3MzQ1 MjBhMTU0M2Y3ZWE3MDdiYzM0OTljZTVjYmJkZDAyODRlNWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVsLmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2Vy U2lkZWJhclBhbmVsLmpzCkBAIC00NjUsNyArNDY1LDcgQEAgV2ViSW5zcGVjdG9yLkRlYnVnZ2Vy U2lkZWJhclBhbmVsID0gY2xhc3MgRGVidWdnZXJTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXZWJJbnNw ZWMKICAgICAgICAgdGhpcy5fYWRkQnJlYWtwb2ludHNGb3JTb3VyY2VDb2RlKHJlc291cmNlKTsK ICAgICAgICAgdGhpcy5fYWRkSXNzdWVzRm9yU291cmNlQ29kZShyZXNvdXJjZSk7CiAKLSAgICAg ICAgaWYgKCF0aGlzLmNvbnRlbnRCcm93c2VyLmN1cnJlbnRDb250ZW50VmlldykKKyAgICAgICAg aWYgKHRoaXMucGFyZW50U2lkZWJhciAmJiAhdGhpcy5jb250ZW50QnJvd3Nlci5jdXJyZW50Q29u dGVudFZpZXcpCiAgICAgICAgICAgICB0aGlzLnNob3dEZWZhdWx0Q29udGVudFZpZXdGb3JUcmVl RWxlbWVudCh0cmVlRWxlbWVudCk7CiAgICAgfQogCkBAIC01NDAsNyArNTQwLDcgQEAgV2ViSW5z cGVjdG9yLkRlYnVnZ2VyU2lkZWJhclBhbmVsID0gY2xhc3MgRGVidWdnZXJTaWRlYmFyUGFuZWwg ZXh0ZW5kcyBXZWJJbnNwZWMKICAgICAgICAgdGhpcy5fYWRkQnJlYWtwb2ludHNGb3JTb3VyY2VD b2RlKHNjcmlwdCk7CiAgICAgICAgIHRoaXMuX2FkZElzc3Vlc0ZvclNvdXJjZUNvZGUoc2NyaXB0 KTsKIAotICAgICAgICBpZiAoIXRoaXMuY29udGVudEJyb3dzZXIuY3VycmVudENvbnRlbnRWaWV3 KQorICAgICAgICBpZiAodGhpcy5wYXJlbnRTaWRlYmFyICYmICF0aGlzLmNvbnRlbnRCcm93c2Vy LmN1cnJlbnRDb250ZW50VmlldykKICAgICAgICAgICAgIHRoaXMuc2hvd0RlZmF1bHRDb250ZW50 Vmlld0ZvclRyZWVFbGVtZW50KHRyZWVFbGVtZW50KTsKIAogICAgICAgICByZXR1cm4gdHJlZUVs ZW1lbnQ7Cg==