169047 2017-03-01 11:23:26 -0800 IsSmartPtr<WKRetainPtr<T>>::value should not be exported 2017-03-02 15:42:20 -0800 1 1 1 Unclassified WebKit WebKit2 Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue juergen mitz thorton oldest_to_newest 1282356 0 aakash_jain 2017-03-01 11:23:26 -0800 This symbol from UIProcess/API/cpp/WKRetainPtr.h is not used by other projects. No headers contains this symbol. We should not export this symbol. 1282360 1 303088 aakash_jain 2017-03-01 11:24:43 -0800 Created attachment 303088 Proposed patch 1282398 2 ap 2017-03-01 12:53:11 -0800 The reason why this is needed is that this header is a private one, used by WebKit tools. But I don't think that there is any reason to have the symbol exported. 1282936 3 303088 commit-queue 2017-03-02 15:42:16 -0800 Comment on attachment 303088 Proposed patch Clearing flags on attachment: 303088 Committed r213312: <http://trac.webkit.org/changeset/213312> 1282937 4 commit-queue 2017-03-02 15:42:20 -0800 All reviewed patches have been landed. Closing bug. 303088 2017-03-01 11:24:43 -0800 2017-03-02 15:42:16 -0800 Proposed patch patch_IsSmartPtr text/plain 1086 aakash_jain SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzIzMykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE3LTAzLTAxICBBYWthc2gg SmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBJc1NtYXJ0UHRyPFdLUmV0 YWluUHRyPFQ+Pjo6dmFsdWUgc2hvdWxkIG5vdCBiZSBleHBvcnRlZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY5MDQ3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2NwcC9XS1Jl dGFpblB0ci5oOgorCiAyMDE3LTAzLTAxICBKb24gTGVlICA8am9ubGVlQGFwcGxlLmNvbT4KIAog ICAgICAgICBVcGRhdGUgcGVlciBjb25uZWN0aW9uIHByZWZlcmVuY2UKSW5kZXg6IFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvY3BwL1dLUmV0YWluUHRyLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9jcHAvV0tSZXRhaW5QdHIuaAkocmV2aXNpb24gMjEz MjIzKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9jcHAvV0tSZXRhaW5QdHIuaAko d29ya2luZyBjb3B5KQpAQCAtMjYzLDcgKzI2Myw3IEBAIHVzaW5nIFdlYktpdDo6cmV0YWluV0s7 CiBuYW1lc3BhY2UgV1RGIHsKIAogdGVtcGxhdGUgPHR5cGVuYW1lIFQ+IHN0cnVjdCBJc1NtYXJ0 UHRyPFdLUmV0YWluUHRyPFQ+PiB7Ci0gICAgc3RhdGljIGNvbnN0IGJvb2wgdmFsdWUgPSB0cnVl OworICAgIFdURl9JTlRFUk5BTCBzdGF0aWMgY29uc3QgYm9vbCB2YWx1ZSA9IHRydWU7CiB9Owog CiB0ZW1wbGF0ZTx0eXBlbmFtZSBQPiBzdHJ1Y3QgRGVmYXVsdEhhc2g8V0tSZXRhaW5QdHI8UD4+ IHsK