169046 2017-03-01 11:04:45 -0800 Web Inspector: Option-clicking the close tab button should close all other tabs 2017-04-03 13:19:48 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg hi bburg commit-queue hi inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1282345 0 bburg 2017-03-01 11:04:45 -0800 Via Nelson Thachuk: """ * SUMMARY - Option-clicking the close tab button should close all other tabs * STEPS TO REPRODUCE 1. Launch Safari 2. Navigate to a webpage 3. Show Web Inspector (⌥⌘I) 4. Option-click the close tab button of any tab * EXPECTED RESULTS - All other tabs should close * ACTUAL RESULTS - Clicked tab closes """ 1282346 1 bburg 2017-03-01 11:05:29 -0800 <rdar://problem/30621679> 1290754 2 bburg 2017-03-24 00:50:19 -0700 Devin, want to knock this out? 1291647 3 305517 hi 2017-03-27 15:14:18 -0700 Created attachment 305517 Patch 1291743 4 305517 mattbaker 2017-03-27 19:03:45 -0700 Comment on attachment 305517 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305517&action=review r=me > Source/WebInspectorUI/UserInterface/Views/TabBar.js:617 > + if (event.altKey) { Suggested early return: if (!event.altKey) { this.removeTabBarItem(tabBarItem, false, true); return; } 1291802 5 305562 hi 2017-03-27 22:32:49 -0700 Created attachment 305562 Patch 1291813 6 305562 commit-queue 2017-03-27 23:18:01 -0700 Comment on attachment 305562 Patch Clearing flags on attachment: 305562 Committed r214464: <http://trac.webkit.org/changeset/214464> 1291814 7 commit-queue 2017-03-27 23:18:05 -0700 All reviewed patches have been landed. Closing bug. 1293764 8 joepeck 2017-04-03 13:19:48 -0700 Is this really what we want? I can see how it is useful in Safari / Web Browser but in Web Inspector I suspect this would only be triggered accidentally / unexpectedly. 305517 2017-03-27 15:14:18 -0700 2017-03-27 22:32:49 -0700 Patch bug-169046-20170327151416.patch text/plain 1796 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGRlMDI3MDA5NDk3NDlkMmMwYWM5NGU0N2Y4NGZi ZGJkNDRlNTRmNzAuLmE0YmVlM2Q5YmE2ZmZkYWRiYzA0OTY0N2FjNTNmYjhjYmMzYzMzYzIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTAzLTI3ICBEZXZp biBSb3Vzc28gIDx3ZWJraXRAZGV2aW5yb3Vzc28uY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IE9wdGlvbi1jbGlja2luZyB0aGUgY2xvc2UgdGFiIGJ1dHRvbiBzaG91bGQgY2xvc2UgYWxs IG90aGVyIHRhYnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE2OTA0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UYWJCYXIuanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuVGFiQmFyLnByb3RvdHlwZS5faGFuZGxlQ2xpY2spOgorCiAyMDE3LTAzLTI0ICBCcmlhbiBC dXJnICA8YmJ1cmdAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJUTDogbnVt YmVyIHNjcmlwdHMgYXJlIHVzZWQgaW5jb25zaXN0ZW50bHkgdGhyb3VnaG91dCB0aGUgVUkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYkJh ci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYkJhci5q cwppbmRleCBkNzkzOTNkOGE2NmFjOTY5YzBkMWQyOGY3MmExZTY2ZDQ5MGY5ZWYyLi4xNjczN2E2 ZWE4OGRhODYyZWY4NDRmZWM0MjcwNzViMTM4NGM3NDYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UYWJCYXIuanMKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFiQmFyLmpzCkBAIC02MTQsNyArNjE0 LDE1IEBAIFdlYkluc3BlY3Rvci5UYWJCYXIgPSBjbGFzcyBUYWJCYXIgZXh0ZW5kcyBXZWJJbnNw ZWN0b3IuVmlldwogICAgICAgICAgICAgaWYgKHRhYkJhckl0ZW0uaXNEZWZhdWx0VGFiICYmIHRo aXMuZWxlbWVudC5jbGFzc0xpc3QuY29udGFpbnMoInNpbmdsZS10YWIiKSkKICAgICAgICAgICAg ICAgICByZXR1cm47CiAKLSAgICAgICAgICAgIHRoaXMucmVtb3ZlVGFiQmFySXRlbSh0YWJCYXJJ dGVtLCBmYWxzZSwgdHJ1ZSk7CisgICAgICAgICAgICBpZiAoZXZlbnQuYWx0S2V5KSB7CisgICAg ICAgICAgICAgICAgZm9yIChsZXQgaSA9IHRoaXMuX3RhYkJhckl0ZW1zLmxlbmd0aCAtIDE7IGkg Pj0gMDsgLS1pKSB7CisgICAgICAgICAgICAgICAgICAgIGxldCBpdGVtID0gdGhpcy5fdGFiQmFy SXRlbXNbaV07CisgICAgICAgICAgICAgICAgICAgIGlmIChpdGVtID09PSB0YWJCYXJJdGVtIHx8 IGl0ZW0gaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuUGlubmVkVGFiQmFySXRlbSkKKyAgICAgICAg ICAgICAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICAgICAgICAgICAgICB0aGlzLnJlbW92 ZVRhYkJhckl0ZW0oaXRlbSk7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfSBlbHNl CisgICAgICAgICAgICAgICAgdGhpcy5yZW1vdmVUYWJCYXJJdGVtKHRhYkJhckl0ZW0sIGZhbHNl LCB0cnVlKTsKICAgICAgICAgfQogICAgIH0KIAo= 305562 2017-03-27 22:32:49 -0700 2017-03-27 23:18:01 -0700 Patch 169046.diff text/plain 1659 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGRlMDI3MDAuLjVmZjY3OTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTAzLTI3ICBEZXZpbiBSb3Vzc28g IDx3ZWJraXRAZGV2aW5yb3Vzc28uY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IE9wdGlv bi1jbGlja2luZyB0aGUgY2xvc2UgdGFiIGJ1dHRvbiBzaG91bGQgY2xvc2UgYWxsIG90aGVyIHRh YnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2OTA0 NgorCisgICAgICAgIFJldmlld2VkIGJ5IE1hdHQgQmFrZXIuCisKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL1ZpZXdzL1RhYkJhci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UYWJCYXIucHJv dG90eXBlLl9oYW5kbGVDbGljayk6CisKIDIwMTctMDMtMjQgIEJyaWFuIEJ1cmcgIDxiYnVyZ0Bh cHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUlRMOiBudW1iZXIgc2NyaXB0cyBh cmUgdXNlZCBpbmNvbnNpc3RlbnRseSB0aHJvdWdob3V0IHRoZSBVSQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFiQmFyLmpzIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFiQmFyLmpzCmluZGV4IGQ3OTM5 M2QuLmYzNTU0ZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1RhYkJhci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9UYWJCYXIuanMKQEAgLTYxNCw3ICs2MTQsMTcgQEAgV2ViSW5zcGVjdG9yLlRh YkJhciA9IGNsYXNzIFRhYkJhciBleHRlbmRzIFdlYkluc3BlY3Rvci5WaWV3CiAgICAgICAgICAg ICBpZiAodGFiQmFySXRlbS5pc0RlZmF1bHRUYWIgJiYgdGhpcy5lbGVtZW50LmNsYXNzTGlzdC5j b250YWlucygic2luZ2xlLXRhYiIpKQogICAgICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAg ICAgICAgdGhpcy5yZW1vdmVUYWJCYXJJdGVtKHRhYkJhckl0ZW0sIGZhbHNlLCB0cnVlKTsKKyAg ICAgICAgICAgIGlmICghZXZlbnQuYWx0S2V5KSB7CisgICAgICAgICAgICAgICAgdGhpcy5yZW1v dmVUYWJCYXJJdGVtKHRhYkJhckl0ZW0sIGZhbHNlLCB0cnVlKTsKKyAgICAgICAgICAgICAgICBy ZXR1cm47CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIGZvciAobGV0IGkgPSB0aGlzLl90 YWJCYXJJdGVtcy5sZW5ndGggLSAxOyBpID49IDA7IC0taSkgeworICAgICAgICAgICAgICAgIGxl dCBpdGVtID0gdGhpcy5fdGFiQmFySXRlbXNbaV07CisgICAgICAgICAgICAgICAgaWYgKGl0ZW0g PT09IHRhYkJhckl0ZW0gfHwgaXRlbSBpbnN0YW5jZW9mIFdlYkluc3BlY3Rvci5QaW5uZWRUYWJC YXJJdGVtKQorICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAgICAgICB0 aGlzLnJlbW92ZVRhYkJhckl0ZW0oaXRlbSk7CisgICAgICAgICAgICB9CiAgICAgICAgIH0KICAg ICB9CiAK