169035 2017-03-01 06:08:32 -0800 [WTF] va_list is not ended in StringPrintStream 2017-03-08 06:50:05 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 104114 1 tpopela tpopela benjamin cdumez cmarcelo commit-queue dbates mcatanzaro oldest_to_newest 1282249 0 tpopela 2017-03-01 06:08:32 -0800 Detected by Coverity scan: 1. webkitgtk-2.14.5/Source/WTF/wtf/StringPrintStream.cpp:57: va_init: Initializing va_list "firstPassArgList". 4. webkitgtk-2.14.5/Source/WTF/wtf/StringPrintStream.cpp:83: missing_va_end: va_end was not called for "firstPassArgList". # 81| ASSERT_WITH_SECURITY_IMPLICATION(m_next < m_size); # 82| ASSERT(!m_buffer[m_next]); # 83|-> } # 84| # 85| CString StringPrintStream::toCString() 1282250 1 303065 tpopela 2017-03-01 06:12:18 -0800 Created attachment 303065 Patch 1282269 2 303065 msaboff 2017-03-01 07:37:26 -0800 Comment on attachment 303065 Patch r=me 1282275 3 303065 tpopela 2017-03-01 07:45:52 -0800 Comment on attachment 303065 Patch Clearing flags on attachment: 303065 Committed r213223: <http://trac.webkit.org/changeset/213223> 1282276 4 tpopela 2017-03-01 07:46:03 -0800 All reviewed patches have been landed. Closing bug. 303065 2017-03-01 06:12:18 -0800 2017-03-01 07:45:52 -0800 Patch bug-169035-20170301150921.patch text/plain 3339 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzMjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGRhNTYyZmUyOWVhMWQ0YTQ5YzhhNjFm NTIxZTRmMzhmNDcwNjBlYjkuLmM3MTAxOTE1ODkxN2Q3ZTEwMzJlNTZlM2M4ZGE2ZDMzMmY1MDhh YTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTctMDMtMDEgIFRvbWFzIFBvcGVsYSAgPHRwb3Bl bGFAcmVkaGF0LmNvbT4KKworICAgICAgICBbV1RGXSB2YV9saXN0IGlzIG5vdCBlbmRlZCBpbiBT dHJpbmdQcmludFN0cmVhbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTY5MDM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWxzbyBmaXggd2hpdGVzcGFjZSBlcnJvcnMgd2hpbGUgdG91Y2hpbmcgdGhpcyBm aWxlLgorCisgICAgICAgICogd3RmL1N0cmluZ1ByaW50U3RyZWFtLmNwcDoKKyAgICAgICAgKFdU Rjo6U3RyaW5nUHJpbnRTdHJlYW06OnZwcmludGYpOgorICAgICAgICAoV1RGOjpTdHJpbmdQcmlu dFN0cmVhbTo6aW5jcmVhc2VTaXplKToKKwogMjAxNy0wMy0wMSAgQW5kcmVhcyBLbGluZyAgPGFr bGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSBNZW1vcnlQcmVzc3VyZUhhbmRsZXIgdG8g V1RGCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9TdHJpbmdQcmludFN0cmVhbS5jcHAgYi9T b3VyY2UvV1RGL3d0Zi9TdHJpbmdQcmludFN0cmVhbS5jcHAKaW5kZXggNGQ1MmMzMzc3NWU0NDYy ZjUwNTZhZTNmZTlhYjhjMmI5N2UzYmRiYi4uNmE4ODgxYzViYmQwYmIzYTE5MWE2NDI5Njg2OTM5 NWZkY2YxMzA1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvU3RyaW5nUHJpbnRTdHJlYW0u Y3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL1N0cmluZ1ByaW50U3RyZWFtLmNwcApAQCAtMjAsNyAr MjAsNyBAQAogICogUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENB VVNFRCBBTkQgT04gQU5ZIFRIRU9SWQogICogT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRS QUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCiAgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0Ug T1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKLSAqIE9GIFRI SVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBE QU1BR0UuIAorICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NT SUJJTElUWSBPRiBTVUNIIERBTUFHRS4KICAqLwogCiAjaW5jbHVkZSAiY29uZmlnLmgiCkBAIC01 MiwzMiArNTIsMzQgQEAgdm9pZCBTdHJpbmdQcmludFN0cmVhbTo6dnByaW50Zihjb25zdCBjaGFy KiBmb3JtYXQsIHZhX2xpc3QgYXJnTGlzdCkKIHsKICAgICBBU1NFUlRfV0lUSF9TRUNVUklUWV9J TVBMSUNBVElPTihtX25leHQgPCBtX3NpemUpOwogICAgIEFTU0VSVCghbV9idWZmZXJbbV9uZXh0 XSk7Ci0gICAgCisKICAgICB2YV9saXN0IGZpcnN0UGFzc0FyZ0xpc3Q7CiAgICAgdmFfY29weShm aXJzdFBhc3NBcmdMaXN0LCBhcmdMaXN0KTsKLSAgICAKKwogICAgIGludCBudW1iZXJPZkJ5dGVz Tm90SW5jbHVkaW5nVGVybWluYXRvclRoYXRXb3VsZEhhdmVCZWVuV3JpdHRlbiA9CiAgICAgICAg IHZzbnByaW50ZihtX2J1ZmZlciArIG1fbmV4dCwgbV9zaXplIC0gbV9uZXh0LCBmb3JtYXQsIGZp cnN0UGFzc0FyZ0xpc3QpOwotICAgIAorCisgICAgdmFfZW5kKGZpcnN0UGFzc0FyZ0xpc3QpOwor CiAgICAgaW50IG51bWJlck9mQnl0ZXNUaGF0V291bGRIYXZlQmVlbldyaXR0ZW4gPQogICAgICAg ICBudW1iZXJPZkJ5dGVzTm90SW5jbHVkaW5nVGVybWluYXRvclRoYXRXb3VsZEhhdmVCZWVuV3Jp dHRlbiArIDE7Ci0gICAgCisKICAgICBpZiAobV9uZXh0ICsgbnVtYmVyT2ZCeXRlc1RoYXRXb3Vs ZEhhdmVCZWVuV3JpdHRlbiA8PSBtX3NpemUpIHsKICAgICAgICAgbV9uZXh0ICs9IG51bWJlck9m Qnl0ZXNOb3RJbmNsdWRpbmdUZXJtaW5hdG9yVGhhdFdvdWxkSGF2ZUJlZW5Xcml0dGVuOwogICAg ICAgICByZXR1cm47IC8vIFRoaXMgbWVhbnMgdGhhdCB2c25wcmludGYoKSBzdWNjZWVkZWQuCiAg ICAgfQotICAgIAorCiAgICAgaW5jcmVhc2VTaXplKG1fbmV4dCArIG51bWJlck9mQnl0ZXNUaGF0 V291bGRIYXZlQmVlbldyaXR0ZW4pOwotICAgIAorCiAgICAgaW50IG51bWJlck9mQnl0ZXNOb3RJ bmNsdWRpbmdUZXJtaW5hdG9yVGhhdFdlcmVXcml0dGVuID0KICAgICAgICAgdnNucHJpbnRmKG1f YnVmZmVyICsgbV9uZXh0LCBtX3NpemUgLSBtX25leHQsIGZvcm1hdCwgYXJnTGlzdCk7Ci0gICAg CisKICAgICBpbnQgbnVtYmVyT2ZCeXRlc1RoYXRXZXJlV3JpdHRlbiA9IG51bWJlck9mQnl0ZXNO b3RJbmNsdWRpbmdUZXJtaW5hdG9yVGhhdFdlcmVXcml0dGVuICsgMTsKLSAgICAKKwogICAgIEFT U0VSVF9VTlVTRUQobnVtYmVyT2ZCeXRlc1RoYXRXZXJlV3JpdHRlbiwgbV9uZXh0ICsgbnVtYmVy T2ZCeXRlc1RoYXRXZXJlV3JpdHRlbiA8PSBtX3NpemUpOwotICAgIAorCiAgICAgbV9uZXh0ICs9 IG51bWJlck9mQnl0ZXNOb3RJbmNsdWRpbmdUZXJtaW5hdG9yVGhhdFdlcmVXcml0dGVuOwotICAg IAorCiAgICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04obV9uZXh0IDwgbV9zaXpl KTsKICAgICBBU1NFUlQoIW1fYnVmZmVyW21fbmV4dF0pOwogfQpAQCAtMTEwLDEwICsxMTIsMTAg QEAgdm9pZCBTdHJpbmdQcmludFN0cmVhbTo6aW5jcmVhc2VTaXplKHNpemVfdCBuZXdTaXplKQog ewogICAgIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKG5ld1NpemUgPiBtX3NpemUp OwogICAgIEFTU0VSVChuZXdTaXplID4gc2l6ZW9mKG1faW5saW5lQnVmZmVyKSk7Ci0gICAgCisK ICAgICAvLyBVc2UgZXhwb25lbnRpYWwgcmVzaXppbmcgdG8gcmVkdWNlIHRocmFzaGluZy4KICAg ICBtX3NpemUgPSBuZXdTaXplIDw8IDE7Ci0gICAgCisKICAgICAvLyBVc2UgZmFzdE1hbGxvYyBp bnN0ZWFkIG9mIGZhc3RSZWFsbG9jIGJlY2F1c2Ugd2Uga25vdyB0aGF0IGZvciB0aGUgc2l6ZXMg d2UncmUgdXNpbmcsCiAgICAgLy8gZmFzdFJlYWxsb2Mgd2lsbCBqdXN0IGRvIG1hbGxvYytmcmVl IGFueXdheS4gQWxzbywgdGhpcyBzaW1wbGlmaWVzIHRoZSBjb2RlIHNpbmNlCiAgICAgLy8gd2Ug Y2FuJ3QgcmVhbGxvYyB0aGUgaW5saW5lIGJ1ZmZlci4K