169034 2017-03-01 06:02:55 -0800 Incorrect RELEASE_ASSERT in JSGlobalObject::addStaticGlobals() 2017-03-10 12:09:35 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 104114 1 tpopela tpopela commit-queue keith_miller mark.lam mcatanzaro msaboff saam webkit-bug-importer oldest_to_newest 1282247 0 tpopela 2017-03-01 06:02:55 -0800 There is an incorrect RELEASE_ASSERT in JSGlobalObject::addStaticGlobals(GlobalPropertyInfo* globals, int count): RELEASE_ASSERT(offset = startOffset + i); it should not assign to offset, but compare to offset. 1282248 1 303064 tpopela 2017-03-01 06:04:38 -0800 Created attachment 303064 Patch 1282305 2 303064 mark.lam 2017-03-01 09:49:23 -0800 Comment on attachment 303064 Patch r=me 1282665 3 303064 tpopela 2017-03-02 01:42:18 -0800 Comment on attachment 303064 Patch Clearing flags on attachment: 303064 Committed r213275: <http://trac.webkit.org/changeset/213275> 1282666 4 tpopela 2017-03-02 01:42:26 -0800 All reviewed patches have been landed. Closing bug. 1285879 5 webkit-bug-importer 2017-03-10 12:09:35 -0800 <rdar://problem/30978527> 303064 2017-03-01 06:04:38 -0800 2017-03-02 01:42:18 -0800 Patch bug-169034-20170301150141.patch text/plain 1675 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzMjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj OGNkYWY4NzNjODRiMjdkNTNmYzM2YWRjOTM4OWI3YTY5YjMyYjAyLi5jZWI4NzQ2MDQ3ZTFlNTlk NDgwNGRhNjY3ZjI2ZmQwY2QxNzZmN2VhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNyBAQAogMjAxNy0wMy0wMSAgVG9tYXMgUG9wZWxhICA8dHBvcGVsYUByZWRoYXQuY29t PgogCisgICAgICAgIEluY29ycmVjdCBSRUxFQVNFX0FTU0VSVCBpbiBKU0dsb2JhbE9iamVjdDo6 YWRkU3RhdGljR2xvYmFscygpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNjkwMzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJdCBzaG91bGQgbm90IGFzc2lnbiB0byBvZmZzZXQsIGJ1dCBjb21wYXJlIHRv IG9mZnNldC4KKworICAgICAgICAqIHJ1bnRpbWUvSlNHbG9iYWxPYmplY3QuY3BwOgorICAgICAg ICAoSlNDOjpKU0dsb2JhbE9iamVjdDo6YWRkU3RhdGljR2xvYmFscyk6CisKKzIwMTctMDMtMDEg IFRvbWFzIFBvcGVsYSAgPHRwb3BlbGFAcmVkaGF0LmNvbT4KKwogICAgICAgICBMZWFrIHVuZGVy IE9wdGlvbnM6OnNldE9wdGlvbnMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2OTAyOQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU0dsb2JhbE9iamVjdC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9KU0dsb2JhbE9iamVjdC5jcHAKaW5kZXggNzZjOTY1Y2FlMWRjMzJjYTg4YjdmZWNmNzc2NTMw ZjQ2OWM1NzVkNC4uNWI4YjhkMjM0YTY0NzNiNGY0NGM1ZDI4ZGUxMmJlODk3N2Q2YzZmNCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmplY3QuY3Bw CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0LmNwcApA QCAtMTMxNiw3ICsxMzE2LDcgQEAgdm9pZCBKU0dsb2JhbE9iamVjdDo6YWRkU3RhdGljR2xvYmFs cyhHbG9iYWxQcm9wZXJ0eUluZm8qIGdsb2JhbHMsIGludCBjb3VudCkKICAgICAgICAgewogICAg ICAgICAgICAgQ29uY3VycmVudEpTTG9ja2VyIGxvY2tlcihzeW1ib2xUYWJsZSgpLT5tX2xvY2sp OwogICAgICAgICAgICAgU2NvcGVPZmZzZXQgb2Zmc2V0ID0gc3ltYm9sVGFibGUoKS0+dGFrZU5l eHRTY29wZU9mZnNldChsb2NrZXIpOwotICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlQob2Zmc2V0 ID0gc3RhcnRPZmZzZXQgKyBpKTsKKyAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJUKG9mZnNldCA9 PSBzdGFydE9mZnNldCArIGkpOwogICAgICAgICAgICAgU3ltYm9sVGFibGVFbnRyeSBuZXdFbnRy eShWYXJPZmZzZXQob2Zmc2V0KSwgZ2xvYmFsLmF0dHJpYnV0ZXMpOwogICAgICAgICAgICAgbmV3 RW50cnkucHJlcGFyZVRvV2F0Y2goKTsKICAgICAgICAgICAgIHdhdGNocG9pbnRTZXQgPSBuZXdF bnRyeS53YXRjaHBvaW50U2V0KCk7Cg==