169028 2017-03-01 03:50:38 -0800 [GTK] Fix problems found by Coverity scan in platform's keyboard and mouse events 2017-03-08 06:49:22 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 104114 1 tpopela tpopela bugs-noreply mcatanzaro oldest_to_newest 1282231 0 tpopela 2017-03-01 03:50:38 -0800 18. webkitgtk-2.14.5/Source/WebCore/platform/gtk/PlatformMouseEventGtk.cpp:116: uninit_member: Non-static class member "m_modifierFlags" is not initialized in this constructor nor in any functions that it calls. # 114| else if (motion->state & GDK_BUTTON3_MASK) # 115| m_button = RightButton; # 116|-> } # 117| } and 12. webkitgtk-2.14.5/Source/WebCore/platform/gtk/PlatformMouseEventGtk.cpp:82: uninit_member: Non-static class member "m_modifierFlags" is not initialized in this constructor nor in any functions that it calls. # 80| ASSERT_NOT_REACHED(); # 81| }; # 82|-> } # 83| # 84| PlatformMouseEvent::PlatformMouseEvent(GdkEventMotion* motion) and 6. webkitgtk-2.14.5/Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp:590: uninit_member: Non-static class member "m_handledByInputMethod" is not initialized in this constructor nor in any functions that it calls. # 588| if (compositionResults.compositionUpdated()) # 589| m_windowsVirtualKeyCode = VK_PROCESSKEY; # 590|-> } # 591| # 592| void PlatformKeyboardEvent::disambiguateKeyDownEvent(Type type, bool backwardCompatibilityMode) 1282232 1 303060 tpopela 2017-03-01 03:56:49 -0800 Created attachment 303060 Patch 1282253 2 303060 tpopela 2017-03-01 06:18:35 -0800 Comment on attachment 303060 Patch Clearing flags on attachment: 303060 Committed r213218: <http://trac.webkit.org/changeset/213218> 1282254 3 tpopela 2017-03-01 06:18:43 -0800 All reviewed patches have been landed. Closing bug. 1282259 4 tpopela 2017-03-01 06:41:24 -0800 The original commit introduced a compiler error that I fixed in http://trac.webkit.org/changeset/213220: [8/67] Building CXX object Source/WebCore/CMakeFiles/WebCorePlatformGTK2.dir/platform/gtk/PlatformKeyboardEventGtk.cpp.o In file included from ../../Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp:31:0: ../../Source/WebCore/platform/PlatformKeyboardEvent.h: In constructor ‘WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent(GdkEventKey*, const WebCore::CompositionResults&)’: ../../Source/WebCore/platform/PlatformKeyboardEvent.h:186:14: warning: ‘WebCore::PlatformKeyboardEvent::m_autoRepeat’ will be initialized after [-Wreorder] bool m_autoRepeat; ^~~~~~~~~~~~ ../../Source/WebCore/platform/PlatformKeyboardEvent.h:179:14: warning: ‘bool WebCore::PlatformKeyboardEvent::m_handledByInputMethod’ [-Wreorder] bool m_handledByInputMethod; ^~~~~~~~~~~~~~~~~~~~~~ ../../Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp:1261:1: warning: when initialized here [-Wreorder] PlatformKeyboardEvent::PlatformKeyboardEvent(GdkEventKey* event, const CompositionResults& compositionResults) ^~~~~~~~~~~~~~~~~~~~~ 303060 2017-03-01 03:56:49 -0800 2017-03-01 06:18:35 -0800 Patch bug-169028-20170301125352.patch text/plain 2815 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzMjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjk5MGE2MzZlYTlmZjcy MDYyZGNiMjMwZDBhYzc2N2EzNjA1YmI0OC4uYTc3YTlhZThkMTNjYzY0ZTE0MjA4ZDEwZWQ1OTEz NTc3MTNhZmJjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTAzLTAxICBUb21h cyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CisKKyAgICAgICAgW0dUS10gRml4IHByb2Js ZW1zIGZvdW5kIGJ5IENvdmVyaXR5IHNjYW4gaW4gcGxhdGZvcm0ncyBrZXlib2FyZCBhbmQgbW91 c2UgZXZlbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjkwMjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHBsYXRmb3JtL2d0ay9QbGF0Zm9ybUtleWJvYXJkRXZlbnRHdGsuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UGxhdGZvcm1LZXlib2FyZEV2ZW50OjpQbGF0Zm9ybUtleWJvYXJkRXZlbnQpOiBJ bml0aWFsaXplCisgICAgICAgIHRoZSBtX2hhbmRsZWRCeUlucHV0TWV0aG9kIG1lbWJlci4KKyAg ICAgICAgKiBwbGF0Zm9ybS9ndGsvUGxhdGZvcm1Nb3VzZUV2ZW50R3RrLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlBsYXRmb3JtTW91c2VFdmVudDo6UGxhdGZvcm1Nb3VzZUV2ZW50KTogSW5pdGlh bGl6ZSB0aGUKKyAgICAgICAgbV9tb2RpZmllckZsYWdzIG1lbWJlci4KKwogMjAxNy0wMy0wMSAg QW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSBNZW1vcnlQ cmVzc3VyZUhhbmRsZXIgdG8gV1RGCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ndGsvUGxhdGZvcm1LZXlib2FyZEV2ZW50R3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2d0ay9QbGF0Zm9ybUtleWJvYXJkRXZlbnRHdGsuY3BwCmluZGV4IGI2ODRiZTg1ZmYxYzE2 YjIxMTk2OWRhNzJlMjdjZjU5Zjg3NmVkZWQuLjI1ZDhmNGE0YzMyNzVkZmJjMjQyODhjNmFjOWY2 OGQwYzBmMzZkYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9QbGF0 Zm9ybUtleWJvYXJkRXZlbnRHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0 ay9QbGF0Zm9ybUtleWJvYXJkRXZlbnRHdGsuY3BwCkBAIC0xMjY3LDYgKzEyNjcsNyBAQCBQbGF0 Zm9ybUtleWJvYXJkRXZlbnQ6OlBsYXRmb3JtS2V5Ym9hcmRFdmVudChHZGtFdmVudEtleSogZXZl bnQsIGNvbnN0IENvbXBvc2l0aQogICAgICwgbV9rZXlJZGVudGlmaWVyKGtleUlkZW50aWZpZXJG b3JHZGtLZXlDb2RlKGV2ZW50LT5rZXl2YWwpKQogICAgICwgbV93aW5kb3dzVmlydHVhbEtleUNv ZGUod2luZG93c0tleUNvZGVGb3JHZGtLZXlDb2RlKGV2ZW50LT5rZXl2YWwpKQogICAgICwgbV9h dXRvUmVwZWF0KGZhbHNlKQorICAgICwgbV9oYW5kbGVkQnlJbnB1dE1ldGhvZChmYWxzZSkKICAg ICAsIG1faXNLZXlwYWQoZXZlbnQtPmtleXZhbCA+PSBHREtfS1BfU3BhY2UgJiYgZXZlbnQtPmtl eXZhbCA8PSBHREtfS1BfOSkKICAgICAsIG1faXNTeXN0ZW1LZXkoZmFsc2UpCiAgICAgLCBtX2dk a0V2ZW50S2V5KGV2ZW50KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Rr L1BsYXRmb3JtTW91c2VFdmVudEd0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv UGxhdGZvcm1Nb3VzZUV2ZW50R3RrLmNwcAppbmRleCBhNWJiMzJiODMwZDI1YzNlZWIzNDAzZDc2 OTQyNDIzYzE3M2UxODlhLi40M2JiN2U4YjcwMzU5Mzc3OWIwMTMwOGYzNWRhNDE2NjcwYjhiY2Nk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGxhdGZvcm1Nb3VzZUV2 ZW50R3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGxhdGZvcm1Nb3Vz ZUV2ZW50R3RrLmNwcApAQCAtNDEsNiArNDEsNyBAQCBQbGF0Zm9ybU1vdXNlRXZlbnQ6OlBsYXRm b3JtTW91c2VFdmVudChHZGtFdmVudEJ1dHRvbiogZXZlbnQpCiAgICAgbV90aW1lc3RhbXAgPSBl dmVudC0+dGltZTsKICAgICBtX3Bvc2l0aW9uID0gSW50UG9pbnQoKGludClldmVudC0+eCwgKGlu dClldmVudC0+eSk7CiAgICAgbV9nbG9iYWxQb3NpdGlvbiA9IEludFBvaW50KChpbnQpZXZlbnQt Pnhfcm9vdCwgKGludClldmVudC0+eV9yb290KTsKKyAgICBtX21vZGlmaWVyRmxhZ3MgPSAwOwog CiAgICAgaWYgKGV2ZW50LT5zdGF0ZSAmIEdES19TSElGVF9NQVNLKQogICAgICAgICBtX21vZGlm aWVycyB8PSBQbGF0Zm9ybUV2ZW50OjpNb2RpZmllcjo6U2hpZnRLZXk7CkBAIC04Nyw2ICs4OCw3 IEBAIFBsYXRmb3JtTW91c2VFdmVudDo6UGxhdGZvcm1Nb3VzZUV2ZW50KEdka0V2ZW50TW90aW9u KiBtb3Rpb24pCiAgICAgbV90aW1lc3RhbXAgPSBtb3Rpb24tPnRpbWU7CiAgICAgbV9wb3NpdGlv biA9IEludFBvaW50KChpbnQpbW90aW9uLT54LCAoaW50KW1vdGlvbi0+eSk7CiAgICAgbV9nbG9i YWxQb3NpdGlvbiA9IEludFBvaW50KChpbnQpbW90aW9uLT54X3Jvb3QsIChpbnQpbW90aW9uLT55 X3Jvb3QpOworICAgIG1fbW9kaWZpZXJGbGFncyA9IDA7CiAKICAgICBpZiAobW90aW9uLT5zdGF0 ZSAmIEdES19TSElGVF9NQVNLKQogICAgICAgICBtX21vZGlmaWVycyB8PSBQbGF0Zm9ybUV2ZW50 OjpNb2RpZmllcjo6U2hpZnRLZXk7Cg==