169027 2017-03-01 03:37:09 -0800 [GTK] Fix problems found by Coverity scan in WebPrintOperationGtk.cpp 2017-03-08 06:48:44 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 104114 1 tpopela tpopela bugs-noreply cgarcia mcatanzaro oldest_to_newest 1282228 0 tpopela 2017-03-01 03:37:09 -0800 65. webkitgtk-2.14.5/Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:365: member_decl: Class member declaration for "totalToPrint". 66. webkitgtk-2.14.5/Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:306: uninit_member: Non-static class member "totalToPrint" is not initialized in this constructor nor in any functions that it calls. 67. webkitgtk-2.14.5/Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:372: member_decl: Class member declaration for "lastPagePosition". 68. webkitgtk-2.14.5/Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:306: uninit_member: Non-static class member "lastPagePosition" is not initialized in this constructor nor in any functions that it calls. # 304| firstPagePosition = printOperation->pagePosition(); # 305| firstSheetNumber = sheetNumber; # 306|-> } # 307| # 308| size_t collatedCopiesLeft() and 69. webkitgtk-2.14.5/Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:365: member_decl: Class member declaration for "totalToPrint". 70. webkitgtk-2.14.5/Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:299: uninit_member: Non-static class member "totalToPrint" is not initialized in this constructor nor in any functions that it calls. # 297| if (sheetNumber * numberUp >= pages.size()) { # 298| isValid = false; # 299|-> return; # 300| } # 301| actually the totalToPrint member is not used at all -> remove it. 1282229 1 303058 tpopela 2017-03-01 03:41:35 -0800 Created attachment 303058 Patch 1282251 2 303058 tpopela 2017-03-01 06:16:01 -0800 Comment on attachment 303058 Patch Clearing flags on attachment: 303058 Committed r213217: <http://trac.webkit.org/changeset/213217> 1282252 3 tpopela 2017-03-01 06:16:10 -0800 All reviewed patches have been landed. Closing bug. 303058 2017-03-01 03:41:35 -0800 2017-03-01 06:16:01 -0800 Patch bug-169027-20170301123838.patch text/plain 1618 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzMjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOThmNjljYTczNWYxZDRi NjI2YzZmOTBjZDBiN2NlYjgzMTk0N2JmMS4uMDQ4NTFjYzJhOTZjYzgyNDRjNDYxNjM2YzYyMDQz MTcxZjA0YzRmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTAzLTAxICBUb21h cyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CisKKyAgICAgICAgW0dUS10gRml4IHByb2Js ZW1zIGZvdW5kIGJ5IENvdmVyaXR5IHNjYW4gaW4gV2ViUHJpbnRPcGVyYXRpb25HdGsuY3BwCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjkwMjcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbml0aWFsaXpl IHRoZSBsYXN0UGFnZVBvc2l0aW9uIHZhcmlhYmxlIGFuZCByZW1vdmUgYW4gdW51c2VkIG9uZQor ICAgICAgICAtIHRvdGFsVG9QcmludC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9n dGsvV2ViUHJpbnRPcGVyYXRpb25HdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpQcmludFBhZ2Vz RGF0YTo6UHJpbnRQYWdlc0RhdGEpOgorCiAyMDE3LTAzLTAxICBBbmRyZWFzIEtsaW5nICA8YWts aW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3ZlIE1lbW9yeVByZXNzdXJlSGFuZGxlciB0byBX VEYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9ndGsvV2Vi UHJpbnRPcGVyYXRpb25HdGsuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L2d0ay9XZWJQcmludE9wZXJhdGlvbkd0ay5jcHAKaW5kZXggYjYyMDVkYjk0OTUwMTNlNGE4ZTIy MWNkNmJmYjZkODQ5ODM4MzAxMi4uZmRkNDE5Mzk0OGY3ZjZlMDVkMjEyMWZjZTFlN2I2ZjNhZjY1 YmNiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2d0ay9X ZWJQcmludE9wZXJhdGlvbkd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL2d0ay9XZWJQcmludE9wZXJhdGlvbkd0ay5jcHAKQEAgLTIxMCw2ICsyMTAsNyBAQCBz dHJ1Y3QgUHJpbnRQYWdlc0RhdGEgewogICAgICAgICAsIGZpcnN0U2hlZXROdW1iZXIoMCkKICAg ICAgICAgLCBudW1iZXJPZlNoZWV0cygwKQogICAgICAgICAsIGZpcnN0UGFnZVBvc2l0aW9uKDAp CisgICAgICAgICwgbGFzdFBhZ2VQb3NpdGlvbigwKQogICAgICAgICAsIGNvbGxhdGVkKDApCiAg ICAgICAgICwgdW5jb2xsYXRlZCgwKQogICAgICAgICAsIGlzRG9uZShmYWxzZSkKQEAgLTM2Miw3 ICszNjMsNiBAQCBzdHJ1Y3QgUHJpbnRQYWdlc0RhdGEgewogICAgIEdSZWZQdHI8R01haW5Mb29w PiBtYWluTG9vcDsKIAogICAgIGludCB0b3RhbFByaW50ZWQ7Ci0gICAgc2l6ZV90IHRvdGFsVG9Q cmludDsKICAgICBpbnQgcGFnZU51bWJlcjsKICAgICBWZWN0b3I8c2l6ZV90PiBwYWdlczsKICAg ICBzaXplX3Qgc2hlZXROdW1iZXI7Cg==