169014 2017-02-28 18:25:18 -0800 [MediaStream] UIClient may not be notified of capture state change when leaving a page 2017-03-02 10:18:39 -0800 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified REOPENED InRadar P2 Normal --- 1 eric.carlson eric.carlson cdumez commit-queue dbates esprehn+autocc kangil.han ryanhaddad webkit-bug-importer youennf oldest_to_newest 1282107 0 eric.carlson 2017-02-28 18:25:18 -0800 The UA may not be notified of the capture state change when leaving a page 1282108 1 eric.carlson 2017-02-28 18:25:45 -0800 <rdar://problem/30632267> 1282110 2 303024 eric.carlson 2017-02-28 18:34:44 -0800 Created attachment 303024 Proposed patch. 1282128 3 303024 youennf 2017-02-28 19:50:28 -0800 Comment on attachment 303024 Proposed patch. Was it also causing microphone/capture sandbox to not be revoked? If so, can we add some sort of test or additional checks for it? What about session-like gum granting? 1282724 4 303024 commit-queue 2017-03-02 07:49:06 -0800 Comment on attachment 303024 Proposed patch. Clearing flags on attachment: 303024 Committed r213281: <http://trac.webkit.org/changeset/213281> 1282725 5 commit-queue 2017-03-02 07:49:12 -0800 All reviewed patches have been landed. Closing bug. 1282767 6 ryanhaddad 2017-03-02 10:02:39 -0800 This change caused API test WebKit2.UserMediaBasic to time out: https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/4018 1282778 7 ryanhaddad 2017-03-02 10:18:39 -0800 Reverted r213281 for reason: This change caused API test WebKit2.UserMediaBasic to time out. Committed r213287: <http://trac.webkit.org/changeset/213287> 303024 2017-02-28 18:34:44 -0800 2017-03-02 07:49:06 -0800 Proposed patch. media_state_change_patch_2.txt text/plain 7177 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzE0OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTAyLTI4ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNZWRpYVN0cmVhbV0g VUlDbGllbnQgbWF5IG5vdCBiZSBub3RpZmllZCBvZiBjYXB0dXJlIHN0YXRlIGNoYW5nZSB3aGVu IGxlYXZpbmcgYSBwYWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNjkwMTQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMwNjMyMjY3PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuYWJsZSBhbmQgdXBk YXRlIHRoZSBXZWJLaXQgQVBJIHRlc3QgV2ViS2l0Mi5Vc2VyTWVkaWEuCisKKyAgICAgICAgKiBk b20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnByZXBhcmVGb3JE ZXN0cnVjdGlvbik6IEFsd2F5cyBjYWxsIHBhZ2UudXBkYXRlSXNQbGF5aW5nTWVkaWEoKSBpZiB0 aGVyZQorICAgICAgICBpcyBhY3RpdmUgbWVkaWEgaW4gdGhlIGRvY3VtZW50IGJlY2F1c2UgaXQg d29uJ3QgYmUgcG9zc2libGUgd2hlbiB0aGUgc3RhdGUgY2hhbmdlcyBsYXRlcgorICAgICAgICBi ZWNhdXNlIHRoZSBmcmFtZSB3aWxsIGhhdmUgYmVlbiBjbGVhcmVkLgorCiAyMDE3LTAyLTI4ICBB bGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTWFp biByZXNvdXJjZSByZXF1ZXN0cyBuZWVkIGNhY2hlUGFydGl0aW9uCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9kb20vRG9jdW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9E b2N1bWVudC5jcHAJKHJldmlzaW9uIDIxMzE0OCkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1 bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIzMjQsNiArMjMyNCwxMSBAQCB2b2lkIERvY3Vt ZW50OjpwcmVwYXJlRm9yRGVzdHJ1Y3Rpb24oKQogICAgIH0KICNlbmRpZgogCisgICAgaWYgKHBh Z2UoKSAmJiBtX21lZGlhU3RhdGUgIT0gTWVkaWFQcm9kdWNlcjo6SXNOb3RQbGF5aW5nKSB7Cisg ICAgICAgIG1fbWVkaWFTdGF0ZSA9IE1lZGlhUHJvZHVjZXI6OklzTm90UGxheWluZzsKKyAgICAg ICAgcGFnZSgpLT51cGRhdGVJc1BsYXlpbmdNZWRpYShIVE1MTWVkaWFFbGVtZW50SW52YWxpZElE KTsKKyAgICB9CisKICAgICBkZXRhY2hGcm9tRnJhbWUoKTsKIAogICAgIG1faGFzUHJlcGFyZWRG b3JEZXN0cnVjdGlvbiA9IHRydWU7CkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YktpdDIvVXNlck1lZGlhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYktpdDIvVXNlck1lZGlhLmNwcAkocmV2aXNpb24gMjEzMTQ4KQorKysgVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyL1VzZXJNZWRpYS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTI1LDE1ICsyNSwyNCBAQAogI2luY2x1ZGUgIlBsYXRmb3JtVXRpbGl0aWVzLmgiCiAjaW5jbHVk ZSAiUGxhdGZvcm1XZWJWaWV3LmgiCiAjaW5jbHVkZSAiVGVzdC5oIgorI2luY2x1ZGUgPFdlYktp dC9XS1BhZ2VQcml2YXRlLmg+CisjaW5jbHVkZSA8V2ViS2l0L1dLUHJlZmVyZW5jZXNSZWYuaD4K KyNpbmNsdWRlIDxXZWJLaXQvV0tQcmVmZXJlbmNlc1JlZlByaXZhdGUuaD4KICNpbmNsdWRlIDxX ZWJLaXQvV0tSZXRhaW5QdHIuaD4KICNpbmNsdWRlIDxzdHJpbmcuaD4KICNpbmNsdWRlIDx2ZWN0 b3I+CiAKIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJIHsKIAotc3RhdGljIGJvb2wgZG9uZTsKK3N0 YXRpYyBib29sIHdhc1Byb21wdGVkOworc3RhdGljIGJvb2wgaXNQbGF5aW5nQ2hhbmdlZDsKK3N0 YXRpYyBib29sIGRpZEZpbmlzaExvYWQ7CiAKLXZvaWQgZGVjaWRlUG9saWN5Rm9yVXNlck1lZGlh UGVybWlzc2lvblJlcXVlc3RDYWxsQmFjayhXS1BhZ2VSZWYsIFdLRnJhbWVSZWYsIFdLU2VjdXJp dHlPcmlnaW5SZWYsIFdLU2VjdXJpdHlPcmlnaW5SZWYsIFdLVXNlck1lZGlhUGVybWlzc2lvblJl cXVlc3RSZWYgcGVybWlzc2lvblJlcXVlc3QsIGNvbnN0IHZvaWQqIC8qIGNsaWVudEluZm8gKi8p CitzdGF0aWMgdm9pZCBudWxsSmF2YVNjcmlwdENhbGxiYWNrKFdLU2VyaWFsaXplZFNjcmlwdFZh bHVlUmVmLCBXS0Vycm9yUmVmIGVycm9yLCB2b2lkKikKK3sKK30KKworc3RhdGljIHZvaWQgZGVj aWRlUG9saWN5Rm9yVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RDYWxsQmFjayhXS1BhZ2VSZWYs IFdLRnJhbWVSZWYsIFdLU2VjdXJpdHlPcmlnaW5SZWYsIFdLU2VjdXJpdHlPcmlnaW5SZWYsIFdL VXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RSZWYgcGVybWlzc2lvblJlcXVlc3QsIGNvbnN0IHZv aWQqIC8qIGNsaWVudEluZm8gKi8pCiB7CiAgICAgV0tSZXRhaW5QdHI8V0tBcnJheVJlZj4gYXVk aW9EZXZpY2VVSURzID0gV0tVc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdEF1ZGlvRGV2aWNlVUlE cyhwZXJtaXNzaW9uUmVxdWVzdCk7CiAgICAgV0tSZXRhaW5QdHI8V0tBcnJheVJlZj4gdmlkZW9E ZXZpY2VVSURzID0gV0tVc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdFZpZGVvRGV2aWNlVUlEcyhw ZXJtaXNzaW9uUmVxdWVzdCk7CkBAIC01NCwyNyArNjMsNzMgQEAgdm9pZCBkZWNpZGVQb2xpY3lG b3JVc2VyTWVkaWFQZXJtaXNzaW9uUgogICAgICAgICBXS1VzZXJNZWRpYVBlcm1pc3Npb25SZXF1 ZXN0QWxsb3cocGVybWlzc2lvblJlcXVlc3QsIGF1ZGlvRGV2aWNlVUlELmdldCgpLCB2aWRlb0Rl dmljZVVJRC5nZXQoKSk7CiAgICAgfQogCi0gICAgZG9uZSA9IHRydWU7CisgICAgd2FzUHJvbXB0 ZWQgPSB0cnVlOworfQorCitzdGF0aWMgdm9pZCBpc1BsYXlpbmdEaWRDaGFuZ2VDYWxsYmFjayhX S1BhZ2VSZWYgcGFnZSwgY29uc3Qgdm9pZCopCit7CisgICAgaXNQbGF5aW5nQ2hhbmdlZCA9IHRy dWU7Cit9CisKK3N0YXRpYyB2b2lkIGRpZEZpbmlzaExvYWRGb3JGcmFtZShXS1BhZ2VSZWYgcGFn ZSwgV0tGcmFtZVJlZiwgV0tUeXBlUmVmLCBjb25zdCB2b2lkKikKK3sKKyAgICBkaWRGaW5pc2hM b2FkID0gdHJ1ZTsKIH0KIAotVEVTVChXZWJLaXQyLCBESVNBQkxFRF9Vc2VyTWVkaWFCYXNpYykK K1RFU1QoV2ViS2l0MiwgVXNlck1lZGlhQmFzaWMpCiB7CiAgICAgYXV0byBjb250ZXh0ID0gYWRv cHRXSyhXS0NvbnRleHRDcmVhdGUoKSk7Ci0gICAgUGxhdGZvcm1XZWJWaWV3IHdlYlZpZXcoY29u dGV4dC5nZXQoKSk7Ci0gICAgV0tQYWdlVUlDbGllbnRWNSB1aUNsaWVudDsKLSAgICBtZW1zZXQo JnVpQ2xpZW50LCAwLCBzaXplb2YodWlDbGllbnQpKTsKIAorICAgIFdLUmV0YWluUHRyPFdLUGFn ZUdyb3VwUmVmPiBwYWdlR3JvdXAoQWRvcHRXSywgV0tQYWdlR3JvdXBDcmVhdGVXaXRoSWRlbnRp ZmllcihVdGlsOjp0b1dLKCJHZXRVc2VyTWVkaWEiKS5nZXQoKSkpOworICAgIFdLUHJlZmVyZW5j ZXNSZWYgcHJlZmVyZW5jZXMgPSBXS1BhZ2VHcm91cEdldFByZWZlcmVuY2VzKHBhZ2VHcm91cC5n ZXQoKSk7CisgICAgV0tQcmVmZXJlbmNlc1NldE1lZGlhU3RyZWFtRW5hYmxlZChwcmVmZXJlbmNl cywgdHJ1ZSk7CisgICAgV0tQcmVmZXJlbmNlc1NldEZpbGVBY2Nlc3NGcm9tRmlsZVVSTHNBbGxv d2VkKHByZWZlcmVuY2VzLCB0cnVlKTsKKyAgICBXS1ByZWZlcmVuY2VzU2V0TWVkaWFDYXB0dXJl UmVxdWlyZXNTZWN1cmVDb25uZWN0aW9uKHByZWZlcmVuY2VzLCBmYWxzZSk7CisgICAgV0tQcmVm ZXJlbmNlc1NldE1vY2tDYXB0dXJlRGV2aWNlc0VuYWJsZWQocHJlZmVyZW5jZXMsIHRydWUpOwor CisgICAgV0tQYWdlTG9hZGVyQ2xpZW50VjAgbG9hZGVyQ2xpZW50OworICAgIG1lbXNldCgmbG9h ZGVyQ2xpZW50LCAwLCBzaXplb2YobG9hZGVyQ2xpZW50KSk7CisgICAgbG9hZGVyQ2xpZW50LmJh c2UudmVyc2lvbiA9IDA7CisgICAgbG9hZGVyQ2xpZW50LmRpZEZpbmlzaExvYWRGb3JGcmFtZSA9 IGRpZEZpbmlzaExvYWRGb3JGcmFtZTsKIAotICAgIHVpQ2xpZW50LmJhc2UudmVyc2lvbiA9IDU7 CisgICAgV0tQYWdlVUlDbGllbnRWNiB1aUNsaWVudDsKKyAgICBtZW1zZXQoJnVpQ2xpZW50LCAw LCBzaXplb2YodWlDbGllbnQpKTsKKyAgICB1aUNsaWVudC5iYXNlLnZlcnNpb24gPSA2OworICAg IHVpQ2xpZW50LmlzUGxheWluZ0F1ZGlvRGlkQ2hhbmdlID0gaXNQbGF5aW5nRGlkQ2hhbmdlQ2Fs bGJhY2s7CiAgICAgdWlDbGllbnQuZGVjaWRlUG9saWN5Rm9yVXNlck1lZGlhUGVybWlzc2lvblJl cXVlc3QgPSBkZWNpZGVQb2xpY3lGb3JVc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdENhbGxCYWNr OwogCisgICAgUGxhdGZvcm1XZWJWaWV3IHdlYlZpZXcoY29udGV4dC5nZXQoKSwgcGFnZUdyb3Vw LmdldCgpKTsKICAgICBXS1BhZ2VTZXRQYWdlVUlDbGllbnQod2ViVmlldy5wYWdlKCksICZ1aUNs aWVudC5iYXNlKTsKKyAgICBXS1BhZ2VTZXRQYWdlTG9hZGVyQ2xpZW50KHdlYlZpZXcucGFnZSgp LCAmbG9hZGVyQ2xpZW50LmJhc2UpOwogCi0gICAgZG9uZSA9IGZhbHNlOwogICAgIGF1dG8gdXJs ID0gYWRvcHRXSyhVdGlsOjpjcmVhdGVVUkxGb3JSZXNvdXJjZSgiZ2V0VXNlck1lZGlhIiwgImh0 bWwiKSk7CisgICAgQVNTRVJUKHVybC5nZXQoKSk7CiAgICAgV0tQYWdlTG9hZFVSTCh3ZWJWaWV3 LnBhZ2UoKSwgdXJsLmdldCgpKTsKKyAgICBVdGlsOjpydW4oJmRpZEZpbmlzaExvYWQpOworCisg ICAgV0tNZWRpYVN0YXRlIGNhcHR1cmVTdGF0ZSA9IFdLUGFnZUdldE1lZGlhU3RhdGUod2ViVmll dy5wYWdlKCkpOworICAgIEVYUEVDVF9GQUxTRShjYXB0dXJlU3RhdGUgJiBrV0tNZWRpYUhhc0Fj dGl2ZVZpZGVvQ2FwdHVyZURldmljZSk7CisgICAgRVhQRUNUX0ZBTFNFKGNhcHR1cmVTdGF0ZSAm IGtXS01lZGlhSGFzQWN0aXZlQXVkaW9DYXB0dXJlRGV2aWNlKTsKKworICAgIFdLUGFnZVJ1bkph dmFTY3JpcHRJbk1haW5GcmFtZSh3ZWJWaWV3LnBhZ2UoKSwgVXRpbDo6dG9XSygicmVxdWVzdEFj Y2VzcygpIikuZ2V0KCksIDAsIG51bGxKYXZhU2NyaXB0Q2FsbGJhY2spOworICAgIFV0aWw6OnJ1 bigmd2FzUHJvbXB0ZWQpOworCisgICAgY2FwdHVyZVN0YXRlID0gV0tQYWdlR2V0TWVkaWFTdGF0 ZSh3ZWJWaWV3LnBhZ2UoKSk7CisgICAgaWYgKCEoY2FwdHVyZVN0YXRlICYga1dLTWVkaWFIYXNB Y3RpdmVWaWRlb0NhcHR1cmVEZXZpY2UpKSB7CisgICAgICAgIFV0aWw6OnJ1bigmaXNQbGF5aW5n Q2hhbmdlZCk7CisgICAgICAgIGNhcHR1cmVTdGF0ZSA9IFdLUGFnZUdldE1lZGlhU3RhdGUod2Vi Vmlldy5wYWdlKCkpOworICAgIH0KKworICAgIEVYUEVDVF9UUlVFKGNhcHR1cmVTdGF0ZSAmIGtX S01lZGlhSGFzQWN0aXZlVmlkZW9DYXB0dXJlRGV2aWNlKTsKKyAgICBFWFBFQ1RfRkFMU0UoY2Fw dHVyZVN0YXRlICYga1dLTWVkaWFIYXNBY3RpdmVBdWRpb0NhcHR1cmVEZXZpY2UpOwogCi0gICAg VXRpbDo6cnVuKCZkb25lKTsKKyAgICBpc1BsYXlpbmdDaGFuZ2VkID0gZmFsc2U7CisgICAgV0tQ YWdlTG9hZFVSTCh3ZWJWaWV3LnBhZ2UoKSwgYWRvcHRXSyhVdGlsOjpjcmVhdGVVUkxGb3JSZXNv dXJjZSgic2ltcGxlIiwgImh0bWwiKSkuZ2V0KCkpOworICAgIFV0aWw6OnJ1bigmaXNQbGF5aW5n Q2hhbmdlZCk7CisKKyAgICBjYXB0dXJlU3RhdGUgPSBXS1BhZ2VHZXRNZWRpYVN0YXRlKHdlYlZp ZXcucGFnZSgpKTsKKyAgICBFWFBFQ1RfRkFMU0UoY2FwdHVyZVN0YXRlICYga1dLTWVkaWFIYXNB Y3RpdmVWaWRlb0NhcHR1cmVEZXZpY2UpOworICAgIEVYUEVDVF9GQUxTRShjYXB0dXJlU3RhdGUg JiBrV0tNZWRpYUhhc0FjdGl2ZUF1ZGlvQ2FwdHVyZURldmljZSk7CiB9CiAKIH0gLy8gbmFtZXNw YWNlIFRlc3RXZWJLaXRBUEkKSW5kZXg6IFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0 Mi9nZXRVc2VyTWVkaWEuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYktpdDIvZ2V0VXNlck1lZGlhLmh0bWwJKHJldmlzaW9uIDIxMzE0OCkKKysrIFRvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mi9nZXRVc2VyTWVkaWEuaHRtbAkod29ya2luZyBj b3B5KQpAQCAtMSwxNCArMSwxNSBAQAotPHNjcmlwdD4KLWZ1bmN0aW9uIGdvdFVzZXJNZWRpYSht ZWRpYVN0cmVhbSkKLXsKLSAgICBjb25zb2xlLmxvZygiR290IHVzZXIgbWVkaWEiKTsKLX0KLQot ZnVuY3Rpb24gdXNlck1lZGlhRXJyb3IoZXJyb3IpCi17Ci0gICAgY29uc29sZS5sb2coZXJyb3Ip OwotfQotCi12YXIgb3B0aW9ucyA9IHsgYXVkaW86IGZhbHNlLCB2aWRlbzogdHJ1ZX07Ci1uYXZp Z2F0b3Iud2Via2l0R2V0VXNlck1lZGlhKG9wdGlvbnMsIGdvdFVzZXJNZWRpYSwgdXNlck1lZGlh RXJyb3IpOwotPC9zY3JpcHQ+Cis8aHRtbD4KKyAgICA8aGVhZD4KKyAgICAgICAgPHNjcmlwdD4K KyAgICAgICAgICAgIGZ1bmN0aW9uIHJlcXVlc3RBY2Nlc3MoKQorICAgICAgICAgICAgeworICAg ICAgICAgICAgICAgIHZhciBvcHRpb25zID0geyBhdWRpbzogZmFsc2UsIHZpZGVvOiB0cnVlIH07 CisgICAgICAgICAgICAgICAgbmF2aWdhdG9yLm1lZGlhRGV2aWNlcy5nZXRVc2VyTWVkaWEob3B0 aW9ucykKKyAgICAgICAgICAgICAgICAgICAgLnRoZW4oc3RyZWFtID0+IHsgY29uc29sZS5sb2co IkdvdCB1c2VyIG1lZGlhIik7IH0pCisgICAgICAgICAgICAgICAgICAgIC5jYXRjaChlcnJvciA9 PiB7IGNvbnNvbGUubG9nKGVycm9yKTsgfSk7CisgICAgICAgICAgICB9CisgICAgICAgIDwvc2Ny aXB0PgorICAgIDwvaGVhZD4KKyAgICA8Ym9keT4KKyAgICA8L2JvZHk+Cis8L2h0bWw+Cg==