168999 2017-02-28 15:51:49 -0800 Web Inspector: RTL: expose the Layout Direction setting in Production builds, keep using LTR by default 2017-02-28 21:31:30 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg hi bburg commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1282014 0 bburg 2017-02-28 15:51:49 -0800 We know of some major things that need work (Timeline tab and DataGrid), but the rest is probably ready for wider feedback. 1282015 1 webkit-bug-importer 2017-02-28 15:52:05 -0800 <rdar://problem/30769594> 1282101 2 hi 2017-02-28 18:11:24 -0800 So do you mean exposing the setting, or allowing those with a RTL system language to use the RTL layout? 1282126 3 bburg 2017-02-28 19:21:44 -0800 (In reply to comment #2) > So do you mean exposing the setting, or allowing those with a RTL system > language to use the RTL layout? This bug is to move the engineering-only Setting in Settings Tab to be always available. So someone could test it out with Safari Technology Preview but we won't show RTL to anyone unless they opt in to it by changing the setting themselves. When RTL support is far enough along, we'll just remove this and make it always inherit the system layout direction. I don't think it's quite there yet. 1282136 4 303031 hi 2017-02-28 20:27:47 -0800 Created attachment 303031 Patch 1282140 5 303031 bburg 2017-02-28 20:56:24 -0800 Comment on attachment 303031 Patch r=me 1282144 6 303031 commit-queue 2017-02-28 21:31:25 -0800 Comment on attachment 303031 Patch Clearing flags on attachment: 303031 Committed r213205: <http://trac.webkit.org/changeset/213205> 1282145 7 commit-queue 2017-02-28 21:31:30 -0800 All reviewed patches have been landed. Closing bug. 303031 2017-02-28 20:27:47 -0800 2017-02-28 21:31:25 -0800 Patch bug-168999-20170228202450.patch text/plain 6013 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDNhZDJhNjhiZmFhZWIyZjY0MmY3ZjVhYzY5MDEz ZDRmZWVhZDA2OTYuLjQzMjhjYTcyODIxNDE1MmI3Y2I4NzFjZjNjZjIwMGQyZDlkNzY1ZWIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE3LTAyLTI4ICBEZXZp biBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgogCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFJUTDogZXhwb3NlIHRoZSBMYXlvdXQgRGlyZWN0aW9uIHNldHRpbmcgaW4gUHJvZHVj dGlvbiBidWlsZHMsIGtlZXAgdXNpbmcgTFRSIGJ5IGRlZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODk5OQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTG9jYWxpemF0aW9ucy9lbi5scHJvai9s b2NhbGl6ZWRTdHJpbmdzLmpzOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvU2V0dGlu Z3NUYWJDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TZXR0aW5nc1RhYkNv bnRlbnRWaWV3LnByb3RvdHlwZS5sYXlvdXQpOgorICAgICAgICBSZW1vdmUgdGhlIFdlYkluc3Bl Y3Rvci5pc0RlYnVnVUlFbmFibGVkKCkgY2hlY2sgYXJvdW5kIHRoZSBMYXlvdXQgRGlyZWN0aW9u IHNldHRpbmcuCisKKzIwMTctMDItMjggIERldmluIFJvdXNzbyAgPGRjcm91c3NvK3dlYmtpdEBn bWFpbC5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogSXQgaXMgcG9zc2libGUgdG8gZ2V0 IHRoZSBOZXcgVGFiIGJ1dHRvbiBpbiBhZGRpdGlvbiB0byB0aGUgc2V2ZW4gZXhwZWN0ZWQgdGFi cwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4OTc2 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxw cm9qL2xvY2FsaXplZFN0cmluZ3MuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvTG9jYWxpemF0 aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCmluZGV4IGQ0ZmZmNWE1ZjRhMmU0NjIw MGMzNTliMGVkZWEwMjBiYTY0OGE1NzQuLmRjYzZmMDFlMWRlZDc5NzkwN2MxMDJhOGJhMWI0MWRh YjVjNWUxNWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25z L2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwpAQCAtNDU2LDggKzQ1 NiwxMCBAQCBsb2NhbGl6ZWRTdHJpbmdzWyJMYXllciBJbmZvIl0gPSAiTGF5ZXIgSW5mbyI7CiBs b2NhbGl6ZWRTdHJpbmdzWyJMYXllcnMiXSA9ICJMYXllcnMiOwogbG9jYWxpemVkU3RyaW5nc1si TGF5b3V0Il0gPSAiTGF5b3V0IjsKIGxvY2FsaXplZFN0cmluZ3NbIkxheW91dCAmIFJlbmRlcmlu ZyJdID0gIkxheW91dCAmIFJlbmRlcmluZyI7Citsb2NhbGl6ZWRTdHJpbmdzWyJMYXlvdXQgRGly ZWN0aW9uOiJdID0gIkxheW91dCBEaXJlY3Rpb246IjsKIGxvY2FsaXplZFN0cmluZ3NbIkxheW91 dCBJbnZhbGlkYXRlZCJdID0gIkxheW91dCBJbnZhbGlkYXRlZCI7CiBsb2NhbGl6ZWRTdHJpbmdz WyJMZWZ0Il0gPSAiTGVmdCI7Citsb2NhbGl6ZWRTdHJpbmdzWyJMZWZ0IHRvIFJpZ2h0IChMVFIp Il0gPSAiTGVmdCB0byBSaWdodCAoTFRSKSI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJMZXR0ZXIiXSA9 ICJMZXR0ZXIiOwogbG9jYWxpemVkU3RyaW5nc1siTGlnYXR1cmVzIl0gPSAiTGlnYXR1cmVzIjsK IGxvY2FsaXplZFN0cmluZ3NbIkxpbmUgJWQiXSA9ICJMaW5lICVkIjsKQEAgLTY1MCw2ICs2NTIs NyBAQCBsb2NhbGl6ZWRTdHJpbmdzWyJSZXZlYWwgaW4gRGVidWdnZXIgVGFiIl0gPSAiUmV2ZWFs IGluIERlYnVnZ2VyIFRhYiI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJSZXZlYWwgaW4gT3JpZ2luYWwg UmVzb3VyY2UiXSA9ICJSZXZlYWwgaW4gT3JpZ2luYWwgUmVzb3VyY2UiOwogbG9jYWxpemVkU3Ry aW5nc1siUmV2ZWFsIGluIFJlc291cmNlcyBUYWIiXSA9ICJSZXZlYWwgaW4gUmVzb3VyY2VzIFRh YiI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJSaWdodCJdID0gIlJpZ2h0IjsKK2xvY2FsaXplZFN0cmlu Z3NbIlJpZ2h0IHRvIExlZnQgKFJUTCkiXSA9ICJSaWdodCB0byBMZWZ0IChSVEwpIjsKIGxvY2Fs aXplZFN0cmluZ3NbIlJvbGUiXSA9ICJSb2xlIjsKIGxvY2FsaXplZFN0cmluZ3NbIlJ1bGUiXSA9 ICJSdWxlIjsKIGxvY2FsaXplZFN0cmluZ3NbIlNhbXBsZXMiXSA9ICJTYW1wbGVzIjsKQEAgLTc2 Miw2ICs3NjUsNyBAQCBsb2NhbGl6ZWRTdHJpbmdzWyJTdHlsZXMgXHUyMDE0IFJ1bGVzIl0gPSAi U3R5bGVzIFx1MjAxNCBSdWxlcyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJTdHlsZXMgXHUyMDE0IFZp c3VhbCJdID0gIlN0eWxlcyBcdTIwMTQgVmlzdWFsIjsKIGxvY2FsaXplZFN0cmluZ3NbIlN0eWxl c2hlZXQiXSA9ICJTdHlsZXNoZWV0IjsKIGxvY2FsaXplZFN0cmluZ3NbIlN0eWxlc2hlZXRzIl0g PSAiU3R5bGVzaGVldHMiOworbG9jYWxpemVkU3RyaW5nc1siU3lzdGVtIERlZmF1bHQiXSA9ICJT eXN0ZW0gRGVmYXVsdCI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJUYWIgd2lkdGg6Il0gPSAiVGFiIHdp ZHRoOiI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJUYWJzIl0gPSAiVGFicyI7CiBsb2NhbGl6ZWRTdHJp bmdzWyJUYWtlIHNuYXBzaG90Il0gPSAiVGFrZSBzbmFwc2hvdCI7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZXR0aW5nc1RhYkNvbnRlbnRW aWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2V0dGlu Z3NUYWJDb250ZW50Vmlldy5qcwppbmRleCAwOWFiNGNiYzUyMjBhZWY5M2ZkZmFlMGNkYzFkMjI4 ODFlNWQxNzZkLi5iNGVkMmM5NjMwOTg0ODFiOWEyMWNkNDI5MDZiMWI3MGFkNTk4NTUyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZXR0aW5n c1RhYkNvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1NldHRpbmdzVGFiQ29udGVudFZpZXcuanMKQEAgLTE5MSwzMCArMTkxLDI4IEBA IFdlYkluc3BlY3Rvci5TZXR0aW5nc1RhYkNvbnRlbnRWaWV3ID0gY2xhc3MgU2V0dGluZ3NUYWJD b250ZW50VmlldyBleHRlbmRzIFdlYkluCiAgICAgICAgICAgICB9KTsKICAgICAgICAgfSk7CiAK LSAgICAgICAgaWYgKFdlYkluc3BlY3Rvci5pc0RlYnVnVUlFbmFibGVkKCkpIHsKLSAgICAgICAg ICAgIHRoaXMuZWxlbWVudC5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJiciIp KTsKLQotICAgICAgICAgICAgY3JlYXRlQ29udGFpbmVyKFdlYkluc3BlY3Rvci51bmxvY2FsaXpl ZFN0cmluZygiTGF5b3V0IERpcmVjdGlvbjoiKSwgKHZhbHVlQ29udHJvbGxlckNvbnRhaW5lcikg PT4gewotICAgICAgICAgICAgICAgIGxldCBzZWxlY3RFbGVtZW50ID0gdmFsdWVDb250cm9sbGVy Q29udGFpbmVyLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInNlbGVjdCIpKTsK LSAgICAgICAgICAgICAgICBzZWxlY3RFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImNoYW5nZSIs IChldmVudCkgPT4gewotICAgICAgICAgICAgICAgICAgICBXZWJJbnNwZWN0b3Iuc2V0TGF5b3V0 RGlyZWN0aW9uKHNlbGVjdEVsZW1lbnQudmFsdWUpOwotICAgICAgICAgICAgICAgIH0pOwotCi0g ICAgICAgICAgICAgICAgbGV0IGN1cnJlbnRMYXlvdXREaXJlY3Rpb24gPSBXZWJJbnNwZWN0b3Iu c2V0dGluZ3MubGF5b3V0RGlyZWN0aW9uLnZhbHVlOwotICAgICAgICAgICAgICAgIGxldCBvcHRp b25zID0gbmV3IE1hcChbCi0gICAgICAgICAgICAgICAgICAgIFtXZWJJbnNwZWN0b3IuTGF5b3V0 RGlyZWN0aW9uLlN5c3RlbSwgV2ViSW5zcGVjdG9yLnVubG9jYWxpemVkU3RyaW5nKCJTeXN0ZW0g RGVmYXVsdCIpXSwKLSAgICAgICAgICAgICAgICAgICAgW1dlYkluc3BlY3Rvci5MYXlvdXREaXJl Y3Rpb24uTFRSLCBXZWJJbnNwZWN0b3IudW5sb2NhbGl6ZWRTdHJpbmcoIkxlZnQgdG8gUmlnaHQg KExUUikiKV0sCi0gICAgICAgICAgICAgICAgICAgIFtXZWJJbnNwZWN0b3IuTGF5b3V0RGlyZWN0 aW9uLlJUTCwgV2ViSW5zcGVjdG9yLnVubG9jYWxpemVkU3RyaW5nKCJSaWdodCB0byBMZWZ0IChS VEwpIildLAotICAgICAgICAgICAgICAgIF0pOwotCi0gICAgICAgICAgICAgICAgZm9yIChsZXQg W2tleSwgdmFsdWVdIG9mIG9wdGlvbnMpIHsKLSAgICAgICAgICAgICAgICAgICAgbGV0IG9wdGlv bkVsZW1lbnQgPSBzZWxlY3RFbGVtZW50LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1l bnQoIm9wdGlvbiIpKTsKLSAgICAgICAgICAgICAgICAgICAgb3B0aW9uRWxlbWVudC52YWx1ZSA9 IGtleTsKLSAgICAgICAgICAgICAgICAgICAgb3B0aW9uRWxlbWVudC50ZXh0Q29udGVudCA9IHZh bHVlOwotICAgICAgICAgICAgICAgICAgICBvcHRpb25FbGVtZW50LnNlbGVjdGVkID0gY3VycmVu dExheW91dERpcmVjdGlvbiA9PT0ga2V5OwotICAgICAgICAgICAgICAgIH0KKyAgICAgICAgdGhp cy5lbGVtZW50LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImJyIikpOworCisg ICAgICAgIGNyZWF0ZUNvbnRhaW5lcihXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkxheW91dCBEaXJl Y3Rpb246IiksICh2YWx1ZUNvbnRyb2xsZXJDb250YWluZXIpID0+IHsKKyAgICAgICAgICAgIGxl dCBzZWxlY3RFbGVtZW50ID0gdmFsdWVDb250cm9sbGVyQ29udGFpbmVyLmFwcGVuZENoaWxkKGRv Y3VtZW50LmNyZWF0ZUVsZW1lbnQoInNlbGVjdCIpKTsKKyAgICAgICAgICAgIHNlbGVjdEVsZW1l bnQuYWRkRXZlbnRMaXN0ZW5lcigiY2hhbmdlIiwgKGV2ZW50KSA9PiB7CisgICAgICAgICAgICAg ICAgV2ViSW5zcGVjdG9yLnNldExheW91dERpcmVjdGlvbihzZWxlY3RFbGVtZW50LnZhbHVlKTsK ICAgICAgICAgICAgIH0pOwotICAgICAgICB9CisKKyAgICAgICAgICAgIGxldCBjdXJyZW50TGF5 b3V0RGlyZWN0aW9uID0gV2ViSW5zcGVjdG9yLnNldHRpbmdzLmxheW91dERpcmVjdGlvbi52YWx1 ZTsKKyAgICAgICAgICAgIGxldCBvcHRpb25zID0gbmV3IE1hcChbCisgICAgICAgICAgICAgICAg W1dlYkluc3BlY3Rvci5MYXlvdXREaXJlY3Rpb24uU3lzdGVtLCBXZWJJbnNwZWN0b3IuVUlTdHJp bmcoIlN5c3RlbSBEZWZhdWx0IildLAorICAgICAgICAgICAgICAgIFtXZWJJbnNwZWN0b3IuTGF5 b3V0RGlyZWN0aW9uLkxUUiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJMZWZ0IHRvIFJpZ2h0IChM VFIpIildLAorICAgICAgICAgICAgICAgIFtXZWJJbnNwZWN0b3IuTGF5b3V0RGlyZWN0aW9uLlJU TCwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJSaWdodCB0byBMZWZ0IChSVEwpIildLAorICAgICAg ICAgICAgXSk7CisKKyAgICAgICAgICAgIGZvciAobGV0IFtrZXksIHZhbHVlXSBvZiBvcHRpb25z KSB7CisgICAgICAgICAgICAgICAgbGV0IG9wdGlvbkVsZW1lbnQgPSBzZWxlY3RFbGVtZW50LmFw cGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoIm9wdGlvbiIpKTsKKyAgICAgICAgICAg ICAgICBvcHRpb25FbGVtZW50LnZhbHVlID0ga2V5OworICAgICAgICAgICAgICAgIG9wdGlvbkVs ZW1lbnQudGV4dENvbnRlbnQgPSB2YWx1ZTsKKyAgICAgICAgICAgICAgICBvcHRpb25FbGVtZW50 LnNlbGVjdGVkID0gY3VycmVudExheW91dERpcmVjdGlvbiA9PT0ga2V5OworICAgICAgICAgICAg fQorICAgICAgICB9KTsKICAgICB9CiB9OwogCg==