168990 2017-02-28 14:23:00 -0800 [WebRTC] CPU Overuse libwebrtc detector is decreasing the quality of the video 2017-02-28 15:24:29 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf achristensen commit-queue eric.carlson oldest_to_newest 1281957 0 youennf 2017-02-28 14:23:00 -0800 For now, we can just disable it. We should at the end investigate the different strategies in that case. 1281959 1 302986 youennf 2017-02-28 14:25:08 -0800 Created attachment 302986 Patch 1281967 2 302986 eric.carlson 2017-02-28 14:50:29 -0800 Comment on attachment 302986 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302986&action=review > Source/ThirdParty/libwebrtc/ChangeLog:4 > + Fix 168990 > + Nit: this isn't necessary. > Source/ThirdParty/libwebrtc/Source/webrtc/video/vie_encoder.cc:791 > + //WEBKIT Change: We disable OveruseDetected for now. Nit: space after the "//" 1281983 3 302994 youennf 2017-02-28 15:09:27 -0800 Created attachment 302994 Patch for landing 1281984 4 youennf 2017-02-28 15:09:57 -0800 Thanks for the review. (In reply to comment #2) > Comment on attachment 302986 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302986&action=review > > > Source/ThirdParty/libwebrtc/ChangeLog:4 > > + Fix 168990 > > + > > Nit: this isn't necessary. OK > > Source/ThirdParty/libwebrtc/Source/webrtc/video/vie_encoder.cc:791 > > + //WEBKIT Change: We disable OveruseDetected for now. > > Nit: space after the "//" Done 1281997 5 302994 commit-queue 2017-02-28 15:24:24 -0800 Comment on attachment 302994 Patch for landing Clearing flags on attachment: 302994 Committed r213184: <http://trac.webkit.org/changeset/213184> 1281998 6 commit-queue 2017-02-28 15:24:29 -0800 All reviewed patches have been landed. Closing bug. 302986 2017-02-28 14:25:08 -0800 2017-02-28 15:09:24 -0800 Patch bug-168990-20170228142212.patch text/plain 1842 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzMDgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCBiY2YxZTQzMjBhNWZjZDcxODI4Zjk4ZjQ4NDE3OWJlMzhlNTJiMGQ2Li5mOTBh ZTQ3NGIwZTllMWQwYTk1Y2RiZTFhMDIwNjEzMDU5MWIxMjA1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNiBAQAogMjAxNy0wMi0yOCAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKKyAgICAgICAgRml4IDE2ODk5MAorCisgICAgICAg IFtXZWJSVENdIENQVSBPdmVydXNlIGxpYndlYnJ0YyBkZXRlY3RvciBpcyBkZWNyZWFzaW5nIHRo ZSBxdWFsaXR5IG9mIHRoZSB2aWRlbworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTY4OTkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBTb3VyY2Uvd2VicnRjL3ZpZGVvL3ZpZV9lbmNvZGVyLmNjOiBEaXNh YmxpbmcgdGVtcG9yYXJpbHkgb3ZlcnVzZSBkZXRlY3Rvci4KKworMjAxNy0wMi0yOCAgWW91ZW5u IEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKICAgICAgICAgZml4IDE2ODk3MwogCiAgICAg ICAgIFtXZWJSVENdIExpYldlYlJUQyBmcmFtZSBkcm9wcGVyIGlzIG5vdCB3b3JraW5nIGNvbnNp c3RlbnRseQpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93 ZWJydGMvdmlkZW8vdmllX2VuY29kZXIuY2MgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMv U291cmNlL3dlYnJ0Yy92aWRlby92aWVfZW5jb2Rlci5jYwppbmRleCA3Y2M3OTlhNjQ0MDU4Mjkx ZGQ1Nzc5MjdiNDdhZjkxZTZjZjVjODVjLi41ZDE4ZjJhMDcwMjVhOWNiMDViZGNkMWMzZjAxMGU0 M2E5ZTI3NjIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNl L3dlYnJ0Yy92aWRlby92aWVfZW5jb2Rlci5jYworKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3 ZWJydGMvU291cmNlL3dlYnJ0Yy92aWRlby92aWVfZW5jb2Rlci5jYwpAQCAtNzg3LDYgKzc4Nywx MCBAQCB2b2lkIFZpRUVuY29kZXI6Ok9uQml0cmF0ZVVwZGF0ZWQodWludDMyX3QgYml0cmF0ZV9i cHMsCiB9CiAKIHZvaWQgVmlFRW5jb2Rlcjo6T3ZlcnVzZURldGVjdGVkKCkgeworI2lmIGRlZmlu ZWQoV0VCUlRDX1dFQktJVF9CVUlMRCkKKyAgLy9XRUJLSVQgQ2hhbmdlOiBXZSBkaXNhYmxlIE92 ZXJ1c2VEZXRlY3RlZCBmb3Igbm93LgorICAvLyBGSVhNRTogSW52ZXN0aWdhdGUgdXNpbmcgaXQu IFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4OTkwLgorI2Vs c2UKICAgUlRDX0RDSEVDS19SVU5fT04oJmVuY29kZXJfcXVldWVfKTsKICAgaWYgKGRlZ3JhZGF0 aW9uX3ByZWZlcmVuY2VfID09CiAgICAgICAgICAgVmlkZW9TZW5kU3RyZWFtOjpEZWdyYWRhdGlv blByZWZlcmVuY2U6OmtNYWludGFpblJlc29sdXRpb24gfHwKQEAgLTgwNSw2ICs4MDksNyBAQCB2 b2lkIFZpRUVuY29kZXI6Ok92ZXJ1c2VEZXRlY3RlZCgpIHsKICAgICArK2NwdV9yZXN0cmljdGVk X2NvdW50ZXJfOwogICAgIHNvdXJjZV9wcm94eV8tPlJlcXVlc3RSZXNvbHV0aW9uTG93ZXJUaGFu KGN1cnJlbnRfcGl4ZWxfY291bnQpOwogICB9CisjZW5kaWYKIH0KIAogdm9pZCBWaUVFbmNvZGVy OjpOb3JtYWxVc2FnZSgpIHsK 302994 2017-02-28 15:09:27 -0800 2017-02-28 15:24:24 -0800 Patch for landing bug-168990-20170228150631.patch text/plain 1788 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzMTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCA1MmI2MjQ1YjAxNGNmOWU5N2EzN2U2ZDRiZDMxMDAwODJjNTkxMTI5Li40NDlm NTkwMzdiMzk0NjM3NzU1MDc3MTZlNDMyZWZlZjZjNjk0NjNjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNy0wMi0yOCAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYlJUQ10gQ1BVIE92ZXJ1c2Ug bGlid2VicnRjIGRldGVjdG9yIGlzIGRlY3JlYXNpbmcgdGhlIHF1YWxpdHkgb2YgdGhlIHZpZGVv CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg5OTAK KworICAgICAgICBSZXZpZXdlZCBieSBFcmljIENhcmxzb24uCisKKyAgICAgICAgKiBTb3VyY2Uv d2VicnRjL3ZpZGVvL3ZpZV9lbmNvZGVyLmNjOiBEaXNhYmxpbmcgdGVtcG9yYXJpbHkgb3ZlcnVz ZSBkZXRlY3Rvci4KKwogMjAxNy0wMi0yOCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNl bkB3ZWJraXQub3JnPgogCiAgICAgICAgIFtXZWJSVENdIEZpeCBhbiBpbnRlcm5hbCBwcm9kdWN0 aW9uIGJ1aWxkCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNl L3dlYnJ0Yy92aWRlby92aWVfZW5jb2Rlci5jYyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0 Yy9Tb3VyY2Uvd2VicnRjL3ZpZGVvL3ZpZV9lbmNvZGVyLmNjCmluZGV4IDdjYzc5OWE2NDQwNTgy OTFkZDU3NzkyN2I0N2FmOTFlNmNmNWM4NWMuLjRiOGQ2MDVkNmNkY2VjYTdlYTcyZDZmMGM0MGNj MzhjMWVkZjIyYWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3Vy Y2Uvd2VicnRjL3ZpZGVvL3ZpZV9lbmNvZGVyLmNjCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3ZpZGVvL3ZpZV9lbmNvZGVyLmNjCkBAIC03ODcsNiArNzg3 LDEwIEBAIHZvaWQgVmlFRW5jb2Rlcjo6T25CaXRyYXRlVXBkYXRlZCh1aW50MzJfdCBiaXRyYXRl X2JwcywKIH0KIAogdm9pZCBWaUVFbmNvZGVyOjpPdmVydXNlRGV0ZWN0ZWQoKSB7CisjaWYgZGVm aW5lZChXRUJSVENfV0VCS0lUX0JVSUxEKQorICAvLyBXRUJLSVQgQ2hhbmdlOiBXZSBkaXNhYmxl IE92ZXJ1c2VEZXRlY3RlZCBmb3Igbm93LgorICAvLyBGSVhNRTogSW52ZXN0aWdhdGUgdXNpbmcg aXQuIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4OTkwLgor I2Vsc2UKICAgUlRDX0RDSEVDS19SVU5fT04oJmVuY29kZXJfcXVldWVfKTsKICAgaWYgKGRlZ3Jh ZGF0aW9uX3ByZWZlcmVuY2VfID09CiAgICAgICAgICAgVmlkZW9TZW5kU3RyZWFtOjpEZWdyYWRh dGlvblByZWZlcmVuY2U6OmtNYWludGFpblJlc29sdXRpb24gfHwKQEAgLTgwNSw2ICs4MDksNyBA QCB2b2lkIFZpRUVuY29kZXI6Ok92ZXJ1c2VEZXRlY3RlZCgpIHsKICAgICArK2NwdV9yZXN0cmlj dGVkX2NvdW50ZXJfOwogICAgIHNvdXJjZV9wcm94eV8tPlJlcXVlc3RSZXNvbHV0aW9uTG93ZXJU aGFuKGN1cnJlbnRfcGl4ZWxfY291bnQpOwogICB9CisjZW5kaWYKIH0KIAogdm9pZCBWaUVFbmNv ZGVyOjpOb3JtYWxVc2FnZSgpIHsK