168984 2017-02-28 12:52:30 -0800 Web Inspector: DOMTreeManager dispatches DocumentUpdated twice when the document is cleared 2017-03-09 09:40:13 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 mattbaker mattbaker commit-queue inspector-bugzilla-changes oldest_to_newest 1281881 0 mattbaker 2017-02-28 12:52:30 -0800 Summary: DOMTreeManager dispatches DocumentUpdated twice when the document is cleared. Note: The backend is dispatching two DOM.documentUpdated events, which seems odd, but the frontend should handle it gracefully regardless. 1281918 1 302974 mattbaker 2017-02-28 13:38:25 -0800 Created attachment 302974 Patch 1281922 2 302977 mattbaker 2017-02-28 13:46:33 -0800 Created attachment 302977 [Test] LayoutTests/inspector/dom/dom-document-updated-event.html The layout test intended for this patch times out. It looks like the DocumentUpdated event is never dispatched. 1281925 3 302974 hi 2017-02-28 13:47:20 -0800 Comment on attachment 302974 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302974&action=review > Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:209 > + if (this._document === newDocument) I might be wrong about this, but I thought that comparing Objects doesn't work unless both variables literally hold the same object. As such, wouldn't this if statement never trigger? let a = {x: 1, y: 2}; let b = {x: 1, y: 2}; console.log(a === b); // false 1281926 4 302978 mattbaker 2017-02-28 13:47:54 -0800 Created attachment 302978 [Test] LayoutTests/inspector/dom/dom-document-updated-event.html Fix typo in test. 1281928 5 302974 mattbaker 2017-02-28 13:49:11 -0800 Comment on attachment 302974 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302974&action=review >> Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:209 >> + if (this._document === newDocument) > > I might be wrong about this, but I thought that comparing Objects doesn't work unless both variables literally hold the same object. As such, wouldn't this if statement never trigger? > > let a = {x: 1, y: 2}; > let b = {x: 1, y: 2}; > console.log(a === b); // false You are correct. This addresses the case where the document is null, and being set to null again. 1284116 6 mattbaker 2017-03-06 18:53:57 -0800 (In reply to comment #2) > Created attachment 302977 [details] > [Test] LayoutTests/inspector/dom/dom-document-updated-event.html > > The layout test intended for this patch times out. It looks like the > DocumentUpdated event is never dispatched. The backend only dispatches DocumentUpdated is the document has been requested. Rewriting test. 1285336 7 302974 timothy 2017-03-09 09:12:43 -0800 Comment on attachment 302974 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302974&action=review >>> Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:209 >>> + if (this._document === newDocument) >> >> I might be wrong about this, but I thought that comparing Objects doesn't work unless both variables literally hold the same object. As such, wouldn't this if statement never trigger? >> >> let a = {x: 1, y: 2}; >> let b = {x: 1, y: 2}; >> console.log(a === b); // false > > You are correct. This addresses the case where the document is null, and being set to null again. Matt is right. This would also just start working in the future if `new WebInspector.DOMNode` started returning the same (cached) object with the same node id. 1285349 8 302974 commit-queue 2017-03-09 09:40:09 -0800 Comment on attachment 302974 Patch Clearing flags on attachment: 302974 Committed r213644: <http://trac.webkit.org/changeset/213644> 1285350 9 commit-queue 2017-03-09 09:40:13 -0800 All reviewed patches have been landed. Closing bug. 302974 2017-02-28 13:38:25 -0800 2017-03-09 09:40:09 -0800 Patch bug-168984-20170228133533.patch text/plain 2077 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzMTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA3 NDQyNGI1MTNjMThiMmQxYjVlN2M0OTcyZWY1OTc4YzM5ZWUyYjYwLi5lMTFiNzI2ZTVmZjA1NDYw MDViNjgwZWJiNzg5YTQ2MGQ2ZTY1Mzg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNy0wMi0yOCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRE9NVHJlZU1hbmFnZXIgZGlzcGF0Y2hlcyBEb2N1 bWVudFVwZGF0ZWQgdHdpY2Ugd2hlbiB0aGUgZG9jdW1lbnQgaXMgY2xlYXJlZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4OTg0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Nv bnRyb2xsZXJzL0RPTVRyZWVNYW5hZ2VyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTVRy ZWVNYW5hZ2VyLnByb3RvdHlwZS5fc2V0RG9jdW1lbnQpOgorICAgICAgICBDb21wYXJlIG9sZCBh bmQgbmV3IGRvY3VtZW50IHZhbHVlcyBiZWZvcmUgZGlzcGF0Y2hpbmcgbWVzc2FnZS4KKwogMjAx Ny0wMi0yNSAgRGV2aW4gUm91c3NvICA8ZGNyb3Vzc28rd2Via2l0QGdtYWlsLmNvbT4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBSVEw6IGFkZCBzdXBwb3J0IGZvciBDb2xvciBQaWNrZXIKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJz L0RPTVRyZWVNYW5hZ2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Q29udHJvbGxlcnMvRE9NVHJlZU1hbmFnZXIuanMKaW5kZXggYzdjNDAwM2RlNDMzMjk4NGFlNDU4 YzAxOWFhMzljNWYyZmU1YjRmNi4uYzAwMGUwZmU5MzA3Y2I1ZGUyZTU3YTkyNDI2MDFkMTllNmU5 YWY1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29u dHJvbGxlcnMvRE9NVHJlZU1hbmFnZXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRE9NVHJlZU1hbmFnZXIuanMKQEAgLTIwMSwxMSArMjAx LDE2IEBAIFdlYkluc3BlY3Rvci5ET01UcmVlTWFuYWdlciA9IGNsYXNzIERPTVRyZWVNYW5hZ2Vy IGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogICAgIF9zZXREb2N1bWVudChwYXlsb2FkKQog ICAgIHsKICAgICAgICAgdGhpcy5faWRUb0RPTU5vZGUgPSB7fTsKKworICAgICAgICBsZXQgbmV3 RG9jdW1lbnQgPSBudWxsOwogICAgICAgICBpZiAocGF5bG9hZCAmJiAibm9kZUlkIiBpbiBwYXls b2FkKQotICAgICAgICAgICAgdGhpcy5fZG9jdW1lbnQgPSBuZXcgV2ViSW5zcGVjdG9yLkRPTU5v ZGUodGhpcywgbnVsbCwgZmFsc2UsIHBheWxvYWQpOwotICAgICAgICBlbHNlCi0gICAgICAgICAg ICB0aGlzLl9kb2N1bWVudCA9IG51bGw7Ci0gICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlz dGVuZXJzKFdlYkluc3BlY3Rvci5ET01UcmVlTWFuYWdlci5FdmVudC5Eb2N1bWVudFVwZGF0ZWQs IHRoaXMuX2RvY3VtZW50KTsKKyAgICAgICAgICAgIG5ld0RvY3VtZW50ID0gbmV3IFdlYkluc3Bl Y3Rvci5ET01Ob2RlKHRoaXMsIG51bGwsIGZhbHNlLCBwYXlsb2FkKTsKKworICAgICAgICBpZiAo dGhpcy5fZG9jdW1lbnQgPT09IG5ld0RvY3VtZW50KQorICAgICAgICAgICAgcmV0dXJuOworCisg ICAgICAgIHRoaXMuX2RvY3VtZW50ID0gbmV3RG9jdW1lbnQ7CisgICAgICAgIHRoaXMuZGlzcGF0 Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5ET01UcmVlTWFuYWdlci5FdmVudC5Eb2N1 bWVudFVwZGF0ZWQsIHtkb2N1bWVudDogdGhpcy5fZG9jdW1lbnR9KTsKICAgICB9CiAKICAgICBf c2V0RGV0YWNoZWRSb290KHBheWxvYWQpCg== 302977 2017-02-28 13:46:33 -0800 2017-02-28 13:47:54 -0800 [Test] LayoutTests/inspector/dom/dom-document-updated-event.html dom-document-updated-event.html text/html 1135 mattbaker PCFkb2N0eXBlIGh0bWw+CjxodG1sPgo8aGVhZD4KPHNjcmlwdCBzcmM9Ii4uLy4uL2h0dHAvdGVz dHMvaW5zcGVjdG9yL3Jlc291cmNlcy9pbnNwZWN0b3ItdGVzdC5qcyI+PC9zY3JpcHQ+CjxzY3Jp cHQ+CmZ1bmN0aW9uIHRlc3QoKQp7CiAgICBsZXQgc3VpdGUgPSBJbnNwZWN0b3JUZXN0LmNyZWF0 ZUFzeW5jU3VpdGUoIkRPTS5Eb2N1bWVudFVwZGF0ZWQiKTsKCiAgICBzdWl0ZS5hZGRUZXN0Q2Fz ZSh7CiAgICAgICAgbmFtZTogIkNoZWNrRG9jdW1lbnRVcGRhdGVkQWZ0ZXJSZWxvYWRpbmciLAog ICAgICAgIGRlc2NyaXB0aW9uOiAiQ2hlY2sgdGhhdCB0aGUgZG9jdW1lbnQgaXMgb25seSBjbGVh cmVkIG9uY2UgZHVyaW5nIHJlbG9hZC4iLAogICAgICAgIHRlc3QocmVzb2x2ZSwgcmVqZWN0KSB7 CiAgICAgICAgICAgIGxldCBkb2N1bWVudENsZWFyZWRDb3VudCA9IGZhbHNlOwogICAgICAgICAg ICBXZWJJbnNwZWN0b3IuZG9tVHJlZU1hbmFnZXIuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0 b3IuRE9NVHJlZU1hbmFnZXIuRXZlbnQuRG9jdW1lbnRVcGRhdGVkLCAoZXZlbnQpID0+IHsKICAg ICAgICAgICAgICAgIGRvY3VtZW50Q2xlYXJlZENvdW50Kys7CiAgICAgICAgICAgICAgICBJbnNw ZWN0b3JUZXN0LmxvZygiRG9jdW1lbnQgY2xlYXJlZC4iKTsKCiAgICAgICAgICAgICAgICBpZiAo ZXZlbnQuZG9jdW1lbnQpIHsKICAgICAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV4cGVj dEVxdWFsKGRvY3VtZW50Q2xlYXJlZENvdW50LCAxLCAiRG9jdW1lbnQgc2hvdWxkIGJlIGNsZWFy ZWQgZXhhY3RseSBvbmNlLiIpOwogICAgICAgICAgICAgICAgICAgIHJlc29sdmUoKTsKICAgICAg ICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgIH0pOwoK ICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5yZWxvYWRQYWdlKCk7CiAgICAgICAgfQogICAgfSk7 CgogICAgc3VpdGUucnVuVGVzdENhc2VzQW5kRmluaXNoKCk7Cn0KPC9zY3JpcHQ+CjwvaGVhZD4K PGJvZHkgb25sb2FkPSJydW5UZXN0KCkiPgo8cD5UZXN0IGZvciBXZWJJbnNwZWN0b3IuRE9NVHJl ZU1hbmFnZXIuRXZlbnQuRG9jdW1lbnRVcGRhdGVkLjwvcD4KPC9ib2R5Pgo8L2h0bWw+Cg== 302978 2017-02-28 13:47:54 -0800 2017-02-28 13:47:54 -0800 [Test] LayoutTests/inspector/dom/dom-document-updated-event.html dom-document-updated-event.html text/html 1131 mattbaker PCFkb2N0eXBlIGh0bWw+CjxodG1sPgo8aGVhZD4KPHNjcmlwdCBzcmM9Ii4uLy4uL2h0dHAvdGVz dHMvaW5zcGVjdG9yL3Jlc291cmNlcy9pbnNwZWN0b3ItdGVzdC5qcyI+PC9zY3JpcHQ+CjxzY3Jp cHQ+CmZ1bmN0aW9uIHRlc3QoKQp7CiAgICBsZXQgc3VpdGUgPSBJbnNwZWN0b3JUZXN0LmNyZWF0 ZUFzeW5jU3VpdGUoIkRPTS5Eb2N1bWVudFVwZGF0ZWQiKTsKCiAgICBzdWl0ZS5hZGRUZXN0Q2Fz ZSh7CiAgICAgICAgbmFtZTogIkNoZWNrRG9jdW1lbnRVcGRhdGVkQWZ0ZXJSZWxvYWRpbmciLAog ICAgICAgIGRlc2NyaXB0aW9uOiAiQ2hlY2sgdGhhdCB0aGUgZG9jdW1lbnQgaXMgb25seSBjbGVh cmVkIG9uY2UgZHVyaW5nIHJlbG9hZC4iLAogICAgICAgIHRlc3QocmVzb2x2ZSwgcmVqZWN0KSB7 CiAgICAgICAgICAgIGxldCBkb2N1bWVudENsZWFyZWRDb3VudCA9IDA7CiAgICAgICAgICAgIFdl Ykluc3BlY3Rvci5kb21UcmVlTWFuYWdlci5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5E T01UcmVlTWFuYWdlci5FdmVudC5Eb2N1bWVudFVwZGF0ZWQsIChldmVudCkgPT4gewogICAgICAg ICAgICAgICAgZG9jdW1lbnRDbGVhcmVkQ291bnQrKzsKICAgICAgICAgICAgICAgIEluc3BlY3Rv clRlc3QubG9nKCJEb2N1bWVudCBjbGVhcmVkLiIpOwoKICAgICAgICAgICAgICAgIGlmIChldmVu dC5kb2N1bWVudCkgewogICAgICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3QuZXhwZWN0RXF1 YWwoZG9jdW1lbnRDbGVhcmVkQ291bnQsIDEsICJEb2N1bWVudCBzaG91bGQgYmUgY2xlYXJlZCBl eGFjdGx5IG9uY2UuIik7CiAgICAgICAgICAgICAgICAgICAgcmVzb2x2ZSgpOwogICAgICAgICAg ICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgfSk7CgogICAg ICAgICAgICBJbnNwZWN0b3JUZXN0LnJlbG9hZFBhZ2UoKTsKICAgICAgICB9CiAgICB9KTsKCiAg ICBzdWl0ZS5ydW5UZXN0Q2FzZXNBbmRGaW5pc2goKTsKfQo8L3NjcmlwdD4KPC9oZWFkPgo8Ym9k eSBvbmxvYWQ9InJ1blRlc3QoKSI+CjxwPlRlc3QgZm9yIFdlYkluc3BlY3Rvci5ET01UcmVlTWFu YWdlci5FdmVudC5Eb2N1bWVudFVwZGF0ZWQuPC9wPgo8L2JvZHk+CjwvaHRtbD4K