16898 2008-01-16 18:22:43 -0800 REGRESSION: Text of entire page incorrectly center aligned 2016-09-13 02:51:56 -0700 1 1 1 Unclassified WebKit CSS 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED http://www.ffconsultancy.com/languages/ray_tracer/comparison.html HasReduction, Regression P1 Normal --- 1 esprehn kevino bdakin codecolorist hyatt webkit oldest_to_newest 67424 0 esprehn 2008-01-16 18:22:43 -0800 The referenced page has all text center aligned. Firefox 2, Opera 9 and IE6 all left align the text of the page. Using "javascript:t = document.getElementsByTagName("table"); for(i=0; i < t.length; i++) { t[i].style.textAlign = "left"; }" in the location bar after the page loads seems to correct this, so I'm going to take a guess this is a table that isn't closed somewhere spilling over across the entire page. 67694 1 ddkilzer 2008-01-19 04:09:56 -0800 This is a regression from Safari 2.0.4 (419.3) with original WebKit on Mac OS X 10.4.11 (8S165). Confirmed with a local debug build of WebKit r29623 with Safari 3.0.4 (523.12.2) on 10.4.11. 67695 2 ddkilzer 2008-01-19 04:12:54 -0800 Unfortunately this bug reproduces with the earliest known WebKit nightly build (r11976), so bisect-builds isn't going to help us. 67707 3 18542 ddkilzer 2008-01-19 09:29:12 -0800 Created attachment 18542 Reduced test case The issue is that one of the stylesheets included in the original page (http://www.ffconsultancy.com/style.css) has an invalid rule, which causes WebKit to stop parsing it, while Firefox 2.0.0.x and Opera 9.2x ignore the rule and continue parsing. The invalid rule is: width: *; When both copies of the invalid rule are removed or commented out, the page renders like Firefox. 67708 4 18543 ddkilzer 2008-01-19 09:34:07 -0800 Created attachment 18543 Test case variation 1 Text is green in Firefox and Opera. 67709 5 18544 ddkilzer 2008-01-19 09:34:46 -0800 Created attachment 18544 Test case variation 2 Text is green in Firefox and Opera. 72439 6 webkit 2008-03-01 02:54:25 -0800 kevino, who is assigned to this bug? 72467 7 19476 kevino 2008-03-01 18:10:12 -0800 Created attachment 19476 Fix for the problem that ignores rules with an invalid value This is my first foray into CSSGrammar.y and Bison code, so I would really appreciate some extra eyes on this fix. I'm not seeing any new layout test failures after the change, but I don't know if there are any corner cases I'm missing or if the approach might be overly general. Also, I assume we want a layout test created for this, so that the regression won't recur later on? Where should I put it? And do we need to generate results on all platforms for it? (New to writing LayoutTests too, sorry... ;-) 72468 8 hyatt 2008-03-01 18:14:12 -0800 This looks good to me. Should attach test cases to the patch. 72493 9 ddkilzer 2008-03-02 08:33:33 -0800 (In reply to comment #7) > Also, I assume we want a layout test created for this, so that the regression > won't recur later on? Where should I put it? And do we need to generate results > on all platforms for it? (New to writing LayoutTests too, sorry... ;-) I would put the test(s) in LayoutTests/fast/css/. If you make it a text-based test (using window.layoutTestController.dumpAsText()), then you don't have to worry about generating results for every platform. Look in LayoutTests/fast/css for examples that use layoutTestController.dumpAsText() and craft a similar test based on one or more reductions in this bug. I usually prefer to use the js-test-* assertions instead of custom "logging" solutions like getComputedStyle-zIndex-auto.html. See legacy-opacity-styles.html for one example. Darin likes to use the WebKitTools/Scripts/make-js-test-wrappers script to create the resources/*.js file first, then let the script generate the test file for it. 72512 10 19486 kevino 2008-03-02 15:48:50 -0800 Created attachment 19486 Version of fix with layout test added 72520 11 19486 hyatt 2008-03-02 17:31:25 -0800 Comment on attachment 19486 Version of fix with layout test added r=me 72524 12 kevino 2008-03-02 18:04:11 -0800 Landed in r30704, thanks! 1229118 13 codecolorist 2016-09-13 02:51:56 -0700 *** Bug 161899 has been marked as a duplicate of this bug. *** 18542 2008-01-19 09:29:12 -0800 2008-01-19 09:29:12 -0800 Reduced test case bug-16898-test.html text/html 90 ddkilzer PHN0eWxlPgouZm9vIHsgd2lkdGg6ICo7IH0KcCB7IGNvbG9yOiBncmVlbjsgfQo8L3N0eWxlPgo8 cD5UaGlzIHRleHQgc2hvdWxkIGJlIGdyZWVuLjwvcD4K 18543 2008-01-19 09:34:07 -0800 2008-01-19 09:34:07 -0800 Test case variation 1 bug-16898-var1.html text/html 89 ddkilzer PHN0eWxlPgpwIHsKICAgIGNvbG9yOiBncmVlbjsKICAgIHdpZHRoOiAqOwp9Cjwvc3R5bGU+Cjxw PlRoaXMgdGV4dCBzaG91bGQgYmUgZ3JlZW4uPC9wPgo= 18544 2008-01-19 09:34:46 -0800 2008-01-19 09:34:46 -0800 Test case variation 2 bug-16898-var2.html text/html 89 ddkilzer PHN0eWxlPgpwIHsKICAgIHdpZHRoOiAqOwogICAgY29sb3I6IGdyZWVuOwp9Cjwvc3R5bGU+Cjxw PlRoaXMgdGV4dCBzaG91bGQgYmUgZ3JlZW4uPC9wPgo= 19476 2008-03-01 18:10:12 -0800 2008-03-02 15:48:50 -0800 Fix for the problem that ignores rules with an invalid value invalidvalue.patch text/plain 1104 kevino SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMDY5NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDgtMDMtMDEgIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9s bGl2aWVycy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgR3JhY2VmdWxseSBoYW5kbGUgYSBDU1MgcnVsZSBjb250YWluaW5nIGFuIGludmFsaWQg dmFsdWUuCisgICAgICAgIChGaXhlcyBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNjg5OCkKKworICAgICAgICBXQVJOSU5HOiBOTyBURVNUIENBU0VTIEFEREVEIE9SIENI QU5HRUQKKworICAgICAgICAqIGNzcy9DU1NHcmFtbWFyLnk6CisKIDIwMDgtMDMtMDEgIFNhbSBX ZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBNYXJr IFJvd2UuCkluZGV4OiBXZWJDb3JlL2Nzcy9DU1NHcmFtbWFyLnkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9jc3MvQ1NTR3JhbW1hci55CShyZXZpc2lvbiAzMDY5NykKKysrIFdlYkNvcmUvY3NzL0NT U0dyYW1tYXIueQkod29ya2luZyBjb3B5KQpAQCAtOTg1LDYgKzk4NSwxMSBAQAogICAgICAgICAv KiBkaXYgeyBmb250LWZhbWlseTogfSBKdXN0IHJlZHVjZSBhd2F5IHRoaXMgcHJvcGVydHkgd2l0 aCBubyB2YWx1ZS4gKi8KICAgICAgICAgJCQgPSBmYWxzZTsKICAgICB9CisgICAgfAorICAgIHBy b3BlcnR5ICc6JyBtYXliZV9zcGFjZSBlcnJvciB7CisgICAgICAgIC8qIGlmIHdlIGNvbWUgYWNy b3NzIHJ1bGVzIHdpdGggaW52YWxpZCB2YWx1ZXMgbGlrZSB0aGlzIGNhc2U6IHAgeyB3ZWlnaHQ6 ICo7IH0sIGp1c3QgZGlzY2FyZCB0aGUgcnVsZSAqLworICAgICAgICAkJCA9IGZhbHNlOworICAg IH0KICAgOwogCiBwcm9wZXJ0eToK 19486 2008-03-02 15:48:50 -0800 2008-03-02 17:31:25 -0800 Version of fix with layout test added invalidvalue2.patch text/plain 3255 kevino SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMDcwMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDgtMDMtMDIgIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9s bGl2aWVycy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgR3JhY2VmdWxseSBoYW5kbGUgYSBDU1MgcnVsZSBjb250YWluaW5nIGFuIGludmFsaWQg dmFsdWUuCisgICAgICAgIChGaXhlcyBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNjg5OCkKKworICAgICAgICAqIGNzcy9DU1NHcmFtbWFyLnk6CisKIDIwMDgtMDMtMDIg IEFscCBUb2tlciAgPGFscEBhdG9rZXIuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcmsg Um93ZS4KSW5kZXg6IFdlYkNvcmUvY3NzL0NTU0dyYW1tYXIueQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL2Nzcy9DU1NHcmFtbWFyLnkJKHJldmlzaW9uIDMwNzAzKQorKysgV2ViQ29yZS9jc3MvQ1NT R3JhbW1hci55CSh3b3JraW5nIGNvcHkpCkBAIC05ODUsNiArOTg1LDExIEBACiAgICAgICAgIC8q IGRpdiB7IGZvbnQtZmFtaWx5OiB9IEp1c3QgcmVkdWNlIGF3YXkgdGhpcyBwcm9wZXJ0eSB3aXRo IG5vIHZhbHVlLiAqLwogICAgICAgICAkJCA9IGZhbHNlOwogICAgIH0KKyAgICB8CisgICAgcHJv cGVydHkgJzonIG1heWJlX3NwYWNlIGVycm9yIHsKKyAgICAgICAgLyogaWYgd2UgY29tZSBhY3Jv c3MgcnVsZXMgd2l0aCBpbnZhbGlkIHZhbHVlcyBsaWtlIHRoaXMgY2FzZTogcCB7IHdlaWdodDog KjsgfSwganVzdCBkaXNjYXJkIHRoZSBydWxlICovCisgICAgICAgICQkID0gZmFsc2U7CisgICAg fQogICA7CiAKIHByb3BlcnR5OgpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMzA3MDMpCisrKyBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAwOC0wMy0w MiAgS2V2aW4gT2xsaXZpZXIgIDxrZXZpbm9AdGhlb2xsaXZpZXJzLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHcmFjZWZ1bGx5IGhhbmRsZSBh IENTUyBydWxlIGNvbnRhaW5pbmcgYW4gaW52YWxpZCB2YWx1ZS4KKyAgICAgICAgKEZpeGVzIGh0 dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODk4KQorCisgICAgICAgICog ZmFzdC9jc3MvaW52YWxpZC1ydWxlLXZhbHVlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAg ICogZmFzdC9jc3MvaW52YWxpZC1ydWxlLXZhbHVlLmh0bWw6IEFkZGVkLgorCiAyMDA4LTAzLTAx ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg U2FtIFdlaW5pZy4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY3NzL2ludmFsaWQtcnVsZS12YWx1 ZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jc3MvaW52YWxp ZC1ydWxlLXZhbHVlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zh c3QvY3NzL2ludmFsaWQtcnVsZS12YWx1ZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0w LDAgKzEsMTAgQEAKK1RoaXMgdGVzdCBjaGVja3MgdGhhdCBhIHJ1bGUgd2l0aCBhbiBpbnZhbGlk IHZhbHVlIGRvZXMgbm90IGhhbHQgb3RoZXIgc3R5bGUgcnVsZXMgZnJvbSBiZWluZyBhcHBsaWVk LgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2Vz LCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgndGVzdC1pbnZhbGlkLXJ1bGUnKS5zdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKCdjb2xv cicpIGlzICdyZ2IoMCwgMTI4LCAwKScKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUK KworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9pbnZhbGlkLXJ1 bGUtdmFsdWUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9pbnZhbGlk LXJ1bGUtdmFsdWUuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvY3NzL2lu dmFsaWQtcnVsZS12YWx1ZS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDIwIEBACis8IURP Q1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFk PgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1z dHlsZS5jc3MiPgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+ PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxkaXYgaWQ9InRlc3QtaW52YWxpZC1ydWxlIiBz dHlsZT0id2VpZ2h0OiAqOyBjb2xvcjogcmdiKDAsIDEyOCwgMCkiPjwvZGl2PgorPHAgaWQ9ImRl c2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQ+CitkZXNj cmlwdGlvbigiVGhpcyB0ZXN0IGNoZWNrcyB0aGF0IGEgcnVsZSB3aXRoIGFuIGludmFsaWQgdmFs dWUgZG9lcyBub3QgaGFsdCBvdGhlciBzdHlsZSBydWxlcyBmcm9tIGJlaW5nIGFwcGxpZWQuIik7 CisKK3Nob3VsZEJlKCJkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGVzdC1pbnZhbGlkLXJ1bGUn KS5zdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKCdjb2xvcicpIiwgIidyZ2IoMCwgMTI4LCAwKSciKTsK KwordmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3Jj PSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwv aHRtbD4K