168976 2017-02-28 10:50:07 -0800 Web Inspector: It is possible to get the New Tab button in addition to the seven expected tabs 2017-02-28 15:36:20 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg hi bburg commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1281804 0 bburg 2017-02-28 10:50:07 -0800 (via Nelson Thachuk:) * SUMMARY - It is possible to get the New Tab button in addition to the seven expected tabs * STEPS TO REPRODUCE 1. Launch Safari 2. Navigate to a webpage 3. Show Web Inspector (⌥⌘I) 4. Open all Web Inspector tabs 5. Close the Console tab 6. Click the New Tab button 7. From any tab, enter something in to the Console at the bottom of the tab 8. Click the “Show console tab” button (if required by the current tab) * EXPECTED RESULTS - New Tab tab should be replaced with Console tab * ACTUAL RESULTS - New Tab tab and Console tab coexist - New Tab tab has no functionality since no tabs can be opened - New Tab tab cannot be closed - Close button for all other tabs moves from expected location to on top of the glyph representing the tab 1281805 1 bburg 2017-02-28 10:50:31 -0800 <rdar://problem/30621630> 1281837 2 hi 2017-02-28 11:35:14 -0800 I feel like a simple solution to this would be to just let the user close the New Tab tab. I will often accidentally click it and it's very annoying to have to open Storage and then close it immediately thereafter. 1281860 3 joepeck 2017-02-28 12:10:29 -0800 (In reply to comment #2) > I feel like a simple solution to this would be to just let the user close > the New Tab tab. I will often accidentally click it and it's very annoying > to have to open Storage and then close it immediately thereafter. Yeah that sounds good. 1281942 4 302983 hi 2017-02-28 13:59:13 -0800 Created attachment 302983 Patch 1281954 5 302983 bburg 2017-02-28 14:16:46 -0800 Comment on attachment 302983 Patch r=me 1282007 6 302983 commit-queue 2017-02-28 15:36:15 -0800 Comment on attachment 302983 Patch Clearing flags on attachment: 302983 Committed r213188: <http://trac.webkit.org/changeset/213188> 1282008 7 commit-queue 2017-02-28 15:36:20 -0800 All reviewed patches have been landed. Closing bug. 302983 2017-02-28 13:59:13 -0800 2017-02-28 15:36:15 -0800 Patch bug-168976-20170228135617.patch text/plain 1953 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDc0NDI0YjUxM2MxOGIyZDFiNWU3YzQ5NzJlZjU5 NzhjMzllZTJiNjAuLjk2NjdmNWQ5OWI1N2VjMjNiYmVlMzJiZTJjYzRiOWMyOWQzOGFkOTkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTAyLTI4ICBEZXZp biBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IEl0IGlzIHBvc3NpYmxlIHRvIGdldCB0aGUgTmV3IFRhYiBidXR0b24gaW4gYWRkaXRp b24gdG8gdGhlIHNldmVuIGV4cGVjdGVkIHRhYnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODk3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UYWJCYXIuY3NzOgor ICAgICAgICAoLnRhYi1iYXIuY29sbGFwc2VkOm5vdCguaGlkZS10aXRsZXMpID4gLml0ZW06bm90 KC5waW5uZWQpOmhvdmVyID4gLmljb24pOgorICAgICAgICAoLnRhYi1iYXIuY29sbGFwc2VkOm5v dCguaGlkZS10aXRsZXMpID4gLml0ZW06aG92ZXIgPiAuY2xvc2UpOgorICAgICAgICAoLnRhYi1i YXIuY29sbGFwc2VkOm5vdCguaGlkZS10aXRsZXMpID4gLml0ZW06bm90KC5waW5uZWQsIC5kZWZh dWx0LXRhYik6aG92ZXIgPiAuaWNvbik6IERlbGV0ZWQuCisgICAgICAgICgudGFiLWJhci5jb2xs YXBzZWQ6bm90KC5oaWRlLXRpdGxlcykgPiAuaXRlbTpub3QoLmRlZmF1bHQtdGFiKTpob3ZlciA+ IC5jbG9zZSk6IERlbGV0ZWQuCisKIDIwMTctMDItMjUgIERldmluIFJvdXNzbyAgPGRjcm91c3Nv K3dlYmtpdEBnbWFpbC5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUlRMOiBhZGQgc3Vw cG9ydCBmb3IgQ29sb3IgUGlja2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9UYWJCYXIuY3NzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvVGFiQmFyLmNzcwppbmRleCBjODA4NzY3Y2Y1YjdlNjcwMjcyZWNl ZmVmOTQyNmQzMzkyODYzZmVjLi41MTJiZDA3MzhiODM5NGZjOWIzM2FiYmU5NWZjOWU3NDRmZWE3 NzgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9UYWJCYXIuY3NzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1RhYkJhci5jc3MKQEAgLTMyMiwxMiArMzIyLDEyIEBAIGJvZHlbZGlyPXJ0bF0gLnRhYi1i YXIuY29sbGFwc2VkID4gLml0ZW0gPiAuY2xvc2UgewogICAgIGRpc3BsYXk6IG5vbmU7CiB9CiAK LS50YWItYmFyLmNvbGxhcHNlZDpub3QoLmhpZGUtdGl0bGVzKSA+IC5pdGVtOm5vdCgucGlubmVk LCAuZGVmYXVsdC10YWIpOmhvdmVyID4gLmljb24sCisudGFiLWJhci5jb2xsYXBzZWQ6bm90KC5o aWRlLXRpdGxlcykgPiAuaXRlbTpub3QoLnBpbm5lZCk6aG92ZXIgPiAuaWNvbiwKIC50YWItYmFy LmhpZGUtdGl0bGVzID4gLml0ZW0uc2VsZWN0ZWQ6aG92ZXIgPiAuaWNvbiB7CiAgICAgZGlzcGxh eTogbm9uZTsKIH0KIAotLnRhYi1iYXIuY29sbGFwc2VkOm5vdCguaGlkZS10aXRsZXMpID4gLml0 ZW06bm90KC5kZWZhdWx0LXRhYik6aG92ZXIgPiAuY2xvc2UsCisudGFiLWJhci5jb2xsYXBzZWQ6 bm90KC5oaWRlLXRpdGxlcykgPiAuaXRlbTpob3ZlciA+IC5jbG9zZSwKIC50YWItYmFyLmhpZGUt dGl0bGVzID4gLml0ZW0uc2VsZWN0ZWQ6aG92ZXIgPiAuY2xvc2UgewogICAgIGRpc3BsYXk6IGlu bGluZS1ibG9jazsKIH0K