168973 2017-02-28 09:16:18 -0800 [WebRTC] LibWebRTC frame dropper is not working consistently 2017-02-28 11:15:14 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf achristensen commit-queue eric.carlson jer.noble oldest_to_newest 1281777 0 youennf 2017-02-28 09:16:18 -0800 It is sometimes dropping frames while there is no need. 1281778 1 302939 youennf 2017-02-28 09:19:29 -0800 Created attachment 302939 Patch 1281779 2 youennf 2017-02-28 09:20:42 -0800 (In reply to comment #1) > Created attachment 302939 [details] > Patch This patch disables the frame dropper optimizer for now. We should investigate it further, probably after migrating to a more recent libwebrtc revision. 1281781 3 302939 eric.carlson 2017-02-28 09:27:24 -0800 Comment on attachment 302939 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302939&action=review > Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/video_sender.cc:117 > + // FIXME: Investigate why and enable it again. Nit: please add a bug number here. 1281792 4 302948 youennf 2017-02-28 10:35:05 -0800 Created attachment 302948 Patch for landing 1281795 5 youennf 2017-02-28 10:36:39 -0800 Thanks for the review. (In reply to comment #3) > Comment on attachment 302939 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302939&action=review > > > Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/video_sender.cc:117 > > + // FIXME: Investigate why and enable it again. > > Nit: please add a bug number here. Let's use this one. I'll reopen this bug once this patch got landed. 1281825 6 302948 commit-queue 2017-02-28 11:15:08 -0800 Comment on attachment 302948 Patch for landing Clearing flags on attachment: 302948 Committed r213152: <http://trac.webkit.org/changeset/213152> 1281826 7 commit-queue 2017-02-28 11:15:14 -0800 All reviewed patches have been landed. Closing bug. 302939 2017-02-28 09:19:29 -0800 2017-02-28 10:35:02 -0800 Patch bug-168973-20170228091633.patch text/plain 2136 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzMDgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCBmYzFkNjM4OGNlN2ZkOGI4Yzk2ZTMyODAxMjdkZmM5MzFhY2U5Mzk4Li5iY2Yx ZTQzMjBhNWZjZDcxODI4Zjk4ZjQ4NDE3OWJlMzhlNTJiMGQ2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNy0wMi0yOCAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgZml4IDE2ODk3MworCisgICAgICAg IFtXZWJSVENdIExpYldlYlJUQyBmcmFtZSBkcm9wcGVyIGlzIG5vdCB3b3JraW5nIGNvbnNpc3Rl bnRseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4 OTczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBT b3VyY2Uvd2VicnRjL21vZHVsZXMvdmlkZW9fY29kaW5nL3ZpZGVvX3NlbmRlci5jYzogRGlzYWJs ZSB0ZW1wb3JhcmlseSB0aGUgZnJhbWUgZHJvcHBlciBhcyBpdCBpcyBzb21ldGltZXMKKyAgICAg ICAgZHJvcHBpbmcgdG9vIG1hbnkgZnJhbWVzLgorCiAyMDE3LTAyLTI3ICBZb3Vlbm4gRmFibGV0 ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViUlRDXSBSZWFsdGltT3V0Z29pbmdW aWRlb1NvdXJjZSBzaG91bGQgbm90IG5lZWQgdG8gZG8gaW1hZ2UgY29udmVyc2lvbgpkaWZmIC0t Z2l0IGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvbW9kdWxlcy92 aWRlb19jb2RpbmcvdmlkZW9fc2VuZGVyLmNjIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRj L1NvdXJjZS93ZWJydGMvbW9kdWxlcy92aWRlb19jb2RpbmcvdmlkZW9fc2VuZGVyLmNjCmluZGV4 IGI3NjY0YTcxOWIzYTdkMTU1ZDIzNjY2ZGY5NDY2MzkyODA4N2JjOGMuLmYwNWRhMGZmZGI1Nzcw YTY0M2Q5OWJhNmVmYzIxOTU1Y2IzMmJiMTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5 L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL21vZHVsZXMvdmlkZW9fY29kaW5nL3ZpZGVvX3NlbmRl ci5jYworKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9tb2R1 bGVzL3ZpZGVvX2NvZGluZy92aWRlb19zZW5kZXIuY2MKQEAgLTExMywxMSArMTEzLDE0IEBAIGlu dDMyX3QgVmlkZW9TZW5kZXI6OlJlZ2lzdGVyU2VuZENvZGVjKGNvbnN0IFZpZGVvQ29kZWMqIHNl bmRDb2RlYywKICAgLy8gSWYgd2UgaGF2ZSBzY3JlZW5zaGFyaW5nIGFuZCB3ZSBoYXZlIGxheWVy cywgd2UgZGlzYWJsZSBmcmFtZSBkcm9wcGVyLgogICBib29sIGRpc2FibGVfZnJhbWVfZHJvcHBl ciA9CiAgICAgICBudW1MYXllcnMgPiAxICYmIHNlbmRDb2RlYy0+bW9kZSA9PSBrU2NyZWVuc2hh cmluZzsKLSAgaWYgKGRpc2FibGVfZnJhbWVfZHJvcHBlcikgewotICAgIF9tZWRpYU9wdC5FbmFi bGVGcmFtZURyb3BwZXIoZmFsc2UpOwotICB9IGVsc2UgaWYgKGZyYW1lX2Ryb3BwZXJfZW5hYmxl ZF8pIHsKLSAgICBfbWVkaWFPcHQuRW5hYmxlRnJhbWVEcm9wcGVyKHRydWUpOwotICB9CisgIC8v IFdFQktJVCBjaGFuZ2U6IHRoZSBmcmFtZSBkcm9wcGVyIGRvZXMgbm90IHdvcmsgY29uc2lzdGVu dGx5LiBXZSBkaXNhYmxlIGl0IGZvciBub3cuCisgIC8vIEZJWE1FOiBJbnZlc3RpZ2F0ZSB3aHkg YW5kIGVuYWJsZSBpdCBhZ2Fpbi4KKyAgX21lZGlhT3B0LkVuYWJsZUZyYW1lRHJvcHBlcihmYWxz ZSk7CisgIC8vIGlmIChkaXNhYmxlX2ZyYW1lX2Ryb3BwZXIpIHsKKyAgLy8gICBfbWVkaWFPcHQu RW5hYmxlRnJhbWVEcm9wcGVyKGZhbHNlKTsKKyAgLy8gfSBlbHNlIGlmIChmcmFtZV9kcm9wcGVy X2VuYWJsZWRfKSB7CisgIC8vICAgX21lZGlhT3B0LkVuYWJsZUZyYW1lRHJvcHBlcih0cnVlKTsK KyAgLy8gfQogICB7CiAgICAgcnRjOjpDcml0U2NvcGUgY3MoJnBhcmFtc19jcml0Xyk7CiAgICAg bmV4dF9mcmFtZV90eXBlc18uY2xlYXIoKTsK 302948 2017-02-28 10:35:05 -0800 2017-02-28 11:15:08 -0800 Patch for landing bug-168973-20170228103208.patch text/plain 2289 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzMTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCBmYzFkNjM4OGNlN2ZkOGI4Yzk2ZTMyODAxMjdkZmM5MzFhY2U5Mzk4Li5iMGQy MDAxYTM4NTk2MDRhOTQ2YTBiNGUwZDAxODNhNjI0M2VmNDJlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNy0wMi0yOCAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYlJUQ10gTGliV2ViUlRDIGZy YW1lIGRyb3BwZXIgaXMgbm90IHdvcmtpbmcgY29uc2lzdGVudGx5CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg5NzMKKworICAgICAgICBSZXZpZXdl ZCBieSBFcmljIENhcmxzb24uCisKKyAgICAgICAgKiBTb3VyY2Uvd2VicnRjL21vZHVsZXMvdmlk ZW9fY29kaW5nL3ZpZGVvX3NlbmRlci5jYzogRGlzYWJsZSB0ZW1wb3JhcmlseSB0aGUgZnJhbWUg ZHJvcHBlciBhcyBpdCBpcyBzb21ldGltZXMKKyAgICAgICAgZHJvcHBpbmcgdG9vIG1hbnkgZnJh bWVzLgorCiAyMDE3LTAyLTI3ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAog ICAgICAgICBbV2ViUlRDXSBSZWFsdGltT3V0Z29pbmdWaWRlb1NvdXJjZSBzaG91bGQgbm90IG5l ZWQgdG8gZG8gaW1hZ2UgY29udmVyc2lvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkv bGlid2VicnRjL1NvdXJjZS93ZWJydGMvbW9kdWxlcy92aWRlb19jb2RpbmcvdmlkZW9fc2VuZGVy LmNjIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvbW9kdWxlcy92 aWRlb19jb2RpbmcvdmlkZW9fc2VuZGVyLmNjCmluZGV4IGI3NjY0YTcxOWIzYTdkMTU1ZDIzNjY2 ZGY5NDY2MzkyODA4N2JjOGMuLjJlYThhZWIyOWRlMmIwZTUwOTk2MDkwYmY5Y2NhYTI5ODY0N2Iy ZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRj L21vZHVsZXMvdmlkZW9fY29kaW5nL3ZpZGVvX3NlbmRlci5jYworKysgYi9Tb3VyY2UvVGhpcmRQ YXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9tb2R1bGVzL3ZpZGVvX2NvZGluZy92aWRlb19z ZW5kZXIuY2MKQEAgLTExMCwxNCArMTEwLDE4IEBAIGludDMyX3QgVmlkZW9TZW5kZXI6OlJlZ2lz dGVyU2VuZENvZGVjKGNvbnN0IFZpZGVvQ29kZWMqIHNlbmRDb2RlYywKICAgICBudW1MYXllcnMg PSAxOwogICB9CiAKKyAgLy8gV0VCS0lUIGNoYW5nZTogdGhlIGZyYW1lIGRyb3BwZXIgZG9lcyBu b3Qgd29yayBjb25zaXN0ZW50bHkuIFdlIGRpc2FibGUgaXQgZm9yIG5vdy4KKyAgLy8gRklYTUU6 IEludmVzdGlnYXRlIHdoeSBhbmQgZW5hYmxlIGl0IGFnYWluLiBTZWUgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODk3My4KKyAgX21lZGlhT3B0LkVuYWJsZUZyYW1l RHJvcHBlcihmYWxzZSk7CisKICAgLy8gSWYgd2UgaGF2ZSBzY3JlZW5zaGFyaW5nIGFuZCB3ZSBo YXZlIGxheWVycywgd2UgZGlzYWJsZSBmcmFtZSBkcm9wcGVyLgotICBib29sIGRpc2FibGVfZnJh bWVfZHJvcHBlciA9Ci0gICAgICBudW1MYXllcnMgPiAxICYmIHNlbmRDb2RlYy0+bW9kZSA9PSBr U2NyZWVuc2hhcmluZzsKLSAgaWYgKGRpc2FibGVfZnJhbWVfZHJvcHBlcikgewotICAgIF9tZWRp YU9wdC5FbmFibGVGcmFtZURyb3BwZXIoZmFsc2UpOwotICB9IGVsc2UgaWYgKGZyYW1lX2Ryb3Bw ZXJfZW5hYmxlZF8pIHsKLSAgICBfbWVkaWFPcHQuRW5hYmxlRnJhbWVEcm9wcGVyKHRydWUpOwot ICB9CisgIC8vIGJvb2wgZGlzYWJsZV9mcmFtZV9kcm9wcGVyID0KKyAgLy8gICAgbnVtTGF5ZXJz ID4gMSAmJiBzZW5kQ29kZWMtPm1vZGUgPT0ga1NjcmVlbnNoYXJpbmc7CisgIC8vIGlmIChkaXNh YmxlX2ZyYW1lX2Ryb3BwZXIpIHsKKyAgLy8gICBfbWVkaWFPcHQuRW5hYmxlRnJhbWVEcm9wcGVy KGZhbHNlKTsKKyAgLy8gfSBlbHNlIGlmIChmcmFtZV9kcm9wcGVyX2VuYWJsZWRfKSB7CisgIC8v ICAgX21lZGlhT3B0LkVuYWJsZUZyYW1lRHJvcHBlcih0cnVlKTsKKyAgLy8gfQogICB7CiAgICAg cnRjOjpDcml0U2NvcGUgY3MoJnBhcmFtc19jcml0Xyk7CiAgICAgbmV4dF9mcmFtZV90eXBlc18u Y2xlYXIoKTsK