168965 2017-02-28 04:06:05 -0800 [Win] Popup menus are too small in HiDPI mode. 2017-03-01 00:49:43 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan achristensen bfulgham webkit-bug-importer oldest_to_newest 1281752 0 pvollan 2017-02-28 04:06:05 -0800 We need to scale with the device scale factor. 1281753 1 302931 pvollan 2017-02-28 04:11:09 -0800 Created attachment 302931 Patch 1281758 2 pvollan 2017-02-28 05:49:28 -0800 rdar://problem/30742143 1281814 3 302931 bfulgham 2017-02-28 10:56:54 -0800 Comment on attachment 302931 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302931&action=review R=me. Looks good, but please consolidate that for handling code. > Source/WebCore/platform/win/PopupMenuWin.cpp:623 > + font.update(m_popupClient->fontSelector()); It seems like this code could be shared with the above method. 1282189 4 pvollan 2017-03-01 00:38:02 -0800 (In reply to comment #3) > Comment on attachment 302931 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302931&action=review > > R=me. > > Looks good, but please consolidate that for handling code. > > > Source/WebCore/platform/win/PopupMenuWin.cpp:623 > > + font.update(m_popupClient->fontSelector()); > > It seems like this code could be shared with the above method. Thanks for reviewing! I will update the patch. 1282194 5 pvollan 2017-03-01 00:49:43 -0800 Committed <http://trac.webkit.org/changeset/213211>. 302931 2017-02-28 04:11:09 -0800 2017-02-28 10:56:54 -0800 Patch bug-168965-20170228040813.patch text/plain 3827 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzE0NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE3LTAyLTI4ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBQb3B1cCBtZW51 cyBhcmUgdG9vIHNtYWxsIGluIEhpRFBJIG1vZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg5NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBTY2FsZSBmb250IHdpdGggZGV2aWNlIHNjYWxlIGZhY3Rv ci4KKworICAgICAgICAqIHBsYXRmb3JtL3dpbi9Qb3B1cE1lbnVXaW4uY3BwOgorICAgICAgICAo V2ViQ29yZTo6UG9wdXBNZW51V2luOjpzaG93KToKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVwTWVu dVdpbjo6Y2FsY3VsYXRlUG9zaXRpb25BbmRTaXplKToKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVw TWVudVdpbjo6cGFpbnQpOgorCiAyMDE3LTAyLTI4ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlz dGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTWFpbiByZXNvdXJjZSByZXF1ZXN0cyBuZWVk IGNhY2hlUGFydGl0aW9uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vUG9wdXBN ZW51V2luLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vUG9w dXBNZW51V2luLmNwcAkocmV2aXNpb24gMjEzMTQ3KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vd2luL1BvcHVwTWVudVdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyOCwxMyArMTI4LDEz IEBAIExQQ1dTVFIgUG9wdXBNZW51V2luOjpwb3B1cENsYXNzTmFtZSgpCiAKIHZvaWQgUG9wdXBN ZW51V2luOjpzaG93KGNvbnN0IEludFJlY3QmIHIsIEZyYW1lVmlldyogdmlldywgaW50IGluZGV4 KQogeworICAgIGlmICh2aWV3ICYmIHZpZXctPmZyYW1lKCkucGFnZSgpKQorICAgICAgICBtX3Nj YWxlRmFjdG9yID0gdmlldy0+ZnJhbWUoKS5wYWdlKCktPmRldmljZVNjYWxlRmFjdG9yKCk7CisK ICAgICBjYWxjdWxhdGVQb3NpdGlvbkFuZFNpemUociwgdmlldyk7CiAgICAgaWYgKGNsaWVudFJl Y3QoKS5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIGlmICh2aWV3ICYmIHZpZXct PmZyYW1lKCkucGFnZSgpKQotICAgICAgICBtX3NjYWxlRmFjdG9yID0gdmlldy0+ZnJhbWUoKS5w YWdlKCktPmRldmljZVNjYWxlRmFjdG9yKCk7Ci0KICAgICBIV05EIGhvc3RXaW5kb3cgPSB2aWV3 LT5ob3N0V2luZG93KCktPnBsYXRmb3JtUGFnZUNsaWVudCgpOwogCiAgICAgaWYgKCFtX3Njcm9s bGJhciAmJiB2aXNpYmxlSXRlbXMoKSA8IGNsaWVudCgpLT5saXN0U2l6ZSgpKSB7CkBAIC0zMTks OSArMzE5LDE2IEBAIHZvaWQgUG9wdXBNZW51V2luOjpjYWxjdWxhdGVQb3NpdGlvbkFuZFMKIAog ICAgIHJTY3JlZW5Db29yZHMuc2V0TG9jYXRpb24obG9jYXRpb24pOwogCisgICAgRm9udENhc2Nh ZGUgZm9udCA9IGNsaWVudCgpLT5tZW51U3R5bGUoKS5mb250KCk7CisgICAgYXV0byBkID0gZm9u dC5mb250RGVzY3JpcHRpb24oKTsKKyAgICBkLnNldENvbXB1dGVkU2l6ZShkLmNvbXB1dGVkU2l6 ZSgpICogbV9zY2FsZUZhY3Rvcik7CisgICAgZm9udCA9IEZvbnRDYXNjYWRlKGQsIGZvbnQubGV0 dGVyU3BhY2luZygpLCBmb250LndvcmRTcGFjaW5nKCkpOworICAgIGZvbnQudXBkYXRlKG1fcG9w dXBDbGllbnQtPmZvbnRTZWxlY3RvcigpKTsKKwogICAgIC8vIEZpcnN0LCBkZXRlcm1pbmUgdGhl IHBvcHVwJ3MgaGVpZ2h0CiAgICAgaW50IGl0ZW1Db3VudCA9IGNsaWVudCgpLT5saXN0U2l6ZSgp OwotICAgIG1faXRlbUhlaWdodCA9IGNsaWVudCgpLT5tZW51U3R5bGUoKS5mb250KCkuZm9udE1l dHJpY3MoKS5oZWlnaHQoKSArIG9wdGlvblNwYWNpbmdNaWRkbGU7CisgICAgbV9pdGVtSGVpZ2h0 ID0gZm9udC5mb250TWV0cmljcygpLmhlaWdodCgpICsgb3B0aW9uU3BhY2luZ01pZGRsZTsKKwog ICAgIGludCBuYXR1cmFsSGVpZ2h0ID0gbV9pdGVtSGVpZ2h0ICogaXRlbUNvdW50OwogICAgIGlu dCBwb3B1cEhlaWdodCA9IHN0ZDo6bWluKG1heFBvcHVwSGVpZ2h0LCBuYXR1cmFsSGVpZ2h0KTsK ICAgICAvLyBUaGUgcG9wdXAgc2hvdWxkIHNob3cgYW4gaW50ZWdyYWwgbnVtYmVyIG9mIGl0ZW1z IChpLmUuIG5vIHBhcnRpYWwgaXRlbXMgc2hvdWxkIGJlIHZpc2libGUpCkBAIC0zMzQsNyArMzQx LDcgQEAgdm9pZCBQb3B1cE1lbnVXaW46OmNhbGN1bGF0ZVBvc2l0aW9uQW5kUwogICAgICAgICBp ZiAodGV4dC5pc0VtcHR5KCkpCiAgICAgICAgICAgICBjb250aW51ZTsKIAotICAgICAgICBGb250 Q2FzY2FkZSBpdGVtRm9udCA9IGNsaWVudCgpLT5tZW51U3R5bGUoKS5mb250KCk7CisgICAgICAg IEZvbnRDYXNjYWRlIGl0ZW1Gb250ID0gZm9udDsKICAgICAgICAgaWYgKGNsaWVudCgpLT5pdGVt SXNMYWJlbChpKSkgewogICAgICAgICAgICAgYXV0byBkID0gaXRlbUZvbnQuZm9udERlc2NyaXB0 aW9uKCk7CiAgICAgICAgICAgICBkLnNldFdlaWdodChkLmJvbGRlcldlaWdodCgpKTsKQEAgLTYw OSw2ICs2MTYsMTIgQEAgdm9pZCBQb3B1cE1lbnVXaW46OnBhaW50KGNvbnN0IEludFJlY3QmCiAg ICAgSW50UmVjdCBsaXN0UmVjdCA9IGRhbWFnZVJlY3Q7CiAgICAgbGlzdFJlY3QubW92ZShJbnRT aXplKDAsIG1fc2Nyb2xsT2Zmc2V0ICogbV9pdGVtSGVpZ2h0KSk7CiAKKyAgICBGb250Q2FzY2Fk ZSBmb250ID0gY2xpZW50KCktPm1lbnVTdHlsZSgpLmZvbnQoKTsKKyAgICBhdXRvIGQgPSBmb250 LmZvbnREZXNjcmlwdGlvbigpOworICAgIGQuc2V0Q29tcHV0ZWRTaXplKGQuY29tcHV0ZWRTaXpl KCkgKiBtX3NjYWxlRmFjdG9yKTsKKyAgICBmb250ID0gRm9udENhc2NhZGUoZCwgZm9udC5sZXR0 ZXJTcGFjaW5nKCksIGZvbnQud29yZFNwYWNpbmcoKSk7CisgICAgZm9udC51cGRhdGUobV9wb3B1 cENsaWVudC0+Zm9udFNlbGVjdG9yKCkpOworCiAgICAgZm9yIChpbnQgeSA9IGxpc3RSZWN0Lnko KTsgeSA8IGxpc3RSZWN0Lm1heFkoKTsgeSArPSBtX2l0ZW1IZWlnaHQpIHsKICAgICAgICAgaW50 IGluZGV4ID0geSAvIG1faXRlbUhlaWdodDsKIApAQCAtNjM5LDggKzY1Miw4IEBAIHZvaWQgUG9w dXBNZW51V2luOjpwYWludChjb25zdCBJbnRSZWN0JgogCiAgICAgICAgIFRleHRSdW4gdGV4dFJ1 bihpdGVtVGV4dCwgMCwgMCwgQWxsb3dUcmFpbGluZ0V4cGFuc2lvbiwgaXRlbVN0eWxlLnRleHRE aXJlY3Rpb24oKSwgaXRlbVN0eWxlLmhhc1RleHREaXJlY3Rpb25PdmVycmlkZSgpKTsKICAgICAg ICAgY29udGV4dC5zZXRGaWxsQ29sb3Iob3B0aW9uVGV4dENvbG9yKTsKLSAgICAgICAgCi0gICAg ICAgIEZvbnRDYXNjYWRlIGl0ZW1Gb250ID0gY2xpZW50KCktPm1lbnVTdHlsZSgpLmZvbnQoKTsK KworICAgICAgICBGb250Q2FzY2FkZSBpdGVtRm9udCA9IGZvbnQ7CiAgICAgICAgIGlmIChjbGll bnQoKS0+aXRlbUlzTGFiZWwoaW5kZXgpKSB7CiAgICAgICAgICAgICBhdXRvIGQgPSBpdGVtRm9u dC5mb250RGVzY3JpcHRpb24oKTsKICAgICAgICAgICAgIGQuc2V0V2VpZ2h0KGQuYm9sZGVyV2Vp Z2h0KCkpOwo=