168959 2017-02-27 20:00:12 -0800 Calling build() on a baseline point results in an exception 2017-02-27 20:08:56 -0800 1 1 1 Unclassified WebKit Perf Dashboard Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa cdumez joepeck rniwa oldest_to_newest 1281694 0 rniwa 2017-02-27 20:00:12 -0800 build() function on a point object returned by MeasurementAdaptor must return null when the builder id is not available instead of throwing. 1281695 1 302916 rniwa 2017-02-27 20:02:29 -0800 Created attachment 302916 Fixes the bug 1281697 2 302916 joepeck 2017-02-27 20:05:54 -0800 Comment on attachment 302916 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=302916&action=review rs=me > Websites/perf.webkit.org/unit-tests/measurement-adaptor-tests.js:65 > + it('should adapt build information as null when the builder is not specified', function () { > + var adoptor = new MeasurementAdaptor(sampleCluster.formatMap); Is this code adopting or adapting? (Same comment applies to surrounding code). 1281698 3 rniwa 2017-02-27 20:08:56 -0800 Committed r213117: <http://trac.webkit.org/changeset/213117> 302916 2017-02-27 20:02:29 -0800 2017-02-27 20:05:54 -0800 Fixes the bug bug-168959-20170227195934.patch text/plain 4332 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMjEzMTE2KQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE3LTAyLTI3ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIENhbGxpbmcgYnVpbGQoKSBvbiBhIGJhc2VsaW5lIHBvaW50IHJlc3VsdHMgaW4g YW4gZXhjZXB0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNjg5NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBTb21lIGJhc2VsaW5lIHBvaW50cyBtYXkgbGFjayB0aGUgYnVpbGQgaW5mb3JtYXRpb24u IGUuZy4gQSBjdXN0b20gZGF0YSBwb2ludCBtYWRlIGJ5IGFuIHVzZXIuCisgICAgICAgIE9ubHkg aW5zdGFudGlhdGUgQnVpbGQgb2JqZWN0IGluIGEgcG9pbnQgb2JqZWN0IHJldHVybmVkIGJ5IE1l YXN1cmVtZW50QWRhcHRvciB3aGVuIHRoZSBidWlsZGVyIGlkCisgICAgICAgIGlzIGF2YWlsYWJs ZSBzbyB0aGF0IHdlIGRvbid0IGhpdCBhbiBhc3NlcnRpb24gaW5zaWRlIEJ1aWxkJ3MgY29uc3Ry dWN0b3IuCisKKyAgICAgICAgKiBwdWJsaWMvdjMvbW9kZWxzL21lYXN1cmVtZW50LWFkYXB0b3Iu anM6CisgICAgICAgIChNZWFzdXJlbWVudEFkYXB0b3IucHJvdG90eXBlLmFwcGx5VG8uLmJ1aWxk KTogT25seSBpbnN0YW50aWF0ZSBCdWlsZCB3aGVuIGJ1aWxkZXJJZCBpcyBzZXQuCisgICAgICAg ICogdW5pdC10ZXN0cy9tZWFzdXJlbWVudC1hZGFwdG9yLXRlc3RzLmpzOiBBZGRlZCBhIHRlc3Qg Y2FzZS4KKwogMjAxNy0wMi0yNyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAog ICAgICAgICBBcnJvdyBrZXkgc2hvdWxkbid0IG1vdmUgdGhlIGluZGljYXRvciBiZXlvbmQgdGhl IHZpc2libGUgcG9pbnRzCkluZGV4OiBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3Yz L21vZGVscy9tZWFzdXJlbWVudC1hZGFwdG9yLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNpdGVzL3Bl cmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvbW9kZWxzL21lYXN1cmVtZW50LWFkYXB0b3IuanMJKHJl dmlzaW9uIDIxMzExNikKKysrIFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvbW9k ZWxzL21lYXN1cmVtZW50LWFkYXB0b3IuanMJKHdvcmtpbmcgY29weSkKQEAgLTYxLDcgKzYxLDcg QEAgY2xhc3MgTWVhc3VyZW1lbnRBZGFwdG9yIHsKICAgICAgICAgICAgIGNvbmZpZ1R5cGU6IG51 bGwsCiAgICAgICAgICAgICByb290U2V0OiBmdW5jdGlvbiAoKSB7IHJldHVybiBNZWFzdXJlbWVu dFJvb3RTZXQuZW5zdXJlU2luZ2xldG9uKGlkLCByb3dbc2VsZi5fcmV2aXNpb25zSW5kZXhdKTsg fSwKICAgICAgICAgICAgIGJ1aWxkOiBmdW5jdGlvbiAoKSB7Ci0gICAgICAgICAgICAgICAgaWYg KGNhY2hlZEJ1aWxkID09IG51bGwpCisgICAgICAgICAgICAgICAgaWYgKGNhY2hlZEJ1aWxkID09 IG51bGwgJiYgYnVpbGRlcklkKQogICAgICAgICAgICAgICAgICAgICBjYWNoZWRCdWlsZCA9IG5l dyBCdWlsZChidWlsZElkLCBCdWlsZGVyLmZpbmRCeUlkKGJ1aWxkZXJJZCksIHJvd1tzZWxmLl9i dWlsZE51bWJlckluZGV4XSwgcm93W3NlbGYuX2J1aWxkVGltZUluZGV4XSk7CiAgICAgICAgICAg ICAgICAgcmV0dXJuIGNhY2hlZEJ1aWxkOwogICAgICAgICAgICAgfSwKSW5kZXg6IFdlYnNpdGVz L3BlcmYud2Via2l0Lm9yZy91bml0LXRlc3RzL21lYXN1cmVtZW50LWFkYXB0b3ItdGVzdHMuanMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3VuaXQtdGVzdHMvbWVhc3Vy ZW1lbnQtYWRhcHRvci10ZXN0cy5qcwkocmV2aXNpb24gMjEzMTE2KQorKysgV2Vic2l0ZXMvcGVy Zi53ZWJraXQub3JnL3VuaXQtdGVzdHMvbWVhc3VyZW1lbnQtYWRhcHRvci10ZXN0cy5qcwkod29y a2luZyBjb3B5KQpAQCAtNSwxMyArNSwxNiBAQCB2YXIgYXNzZXJ0ID0gcmVxdWlyZSgnYXNzZXJ0 Jyk7CiByZXF1aXJlKCcuLi90b29scy9qcy92My1tb2RlbHMuanMnKTsKIGxldCBNb2NrTW9kZWxz ID0gcmVxdWlyZSgnLi9yZXNvdXJjZXMvbW9jay12My1tb2RlbHMuanMnKS5Nb2NrTW9kZWxzOwog Ci12YXIgc2FtcGxlQ2x1c3RlciA9IHsKK2NvbnN0IHNhbXBsZUNsdXN0ZXIgPSB7CiAgICAgJ2Ns dXN0ZXJTdGFydCc6IDk0NjY4NDgwMDAwMCwKICAgICAnY2x1c3RlclNpemUnOiA1MTg0MDAwMDAw LAogICAgICdjb25maWd1cmF0aW9ucyc6IHsKICAgICAgICAgJ2N1cnJlbnQnOiBbCiAgICAgICAg ICAgICBbMjg5NTQ5ODMsIDIxNy45NDYwNzE0Mjg1NywgMjAsIDQzNTguOTIxNDI4NTcxNCwgOTUw MzAzLjAyMzY1NDM0LCBmYWxzZSwgW1sxMTEsIDksICcxMC4xMSAxNUQyMScsIDBdLCBbMjIyLCAx MSwgJzE5MjQ4MycsIDE0NDc3MDcwNTU1NzZdLCBbMzMzLCA5OTksICdzb21lIHVua25vd24gcmV2 aXNpb24nLCAwXV0sIDE0NDc3MDcwNTU1NzYsIDE4NDYyOSwgMTQ0Nzc2MjI2NjE1MywgJzE3OCcs IDE3Nl0sCiAgICAgICAgICAgICBbMjg5NTIyNTcsIDIyMC4xMTQ1NTM1NzE0MywgMjAsIDQ0MDIu MjkxMDcxNDI4NiwgOTY5MDk5LjY3NTA5ODg1LCBmYWxzZSwgW1sxMTEsIDksICcxMC4xMSAxNUQy MScsIDBdLCBbNDQ0LCAxMSwgJzE5MjQ4NicsIDE0NDc3MTM1MDA0NjBdXSwgMTQ0NzcxMzUwMDQ2 MCwgMTg0NjE0LCAxNDQ3NzYwMjU1NjgzLCAnMTc3JywgMTc2XQorICAgICAgICBdLAorICAgICAg ICAnYmFzZWxpbmUnOiBbCisgICAgICAgICAgICBbMTA1NDg5NTYsIDMxMi41OSwgMSwgMCwgMCwg ZmFsc2UsIFtdLCAxNDIwMDcwNDAwMDAwLCA2NzcyNCwgMTQyMDA3MDQwMDAwMCwgIjAiLCAwXQog ICAgICAgICBdCiAgICAgfSwKICAgICAnZm9ybWF0TWFwJzogWydpZCcsICdtZWFuJywgJ2l0ZXJh dGlvbkNvdW50JywgJ3N1bScsICdzcXVhcmVTdW0nLCAnbWFya2VkT3V0bGllcicsICdyZXZpc2lv bnMnLApAQCAtMjMsNyArMjYsOCBAQCB2YXIgc2FtcGxlQ2x1c3RlciA9IHsKICAgICAnZWxhcHNl ZFRpbWUnOiAyMTAuNjg0MDYxMDUwNDIsCiAgICAgJ3N0YXR1cyc6ICdPSycKIH07Ci12YXIgc2Ft cGxlRGF0YSA9IHNhbXBsZUNsdXN0ZXIuY29uZmlndXJhdGlvbnMuY3VycmVudFswXTsKK2NvbnN0 IHNhbXBsZURhdGEgPSBzYW1wbGVDbHVzdGVyLmNvbmZpZ3VyYXRpb25zLmN1cnJlbnRbMF07Citj b25zdCBzYW1wbGVDdXN0b21CYXNlbGluZURhdGEgPSBzYW1wbGVDbHVzdGVyLmNvbmZpZ3VyYXRp b25zLmJhc2VsaW5lWzBdOwogCiBkZXNjcmliZSgnTWVhc3VyZW1lbnRBZGFwdG9yJywgZnVuY3Rp b24gKCkgewogICAgIE1vY2tNb2RlbHMuaW5qZWN0KCk7CkBAIC01Nyw2ICs2MSwxMSBAQCBkZXNj cmliZSgnTWVhc3VyZW1lbnRBZGFwdG9yJywgZnVuY3Rpb24gCiAgICAgICAgICAgICBhc3NlcnQu ZXF1YWwoYWRvcHRvci5hcHBseVRvKHNhbXBsZURhdGEpLmJ1aWxkKCkudXJsKCksICdodHRwOi8v YnVpbGQud2Via2l0Lm9yZy9idWlsZGVycy9XZWJLaXQgUGVyZiBCdWlsZGVyLzE3OCcpOwogICAg ICAgICB9KTsKIAorICAgICAgICBpdCgnc2hvdWxkIGFkYXB0IGJ1aWxkIGluZm9ybWF0aW9uIGFz IG51bGwgd2hlbiB0aGUgYnVpbGRlciBpcyBub3Qgc3BlY2lmaWVkJywgZnVuY3Rpb24gKCkgewor ICAgICAgICAgICAgdmFyIGFkb3B0b3IgPSBuZXcgTWVhc3VyZW1lbnRBZGFwdG9yKHNhbXBsZUNs dXN0ZXIuZm9ybWF0TWFwKTsKKyAgICAgICAgICAgIGFzc2VydC5lcXVhbChhZG9wdG9yLmFwcGx5 VG8oc2FtcGxlQ3VzdG9tQmFzZWxpbmVEYXRhKS5idWlsZCgpLCBudWxsKTsKKyAgICAgICAgfSk7 CisKICAgICAgICAgaXQoJ3Nob3VsZCBhZGFwdCByZXZpc2lvbiBpbmZvcm1hdGlvbiBhcyBhIFJv b3RTZXQgb2JqZWN0JywgZnVuY3Rpb24gKCkgewogICAgICAgICAgICAgdmFyIGFkb3B0b3IgPSBu ZXcgTWVhc3VyZW1lbnRBZGFwdG9yKHNhbXBsZUNsdXN0ZXIuZm9ybWF0TWFwKTsKICAgICAgICAg ICAgIHZhciByb290U2V0ID0gYWRvcHRvci5hcHBseVRvKHNhbXBsZURhdGEpLnJvb3RTZXQoKTsK