168955 2017-02-27 17:52:29 -0800 Expose _WKVisitedLinkProvider in a header 2017-02-28 17:05:57 -0800 1 1 1 Unclassified WebKit WebKit2 Safari 9 Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap aakash_jain commit-queue mitz oldest_to_newest 1281654 0 ap 2017-02-27 17:52:29 -0800 _WKVisitedLinkProvider should be in a header, because it is exported. 1281656 1 302903 ap 2017-02-27 17:55:06 -0800 Created attachment 302903 proposed patch 1281658 2 302903 aakash_jain 2017-02-27 18:01:53 -0800 Comment on attachment 302903 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=302903&action=review overall looks good to me. > Source/WebKit2/UIProcess/API/Cocoa/_WKVisitedLinkStore.h:40 > +__attribute__((visibility("default"))) NS_UNAVAILABLE why do we need NS_UNAVAILABLE? 1282042 3 ap 2017-02-28 16:37:36 -0800 We don't want any new clients to use this function, it is only for binary compatibility. 1282066 4 302903 commit-queue 2017-02-28 17:05:54 -0800 Comment on attachment 302903 proposed patch Clearing flags on attachment: 302903 Committed r213195: <http://trac.webkit.org/changeset/213195> 1282067 5 commit-queue 2017-02-28 17:05:57 -0800 All reviewed patches have been landed. Closing bug. 302903 2017-02-27 17:55:06 -0800 2017-02-28 17:05:54 -0800 proposed patch _WKVisitedLinkProvider.txt text/plain 1815 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzExMCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE3LTAyLTI3ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIEV4cG9zZSBfV0tWaXNpdGVk TGlua1Byb3ZpZGVyIGluIGEgaGVhZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjg5NTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLVmlzaXRlZExpbmtQcm92 aWRlci5tbToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL19XS1Zpc2l0ZWRMaW5rU3Rv cmUuaDoKKyAgICAgICAgVGhlIGNsYXNzIG5lZWRzIHRvIGJlIHZpc2libGUgaW4gYSBoZWFkZXIs IGFzIGl0IGlzIGV4cG9ydGVkIFNQSS4KKwogMjAxNy0wMi0yNyAgWW91ZW5uIEZhYmxldCAgPHlv dWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYlJUQ10gQWRkIHN1cHBvcnQgZm9yIGxpYndl YnJ0YyBUQ1AgaW5jb21pbmcgY29ubmVjdGlvbnMKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvQ29jb2EvX1dLVmlzaXRlZExpbmtQcm92aWRlci5tbQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1Zpc2l0ZWRMaW5rUHJvdmlkZXIu bW0JKHJldmlzaW9uIDIxMzA5MSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29j b2EvX1dLVmlzaXRlZExpbmtQcm92aWRlci5tbQkod29ya2luZyBjb3B5KQpAQCAtMjgsMTIgKzI4 LDYgQEAKIAogI2lmIFdLX0FQSV9FTkFCTEVECiAKLS8vIERlZmluZWQgZm9yIGJpbmFyeSBjb21w YXRpYmlsaXR5IHdpdGggU2FmYXJpIGluIGlPUyAxMC4KLQotX19hdHRyaWJ1dGVfXygodmlzaWJp bGl0eSgiZGVmYXVsdCIpKSkKLUBpbnRlcmZhY2UgX1dLVmlzaXRlZExpbmtQcm92aWRlciA6IF9X S1Zpc2l0ZWRMaW5rU3RvcmUKLUBlbmQKLQogQGltcGxlbWVudGF0aW9uIF9XS1Zpc2l0ZWRMaW5r UHJvdmlkZXIKIEBlbmQKIApJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2Nv YS9fV0tWaXNpdGVkTGlua1N0b3JlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9Db2NvYS9fV0tWaXNpdGVkTGlua1N0b3JlLmgJKHJldmlzaW9uIDIxMzA5MSkK KysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLVmlzaXRlZExpbmtTdG9y ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw0ICszNiw5IEBAIFdLX0NMQVNTX0FWQUlMQUJMRSht YWNvc3goMTAuMTApLCBpb3MoOC4KIAogQGVuZAogCisvLyBEZWZpbmVkIGZvciBiaW5hcnkgY29t cGF0aWJpbGl0eSB3aXRoIFNhZmFyaSBpbiBpT1MgMTAuCitfX2F0dHJpYnV0ZV9fKCh2aXNpYmls aXR5KCJkZWZhdWx0IikpKSBOU19VTkFWQUlMQUJMRQorQGludGVyZmFjZSBfV0tWaXNpdGVkTGlu a1Byb3ZpZGVyIDogX1dLVmlzaXRlZExpbmtTdG9yZQorQGVuZAorCiAjZW5kaWYK