168951 2017-02-27 17:05:23 -0800 Export WKPluginInformationBundleShortVersionKey 2017-02-27 18:08:13 -0800 1 1 1 Unclassified WebKit WebKit2 Safari 9 Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap aakash_jain commit-queue mitz sam oldest_to_newest 1281620 0 ap 2017-02-27 17:05:23 -0800 WKPluginInformationBundleShortVersionKey was accidentally not exported from the framework in https://trac.webkit.org/changeset/151767 1281622 1 302894 ap 2017-02-27 17:06:45 -0800 Created attachment 302894 proposed patch 1281627 2 aakash_jain 2017-02-27 17:13:07 -0800 Do we need the WKPluginInformationBundleShortVersionKey method at all. It doesn't seems to be used anywhere. Shouldn't we just delete it from WKPluginInformation.h and WKPluginInformation.cpp 1281631 3 302896 aakash_jain 2017-02-27 17:16:10 -0800 Created attachment 302896 Another proposed patch 1281651 4 302894 ap 2017-02-27 17:40:20 -0800 Comment on attachment 302894 proposed patch It's not used, but I think that it's better to keep for consistency. It would be strange to expose WKPluginInformationBundleVersionKey, but not WKPluginInformationBundleShortVersionKey. 1281662 5 302894 commit-queue 2017-02-27 18:08:09 -0800 Comment on attachment 302894 proposed patch Clearing flags on attachment: 302894 Committed r213111: <http://trac.webkit.org/changeset/213111> 1281663 6 commit-queue 2017-02-27 18:08:13 -0800 All reviewed patches have been landed. Closing bug. 302894 2017-02-27 17:06:45 -0800 2017-02-27 18:08:09 -0800 proposed patch WKPluginInformationBundleShortVersionKey.txt text/plain 1262 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzEwMikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE3LTAyLTI3ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIEV4cG9ydCBXS1BsdWdpbklu Zm9ybWF0aW9uQnVuZGxlU2hvcnRWZXJzaW9uS2V5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg5NTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9BUEkvYy9XS1BsdWdpbkluZm9ybWF0aW9u Lmg6IEl0IHdhcyBhY2NpZGVudGFsbHkgbm90IGV4cG9ydGVkIHdoZW4gYWRkZWQuCisKIDIwMTct MDItMjcgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgW01h Y10gRG9uJ3QgdXNlIHVuZGVmaW5lZCBzYW5kYm94IHJ1bGUgb24gbWFjT1MgMTAuMTEgb3IgZWFy bGllcgpJbmRleDogU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLUGx1Z2luSW5mb3JtYXRp b24uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tQbHVnaW5J bmZvcm1hdGlvbi5oCShyZXZpc2lvbiAyMTMwOTEpCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQv QVBJL2MvV0tQbHVnaW5JbmZvcm1hdGlvbi5oCSh3b3JraW5nIGNvcHkpCkBAIC00MSw3ICs0MSw3 IEBAIFdLX0VYUE9SVCBXS1N0cmluZ1JlZiBXS1BsdWdpbkluZm9ybWF0aW8KIFdLX0VYUE9SVCBX S1N0cmluZ1JlZiBXS1BsdWdpbkluZm9ybWF0aW9uQnVuZGxlVmVyc2lvbktleSgpOwogCiAvKiBW YWx1ZSB0eXBlOiBXS1N0cmluZ1JlZiAqLwotV0tTdHJpbmdSZWYgV0tQbHVnaW5JbmZvcm1hdGlv bkJ1bmRsZVNob3J0VmVyc2lvbktleSgpOworV0tfRVhQT1JUIFdLU3RyaW5nUmVmIFdLUGx1Z2lu SW5mb3JtYXRpb25CdW5kbGVTaG9ydFZlcnNpb25LZXkoKTsKIAogLyogVmFsdWUgdHlwZTogV0tT dHJpbmdSZWYgKi8KIFdLX0VYUE9SVCBXS1N0cmluZ1JlZiBXS1BsdWdpbkluZm9ybWF0aW9uUGF0 aEtleSgpOwo= 302896 2017-02-27 17:16:10 -0800 2017-02-27 17:40:31 -0800 Another proposed patch patch_WKPluginInformationBundleShortVersionKey text/plain 2030 aakash_jain SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzEwNCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE3LTAyLTI3ICBBYWthc2gg SmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBFeHBvcnQgV0tQbHVnaW5J bmZvcm1hdGlvbkJ1bmRsZVNob3J0VmVyc2lvbktleQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4OTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQvQVBJL2MvV0tQbHVnaW5JbmZvcm1hdGlv bi5jcHA6IFJlbW92ZSB1bnVzZWQgV0tQbHVnaW5JbmZvcm1hdGlvbkJ1bmRsZVNob3J0VmVyc2lv bktleS4KKyAgICAgICAgKFdLUGx1Z2luSW5mb3JtYXRpb25CdW5kbGVTaG9ydFZlcnNpb25LZXkp OiBEZWxldGVkLgorICAgICAgICAqIFNoYXJlZC9BUEkvYy9XS1BsdWdpbkluZm9ybWF0aW9uLmg6 IERpdHRvLgorCiAyMDE3LTAyLTI3ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4K IAogICAgICAgICBbV2ViUlRDXSBBZGQgc3VwcG9ydCBmb3IgbGlid2VicnRjIFRDUCBpbmNvbWlu ZyBjb25uZWN0aW9ucwpJbmRleDogU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLUGx1Z2lu SW5mb3JtYXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkv Yy9XS1BsdWdpbkluZm9ybWF0aW9uLmNwcAkocmV2aXNpb24gMjEzMDg1KQorKysgU291cmNlL1dl YktpdDIvU2hhcmVkL0FQSS9jL1dLUGx1Z2luSW5mb3JtYXRpb24uY3BwCSh3b3JraW5nIGNvcHkp CkBAIC01MiwxNiArNTIsNiBAQCBXS1N0cmluZ1JlZiBXS1BsdWdpbkluZm9ybWF0aW9uQnVuZGxl VmVyCiAjZW5kaWYKIH0KIAotV0tTdHJpbmdSZWYgV0tQbHVnaW5JbmZvcm1hdGlvbkJ1bmRsZVNo b3J0VmVyc2lvbktleSgpCi17Ci0jaWYgRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCi0gICAg c3RhdGljIEFQSTo6U3RyaW5nJiBrZXkgPSBBUEk6OlN0cmluZzo6Y3JlYXRlKHBsdWdpbkluZm9y bWF0aW9uQnVuZGxlU2hvcnRWZXJzaW9uS2V5KCkpLmxlYWtSZWYoKTsKLSAgICByZXR1cm4gdG9B UEkoJmtleSk7Ci0jZWxzZQotICAgIHJldHVybiAwOwotI2VuZGlmCi19Ci0KIFdLU3RyaW5nUmVm IFdLUGx1Z2luSW5mb3JtYXRpb25QYXRoS2V5KCkKIHsKICNpZiBFTkFCTEUoTkVUU0NBUEVfUExV R0lOX0FQSSkKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvYy9XS1BsdWdpbkluZm9y bWF0aW9uLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLUGx1 Z2luSW5mb3JtYXRpb24uaAkocmV2aXNpb24gMjEzMDg1KQorKysgU291cmNlL1dlYktpdDIvU2hh cmVkL0FQSS9jL1dLUGx1Z2luSW5mb3JtYXRpb24uaAkod29ya2luZyBjb3B5KQpAQCAtNDEsOSAr NDEsNiBAQCBXS19FWFBPUlQgV0tTdHJpbmdSZWYgV0tQbHVnaW5JbmZvcm1hdGlvCiBXS19FWFBP UlQgV0tTdHJpbmdSZWYgV0tQbHVnaW5JbmZvcm1hdGlvbkJ1bmRsZVZlcnNpb25LZXkoKTsKIAog LyogVmFsdWUgdHlwZTogV0tTdHJpbmdSZWYgKi8KLVdLU3RyaW5nUmVmIFdLUGx1Z2luSW5mb3Jt YXRpb25CdW5kbGVTaG9ydFZlcnNpb25LZXkoKTsKLQotLyogVmFsdWUgdHlwZTogV0tTdHJpbmdS ZWYgKi8KIFdLX0VYUE9SVCBXS1N0cmluZ1JlZiBXS1BsdWdpbkluZm9ybWF0aW9uUGF0aEtleSgp OwogCiAvKiBWYWx1ZSB0eXBlOiBXS1N0cmluZ1JlZiAqLwo=