168944 2017-02-27 16:20:59 -0800 Package ImageDiff built with host SDK 2017-05-03 09:19:14 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 168531 168939 1 jbedard jbedard clopez commit-queue ddkilzer lforschler webkit-bug-importer oldest_to_newest 1281589 0 jbedard 2017-02-27 16:20:59 -0800 Package ImageDiff that has been built with the host SDK in build products. 1281590 1 webkit-bug-importer 2017-02-27 16:21:28 -0800 <rdar://problem/30745642> 1297137 2 307026 jbedard 2017-04-13 14:38:53 -0700 Created attachment 307026 Patch 1297148 3 307030 jbedard 2017-04-13 14:53:54 -0700 Created attachment 307030 Patch 1300697 4 307030 ddkilzer 2017-04-24 16:15:07 -0700 Comment on attachment 307030 Patch r=me 1300714 5 307030 commit-queue 2017-04-24 16:45:02 -0700 Comment on attachment 307030 Patch Clearing flags on attachment: 307030 Committed r215702: <http://trac.webkit.org/changeset/215702> 1300715 6 commit-queue 2017-04-24 16:45:03 -0700 All reviewed patches have been landed. Closing bug. 1300755 7 clopez 2017-04-24 17:30:40 -0700 Committed r215708: <http://trac.webkit.org/changeset/215708> 1301014 8 jbedard 2017-04-25 08:14:56 -0700 (In reply to Carlos Alberto Lopez Perez from comment #7) > Committed r215708: <http://trac.webkit.org/changeset/215708> Thank you for the fix! 307026 2017-04-13 14:38:53 -0700 2017-04-13 14:53:53 -0700 Patch bug-168944-20170413143852.patch text/plain 3047 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNTMzNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE3LTA0LTEzICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBQYWNrYWdlIEltYWdlRGlmZiBidWlsdCB3aXRoIGhvc3QgU0RLCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg5NDQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBpT1MgU2ltdWxhdG9y IGFuZCBpT1MgZGV2aWNlIHNob3VsZCBhcmNoaXZlIHRoZSBJbWFnZURpZmYgYnVpbHQgZm9yIHRo ZSBob3N0CisgICAgICAgIG1hY2hpbmUuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9i dWlsdC1wcm9kdWN0LWFyY2hpdmU6CisgICAgICAgIChkZXRlcm1pbmVXZWJLaXRCdWlsZERpcmVj dG9yaWVzKTogQWRkIF9ob3N0QnVpbGREaXJlY3RvcnkgZm9yIGlPUy4KKyAgICAgICAgKGFyY2hp dmVCdWlsdFByb2R1Y3QpOiBBcmNoaXZlIE1hYyBwcm9kdWN0cyBmb3IgaU9TIHNvIHRoYXQgSW1h Z2VEaWZmIGlzIGluY2x1ZGVkLgorCiAyMDE3LTA0LTEzICBKb25hdGhhbiBCZWRhcmQgIDxqYmVk YXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBCdWlsZCBJbWFnZURpZmYgd2l0aCBob3N0IFNESwpJ bmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbHQtcHJvZHVjdC1hcmNoaXZlCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWx0LXByb2R1Y3QtYXJjaGl2ZQko cmV2aXNpb24gMjE1MzM1KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbHQtcHJvZHVj dC1hcmNoaXZlCSh3b3JraW5nIGNvcHkpCkBAIC0zNCw2ICszNCw3IEBAIGltcG9ydCB6aXBmaWxl CiAKIF9jb25maWd1cmF0aW9uQnVpbGREaXJlY3RvcnkgPSBOb25lCiBfdG9wTGV2ZWxCdWlsZERp cmVjdG9yeSA9IE5vbmUKK19ob3N0QnVpbGREaXJlY3RvcnkgPSBOb25lCiAKIAogZGVmIG1haW4o KToKQEAgLTg0LDggKzg1LDE0IEBAIGRlZiB3ZWJraXRCdWlsZERpcmVjdG9yeUZvckNvbmZpZ3Vy YXRpb24KIGRlZiBkZXRlcm1pbmVXZWJLaXRCdWlsZERpcmVjdG9yaWVzKHBsYXRmb3JtLCBmdWxs UGxhdGZvcm0sIGNvbmZpZ3VyYXRpb24pOgogICAgIGdsb2JhbCBfY29uZmlndXJhdGlvbkJ1aWxk RGlyZWN0b3J5CiAgICAgZ2xvYmFsIF90b3BMZXZlbEJ1aWxkRGlyZWN0b3J5CisgICAgZ2xvYmFs IF9ob3N0QnVpbGREaXJlY3RvcnkKICAgICBfY29uZmlndXJhdGlvbkJ1aWxkRGlyZWN0b3J5ID0g d2Via2l0QnVpbGREaXJlY3RvcnlGb3JDb25maWd1cmF0aW9uQW5kUGxhdGZvcm0oY29uZmlndXJh dGlvbiwgcGxhdGZvcm0sIGZ1bGxQbGF0Zm9ybSkKICAgICBfdG9wTGV2ZWxCdWlsZERpcmVjdG9y eSA9IHdlYmtpdEJ1aWxkRGlyZWN0b3J5Rm9yQ29uZmlndXJhdGlvbkFuZFBsYXRmb3JtKGNvbmZp Z3VyYXRpb24sIHBsYXRmb3JtLCBmdWxsUGxhdGZvcm0sIHJldHVyblRvcExldmVsRGlyZWN0b3J5 PVRydWUpCisgICAgaWYgcGxhdGZvcm0gPT0gJ2lvcyc6CisgICAgICAgIF9ob3N0QnVpbGREaXJl Y3RvcnkgPSB3ZWJraXRCdWlsZERpcmVjdG9yeUZvckNvbmZpZ3VyYXRpb25BbmRQbGF0Zm9ybShj b25maWd1cmF0aW9uLCAnbWFjJykKKyAgICBlbHNlOgorICAgICAgICBfaG9zdEJ1aWxkRGlyZWN0 b3J5ID0gX2NvbmZpZ3VyYXRpb25CdWlsZERpcmVjdG9yeQorICAgIAogICAgIHJldHVybiBfdG9w TGV2ZWxCdWlsZERpcmVjdG9yeQogCiAKQEAgLTE2Nyw3ICsxNzQsMTggQEAgZGVmIGFyY2hpdmVC dWlsdFByb2R1Y3QoY29uZmlndXJhdGlvbiwgcAogCiAgICAgIyBGSVhNRTogSW1hZ2VEaWZmIHNo b3VsZCBiZSBidWlsdCB3aXRoIHRoZSBob3N0IFNESywgPHJkYXI6Ly9wcm9ibGVtLzMwMjY2MDM4 Pi4KICAgICAjIEFuIGFwcHJvYWNoIHNpbWlsYXIgdG8gdGhlIG9uZSB1c2VkIGZvciBMYXlvdXRU ZXN0UmVsYXkgaW4gcjE5MDUxNSBzaG91bGQgYmUgaW1sZW1lbnRlZC4KLSAgICBpZiBwbGF0Zm9y bSBpbiAoJ21hYycsICdpb3MnKToKKyAgICBpZiBwbGF0Zm9ybSA9PSAnaW9zJzoKKyAgICAgICAg Y29tYmluZWREaXJlY3RvcnkgPSBvcy5wYXRoLmpvaW4oX3RvcExldmVsQnVpbGREaXJlY3Rvcnks ICdjb21iaW5lZC1tYWMtYW5kLWlvcycpCisgICAgICAgIHJlbW92ZURpcmVjdG9yeUlmRXhpc3Rz KGNvbWJpbmVkRGlyZWN0b3J5KQorICAgICAgICBvcy5tYWtlZGlycyhjb21iaW5lZERpcmVjdG9y eSkKKworICAgICAgICBpZiBzdWJwcm9jZXNzLmNhbGwoWycvYmluL2NwJywgJy1wUicsIF9jb25m aWd1cmF0aW9uQnVpbGREaXJlY3RvcnksIGNvbWJpbmVkRGlyZWN0b3J5XSk6CisgICAgICAgICAg ICByZXR1cm4gMQorICAgICAgICBpZiBzdWJwcm9jZXNzLmNhbGwoWycvYmluL2NwJywgJy1wUics IF9ob3N0QnVpbGREaXJlY3RvcnksIGNvbWJpbmVkRGlyZWN0b3J5XSk6CisgICAgICAgICAgICBy ZXR1cm4gMQorCisgICAgICAgIHJldHVybiBjcmVhdGVaaXAoY29tYmluZWREaXJlY3RvcnksIGNv bmZpZ3VyYXRpb24pOgorICAgIGVsaWYgcGxhdGZvcm0gPT0gJ21hYyc6CQogICAgICAgICByZXR1 cm4gY3JlYXRlWmlwKF9jb25maWd1cmF0aW9uQnVpbGREaXJlY3RvcnksIGNvbmZpZ3VyYXRpb24s IGVtYmVkUGFyZW50RGlyZWN0b3J5TmFtZU9uRGFyd2luPVRydWUpCiAgICAgZWxpZiBwbGF0Zm9y bSA9PSAnd2luJzoKICAgICAgICAgIyBGSVhNRTogV2Ugc2hvdWxkbid0IGhhcmRjb2RlIHRoZSBh c3N1bXB0aW9uIG9mIGEgMzItYml0IGJ1aWxkLiBTZWUgPGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDk3MTU+Lgo= 307030 2017-04-13 14:53:54 -0700 2017-04-24 16:45:02 -0700 Patch bug-168944-20170413145353.patch text/plain 3197 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNTMzNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE3LTA0LTEzICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBQYWNrYWdlIEltYWdlRGlmZiBidWlsdCB3aXRoIGhvc3QgU0RLCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg5NDQKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzMwNzQ1NjQyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGlPUyBTaW11bGF0b3IgYW5kIGlPUyBkZXZpY2Ugc2hvdWxk IGFyY2hpdmUgdGhlIEltYWdlRGlmZiBidWlsdCBmb3IgdGhlIGhvc3QKKyAgICAgICAgbWFjaGlu ZS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWx0LXByb2R1Y3QtYXJjaGl2ZToK KyAgICAgICAgKGRldGVybWluZVdlYktpdEJ1aWxkRGlyZWN0b3JpZXMpOiBBZGQgX2hvc3RCdWls ZERpcmVjdG9yeSBmb3IgaU9TLgorICAgICAgICAoYXJjaGl2ZUJ1aWx0UHJvZHVjdCk6IEFyY2hp dmUgTWFjIHByb2R1Y3RzIGZvciBpT1Mgc28gdGhhdCBJbWFnZURpZmYgaXMgaW5jbHVkZWQuCisK IDIwMTctMDQtMTMgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAg ICAgIEJ1aWxkIEltYWdlRGlmZiB3aXRoIGhvc3QgU0RLCkluZGV4OiBUb29scy9CdWlsZFNsYXZl U3VwcG9ydC9idWlsdC1wcm9kdWN0LWFyY2hpdmUKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQvYnVpbHQtcHJvZHVjdC1hcmNoaXZlCShyZXZpc2lvbiAyMTUzMzUpCisrKyBU b29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsdC1wcm9kdWN0LWFyY2hpdmUJKHdvcmtpbmcgY29w eSkKQEAgLTM0LDYgKzM0LDcgQEAgaW1wb3J0IHppcGZpbGUKIAogX2NvbmZpZ3VyYXRpb25CdWls ZERpcmVjdG9yeSA9IE5vbmUKIF90b3BMZXZlbEJ1aWxkRGlyZWN0b3J5ID0gTm9uZQorX2hvc3RC dWlsZERpcmVjdG9yeSA9IE5vbmUKIAogCiBkZWYgbWFpbigpOgpAQCAtODQsOCArODUsMTQgQEAg ZGVmIHdlYmtpdEJ1aWxkRGlyZWN0b3J5Rm9yQ29uZmlndXJhdGlvbgogZGVmIGRldGVybWluZVdl YktpdEJ1aWxkRGlyZWN0b3JpZXMocGxhdGZvcm0sIGZ1bGxQbGF0Zm9ybSwgY29uZmlndXJhdGlv bik6CiAgICAgZ2xvYmFsIF9jb25maWd1cmF0aW9uQnVpbGREaXJlY3RvcnkKICAgICBnbG9iYWwg X3RvcExldmVsQnVpbGREaXJlY3RvcnkKKyAgICBnbG9iYWwgX2hvc3RCdWlsZERpcmVjdG9yeQog ICAgIF9jb25maWd1cmF0aW9uQnVpbGREaXJlY3RvcnkgPSB3ZWJraXRCdWlsZERpcmVjdG9yeUZv ckNvbmZpZ3VyYXRpb25BbmRQbGF0Zm9ybShjb25maWd1cmF0aW9uLCBwbGF0Zm9ybSwgZnVsbFBs YXRmb3JtKQogICAgIF90b3BMZXZlbEJ1aWxkRGlyZWN0b3J5ID0gd2Via2l0QnVpbGREaXJlY3Rv cnlGb3JDb25maWd1cmF0aW9uQW5kUGxhdGZvcm0oY29uZmlndXJhdGlvbiwgcGxhdGZvcm0sIGZ1 bGxQbGF0Zm9ybSwgcmV0dXJuVG9wTGV2ZWxEaXJlY3Rvcnk9VHJ1ZSkKKyAgICBpZiBwbGF0Zm9y bSA9PSAnaW9zJzoKKyAgICAgICAgX2hvc3RCdWlsZERpcmVjdG9yeSA9IHdlYmtpdEJ1aWxkRGly ZWN0b3J5Rm9yQ29uZmlndXJhdGlvbkFuZFBsYXRmb3JtKGNvbmZpZ3VyYXRpb24sICdtYWMnKQor ICAgIGVsc2U6CisgICAgICAgIF9ob3N0QnVpbGREaXJlY3RvcnkgPSBfY29uZmlndXJhdGlvbkJ1 aWxkRGlyZWN0b3J5CisgICAgCiAgICAgcmV0dXJuIF90b3BMZXZlbEJ1aWxkRGlyZWN0b3J5CiAK IApAQCAtMTY1LDkgKzE3MiwxOCBAQCBkZWYgZGlyQ29udGFpbnNkd28oZGlyZWN0b3J5KToKIGRl ZiBhcmNoaXZlQnVpbHRQcm9kdWN0KGNvbmZpZ3VyYXRpb24sIHBsYXRmb3JtLCBmdWxsUGxhdGZv cm0pOgogICAgIGFzc2VydCBwbGF0Zm9ybSBpbiAoJ21hYycsICd3aW4nLCAnZ3RrJywgJ2VmbCcs ICdpb3MnKQogCi0gICAgIyBGSVhNRTogSW1hZ2VEaWZmIHNob3VsZCBiZSBidWlsdCB3aXRoIHRo ZSBob3N0IFNESywgPHJkYXI6Ly9wcm9ibGVtLzMwMjY2MDM4Pi4KLSAgICAjIEFuIGFwcHJvYWNo IHNpbWlsYXIgdG8gdGhlIG9uZSB1c2VkIGZvciBMYXlvdXRUZXN0UmVsYXkgaW4gcjE5MDUxNSBz aG91bGQgYmUgaW1sZW1lbnRlZC4KLSAgICBpZiBwbGF0Zm9ybSBpbiAoJ21hYycsICdpb3MnKToK KyAgICBpZiBwbGF0Zm9ybSA9PSAnaW9zJzoKKyAgICAgICAgY29tYmluZWREaXJlY3RvcnkgPSBv cy5wYXRoLmpvaW4oX3RvcExldmVsQnVpbGREaXJlY3RvcnksICdjb21iaW5lZC1tYWMtYW5kLWlv cycpCisgICAgICAgIHJlbW92ZURpcmVjdG9yeUlmRXhpc3RzKGNvbWJpbmVkRGlyZWN0b3J5KQor ICAgICAgICBvcy5tYWtlZGlycyhjb21iaW5lZERpcmVjdG9yeSkKKworICAgICAgICBpZiBzdWJw cm9jZXNzLmNhbGwoWycvYmluL2NwJywgJy1wUicsIF9jb25maWd1cmF0aW9uQnVpbGREaXJlY3Rv cnksIGNvbWJpbmVkRGlyZWN0b3J5XSk6CisgICAgICAgICAgICByZXR1cm4gMQorICAgICAgICBp ZiBzdWJwcm9jZXNzLmNhbGwoWycvYmluL2NwJywgJy1wUicsIF9ob3N0QnVpbGREaXJlY3Rvcnks IGNvbWJpbmVkRGlyZWN0b3J5XSk6CisgICAgICAgICAgICByZXR1cm4gMQorCisgICAgICAgIHJl dHVybiBjcmVhdGVaaXAoY29tYmluZWREaXJlY3RvcnksIGNvbmZpZ3VyYXRpb24pOgorICAgIGVs aWYgcGxhdGZvcm0gPT0gJ21hYyc6CQogICAgICAgICByZXR1cm4gY3JlYXRlWmlwKF9jb25maWd1 cmF0aW9uQnVpbGREaXJlY3RvcnksIGNvbmZpZ3VyYXRpb24sIGVtYmVkUGFyZW50RGlyZWN0b3J5 TmFtZU9uRGFyd2luPVRydWUpCiAgICAgZWxpZiBwbGF0Zm9ybSA9PSAnd2luJzoKICAgICAgICAg IyBGSVhNRTogV2Ugc2hvdWxkbid0IGhhcmRjb2RlIHRoZSBhc3N1bXB0aW9uIG9mIGEgMzItYml0 IGJ1aWxkLiBTZWUgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDk3 MTU+Lgo=