168940 2017-02-27 15:15:43 -0800 [iOS] Getting QLPreviewProtocol slows down first navigation in Web process 2017-02-28 15:23:25 -0800 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mitz thorton achristensen aestes beidson cdumez commit-queue dbates japhet simon.fraser thorton oldest_to_newest 1281565 0 mitz 2017-02-27 15:15:43 -0800 The first navigation in a Web process is slowed down checking if the protocol is QLPreviewProtocol, which involves dynamically loading Quick Look. This can be avoided for common schemes. 1281979 1 thorton 2017-02-28 15:05:25 -0800 *** Bug 168993 has been marked as a duplicate of this bug. *** 1281980 2 302993 thorton 2017-02-28 15:07:11 -0800 Created attachment 302993 Patch 1281982 3 thorton 2017-02-28 15:07:35 -0800 rdar://problem/29468999 1281989 4 302993 simon.fraser 2017-02-28 15:15:28 -0800 Comment on attachment 302993 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302993&action=review > Source/WebCore/loader/ios/QuickLook.mm:130 > + return NO; NO! 1281996 5 thorton 2017-02-28 15:23:18 -0800 https://trac.webkit.org/changeset/213182 and https://trac.webkit.org/changeset/213183. 302993 2017-02-28 15:07:11 -0800 2017-02-28 15:15:28 -0800 Patch bug-168940-20170228150415.patch text/plain 7266 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyNjU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDNiZDEyN2UwODMxNzQ3 NGMxMDc2MzYwNGY2MzA3MDZlMDAxMGQzMC4uZjg2MzYwN2QwNmVjYzNmOTExZmEzZjU5ODM1NTI1 Nzk2YmYwYjgyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDE3LTAyLTI4ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIEdldHRp bmcgUUxQcmV2aWV3UHJvdG9jb2wgc2xvd3MgZG93biBmaXJzdCBuYXZpZ2F0aW9uIGluIFdlYiBw cm9jZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x Njg5NDAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI5NDY4OTk5PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywganVzdCBhIHBl cmZvcm1hbmNlIGltcHJvdmVtZW50LgorCisgICAgICAgICogbG9hZGVyL0RvY3VtZW50TG9hZGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmlzUmVtb3RlV2ViQXJjaGl2ZSk6CisgICAgICAgICog bG9hZGVyL1BvbGljeUNoZWNrZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UG9saWN5Q2hlY2tl cjo6Y2hlY2tOYXZpZ2F0aW9uUG9saWN5KToKKyAgICAgICAgKiBsb2FkZXIvUmVzb3VyY2VMb2Fk Tm90aWZpZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VMb2FkTm90aWZpZXI6OmRp c3BhdGNoV2lsbFNlbmRSZXF1ZXN0KToKKyAgICAgICAgTWFrZSB1c2Ugb2YgaXNRdWlja0xvb2tQ cmV2aWV3VVJMLgorCisgICAgICAgICogbG9hZGVyL2lvcy9RdWlja0xvb2suaDoKKyAgICAgICAg KiBsb2FkZXIvaW9zL1F1aWNrTG9vay5tbToKKyAgICAgICAgKFdlYkNvcmU6OmlzUXVpY2tMb29r UHJldmlld1VSTCk6CisgICAgICAgIEFkZCBpc1F1aWNrTG9va1ByZXZpZXdVUkwsIHdoaWNoIGZp cnN0IGVhcmx5LXJldHVybnMgaWYgdGhlIHByb3RvY29sCisgICAgICAgIG9mIHRoZSBVUkwgaXMg YSB3ZWxsLWtub3duIHByb3RvY29sLCBhbmQgdGhlbiBmYWxscyBiYWNrIHRvIGxvYWRpbmcgUXVp Y2tMb29rLgorCisgICAgICAgIEluIGEgbWljcm9iZW5jaG1hcmsgdGhpcyBpcyBhIDMwLTQwJSBp bXByb3ZlbWVudCBpbiB0b3RhbCB0aW1lIHNwZW50CisgICAgICAgIGxvYWRpbmcgYW4gZW1wdHkg SFRNTCBkb2N1bWVudCAod2FsbC1jbG9jayB0aW1lIGJldHdlZW4gbG9hZEhUTUxTdHJpbmcKKyAg ICAgICAgYW5kIGRpZEZpbmlzaE5hdmlnYXRpb24pLgorCisKIDIwMTctMDItMjAgIFJvbWFpbiBC ZWxsZXNzb3J0ICA8cm9tYWluLmJlbGxlc3NvcnRAY3JmLmNhbm9uLmZyPgogCiAgICAgICAgIFtS ZWFkYWJsZSBTdHJlYW1zIEFQSV0gQWRkIFJlYWRhYmxlQnl0ZVN0cmVhbUNvbnRyb2xsZXIgYnlv YlJlcXVlc3QgYXR0cmlidXRlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjQyNTU3NzljOGI3ZDIzYzY0YTE5ZDUz ZjQyNTE5ZmY0YzJkMTZlNi4uMjYxMDY5NjdjNTc2Y2Y2NWY1MTdiMmY0YTBjOTA5ZmY2ODNhOWNk NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJL aXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAyLTI4ICBUaW0gSG9ydG9uICA8 dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIEdldHRpbmcgUUxQcmV2 aWV3UHJvdG9jb2wgc2xvd3MgZG93biBmaXJzdCBuYXZpZ2F0aW9uIGluIFdlYiBwcm9jZXNzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg5NDAKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI5NDY4OTk5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYkxvYWRlclN0 cmF0ZWd5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViTG9hZGVyU3RyYXRlZ3k6OnNjaGVkdWxl TG9hZCk6CisgICAgICAgIE1ha2UgdXNlIG9mIGlzUXVpY2tMb29rUHJldmlld1VSTC4KKwogMjAx Ny0wMi0yMCAgUnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4KIAogICAgICAgICBV bnJldmlld2VkLCByb2xsaW5nIG91dCByMjEyNjMyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1 bWVudExvYWRlci5jcHAKaW5kZXggOTZmMjVkZTlmYWFiNzQyN2IyMDI5ZGQ5MGY4OTRhMDkyODU5 NjA3NC4uNjgzMTQyYmIxZjQyODg3ZWIzMGZlMDI0ZmQ2Njc5YjM1MjZmZDQxYyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCkBAIC03MzAsNyArNzMwLDcgQEAgc3Rh dGljIGJvb2wgaXNSZW1vdGVXZWJBcmNoaXZlKGNvbnN0IERvY3VtZW50TG9hZGVyJiBkb2N1bWVu dExvYWRlcikKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAjaWYgVVNFKFFVSUNLX0xPT0spCi0g ICAgaWYgKHJlc3BvbnNlLnVybCgpLnByb3RvY29sSXMoUUxQcmV2aWV3UHJvdG9jb2woKSkpCisg ICAgaWYgKGlzUXVpY2tMb29rUHJldmlld1VSTChyZXNwb25zZS51cmwoKSkpCiAgICAgICAgIHJl dHVybiBmYWxzZTsKICNlbmRpZgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIv UG9saWN5Q2hlY2tlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvUG9saWN5Q2hlY2tlci5j cHAKaW5kZXggYTAxY2UyOTI5YTEwMTA2MDA0YTI0ZTc0YTYwOGI4Y2Q3Njc2MWE2Ny4uYzU3MDQy YTJiMWYwNDhkNzYzNmIwNjE5NWRmOTg1OGMyZGRlNDk4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvbG9hZGVyL1BvbGljeUNoZWNrZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9Qb2xpY3lDaGVja2VyLmNwcApAQCAtMTI1LDcgKzEyNSw3IEBAIHZvaWQgUG9saWN5Q2hlY2tl cjo6Y2hlY2tOYXZpZ2F0aW9uUG9saWN5KGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCwg Ym9vbCBkCiAKICNpZiBVU0UoUVVJQ0tfTE9PSykKICAgICAvLyBBbHdheXMgYWxsb3cgUXVpY2tM b29rLWdlbmVyYXRlZCBVUkxzIGJhc2VkIG9uIHRoZSBwcm90b2NvbCBzY2hlbWUuCi0gICAgaWYg KCFyZXF1ZXN0LmlzTnVsbCgpICYmIHJlcXVlc3QudXJsKCkucHJvdG9jb2xJcyhRTFByZXZpZXdQ cm90b2NvbCgpKSkgeworICAgIGlmICghcmVxdWVzdC5pc051bGwoKSAmJiBpc1F1aWNrTG9va1By ZXZpZXdVUkwocmVxdWVzdC51cmwoKSkpIHsKICAgICAgICAgY29udGludWVBZnRlck5hdmlnYXRp b25Qb2xpY3koUG9saWN5VXNlKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWROb3RpZmllci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkTm90aWZpZXIuY3BwCmluZGV4IDYzNDQzZDM2ZTFi ZjdlYWUxNTk1OWJjNGE2ODFhZTIwYTZiNmM2NWQuLjdlNTkwYjE0MWQzYTk0YTUzNTk3NGE4Yjc1 NjQyNTNhY2JlNzllNGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJj ZUxvYWROb3RpZmllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9h ZE5vdGlmaWVyLmNwcApAQCAtMTE2LDcgKzExNiw3IEBAIHZvaWQgUmVzb3VyY2VMb2FkTm90aWZp ZXI6OmRpc3BhdGNoV2lsbFNlbmRSZXF1ZXN0KERvY3VtZW50TG9hZGVyKiBsb2FkZXIsIHVuc2ln CiB7CiAjaWYgVVNFKFFVSUNLX0xPT0spCiAgICAgLy8gQWx3YXlzIGFsbG93IFF1aWNrTG9vay1n ZW5lcmF0ZWQgVVJMcyBiYXNlZCBvbiB0aGUgcHJvdG9jb2wgc2NoZW1lLgotICAgIGlmICghcmVx dWVzdC5pc051bGwoKSAmJiByZXF1ZXN0LnVybCgpLnByb3RvY29sSXMoUUxQcmV2aWV3UHJvdG9j b2woKSkpCisgICAgaWYgKCFyZXF1ZXN0LmlzTnVsbCgpICYmIGlzUXVpY2tMb29rUHJldmlld1VS TChyZXF1ZXN0LnVybCgpKSkKICAgICAgICAgcmV0dXJuOwogI2VuZGlmCiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2xvYWRlci9pb3MvUXVpY2tMb29rLmggYi9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvaW9zL1F1aWNrTG9vay5oCmluZGV4IDgxMzU5MWZhYzBlNTlhNmFhODIyNjBmNGI0MWFm MTM1MmM4ZGI3OWQuLjdkNTkzYzExN2NjZWVhMDJhNGZhNDQ2YzNiMjEwZDdkMjIxNWMzNjEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9pb3MvUXVpY2tMb29rLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvbG9hZGVyL2lvcy9RdWlja0xvb2suaApAQCAtNDQsMTEgKzQ0LDEzIEBAIGNs YXNzIFJlc291cmNlTG9hZGVyOwogY2xhc3MgUmVzb3VyY2VSZXF1ZXN0OwogY2xhc3MgUmVzb3Vy Y2VSZXNwb25zZTsKIGNsYXNzIFNoYXJlZEJ1ZmZlcjsKK2NsYXNzIFVSTDsKIAogV0VCQ09SRV9F WFBPUlQgTlNTZXQgKlFMUHJldmlld0dldFN1cHBvcnRlZE1JTUVUeXBlc1NldCgpOwogV0VCQ09S RV9FWFBPUlQgdm9pZCByZW1vdmVRTFByZXZpZXdDb252ZXJ0ZXJGb3JVUkwoTlNVUkwgKik7CiBX RUJDT1JFX0VYUE9SVCBSZXRhaW5QdHI8TlNVUkxSZXF1ZXN0PiByZWdpc3RlclFMUHJldmlld0Nv bnZlcnRlcklmTmVlZGVkKE5TVVJMICosIE5TU3RyaW5nICptaW1lVHlwZSwgTlNEYXRhICopOwog V0VCQ09SRV9FWFBPUlQgY29uc3QgY2hhciogUUxQcmV2aWV3UHJvdG9jb2woKTsKK1dFQkNPUkVf RVhQT1JUIGJvb2wgaXNRdWlja0xvb2tQcmV2aWV3VVJMKGNvbnN0IFVSTCYpOwogV0VCQ09SRV9F WFBPUlQgTlNTdHJpbmcgKmNyZWF0ZVRlbXBvcmFyeUZpbGVGb3JRdWlja0xvb2soTlNTdHJpbmcg KmZpbGVOYW1lKTsKIAogY2xhc3MgUXVpY2tMb29rSGFuZGxlIHsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2xvYWRlci9pb3MvUXVpY2tMb29rLm1tIGIvU291cmNlL1dlYkNvcmUvbG9hZGVy L2lvcy9RdWlja0xvb2subW0KaW5kZXggMzk2YjgzNTEwNDRkZmRiNDlhM2MyMWI3MDYxYTFjYWQw Y2UwZTM0YS4uMGQzYjVhODUxMGU1Zjk4NTVhMzlmNjM0ODM3NGM4NjFhM2RhZmI1NCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2lvcy9RdWlja0xvb2subW0KKysrIGIvU291cmNl L1dlYkNvcmUvbG9hZGVyL2lvcy9RdWlja0xvb2subW0KQEAgLTM5LDYgKzM5LDcgQEAKICNpbXBv cnQgIlJlc291cmNlRXJyb3IuaCIKICNpbXBvcnQgIlJlc291cmNlTG9hZGVyLmgiCiAjaW1wb3J0 ICJSZXNvdXJjZVJlcXVlc3QuaCIKKyNpbXBvcnQgIlNjaGVtZVJlZ2lzdHJ5LmgiCiAjaW1wb3J0 ICJTaGFyZWRCdWZmZXIuaCIKICNpbXBvcnQgPHd0Zi9OZXZlckRlc3Ryb3llZC5oPgogI2ltcG9y dCA8d3RmL1ZlY3Rvci5oPgpAQCAtMTIyLDYgKzEyMywxNCBAQCBjb25zdCBjaGFyKiBXZWJDb3Jl OjpRTFByZXZpZXdQcm90b2NvbCgpCiAgICAgcmV0dXJuIHByZXZpZXdQcm90b2NvbC5nZXQoKS5k YXRhKCk7CiB9CiAKK2Jvb2wgV2ViQ29yZTo6aXNRdWlja0xvb2tQcmV2aWV3VVJMKGNvbnN0IFVS TCYgdXJsKQoreworICAgIC8vIFVzZSBzb21lIGtub3duIHByb3RvY29scyBhcyBhIHNob3J0LWN1 dCB0byBhdm9pZCBsb2FkaW5nIHRoZSBRdWlja0xvb2sgZnJhbWV3b3JrLgorICAgIGlmICh1cmwu cHJvdG9jb2xJc0luSFRUUEZhbWlseSgpIHx8IHVybC5pc0JsYW5rVVJMKCkgfHwgdXJsLnByb3Rv Y29sSXNCbG9iKCkgfHwgdXJsLnByb3RvY29sSXNEYXRhKCkgfHwgU2NoZW1lUmVnaXN0cnk6OnNo b3VsZFRyZWF0VVJMU2NoZW1lQXNMb2NhbCh1cmwucHJvdG9jb2woKS50b1N0cmluZygpKSkKKyAg ICAgICAgcmV0dXJuIE5POworICAgIHJldHVybiB1cmwucHJvdG9jb2xJcyhRTFByZXZpZXdQcm90 b2NvbCgpKTsKK30KKwogc3RhdGljIFJlZlB0cjxRdWlja0xvb2tIYW5kbGVDbGllbnQ+JiB0ZXN0 aW5nQ2xpZW50KCkKIHsKICAgICBzdGF0aWMgTmV2ZXJEZXN0cm95ZWQ8UmVmUHRyPFF1aWNrTG9v a0hhbmRsZUNsaWVudD4+IHRlc3RpbmdDbGllbnQ7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL05ldHdvcmsvV2ViTG9hZGVyU3RyYXRlZ3kuY3BwIGIvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYkxvYWRlclN0cmF0ZWd5LmNwcAppbmRleCA0YmRkYTJl MmRmYTAzYjJhYTc0OTgxZDgyYjNhMmNkYmUxYjBhNDRiLi40NzZhMmY4ZjFjNzYwZTc1MWM4MzM4 NWQ2YTkzZjRiYzQyM2YyNWM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L05ldHdvcmsvV2ViTG9hZGVyU3RyYXRlZ3kuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvTmV0d29yay9XZWJMb2FkZXJTdHJhdGVneS5jcHAKQEAgLTE3OSw3ICsxNzksNyBAQCB2 b2lkIFdlYkxvYWRlclN0cmF0ZWd5OjpzY2hlZHVsZUxvYWQoUmVzb3VyY2VMb2FkZXImIHJlc291 cmNlTG9hZGVyLCBDYWNoZWRSZXNvdQogICAgIH0KIAogI2lmIFVTRShRVUlDS19MT09LKQotICAg IGlmIChyZXNvdXJjZUxvYWRlci5yZXF1ZXN0KCkudXJsKCkucHJvdG9jb2xJcyhRTFByZXZpZXdQ cm90b2NvbCgpKSkgeworICAgIGlmIChpc1F1aWNrTG9va1ByZXZpZXdVUkwocmVzb3VyY2VMb2Fk ZXIucmVxdWVzdCgpLnVybCgpKSkgewogICAgICAgICBMT0coTmV0d29ya1NjaGVkdWxpbmcsICIo V2ViUHJvY2VzcykgV2ViTG9hZGVyU3RyYXRlZ3k6OnNjaGVkdWxlTG9hZCwgdXJsICclcycgd2ls bCBiZSBoYW5kbGVkIGFzIGEgUXVpY2tMb29rIHJlc291cmNlLiIsIHJlc291cmNlTG9hZGVyLnVy bCgpLnN0cmluZygpLnV0ZjgoKS5kYXRhKCkpOwogICAgICAgICBSRUxFQVNFX0xPR19JRl9BTExP V0VEKHJlc291cmNlTG9hZGVyLCAic2NoZWR1bGVMb2FkOiBVUkwgd2lsbCBiZSBoYW5kbGVkIGFz IGEgUXVpY2tMb29rIHJlc291cmNlIChmcmFtZSA9ICVwLCByZXNvdXJjZUlEID0gJSIgUFJJdTY0 ICIpIiwgcmVzb3VyY2VMb2FkZXIuZnJhbWUoKSwgaWRlbnRpZmllcik7CiAgICAgICAgIHN0YXJ0 TG9jYWxMb2FkKHJlc291cmNlTG9hZGVyKTsK