168935 2017-02-27 14:29:38 -0800 LayoutTest media/modern-media-controls/volume-down-support/volume-down-support.html is flaky 2017-03-01 19:45:02 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad graouts ap commit-queue graouts webkit-bug-importer oldest_to_newest 1281529 0 ryanhaddad 2017-02-27 14:29:38 -0800 LayoutTest media/modern-media-controls/volume-down-support/volume-down-support.html is flaky https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r213089%20(4021)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fvolume-down-support%2Fvolume-down-support.html It looks like this test is frequently timing out or failing on macOS. Here is the diff from the most recent failure: --- /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/media/modern-media-controls/volume-down-support/volume-down-support-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/media/modern-media-controls/volume-down-support/volume-down-support-actual.txt @@ -6,7 +6,7 @@ PASS media.volume is 1 Pressing on the volume down button -PASS media.volume is 0 +FAIL media.volume should be 0. Was 0.009. PASS successfullyParsed is true 1281531 1 ryanhaddad 2017-02-27 14:31:33 -0800 This one seems to be affecting EWS results. 1282551 2 webkit-bug-importer 2017-03-01 17:39:27 -0800 <rdar://problem/30796699> 1282557 3 303153 graouts 2017-03-01 18:06:42 -0800 Created attachment 303153 Patch 1282580 4 303153 dino 2017-03-01 19:17:40 -0800 Comment on attachment 303153 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303153&action=review > LayoutTests/ChangeLog:11 > + Use asynchronous assertions to guarantee we've entered fullscreen and the volume down button > + is present and leave a little room for error when checking the volume since we would sometime > + see a value of 0.009 rather than 0. This is a long sentence. Why do we see this value? > LayoutTests/media/modern-media-controls/volume-down-support/volume-down-support.html:25 > + shouldBeCloseTo("media.volume", 0, 0.1); Maybe add a comment explaining why the fudge factor. 1282583 5 303153 commit-queue 2017-03-01 19:44:57 -0800 Comment on attachment 303153 Patch Clearing flags on attachment: 303153 Committed r213258: <http://trac.webkit.org/changeset/213258> 1282584 6 commit-queue 2017-03-01 19:45:02 -0800 All reviewed patches have been landed. Closing bug. 303153 2017-03-01 18:06:42 -0800 2017-03-01 19:44:57 -0800 Patch bug-168935-20170301180641.patch text/plain 4926 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzMjA1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTE2ZTBjYTU4ZWE5YmM5NDkwYTY1 MzA1ZjFhYzcwY2YxNzA4MDMyZC4uODY3ZTRmMzgwYzY5YTY5OWZlZDIyMWNmNGQ4NWM1ZDRmNDk4 Zjk5MiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTAzLTAxICBBbnRvaW5lIFF1aW50ICA8 Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0VGVzdCBtZWRpYS9tb2Rlcm4tbWVk aWEtY29udHJvbHMvdm9sdW1lLWRvd24tc3VwcG9ydC92b2x1bWUtZG93bi1zdXBwb3J0Lmh0bWwg aXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE2ODkzNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzA3OTY2OTk+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIGFzeW5jaHJvbm91cyBhc3Nl cnRpb25zIHRvIGd1YXJhbnRlZSB3ZSd2ZSBlbnRlcmVkIGZ1bGxzY3JlZW4gYW5kIHRoZSB2b2x1 bWUgZG93biBidXR0b24KKyAgICAgICAgaXMgcHJlc2VudCBhbmQgbGVhdmUgYSBsaXR0bGUgcm9v bSBmb3IgZXJyb3Igd2hlbiBjaGVja2luZyB0aGUgdm9sdW1lIHNpbmNlIHdlIHdvdWxkIHNvbWV0 aW1lCisgICAgICAgIHNlZSBhIHZhbHVlIG9mIDAuMDA5IHJhdGhlciB0aGFuIDAuCisKKyAgICAg ICAgKiBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvdm9sdW1lLWRvd24tc3VwcG9ydC92b2x1 bWUtZG93bi1zdXBwb3J0LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBtZWRpYS9tb2Rlcm4tbWVk aWEtY29udHJvbHMvdm9sdW1lLWRvd24tc3VwcG9ydC92b2x1bWUtZG93bi1zdXBwb3J0Lmh0bWw6 CisKIDIwMTctMDItMjggIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KIAogICAg ICAgICBbbWFjLXdrMV0gTGF5b3V0VGVzdCBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvbWFj b3MtZnVsbHNjcmVlbi1tZWRpYS1jb250cm9scy9tYWNvcy1mdWxsc2NyZWVuLW1lZGlhLWNvbnRy b2xzLWJ1dHRvbnMtY29udGFpbmVycy1zdHlsZXMuaHRtbCBpcyBhIGZsYWt5IHRpbWVvdXQKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy92b2x1bWUt ZG93bi1zdXBwb3J0L3ZvbHVtZS1kb3duLXN1cHBvcnQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL3ZvbHVtZS1kb3duLXN1cHBvcnQvdm9sdW1l LWRvd24tc3VwcG9ydC1leHBlY3RlZC50eHQKaW5kZXggYWYwN2EzZDhkZDZjZmVlMTRhZDM0MDZl ZGI1Nzc5MzVjYTE1ZjJjOS4uNGM0N2IyNWEzOTQyNWM4N2YyZmU5YjhjMzI1YmRhMGQ0ZjQ0YmMw OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL3Zv bHVtZS1kb3duLXN1cHBvcnQvdm9sdW1lLWRvd24tc3VwcG9ydC1leHBlY3RlZC50eHQKKysrIGIv TGF5b3V0VGVzdHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL3ZvbHVtZS1kb3duLXN1cHBv cnQvdm9sdW1lLWRvd24tc3VwcG9ydC1leHBlY3RlZC50eHQKQEAgLTMsMTAgKzMsMTIgQEAgVGVz dGluZyBjbGlja2luZyBvbiB0aGUgdm9sdW1lIGRvd24gYnV0dG9uIGNvcnJlY3RseSBzZXRzIHRo ZSB2b2x1bWUgdG8gMC4KIE9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFT UyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KIAogCitQQVNTICEhd2lu ZG93LmludGVybmFscy5zaGFkb3dSb290KG1lZGlhKS5sYXN0Q2hpbGQucXVlcnlTZWxlY3Rvcigi YnV0dG9uLnZvbHVtZS1kb3duIikgYmVjYW1lIHRydWUKK1BBU1MgbWVkaWEud2Via2l0RGlzcGxh eWluZ0Z1bGxzY3JlZW4gaXMgdHJ1ZQogUEFTUyBtZWRpYS52b2x1bWUgaXMgMQogCiBQcmVzc2lu ZyBvbiB0aGUgdm9sdW1lIGRvd24gYnV0dG9uCi1QQVNTIG1lZGlhLnZvbHVtZSBpcyAwCitQQVNT IG1lZGlhLnZvbHVtZSBpcyB3aXRoaW4gMC4xIG9mIDAKIAogUEFTUyBzdWNjZXNzZnVsbHlQYXJz ZWQgaXMgdHJ1ZQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEt Y29udHJvbHMvdm9sdW1lLWRvd24tc3VwcG9ydC92b2x1bWUtZG93bi1zdXBwb3J0Lmh0bWwgYi9M YXlvdXRUZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvdm9sdW1lLWRvd24tc3VwcG9y dC92b2x1bWUtZG93bi1zdXBwb3J0Lmh0bWwKaW5kZXggMjIyMDk2OWNiNjMxMTU1NTY0ZGNiY2Y3 N2Y1ZmRiMDY4NjJlOGVjMS4uN2Q0MTA3YzkxYWQ5ZGRlNWUyZTRhN2Y4ZTU0NmY1MDg0ZmFlOWZk NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL3Zv bHVtZS1kb3duLXN1cHBvcnQvdm9sdW1lLWRvd24tc3VwcG9ydC5odG1sCisrKyBiL0xheW91dFRl c3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy92b2x1bWUtZG93bi1zdXBwb3J0L3ZvbHVt ZS1kb3duLXN1cHBvcnQuaHRtbApAQCAtMTMsNDUgKzEzLDI2IEBAIGRlc2NyaXB0aW9uKCJUZXN0 aW5nIGNsaWNraW5nIG9uIHRoZSB2b2x1bWUgZG93biBidXR0b24gY29ycmVjdGx5IHNldHMgdGhl IHZvbHVtCiBjb25zdCBtZWRpYSA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoInZpZGVvIik7CiBj b25zdCBidXR0b24gPSBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVs ZW1lbnQoImJ1dHRvbiIpKTsKIAotbWVkaWEuYWRkRXZlbnRMaXN0ZW5lcigid2Via2l0ZnVsbHNj cmVlbmNoYW5nZSIsIGZ1bmN0aW9uKCkgewotICAgIGlmIChtZWRpYS53ZWJraXREaXNwbGF5aW5n RnVsbHNjcmVlbikgewotICAgICAgICB3aW5kb3cucmVxdWVzdEFuaW1hdGlvbkZyYW1lKCgpID0+ IHsKLSAgICAgICAgICAgIHdpbmRvdy5yZXF1ZXN0QW5pbWF0aW9uRnJhbWUoKCkgPT4gewotICAg ICAgICAgICAgICAgIHNob3VsZEJlKCJtZWRpYS52b2x1bWUiLCAiMSIpOwotCi0gICAgICAgICAg ICAgICAgbWVkaWEuYWRkRXZlbnRMaXN0ZW5lcigidm9sdW1lY2hhbmdlIiwgKCkgPT4gewotICAg ICAgICAgICAgICAgICAgICBzaG91bGRCZSgibWVkaWEudm9sdW1lIiwgIjAiKTsKLSAgICAgICAg ICAgICAgICAgICAgZGVidWcoIiIpOwotICAgICAgICAgICAgICAgICAgICBtZWRpYS5yZW1vdmUo KTsKLSAgICAgICAgICAgICAgICAgICAgYnV0dG9uLnJlbW92ZSgpOwotICAgICAgICAgICAgICAg ICAgICBmaW5pc2hKU1Rlc3QoKTsKLSAgICAgICAgICAgICAgICB9KTsKLQotICAgICAgICAgICAg ICAgIGRlYnVnKCIiKTsKLSAgICAgICAgICAgICAgICBkZWJ1ZygiUHJlc3Npbmcgb24gdGhlIHZv bHVtZSBkb3duIGJ1dHRvbiIpOwotICAgICAgICAgICAgICAgIHByZXNzT25FbGVtZW50KHdpbmRv dy5pbnRlcm5hbHMuc2hhZG93Um9vdChtZWRpYSkubGFzdEVsZW1lbnRDaGlsZC5sYXN0RWxlbWVu dENoaWxkLnF1ZXJ5U2VsZWN0b3IoImJ1dHRvbi52b2x1bWUtZG93biIpKTsKLSAgICAgICAgICAg IH0pOwotICAgICAgICB9KTsKLSAgICB9Ci19KTsKK2J1dHRvbi5hZGRFdmVudExpc3RlbmVyKCJj bGljayIsICgpID0+IG1lZGlhLndlYmtpdEVudGVyRnVsbHNjcmVlbigpKTsKIAogbWVkaWEuYWRk RXZlbnRMaXN0ZW5lcigibG9hZGVkbWV0YWRhdGEiLCAoKSA9PiB7Ci0gICAgaWYgKCEoImV2ZW50 U2VuZGVyIiBpbiB3aW5kb3cpKSB7Ci0gICAgICAgIGRlYnVnKCJUaGlzIHRlc3QgaXMgZGVzaWdu ZWQgdG8gcnVuIGluIERSVCIpOwotICAgICAgICByZXR1cm47Ci0gICAgfQotCi0gICAgLy8gQ2xp Y2sgYSBidXR0b24gc28gd2UgbWF5IGVudGVyIGZ1bGxzY3JlZW4uCi0gICAgYnV0dG9uLmFkZEV2 ZW50TGlzdGVuZXIoImNsaWNrIiwgZXZlbnQgPT4gewotICAgICAgICB0cnkgewotICAgICAgICAg ICAgbWVkaWEud2Via2l0RW50ZXJGdWxsc2NyZWVuKCk7Ci0gICAgICAgIH0gY2F0Y2goZSkgewot ICAgICAgICAgICAgZGVidWcoIlRvZ2dsaW5nIGZ1bGxzY3JlZW4gZmFpbGVkIik7CisgICAgcHJl c3NPbkVsZW1lbnQoYnV0dG9uKTsKKyAgICBzaG91bGRCZWNvbWVFcXVhbCgnISF3aW5kb3cuaW50 ZXJuYWxzLnNoYWRvd1Jvb3QobWVkaWEpLmxhc3RDaGlsZC5xdWVyeVNlbGVjdG9yKCJidXR0b24u dm9sdW1lLWRvd24iKScsICJ0cnVlIiwgKCkgPT4geworICAgICAgICBzaG91bGRCZVRydWUoIm1l ZGlhLndlYmtpdERpc3BsYXlpbmdGdWxsc2NyZWVuIik7CisgICAgICAgIHNob3VsZEJlKCJtZWRp YS52b2x1bWUiLCAiMSIpOworCisgICAgICAgIG1lZGlhLmFkZEV2ZW50TGlzdGVuZXIoInZvbHVt ZWNoYW5nZSIsICgpID0+IHsKKyAgICAgICAgICAgIHNob3VsZEJlQ2xvc2VUbygibWVkaWEudm9s dW1lIiwgMCwgMC4xKTsKKyAgICAgICAgICAgIGRlYnVnKCIiKTsKKyAgICAgICAgICAgIG1lZGlh LnJlbW92ZSgpOworICAgICAgICAgICAgYnV0dG9uLnJlbW92ZSgpOwogICAgICAgICAgICAgZmlu aXNoSlNUZXN0KCk7Ci0gICAgICAgIH0KLSAgICB9KTsKKyAgICAgICAgfSk7CiAKLSAgICBwcmVz c09uRWxlbWVudChidXR0b24pOworICAgICAgICBkZWJ1ZygiIik7CisgICAgICAgIGRlYnVnKCJQ cmVzc2luZyBvbiB0aGUgdm9sdW1lIGRvd24gYnV0dG9uIik7CisgICAgICAgIHByZXNzT25FbGVt ZW50KHdpbmRvdy5pbnRlcm5hbHMuc2hhZG93Um9vdChtZWRpYSkubGFzdEVsZW1lbnRDaGlsZC5s YXN0RWxlbWVudENoaWxkLnF1ZXJ5U2VsZWN0b3IoImJ1dHRvbi52b2x1bWUtZG93biIpKTsKKyAg ICB9KTsKIH0pOwogCiA8L3NjcmlwdD4K