168928 2017-02-27 13:44:53 -0800 [Win] REGRESSION(r211254): IWebPreferencesPrivate binary API broken 2017-03-15 09:19:43 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 167421 1 bfulgham pvollan bfulgham webkit-bug-importer oldest_to_newest 1281507 0 bfulgham 2017-02-27 13:44:53 -0800 Two new methods were injected into the existing IWebPreferencesPrivate interface, breaking binary API compatibility. We need to create a new IWebPreferencesPrivate5 interface holding these two new methods. 1281508 1 bfulgham 2017-02-27 13:45:56 -0800 <rdar://problem/30687449> 1281727 2 pvollan 2017-02-27 23:09:23 -0800 It seems these methods were removed again in <http://trac.webkit.org/changeset/212173>. 1281780 3 302940 pvollan 2017-02-28 09:23:06 -0800 Created attachment 302940 Patch 1281783 4 302942 pvollan 2017-02-28 09:41:08 -0800 Created attachment 302942 Patch 1281806 5 302942 bfulgham 2017-02-28 10:50:50 -0800 Comment on attachment 302942 Patch R=me 1281810 6 bfulgham 2017-02-28 10:52:01 -0800 I think this is only relevant to the branch where this code is still present. 1288078 7 bfulgham 2017-03-15 09:19:43 -0700 This was a branch-specific change. 302940 2017-02-28 09:23:06 -0800 2017-02-28 09:41:04 -0800 Patch bug-168928-20170228092010.patch text/plain 2944 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzE1MCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAyLTI4 ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBS RUdSRVNTSU9OKHIyMTEyNTQpOiBJV2ViUHJlZmVyZW5jZXNQcml2YXRlIGJpbmFyeSBBUEkgYnJv a2VuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg5 MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb3Zl IG5ldyBtZXRob2RzIHRvIGVuZCBvZiBsYXN0IGludGVyZmFjZS4KKworICAgICAgICAqIEludGVy ZmFjZXMvSVdlYlByZWZlcmVuY2VzUHJpdmF0ZS5pZGw6CisgICAgICAgICogV2ViUHJlZmVyZW5j ZXMuaDoKKwogMjAxNy0wMi0yMCAgTWF0dGhldyBIYW5zb24gIDxtYXR0aGV3X2hhbnNvbkBhcHBs ZS5jb20+CiAKICAgICAgICAgUm9sbG91dCByMjEyNTM4LiByZGFyOi8vcHJvYmxlbS8zMDU0MTc0 OApJbmRleDogU291cmNlL1dlYktpdC93aW4vV2ViUHJlZmVyZW5jZXMuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L3dpbi9XZWJQcmVmZXJlbmNlcy5oCShyZXZpc2lvbiAyMTMxNTApCisr KyBTb3VyY2UvV2ViS2l0L3dpbi9XZWJQcmVmZXJlbmNlcy5oCSh3b3JraW5nIGNvcHkpCkBAIC0x NTksOCArMTU5LDYgQEAgcHVibGljOgogICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxM VFlQRSBzZXRMb2NhbFN0b3JhZ2VEYXRhYmFzZVBhdGgoX0luXyBCU1RSKTsKICAgICB2aXJ0dWFs IEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgZXhwZXJpbWVudGFsTm90aWZpY2F0aW9uc0VuYWJs ZWQoX091dF8gQk9PTCopOwogICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBz ZXRFeHBlcmltZW50YWxOb3RpZmljYXRpb25zRW5hYmxlZChCT09MKTsKLSAgICB2aXJ0dWFsIEhS RVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgYWxsb3dzUGFnZUNhY2hlV2l0aFdpbmRvd09wZW5lcihf T3V0XyBCT09MKik7Ci0gICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIHNldEFs bG93c1BhZ2VDYWNoZVdpdGhXaW5kb3dPcGVuZXIoQk9PTCk7CiAKICAgICAvLyBUaGVzZSB0d28g bWV0aG9kcyBhcmUgbm8tb3BzLCBhbmQgb25seSByZXRhaW5lZCB0byBrZWVwCiAgICAgLy8gdGhl IEludGVyZmFjZSBjb25zaXN0ZW50LiBETyBOT1QgVVNFIFRIRU0uCkBAIC0yNDcsNiArMjQ1LDgg QEAgcHVibGljOgogCiAgICAgLy8gSVdlYlByZWZlcmVuY2VzUHJpdmF0ZTQKICAgICB2aXJ0dWFs IEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgc2V0QXBwbGljYXRpb25JZChCU1RSKTsKKyAgICB2 aXJ0dWFsIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgYWxsb3dzUGFnZUNhY2hlV2l0aFdpbmRv d09wZW5lcihfT3V0XyBCT09MKik7CisgICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExU WVBFIHNldEFsbG93c1BhZ2VDYWNoZVdpdGhXaW5kb3dPcGVuZXIoQk9PTCk7CiAKICAgICAvLyBX ZWJQcmVmZXJlbmNlcwogCkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9JbnRlcmZhY2VzL0lXZWJQ cmVmZXJlbmNlc1ByaXZhdGUuaWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvd2luL0lu dGVyZmFjZXMvSVdlYlByZWZlcmVuY2VzUHJpdmF0ZS5pZGwJKHJldmlzaW9uIDIxMzE1MCkKKysr IFNvdXJjZS9XZWJLaXQvd2luL0ludGVyZmFjZXMvSVdlYlByZWZlcmVuY2VzUHJpdmF0ZS5pZGwJ KHdvcmtpbmcgY29weSkKQEAgLTkxLDkgKzkxLDYgQEAgaW50ZXJmYWNlIElXZWJQcmVmZXJlbmNl c1ByaXZhdGUgOiBJVW5rbgogICAgIEhSRVNVTFQgZXhwZXJpbWVudGFsTm90aWZpY2F0aW9uc0Vu YWJsZWQoW291dCwgcmV0dmFsXSBCT09MICplbmFibGVkKTsKICAgICBIUkVTVUxUIHNldEV4cGVy aW1lbnRhbE5vdGlmaWNhdGlvbnNFbmFibGVkKFtpbl0gQk9PTCBlbmFibGVkKTsKIAotICAgIEhS RVNVTFQgYWxsb3dzUGFnZUNhY2hlV2l0aFdpbmRvd09wZW5lcihbb3V0LCByZXR2YWxdIEJPT0wq IHVzZXNQYWdlQ2FjaGUpOwotICAgIEhSRVNVTFQgc2V0QWxsb3dzUGFnZUNhY2hlV2l0aFdpbmRv d09wZW5lcihbaW5dIEJPT0wgdXNlc1BhZ2VDYWNoZSk7Ci0KICAgICBIUkVTVUxUIHNldFNob3Vs ZFVzZUhpZ2hSZXNvbHV0aW9uVGltZXJzKFtpbl0gQk9PTCB1c2VIaWdoUmVzb2x1dGlvblRpbWVy cyk7CiAgICAgSFJFU1VMVCBzaG91bGRVc2VIaWdoUmVzb2x1dGlvblRpbWVycyhbb3V0LCByZXR2 YWxdIEJPT0wqIHVzZUhpZ2hSZXNvbHV0aW9uVGltZXJzKTsKIApAQCAtMTk0LDQgKzE5MSw3IEBA IGludGVyZmFjZSBJV2ViUHJlZmVyZW5jZXNQcml2YXRlMyA6IElXZWIKIGludGVyZmFjZSBJV2Vi UHJlZmVyZW5jZXNQcml2YXRlNCA6IElXZWJQcmVmZXJlbmNlc1ByaXZhdGUzCiB7CiAgICAgSFJF U1VMVCBzZXRBcHBsaWNhdGlvbklkKFtpbl0gQlNUUiBhcHBsaWNhdGlvbklkKTsKKworICAgIEhS RVNVTFQgYWxsb3dzUGFnZUNhY2hlV2l0aFdpbmRvd09wZW5lcihbb3V0LCByZXR2YWxdIEJPT0wq IHVzZXNQYWdlQ2FjaGUpOworICAgIEhSRVNVTFQgc2V0QWxsb3dzUGFnZUNhY2hlV2l0aFdpbmRv d09wZW5lcihbaW5dIEJPT0wgdXNlc1BhZ2VDYWNoZSk7CiB9Cg== 302942 2017-02-28 09:41:08 -0800 2017-02-28 10:50:50 -0800 Patch bug-168928-20170228093811.patch text/plain 3603 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzE1MCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE3LTAyLTI4 ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBS RUdSRVNTSU9OKHIyMTEyNTQpOiBJV2ViUHJlZmVyZW5jZXNQcml2YXRlIGJpbmFyeSBBUEkgYnJv a2VuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg5 MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb3Zl IG5ldyBtZXRob2RzIHRvIGVuZCBvZiBsYXN0IGludGVyZmFjZS4KKyAKKyAgICAgICAgKiBJbnRl cmZhY2VzL0lXZWJQcmVmZXJlbmNlc1ByaXZhdGUuaWRsOgorICAgICAgICAqIFdlYlByZWZlcmVu Y2VzLmg6CisgICAgICAgICogV2ViVmlldy5jcHA6CisgICAgICAgIChXZWJWaWV3Ojpub3RpZnlQ cmVmZXJlbmNlc0NoYW5nZWQpOgorCiAyMDE3LTAyLTIwICBNYXR0aGV3IEhhbnNvbiAgPG1hdHRo ZXdfaGFuc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSb2xsb3V0IHIyMTI1MzguIHJkYXI6Ly9w cm9ibGVtLzMwNTQxNzQ4CkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9XZWJQcmVmZXJlbmNlcy5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvd2luL1dlYlByZWZlcmVuY2VzLmgJKHJldmlz aW9uIDIxMzE1MCkKKysrIFNvdXJjZS9XZWJLaXQvd2luL1dlYlByZWZlcmVuY2VzLmgJKHdvcmtp bmcgY29weSkKQEAgLTE1OSw4ICsxNTksNiBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBIUkVTVUxU IFNURE1FVEhPRENBTExUWVBFIHNldExvY2FsU3RvcmFnZURhdGFiYXNlUGF0aChfSW5fIEJTVFIp OwogICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBleHBlcmltZW50YWxOb3Rp ZmljYXRpb25zRW5hYmxlZChfT3V0XyBCT09MKik7CiAgICAgdmlydHVhbCBIUkVTVUxUIFNURE1F VEhPRENBTExUWVBFIHNldEV4cGVyaW1lbnRhbE5vdGlmaWNhdGlvbnNFbmFibGVkKEJPT0wpOwot ICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBhbGxvd3NQYWdlQ2FjaGVXaXRo V2luZG93T3BlbmVyKF9PdXRfIEJPT0wqKTsKLSAgICB2aXJ0dWFsIEhSRVNVTFQgU1RETUVUSE9E Q0FMTFRZUEUgc2V0QWxsb3dzUGFnZUNhY2hlV2l0aFdpbmRvd09wZW5lcihCT09MKTsKIAogICAg IC8vIFRoZXNlIHR3byBtZXRob2RzIGFyZSBuby1vcHMsIGFuZCBvbmx5IHJldGFpbmVkIHRvIGtl ZXAKICAgICAvLyB0aGUgSW50ZXJmYWNlIGNvbnNpc3RlbnQuIERPIE5PVCBVU0UgVEhFTS4KQEAg LTI0Nyw2ICsyNDUsOCBAQCBwdWJsaWM6CiAKICAgICAvLyBJV2ViUHJlZmVyZW5jZXNQcml2YXRl NAogICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBzZXRBcHBsaWNhdGlvbklk KEJTVFIpOworICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBhbGxvd3NQYWdl Q2FjaGVXaXRoV2luZG93T3BlbmVyKF9PdXRfIEJPT0wqKTsKKyAgICB2aXJ0dWFsIEhSRVNVTFQg U1RETUVUSE9EQ0FMTFRZUEUgc2V0QWxsb3dzUGFnZUNhY2hlV2l0aFdpbmRvd09wZW5lcihCT09M KTsKIAogICAgIC8vIFdlYlByZWZlcmVuY2VzCiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL1dl YlZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCShy ZXZpc2lvbiAyMTMxNTApCisrKyBTb3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNTE4MSw3ICs1MTgxLDcgQEAgSFJFU1VMVCBXZWJWaWV3Ojpub3RpZnlQcmVm ZXJlbmNlc0NoYW5nZQogICAgIHNldHRpbmdzLnNldFNob3VsZERpc3BsYXlUZXh0RGVzY3JpcHRp b25zKGVuYWJsZWQpOwogI2VuZGlmCiAKLSAgICBDT01QdHI8SVdlYlByZWZlcmVuY2VzUHJpdmF0 ZTM+IHByZWZzUHJpdmF0ZShRdWVyeSwgcHJlZmVyZW5jZXMpOworICAgIENPTVB0cjxJV2ViUHJl ZmVyZW5jZXNQcml2YXRlND4gcHJlZnNQcml2YXRlKFF1ZXJ5LCBwcmVmZXJlbmNlcyk7CiAgICAg aWYgKHByZWZzUHJpdmF0ZSkgewogICAgICAgICBociA9IHByZWZzUHJpdmF0ZS0+bG9jYWxTdG9y YWdlRGF0YWJhc2VQYXRoKCZzdHIpOwogICAgICAgICBpZiAoRkFJTEVEKGhyKSkKSW5kZXg6IFNv dXJjZS9XZWJLaXQvd2luL0ludGVyZmFjZXMvSVdlYlByZWZlcmVuY2VzUHJpdmF0ZS5pZGwKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdC93aW4vSW50ZXJmYWNlcy9JV2ViUHJlZmVyZW5jZXNQ cml2YXRlLmlkbAkocmV2aXNpb24gMjEzMTUwKQorKysgU291cmNlL1dlYktpdC93aW4vSW50ZXJm YWNlcy9JV2ViUHJlZmVyZW5jZXNQcml2YXRlLmlkbAkod29ya2luZyBjb3B5KQpAQCAtOTEsOSAr OTEsNiBAQCBpbnRlcmZhY2UgSVdlYlByZWZlcmVuY2VzUHJpdmF0ZSA6IElVbmtuCiAgICAgSFJF U1VMVCBleHBlcmltZW50YWxOb3RpZmljYXRpb25zRW5hYmxlZChbb3V0LCByZXR2YWxdIEJPT0wg KmVuYWJsZWQpOwogICAgIEhSRVNVTFQgc2V0RXhwZXJpbWVudGFsTm90aWZpY2F0aW9uc0VuYWJs ZWQoW2luXSBCT09MIGVuYWJsZWQpOwogCi0gICAgSFJFU1VMVCBhbGxvd3NQYWdlQ2FjaGVXaXRo V2luZG93T3BlbmVyKFtvdXQsIHJldHZhbF0gQk9PTCogdXNlc1BhZ2VDYWNoZSk7Ci0gICAgSFJF U1VMVCBzZXRBbGxvd3NQYWdlQ2FjaGVXaXRoV2luZG93T3BlbmVyKFtpbl0gQk9PTCB1c2VzUGFn ZUNhY2hlKTsKLQogICAgIEhSRVNVTFQgc2V0U2hvdWxkVXNlSGlnaFJlc29sdXRpb25UaW1lcnMo W2luXSBCT09MIHVzZUhpZ2hSZXNvbHV0aW9uVGltZXJzKTsKICAgICBIUkVTVUxUIHNob3VsZFVz ZUhpZ2hSZXNvbHV0aW9uVGltZXJzKFtvdXQsIHJldHZhbF0gQk9PTCogdXNlSGlnaFJlc29sdXRp b25UaW1lcnMpOwogCkBAIC0xOTQsNCArMTkxLDcgQEAgaW50ZXJmYWNlIElXZWJQcmVmZXJlbmNl c1ByaXZhdGUzIDogSVdlYgogaW50ZXJmYWNlIElXZWJQcmVmZXJlbmNlc1ByaXZhdGU0IDogSVdl YlByZWZlcmVuY2VzUHJpdmF0ZTMKIHsKICAgICBIUkVTVUxUIHNldEFwcGxpY2F0aW9uSWQoW2lu XSBCU1RSIGFwcGxpY2F0aW9uSWQpOworCisgICAgSFJFU1VMVCBhbGxvd3NQYWdlQ2FjaGVXaXRo V2luZG93T3BlbmVyKFtvdXQsIHJldHZhbF0gQk9PTCogdXNlc1BhZ2VDYWNoZSk7CisgICAgSFJF U1VMVCBzZXRBbGxvd3NQYWdlQ2FjaGVXaXRoV2luZG93T3BlbmVyKFtpbl0gQk9PTCB1c2VzUGFn ZUNhY2hlKTsKIH0K