<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>168912</bug_id>
          
          <creation_ts>2017-02-27 07:12:13 -0800</creation_ts>
          <short_desc>[Soup] &quot;Only from websites I visit&quot; cookie policy is broken</short_desc>
          <delta_ts>2017-03-22 03:09:33 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Hussam Al-Tayeb">ht990332</reporter>
          <assigned_to name="Sergio Villar Senin">svillar</assigned_to>
          <cc>achristensen</cc>
    
    <cc>berto</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>cdumez</cc>
    
    <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>danw</cc>
    
    <cc>gustavo</cc>
    
    <cc>joepeck</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>mrobinson</cc>
    
    <cc>svillar</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1281372</commentid>
    <comment_count>0</comment_count>
    <who name="Hussam Al-Tayeb">ht990332</who>
    <bug_when>2017-02-27 07:12:13 -0800</bug_when>
    <thetext>I noticed &quot;Only from websites I visit&quot; cookie policy is broken on WebKitGTK+ 2.15.90 and epiphany 2.23.90 (latest from git master branch). I don&apos;t have advertisements disabled and it is saving cookies from domains of hotlinked ads.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1281416</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-02-27 10:34:20 -0800</bug_when>
    <thetext>Lots of changes to this code recently. Is it a regression? Did it work properly in 2.14? Or has it always been broken like this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1282395</commentid>
    <comment_count>2</comment_count>
    <who name="Hussam Al-Tayeb">ht990332</who>
    <bug_when>2017-03-01 12:50:33 -0800</bug_when>
    <thetext>It looks like this was broken in 2.14.xx and epiphany 3.22.xx as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1289490</commentid>
    <comment_count>3</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2017-03-20 10:21:49 -0700</bug_when>
    <thetext>After some quick research it looks like we are not properly setting the first party for cookies in some cases, that&apos;s why cookies are being stored anyway. For example if I visit http://www.bmw.es I can see how some cookies are set by youtube because the first party for the requests is youtube.com.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1289518</commentid>
    <comment_count>4</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2017-03-20 11:46:00 -0700</bug_when>
    <thetext>OK so I finally found the culprit. It&apos;s in NetworkDataTaskSoup::continuteHTTPRedirection(). I am not sure what&apos;s the relationship with ResourceHandleSoup but they look pretty much the same. The problem is that we&apos;re setting the firstPartyForCookies to the URL of the redirected message meaning that any redirection will successfully bypass the &quot;no third party cookies&quot; policy.

That call is already present in ResourceHandleSoup and has been there for ages. I am almost sure that we can safely remove that call (the cocoa code does not do that BTW) as it does not correct. Setting the first party for cookies is handled by the FrameLoader and we should not overwrite that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1289620</commentid>
    <comment_count>5</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-03-20 16:29:48 -0700</bug_when>
    <thetext>Sergio, are you planning to submit a patch?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1289730</commentid>
    <comment_count>6</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2017-03-21 01:34:46 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; OK so I finally found the culprit.

\o/ Thanks for investigating this.

&gt; It&apos;s in
&gt; NetworkDataTaskSoup::continuteHTTPRedirection().

No recent regression then . . .

&gt; I am not sure what&apos;s the
&gt; relationship with ResourceHandleSoup but they look pretty much the same.

NetworkDataTask is the new ResourceHandle. The latter is only used in the web process now for the few bits that hasn&apos;t been moved to the network process yet.

&gt; The
&gt; problem is that we&apos;re setting the firstPartyForCookies to the URL of the
&gt; redirected message meaning that any redirection will successfully bypass the
&gt; &quot;no third party cookies&quot; policy.

Actually, I think the problem is that we are assuming that all redirections are main resource loads. It&apos;s amazing that this problem has always been there!

&gt; That call is already present in ResourceHandleSoup and has been there for
&gt; ages.

Exactly, this is copied from ResourceHandle.

&gt; I am almost sure that we can safely remove that call (the cocoa code
&gt; does not do that BTW) as it does not correct. Setting the first party for
&gt; cookies is handled by the FrameLoader and we should not overwrite that.

Right. In case of main resource, DocumentLoader::willSendRequest sets the first party for cookies after the redirection, and in case of subresources, the initial request first party for cookies is copied to the new one, so it&apos;s the right one too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1289744</commentid>
    <comment_count>7</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2017-03-21 03:32:16 -0700</bug_when>
    <thetext>Actually I added it https://bugs.webkit.org/show_bug.cgi?id=64575 :O</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1289776</commentid>
    <comment_count>8</comment_count>
      <attachid>305004</attachid>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2017-03-21 08:22:10 -0700</bug_when>
    <thetext>Created attachment 305004
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1289919</commentid>
    <comment_count>9</comment_count>
      <attachid>305004</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-03-21 18:03:54 -0700</bug_when>
    <thetext>Comment on attachment 305004
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305004&amp;action=review

Looks excellent, thanks for the test. I&apos;ll let Carlos give final r+.

&gt; Source/WebCore/ChangeLog:12
&gt; +        The most notable effect was that subresources loaded via redirects where effectively

were

&gt; LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-redirect-expected.txt:2
&gt; +This test PASS if you can see the text &quot;FAILED: Cookie not set&quot;.

I&apos;m not sure what you were thinking here, but this was a bad idea. :) Please change the text to &quot;PASS: Cookie not set&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1290001</commentid>
    <comment_count>10</comment_count>
      <attachid>305004</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2017-03-22 00:40:10 -0700</bug_when>
    <thetext>Comment on attachment 305004
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305004&amp;action=review

&gt;&gt; LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-redirect-expected.txt:2
&gt;&gt; +This test PASS if you can see the text &quot;FAILED: Cookie not set&quot;.
&gt; 
&gt; I&apos;m not sure what you were thinking here, but this was a bad idea. :) Please change the text to &quot;PASS: Cookie not set&quot;.

I think this is because it&apos;s reusing the cookies/resources/set-cookie-on-redirect.php that is used to test that cookies are indeed set on redirect, but here we want to test the opposite.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1290033</commentid>
    <comment_count>11</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2017-03-22 03:05:19 -0700</bug_when>
    <thetext>(In reply to Carlos Garcia Campos from comment #10)
&gt; Comment on attachment 305004 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=305004&amp;action=review
&gt; 
&gt; &gt;&gt; LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-redirect-expected.txt:2
&gt; &gt;&gt; +This test PASS if you can see the text &quot;FAILED: Cookie not set&quot;.
&gt; &gt; 
&gt; &gt; I&apos;m not sure what you were thinking here, but this was a bad idea. :) Please change the text to &quot;PASS: Cookie not set&quot;.
&gt; 
&gt; I think this is because it&apos;s reusing the
&gt; cookies/resources/set-cookie-on-redirect.php that is used to test that
&gt; cookies are indeed set on redirect, but here we want to test the opposite.

Right.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1290035</commentid>
    <comment_count>12</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2017-03-22 03:09:33 -0700</bug_when>
    <thetext>Committed r214246: &lt;http://trac.webkit.org/changeset/214246&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>305004</attachid>
            <date>2017-03-21 08:22:10 -0700</date>
            <delta_ts>2017-03-22 00:40:10 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-168912-20170321162208.patch</filename>
            <type>text/plain</type>
            <size>6576</size>
            <attacher name="Sergio Villar Senin">svillar</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0MTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjM4NDAzNzliY2FjYzM3
ZjA3ODk2NTUxODIwZmE0NjI2MzI1ZDI4MC4uYTQ3YmVhOTljMzNmYzE5NTE4NjkwOTQ3YTc4ZjIz
OGRhNDIzOTRjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTAzLTIxICBTZXJn
aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtTb3VwXSAi
T25seSBmcm9tIHdlYnNpdGVzIEkgdmlzaXQiIGNvb2tpZSBwb2xpY3kgaXMgYnJva2VuCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg5MTIKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEbyBub3QgcmVzZXQg
dGhlIGZpcnN0IHBhcnR5IGZvciBjb29raWVzIG9uIHJlZGlyZWN0cy4gVGhhdCdzIHByb3Blcmx5
IGRvbmUgZm9yIHRoZSBtYWluCisgICAgICAgIHJlc291cmNlIGluIERvY3VtZW50TG9hZGVyOjp3
aWxsU2VuZFJlcXVlc3QgYW5kLCBpbiB0aGUgY2FzZSBvZiBzdWJyZXNvdXJjZXMsIGlzIGFic29s
dXRlbHkKKyAgICAgICAgd3JvbmcgKHdoaWNoIGlzIHdoYXQgd2Ugd2VyZSBkb2luZyBzaW5jZSBy
MTQzOTMxKS4KKworICAgICAgICBUaGUgbW9zdCBub3RhYmxlIGVmZmVjdCB3YXMgdGhhdCBzdWJy
ZXNvdXJjZXMgbG9hZGVkIHZpYSByZWRpcmVjdHMgd2hlcmUgZWZmZWN0aXZlbHkKKyAgICAgICAg
YnlwYXNzaW5nIHRoZSAibm8gdGhpcmQgcGFydHkiIHBvbGljeSBmb3IgY29va2llcy4KKworICAg
ICAgICBUZXN0OiBodHRwL3Rlc3RzL3NlY3VyaXR5L2Nvb2tpZXMvdGhpcmQtcGFydHktY29va2ll
LWJsb2NraW5nLXJlZGlyZWN0Lmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291
cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6ZG9SZWRpcmVjdCk6
CisKIDIwMTctMDMtMTYgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9y
Zz4KIAogICAgICAgICBVc2UgY29tcGxldGlvbiBoYW5kbGVycyBpbnN0ZWFkIG9mIHJldHVybiB2
YWx1ZXMgZm9yIHNlbmRpbmcgd2Vic29ja2V0IGRhdGEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL
aXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA5MWU2YTI2MmIx
N2YxMjZhZTQ5ZjQxYmViZjZiMjM5NzIyMDAyZDQ5Li5jYTdjNDdlZTcyZWNjNTExNDhlYjMzYjRl
NTM2NjhjMzY1MjhlZjZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysr
IGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTctMDMtMjEg
IFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1Nv
dXBdICJPbmx5IGZyb20gd2Vic2l0ZXMgSSB2aXNpdCIgY29va2llIHBvbGljeSBpcyBicm9rZW4K
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODkxMgor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvIG5vdCBy
ZXNldCB0aGUgZmlyc3QgcGFydHkgZm9yIGNvb2tpZXMgb24gcmVkaXJlY3RzLiBUaGF0J3MgcHJv
cGVybHkgZG9uZSBmb3IgdGhlIG1haW4KKyAgICAgICAgcmVzb3VyY2UgaW4gRG9jdW1lbnRMb2Fk
ZXI6OndpbGxTZW5kUmVxdWVzdCBhbmQsIGluIHRoZSBjYXNlIG9mIHN1YnJlc291cmNlcywgaXMg
YWJzb2x1dGVseQorICAgICAgICB3cm9uZyAod2hpY2ggaXMgd2hhdCB3ZSB3ZXJlIGRvaW5nIHNp
bmNlIHIxNDM5MzEpLgorCisgICAgICAgIFRoZSBtb3N0IG5vdGFibGUgZWZmZWN0IHdhcyB0aGF0
IHN1YnJlc291cmNlcyBsb2FkZWQgdmlhIHJlZGlyZWN0cyB3aGVyZSBlZmZlY3RpdmVseQorICAg
ICAgICBieXBhc3NpbmcgdGhlICJubyB0aGlyZCBwYXJ0eSIgcG9saWN5IGZvciBjb29raWVzLgor
CisgICAgICAgICogTmV0d29ya1Byb2Nlc3Mvc291cC9OZXR3b3JrRGF0YVRhc2tTb3VwLmNwcDoK
KyAgICAgICAgKFdlYktpdDo6TmV0d29ya0RhdGFUYXNrU291cDo6Y29udGludWVIVFRQUmVkaXJl
Y3Rpb24pOgorCiAyMDE3LTAzLTE2ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl
YmtpdC5vcmc+CiAKICAgICAgICAgVXNlIGNvbXBsZXRpb24gaGFuZGxlcnMgaW5zdGVhZCBvZiBy
ZXR1cm4gdmFsdWVzIGZvciBzZW5kaW5nIHdlYnNvY2tldCBkYXRhCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcCBi
L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAu
Y3BwCmluZGV4IGU2OGU1MWMxY2I1M2MzZjRkODVmNDEyODY5NDJlNjdkNGVjZjM5MWEuLjEzOWUw
OWRiNzJlYWNiMjEzYmEzNjNjZGYzN2U4YmIyMjhkMmUzNDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X
ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCisrKyBi
L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAu
Y3BwCkBAIC0zMjIsNyArMzIyLDYgQEAgc3RhdGljIHZvaWQgZG9SZWRpcmVjdChSZXNvdXJjZUhh
bmRsZSogaGFuZGxlKQogICAgIFVSTCBuZXdVUkwgPSBVUkwoVVJMKHNvdXBfbWVzc2FnZV9nZXRf
dXJpKG1lc3NhZ2UpKSwgbG9jYXRpb24pOwogICAgIGJvb2wgY3Jvc3NPcmlnaW4gPSAhcHJvdG9j
b2xIb3N0QW5kUG9ydEFyZUVxdWFsKGhhbmRsZS0+Zmlyc3RSZXF1ZXN0KCkudXJsKCksIG5ld1VS
TCk7CiAgICAgbmV3UmVxdWVzdC5zZXRVUkwobmV3VVJMKTsKLSAgICBuZXdSZXF1ZXN0LnNldEZp
cnN0UGFydHlGb3JDb29raWVzKG5ld1VSTCk7CiAKICAgICBpZiAobmV3UmVxdWVzdC5odHRwTWV0
aG9kKCkgIT0gIkdFVCIpIHsKICAgICAgICAgLy8gQ2hhbmdlIG5ld1JlcXVlc3QgbWV0aG9kIHRv
IEdFVCBpZiBjaGFuZ2Ugd2FzIG1hZGUgZHVyaW5nIGEgcHJldmlvdXMgcmVkaXJlY3Rpb24KZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya0RhdGFU
YXNrU291cC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtE
YXRhVGFza1NvdXAuY3BwCmluZGV4IDQxZDkyNmVhOTdiZDA2YjcwMDkxNWQwNjIzMjIxMTg4Nzhl
NDc0MDkuLmE4OGU5NGFlYWFkZTkzYjc0NGJkMjAwOWZjNjExMWZlMzc4MmM2YTcgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya0RhdGFUYXNrU291
cC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3Mvc291cC9OZXR3b3JrRGF0
YVRhc2tTb3VwLmNwcApAQCAtNjM4LDcgKzYzOCw2IEBAIHZvaWQgTmV0d29ya0RhdGFUYXNrU291
cDo6Y29udGludWVIVFRQUmVkaXJlY3Rpb24oKQogCiAgICAgUmVzb3VyY2VSZXF1ZXN0IHJlcXVl
c3QgPSBtX2ZpcnN0UmVxdWVzdDsKICAgICByZXF1ZXN0LnNldFVSTChVUkwobV9yZXNwb25zZS51
cmwoKSwgbV9yZXNwb25zZS5odHRwSGVhZGVyRmllbGQoSFRUUEhlYWRlck5hbWU6OkxvY2F0aW9u
KSkpOwotICAgIHJlcXVlc3Quc2V0Rmlyc3RQYXJ0eUZvckNvb2tpZXMocmVxdWVzdC51cmwoKSk7
CiAKICAgICAvLyBTaG91bGQgbm90IHNldCBSZWZlcmVyIGFmdGVyIGEgcmVkaXJlY3QgZnJvbSBh
IHNlY3VyZSByZXNvdXJjZSB0byBub24tc2VjdXJlIG9uZS4KICAgICBpZiAobV9zaG91bGRDbGVh
clJlZmVycmVyT25IVFRQU1RvSFRUUFJlZGlyZWN0ICYmICFyZXF1ZXN0LnVybCgpLnByb3RvY29s
SXMoImh0dHBzIikgJiYgcHJvdG9jb2xJcyhyZXF1ZXN0Lmh0dHBSZWZlcnJlcigpLCAiaHR0cHMi
KSkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5n
ZUxvZwppbmRleCBiMjY0YTEyNmY0N2I0OTNiODM2M2VjMGJkMzVkZjFhMzUyMTEzY2NlLi4wOTc4
MGEyOTQyY2Q0YWIwOGJjNGM4NDExNWQ5MjFkZGZlZmFlYWJmIDEwMDY0NAotLS0gYS9MYXlvdXRU
ZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg
QEAKKzIwMTctMDMtMjEgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+
CisKKyAgICAgICAgW1NvdXBdICJPbmx5IGZyb20gd2Vic2l0ZXMgSSB2aXNpdCIgY29va2llIHBv
bGljeSBpcyBicm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTE2ODkxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgICogaHR0cC90ZXN0cy9zZWN1cml0eS9jb29raWVzL3RoaXJkLXBhcnR5LWNvb2tpZS1i
bG9ja2luZy1yZWRpcmVjdC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVz
dHMvc2VjdXJpdHkvY29va2llcy90aGlyZC1wYXJ0eS1jb29raWUtYmxvY2tpbmctcmVkaXJlY3Qu
aHRtbDogQWRkZWQuCisKIDIwMTctMDMtMTcgIE1pZ3VlbCBHb21leiAgPG1hZ29tZXpAaWdhbGlh
LmNvbT4KIAogICAgICAgICBGb2xsb3ctdXAgKHIyMTM4MzMpOiB3cml0ZSBhIGxheW91dCB0ZXN0
IGZvciAxNjkxOTkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkv
Y29va2llcy90aGlyZC1wYXJ0eS1jb29raWUtYmxvY2tpbmctcmVkaXJlY3QtZXhwZWN0ZWQudHh0
IGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9jb29raWVzL3RoaXJkLXBhcnR5LWNv
b2tpZS1ibG9ja2luZy1yZWRpcmVjdC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQK
aW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMzNlYWFhMDhm
YmZjMTQzYzA1Y2JiZDY2OWQ2NjE5YzVlMWI4NTQ2MgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91
dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvY29va2llcy90aGlyZC1wYXJ0eS1jb29raWUtYmxv
Y2tpbmctcmVkaXJlY3QtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsOSBAQAorQ2hlY2tzIHRoYXQg
c3VicmVzb3VyY2VzIHRoYXQgZ290IHJlZGlyZWN0ZWQgZG8gbm90IGNpcmN1bXZlbnQgdGhpcmQt
cGFydHkgY29va2llIHJ1bGVzLgorVGhpcyB0ZXN0IFBBU1MgaWYgeW91IGNhbiBzZWUgdGhlIHRl
eHQgIkZBSUxFRDogQ29va2llIG5vdCBzZXQiLgorCisKKworLS0tLS0tLS0KK0ZyYW1lOiAnPCEt
LWZyYW1lUGF0aCAvLzwhLS1mcmFtZTAtLT4tLT4nCistLS0tLS0tLQorRkFJTEVEOiBDb29raWUg
bm90IHNldApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9jb29r
aWVzL3RoaXJkLXBhcnR5LWNvb2tpZS1ibG9ja2luZy1yZWRpcmVjdC5odG1sIGIvTGF5b3V0VGVz
dHMvaHR0cC90ZXN0cy9zZWN1cml0eS9jb29raWVzL3RoaXJkLXBhcnR5LWNvb2tpZS1ibG9ja2lu
Zy1yZWRpcmVjdC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjc5Mzk0MWI3NDNkMDQ2N2Y2YzE1MTFlOWMwMDJk
ZmY0Y2MxNjhlOTAKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3Nl
Y3VyaXR5L2Nvb2tpZXMvdGhpcmQtcGFydHktY29va2llLWJsb2NraW5nLXJlZGlyZWN0Lmh0bWwK
QEAgLTAsMCArMSwyMSBAQAorPCFET0NUWVBFIGh0bWw+Cis8c2NyaXB0PgorZnVuY3Rpb24gdGVz
dCgpIHsKKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgIHRlc3RSdW5uZXIubm90
aWZ5RG9uZSgpOworfQorCitpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKKyAgICB0ZXN0UnVubmVy
LndhaXRVbnRpbERvbmUoKTsKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAgICB0ZXN0
UnVubmVyLmR1bXBDaGlsZEZyYW1lc0FzVGV4dCgpOworCisgICAgaWYgKHRlc3RSdW5uZXIuc2V0
UHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCkKKyAgICAgICAgdGVzdFJ1bm5lci5zZXRQcml2YXRlQnJv
d3NpbmdFbmFibGVkKHRydWUpOworCisgICAgdGVzdFJ1bm5lci5zZXRBbHdheXNBY2NlcHRDb29r
aWVzKGZhbHNlKTsKK30KKzwvc2NyaXB0PgorCis8cD5DaGVja3MgdGhhdCBzdWJyZXNvdXJjZXMg
dGhhdCBnb3QgcmVkaXJlY3RlZCBkbyBub3QgY2lyY3VtdmVudCB0aGlyZC1wYXJ0eSBjb29raWUg
cnVsZXMuPGJyPlRoaXMgdGVzdCBQQVNTIGlmIHlvdSBjYW4gc2VlIHRoZSB0ZXh0ICJGQUlMRUQ6
IENvb2tpZSBub3Qgc2V0Ii48L3A+Cis8aWZyYW1lIG9ubG9hZD0idGVzdCIgc3JjPSJodHRwOi8v
bG9jYWxob3N0OjgwMDAvY29va2llcy9yZXNvdXJjZXMvc2V0LWNvb2tpZS1vbi1yZWRpcmVjdC5w
aHA/c3RlcD0xIj48L2lmcmFtZT4K
</data>
<flag name="review"
          id="326485"
          type_id="1"
          status="+"
          setter="cgarcia"
    />
          </attachment>
      

    </bug>

</bugzilla>