16889 2008-01-16 00:30:18 -0800 REGRESSION (r29425): Canvas-based graphing calculator fails to run 2008-02-04 22:29:51 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED DUPLICATE 17164 http://www.calc5.com/ InRadar, NeedsReduction, Regression P1 Normal --- 17164 1 oliver webkit-unassigned ddkilzer eric ggaren mjs oliver zwarich oldest_to_newest 67343 0 oliver 2008-01-16 00:30:18 -0800 The graphing calcualtor at calc5.com now completely fails to load or run, it appears to produce "undefined value" exception when it did not used to. 67344 1 oliver 2008-01-16 00:37:13 -0800 Regression occurs between r29414 and r29438 67345 2 oliver 2008-01-16 00:40:28 -0800 Erk, this includes the activation patch, which could easily be the cause of the badness :( 67357 3 zwarich 2008-01-16 05:46:53 -0800 I can confirm that it doesn't work. It also doesn't work with my latest patch for bug 16868. Once that gets landed, I'll fix this. It doesn't look like it'll be too bad. The JS isn't obfuscated in any way like the Google stuff. 67363 4 oliver 2008-01-16 09:25:45 -0800 yay google code! /me curses obfuscation tools 67422 5 zwarich 2008-01-16 17:17:35 -0800 I can confirm our suspicions that the bug is caused by r29425 (the ActivationImp tear-off patch). I patched a clean r29414 tree with it and it no longer worked. 67642 6 zwarich 2008-01-18 16:26:34 -0800 This is not fixed by Maciej's fix for bug 16909. 67644 7 oliver 2008-01-18 17:01:49 -0800 That makes me sad :( 67684 8 ddkilzer 2008-01-19 03:05:26 -0800 <rdar://problem/5696255> 67994 9 ddkilzer 2008-01-22 18:02:10 -0800 (In reply to comment #5) > I can confirm our suspicions that the bug is caused by r29425 (the > ActivationImp tear-off patch). I patched a clean r29414 tree with it and it no > longer worked. The ActivationImp issue is now resolved, but the results for the calculator don't display properly (unlike on Firefox). I think this bug should be kept open, and have its focus change to resolve the issue with displaying results. 68002 10 oliver 2008-01-22 19:47:32 -0800 Dave, what makes you think that the activation imp issue is resolved? afaict the activation patch introduced the undefined variable exception, and that is still present in ToT -- the various activation related fixes were to stop crashes in GC, not fix correctness bugs -- none even touched correctness 69231 11 zwarich 2008-02-03 01:43:47 -0800 (In reply to comment #9) > (In reply to comment #5) > > I can confirm our suspicions that the bug is caused by r29425 (the > > ActivationImp tear-off patch). I patched a clean r29414 tree with it and it no > > longer worked. > > The ActivationImp issue is now resolved, but the results for the calculator > don't display properly (unlike on Firefox). I think this bug should be kept > open, and have its focus change to resolve the issue with displaying results. Like Oliver said, the GC marking issues were resolved, but this bug didn't change one bit. It is such a random error that it must be caused by some strange behaviour introduced by the ActivationImp tear-off. There are a few of these bugs now, but my previous attempts to reduce them failed. I will try again with the calculator now that I have more free time because I really want to see this resolved. 69326 12 zwarich 2008-02-04 02:09:25 -0800 This bug is fixed by the patch for bug 17164. 69432 13 oliver 2008-02-04 22:29:51 -0800 *** This bug has been marked as a duplicate of 17164 ***