168885 2017-02-26 20:06:19 -0800 Stop exporting C++ member variables from WKDOMTextIterator 2017-02-26 21:22:11 -0800 1 1 1 Unclassified WebKit WebKit2 Safari 9 Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap aakash_jain commit-queue mitz sam oldest_to_newest 1281237 0 ap 2017-02-26 20:06:19 -0800 Having these as public variables results in exporting symbols from the binary. As far as I can tell, there is no reason for them to be public. 1281238 1 302802 ap 2017-02-26 20:07:32 -0800 Created attachment 302802 proposed patch 1281256 2 302802 commit-queue 2017-02-26 21:22:07 -0800 Comment on attachment 302802 proposed patch Clearing flags on attachment: 302802 Committed r213023: <http://trac.webkit.org/changeset/213023> 1281257 3 commit-queue 2017-02-26 21:22:11 -0800 All reviewed patches have been landed. Closing bug. 302802 2017-02-26 20:07:32 -0800 2017-02-26 21:22:07 -0800 proposed patch WKDOMTextIterator.txt text/plain 1142 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzAyMSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE3LTAyLTI2ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFN0b3AgZXhwb3J0aW5nIEMr KyBtZW1iZXIgdmFyaWFibGVzIGZyb20gV0tET01UZXh0SXRlcmF0b3IKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODg4NQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1 bmRsZS9BUEkvbWFjL1dLRE9NVGV4dEl0ZXJhdG9yLm1tOgorCiAyMDE3LTAyLTI2ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBzcHVyaW91cyBD KysgaW5jbHVkZSBmcm9tIF9XS1Rlc3RpbmdEZWxlZ2F0ZS5oCkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9tYWMvV0tET01UZXh0SXRlcmF0b3IubW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9B UEkvbWFjL1dLRE9NVGV4dEl0ZXJhdG9yLm1tCShyZXZpc2lvbiAyMTMwMjEpCisrKyBTb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9tYWMvV0tET01UZXh0SXRlcmF0 b3IubW0JKHdvcmtpbmcgY29weSkKQEAgLTMzLDcgKzMzLDcgQEAKICNpbXBvcnQgPFdlYkNvcmUv VGV4dEl0ZXJhdG9yLmg+CiAKIEBpbnRlcmZhY2UgV0tET01UZXh0SXRlcmF0b3IgKCkgewotQHB1 YmxpYworQHByaXZhdGUKICAgICBzdGQ6OnVuaXF1ZV9wdHI8V2ViQ29yZTo6VGV4dEl0ZXJhdG9y PiBfdGV4dEl0ZXJhdG9yOwogICAgIFZlY3Rvcjx1bmljaGFyPiBfdXBjb252ZXJ0ZWRUZXh0Owog fQo=