<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>168819</bug_id>
          
          <creation_ts>2017-02-23 20:26:56 -0800</creation_ts>
          <short_desc>Simplify EXPORTED_SYMBOLS_FILE variables in WebKitLegacy.xcconfig</short_desc>
          <delta_ts>2017-02-26 16:18:46 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=168758</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Aakash Jain">aakash_jain</reporter>
          <assigned_to name="Aakash Jain">aakash_jain</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>ap</cc>
    
    <cc>commit-queue</cc>
    
    <cc>juergen</cc>
    
    <cc>mitz</cc>
    
    <cc>thorton</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1280645</commentid>
    <comment_count>0</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2017-02-23 20:26:56 -0800</bug_when>
    <thetext>Mac 32-bit (i386) can not use Objective C symbols (starting with _OBJC_IVAR) in the exp file. Therefore it uses separate symbol file WebKitLegacy.i386.exp. However iphonesimulator i386 doesn&apos;t have any restriction and it can use the regular WebKitLegacy.generated.exp file.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1280646</commentid>
    <comment_count>1</comment_count>
      <attachid>302633</attachid>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2017-02-23 20:31:38 -0800</bug_when>
    <thetext>Created attachment 302633
Proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1280654</commentid>
    <comment_count>2</comment_count>
      <attachid>302636</attachid>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2017-02-23 21:08:01 -0800</bug_when>
    <thetext>Created attachment 302636
Updated patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1280657</commentid>
    <comment_count>3</comment_count>
      <attachid>302636</attachid>
    <who name="">mitz</who>
    <bug_when>2017-02-23 21:15:38 -0800</bug_when>
    <thetext>Comment on attachment 302636
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302636&amp;action=review

&gt; Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig:39
&gt;  EXPORTED_SYMBOLS_FILE_armv7k = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp;
&gt;  EXPORTED_SYMBOLS_FILE_armv7s = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp;
&gt;  EXPORTED_SYMBOLS_FILE_arm64 = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp;
&gt; -EXPORTED_SYMBOLS_FILE_i386 = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.i386.exp;
&gt; +EXPORTED_SYMBOLS_FILE_i386[sdk=*simulator*] = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp;
&gt; +EXPORTED_SYMBOLS_FILE_i386[sdk=macosx*] = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.i386.exp;
&gt;  EXPORTED_SYMBOLS_FILE_x86_64[sdk=iphonesimulator*] = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp;
&gt;  EXPORTED_SYMBOLS_FILE_x86_64[sdk=macosx*] = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.LP64.exp;

I know that you are just trying to fix a small problem, but looking at this, I notice that the list doesn’t cover 64-bit non-iPhone simulators, and that the entire construct is way over-complicated.

If I’m reading this correctly, there are three exports files we use: WebKitLegacy.generated.exp, WebKitLegacy.i386.exp, and WebKitLegacy.LP64.exp. Weird naming scheme. It also looks like WebKitLegacy.generated.exp is the default.

Here’s how I’d rewrite this entire section of the .xcconfig file (lines 30-39):

EXPORTED_SYMBOLS_FILE = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp;
EXPORTED_SYMBOLS_FILE[sdk=macosx] = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.LP64.exp;
EXPORTED_SYMBOLS_FILE[sdk=macosx][arch=i386] = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.i386.exp;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1280674</commentid>
    <comment_count>4</comment_count>
      <attachid>302643</attachid>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2017-02-23 22:07:10 -0800</bug_when>
    <thetext>Created attachment 302643
Updated patch

Agree with you. It simplifies the code quite a bit and make it more readable as well.

I made a small change for WebKitLegacy.LP64.exp file (added [arch=x86_64]).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1280676</commentid>
    <comment_count>5</comment_count>
      <attachid>302643</attachid>
    <who name="">mitz</who>
    <bug_when>2017-02-23 22:09:23 -0800</bug_when>
    <thetext>Comment on attachment 302643
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302643&amp;action=review

&gt; Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig:32
&gt; +EXPORTED_SYMBOLS_FILE[sdk=macosx][arch=x86_64] = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebKitLegacy/WebKitLegacy.LP64.exp;

Neat! r=me once you see that the bots are OK with this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1280722</commentid>
    <comment_count>6</comment_count>
      <attachid>302656</attachid>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2017-02-24 00:36:11 -0800</bug_when>
    <thetext>Created attachment 302656
Updated patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1281182</commentid>
    <comment_count>7</comment_count>
      <attachid>302656</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-02-26 16:18:40 -0800</bug_when>
    <thetext>Comment on attachment 302656
Updated patch

Clearing flags on attachment: 302656

Committed r213017: &lt;http://trac.webkit.org/changeset/213017&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1281183</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-02-26 16:18:46 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>302633</attachid>
            <date>2017-02-23 20:31:38 -0800</date>
            <delta_ts>2017-02-23 21:08:01 -0800</delta_ts>
            <desc>Proposed patch</desc>
            <filename>patch_i386_iphonesimulator</filename>
            <type>text/plain</type>
            <size>1896</size>
            <attacher name="Aakash Jain">aakash_jain</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMjkzOSkKKysrIFNvdXJjZS9XZWJLaXQv
bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE3LTAyLTIz
ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBVc2Ugc2Vw
YXJhdGUgc3ltYm9sIGZpbGUgZm9yIGkzODYgYXJjaGl0ZWN0dXJlIG9uIG1hYyBhbmQgaXBob25l
c2ltdWxhdG9yIGluIFdlYktpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MTY4ODE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9XZWJLaXRMZWdhY3kueGNjb25maWc6CisKIDIw
MTctMDItMjIgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAg
IEV4cG9ydCBPYmplY3RpdmUtQyBzeW1ib2xzIGZvciB2YXJpYWJsZXMgaW4gV2Via2l0IFNQSQpJ
bmRleDogU291cmNlL1dlYktpdC9tYWMvQ29uZmlndXJhdGlvbnMvV2ViS2l0TGVnYWN5LnhjY29u
ZmlnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFjL0NvbmZpZ3VyYXRpb25zL1dlYktp
dExlZ2FjeS54Y2NvbmZpZwkocmV2aXNpb24gMjEyOTI4KQorKysgU291cmNlL1dlYktpdC9tYWMv
Q29uZmlndXJhdGlvbnMvV2ViS2l0TGVnYWN5LnhjY29uZmlnCSh3b3JraW5nIGNvcHkpCkBAIC0z
Myw3ICszMyw4IEBAIEVYUE9SVEVEX1NZTUJPTFNfRklMRV9hcm12NyA9ICQoQlVJTFRfUFIKIEVY
UE9SVEVEX1NZTUJPTFNfRklMRV9hcm12N2sgPSAkKEJVSUxUX1BST0RVQ1RTX0RJUikvRGVyaXZl
ZFNvdXJjZXMvV2ViS2l0TGVnYWN5L1dlYktpdExlZ2FjeS5nZW5lcmF0ZWQuZXhwOwogRVhQT1JU
RURfU1lNQk9MU19GSUxFX2FybXY3cyA9ICQoQlVJTFRfUFJPRFVDVFNfRElSKS9EZXJpdmVkU291
cmNlcy9XZWJLaXRMZWdhY3kvV2ViS2l0TGVnYWN5LmdlbmVyYXRlZC5leHA7CiBFWFBPUlRFRF9T
WU1CT0xTX0ZJTEVfYXJtNjQgPSAkKEJVSUxUX1BST0RVQ1RTX0RJUikvRGVyaXZlZFNvdXJjZXMv
V2ViS2l0TGVnYWN5L1dlYktpdExlZ2FjeS5nZW5lcmF0ZWQuZXhwOwotRVhQT1JURURfU1lNQk9M
U19GSUxFX2kzODYgPSAkKEJVSUxUX1BST0RVQ1RTX0RJUikvRGVyaXZlZFNvdXJjZXMvV2ViS2l0
TGVnYWN5L1dlYktpdExlZ2FjeS5pMzg2LmV4cDsKK0VYUE9SVEVEX1NZTUJPTFNfRklMRV9pMzg2
W3Nkaz1pcGhvbmVzaW11bGF0b3IqXSA9ICQoQlVJTFRfUFJPRFVDVFNfRElSKS9EZXJpdmVkU291
cmNlcy9XZWJLaXRMZWdhY3kvV2ViS2l0TGVnYWN5LmdlbmVyYXRlZC5leHA7CitFWFBPUlRFRF9T
WU1CT0xTX0ZJTEVfaTM4NltzZGs9bWFjb3N4Kl0gPSAkKEJVSUxUX1BST0RVQ1RTX0RJUikvRGVy
aXZlZFNvdXJjZXMvV2ViS2l0TGVnYWN5L1dlYktpdExlZ2FjeS5pMzg2LmV4cDsKIEVYUE9SVEVE
X1NZTUJPTFNfRklMRV94ODZfNjRbc2RrPWlwaG9uZXNpbXVsYXRvcipdID0gJChCVUlMVF9QUk9E
VUNUU19ESVIpL0Rlcml2ZWRTb3VyY2VzL1dlYktpdExlZ2FjeS9XZWJLaXRMZWdhY3kuZ2VuZXJh
dGVkLmV4cDsKIEVYUE9SVEVEX1NZTUJPTFNfRklMRV94ODZfNjRbc2RrPW1hY29zeCpdID0gJChC
VUlMVF9QUk9EVUNUU19ESVIpL0Rlcml2ZWRTb3VyY2VzL1dlYktpdExlZ2FjeS9XZWJLaXRMZWdh
Y3kuTFA2NC5leHA7CiAK
</data>
<flag name="review"
          id="324346"
          type_id="1"
          status="+"
          setter="mitz"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>302636</attachid>
            <date>2017-02-23 21:08:01 -0800</date>
            <delta_ts>2017-02-23 22:07:10 -0800</delta_ts>
            <desc>Updated patch</desc>
            <filename>patch_i386_iphonesimulator_v2</filename>
            <type>text/plain</type>
            <size>1891</size>
            <attacher name="Aakash Jain">aakash_jain</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMjkzOSkKKysrIFNvdXJjZS9XZWJLaXQv
bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE3LTAyLTIz
ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBVc2Ugc2Vw
YXJhdGUgc3ltYm9sIGZpbGUgZm9yIGkzODYgYXJjaGl0ZWN0dXJlIG9uIG1hYyBhbmQgaXBob25l
c2ltdWxhdG9yIGluIFdlYktpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MTY4ODE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9XZWJLaXRMZWdhY3kueGNjb25maWc6CisKIDIw
MTctMDItMjIgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAg
IEV4cG9ydCBPYmplY3RpdmUtQyBzeW1ib2xzIGZvciB2YXJpYWJsZXMgaW4gV2Via2l0IFNQSQpJ
bmRleDogU291cmNlL1dlYktpdC9tYWMvQ29uZmlndXJhdGlvbnMvV2ViS2l0TGVnYWN5LnhjY29u
ZmlnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFjL0NvbmZpZ3VyYXRpb25zL1dlYktp
dExlZ2FjeS54Y2NvbmZpZwkocmV2aXNpb24gMjEyOTI4KQorKysgU291cmNlL1dlYktpdC9tYWMv
Q29uZmlndXJhdGlvbnMvV2ViS2l0TGVnYWN5LnhjY29uZmlnCSh3b3JraW5nIGNvcHkpCkBAIC0z
Myw3ICszMyw4IEBAIEVYUE9SVEVEX1NZTUJPTFNfRklMRV9hcm12NyA9ICQoQlVJTFRfUFIKIEVY
UE9SVEVEX1NZTUJPTFNfRklMRV9hcm12N2sgPSAkKEJVSUxUX1BST0RVQ1RTX0RJUikvRGVyaXZl
ZFNvdXJjZXMvV2ViS2l0TGVnYWN5L1dlYktpdExlZ2FjeS5nZW5lcmF0ZWQuZXhwOwogRVhQT1JU
RURfU1lNQk9MU19GSUxFX2FybXY3cyA9ICQoQlVJTFRfUFJPRFVDVFNfRElSKS9EZXJpdmVkU291
cmNlcy9XZWJLaXRMZWdhY3kvV2ViS2l0TGVnYWN5LmdlbmVyYXRlZC5leHA7CiBFWFBPUlRFRF9T
WU1CT0xTX0ZJTEVfYXJtNjQgPSAkKEJVSUxUX1BST0RVQ1RTX0RJUikvRGVyaXZlZFNvdXJjZXMv
V2ViS2l0TGVnYWN5L1dlYktpdExlZ2FjeS5nZW5lcmF0ZWQuZXhwOwotRVhQT1JURURfU1lNQk9M
U19GSUxFX2kzODYgPSAkKEJVSUxUX1BST0RVQ1RTX0RJUikvRGVyaXZlZFNvdXJjZXMvV2ViS2l0
TGVnYWN5L1dlYktpdExlZ2FjeS5pMzg2LmV4cDsKK0VYUE9SVEVEX1NZTUJPTFNfRklMRV9pMzg2
W3Nkaz0qc2ltdWxhdG9yKl0gPSAkKEJVSUxUX1BST0RVQ1RTX0RJUikvRGVyaXZlZFNvdXJjZXMv
V2ViS2l0TGVnYWN5L1dlYktpdExlZ2FjeS5nZW5lcmF0ZWQuZXhwOworRVhQT1JURURfU1lNQk9M
U19GSUxFX2kzODZbc2RrPW1hY29zeCpdID0gJChCVUlMVF9QUk9EVUNUU19ESVIpL0Rlcml2ZWRT
b3VyY2VzL1dlYktpdExlZ2FjeS9XZWJLaXRMZWdhY3kuaTM4Ni5leHA7CiBFWFBPUlRFRF9TWU1C
T0xTX0ZJTEVfeDg2XzY0W3Nkaz1pcGhvbmVzaW11bGF0b3IqXSA9ICQoQlVJTFRfUFJPRFVDVFNf
RElSKS9EZXJpdmVkU291cmNlcy9XZWJLaXRMZWdhY3kvV2ViS2l0TGVnYWN5LmdlbmVyYXRlZC5l
eHA7CiBFWFBPUlRFRF9TWU1CT0xTX0ZJTEVfeDg2XzY0W3Nkaz1tYWNvc3gqXSA9ICQoQlVJTFRf
UFJPRFVDVFNfRElSKS9EZXJpdmVkU291cmNlcy9XZWJLaXRMZWdhY3kvV2ViS2l0TGVnYWN5LkxQ
NjQuZXhwOwogCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>302643</attachid>
            <date>2017-02-23 22:07:10 -0800</date>
            <delta_ts>2017-02-24 00:36:11 -0800</delta_ts>
            <desc>Updated patch</desc>
            <filename>patch_i386_iphonesimulator_v3</filename>
            <type>text/plain</type>
            <size>3445</size>
            <attacher name="Aakash Jain">aakash_jain</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMjk0MikKKysrIFNvdXJjZS9XZWJLaXQv
bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE3LTAyLTIz
ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBTaW1wbGlm
eSBFWFBPUlRFRF9TWU1CT0xTX0ZJTEUgdmFyaWFibGVzIGluIFdlYktpdExlZ2FjeS54Y2NvbmZp
ZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4ODE5
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDb25m
aWd1cmF0aW9ucy9XZWJLaXRMZWdhY3kueGNjb25maWc6CisKIDIwMTctMDItMjIgIEFha2FzaCBK
YWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIEV4cG9ydCBPYmplY3RpdmUt
QyBzeW1ib2xzIGZvciB2YXJpYWJsZXMgaW4gV2Via2l0IFNQSQpJbmRleDogU291cmNlL1dlYktp
dC9tYWMvQ29uZmlndXJhdGlvbnMvV2ViS2l0TGVnYWN5LnhjY29uZmlnCj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IFNvdXJjZS9XZWJLaXQvbWFjL0NvbmZpZ3VyYXRpb25zL1dlYktpdExlZ2FjeS54Y2NvbmZpZwko
cmV2aXNpb24gMjEyOTI4KQorKysgU291cmNlL1dlYktpdC9tYWMvQ29uZmlndXJhdGlvbnMvV2Vi
S2l0TGVnYWN5LnhjY29uZmlnCSh3b3JraW5nIGNvcHkpCkBAIC0yNywxNSArMjcsOSBAQAogRVhD
TFVERURfU09VUkNFX0ZJTEVfTkFNRVNbc2RrPWlwaG9uZSpdID0gKi5kZWZzICoubmliICoucGRm
ICoudGlmZiBDYXJib25VdGlscy4qIENhcmJvbldpbmRvd0FkYXB0ZXIuKiBDYXJib25XaW5kb3dD
b250ZW50Vmlldy4qIENhcmJvbldpbmRvd0ZyYW1lLiogSElWaWV3QWRhcHRlci4qIEhJV2ViVmll
dy4qIE91dGxvb2tRdWlya3NVc2VyU2NyaXB0LmpzIFBvcHVwTWVudU1hYy4qIFNlYXJjaFBvcHVw
TWVudU1hYy4qIFdlYkNsaXBWaWV3LiogV2ViRGFzaGJvYXJkUmVnaW9uLiogV2ViRHluYW1pY1Nj
cm9sbEJhcnNWaWV3LiogV2ViSWNvbkRhdGFiYXNlLiogV2ViSWNvbkRhdGFiYXNlUHJpdmF0ZS4q
IFdlYkluc3BlY3RvckNsaWVudC4qIFdlYkphdmFTY3JpcHRUZXh0SW5wdXRQYW5lbC4qIFdlYk5T
RXZlbnRFeHRyYXMuKiBXZWJOU1Bhc3RlYm9hcmRFeHRyYXMuKiBXZWJOU1dpbmRvd0V4dHJhcy4q
IFdlYlBhbmVsQXV0aGVudGljYXRpb25IYW5kbGVyLiogV2ViUGx1Z2luc1ByaXZhdGUuKiBXZWJT
dHJpbmdUcnVuY2F0b3IuKiBXZWJUZXh0Q29tcGxldGlvbkNvbnRyb2xsZXIuKjsKIEVYQ0xVREVE
X1NPVVJDRV9GSUxFX05BTUVTW3Nkaz1tYWNvc3gqXSA9ICpJT1MubW0gTWVtb3J5TWVhc3VyZS5o
IFdlYkNhcmV0Q2hhbmdlTGlzdGVuZXIuaCBXZWJGaXhlZFBvc2l0aW9uQ29udGVudC5oIFdlYkZy
YW1lSU9TLmggV2ViRnJhbWVJUGhvbmUuaCBXZWJHZW9sb2NhdGlvbkNvcmVMb2NhdGlvblByb3Zp
ZGVyLmggV2ViR2VvbG9jYXRpb25Qcml2YXRlLmggV2ViR2VvbG9jYXRpb25Qcm92aWRlcklPUy5o
IFdlYk1JTUVUeXBlUmVnaXN0cnkuaCBXZWJOU1N0cmluZ0V4dHJhc0lPUy5oIFdlYk5TU3RyaW5n
RXh0cmFzSVBob25lLmggV2ViUERGVmlld0lPUy5oIFdlYlBERlZpZXdJUGhvbmUuaCBXZWJQREZW
aWV3UGxhY2Vob2xkZXIuaCBXZWJTZWxlY3Rpb25SZWN0LmggV2ViVUlLaXREZWxlZ2F0ZS5oIFdl
YlVJS2l0U3VwcG9ydC5oIFdlYlZpc2libGVQb3NpdGlvbi5oIERPTUhUTUxUZXh0QXJlYUVsZW1l
bnRQcml2YXRlLmggRE9NVUlLaXRFeHRlbnNpb25zLmg7CiAKLUVYUE9SVEVEX1NZTUJPTFNfRklM
RSA9ICQoRVhQT1JURURfU1lNQk9MU19GSUxFXyQoQ1VSUkVOVF9BUkNIKSk7Ci1FWFBPUlRFRF9T
WU1CT0xTX0ZJTEVfID0gJChCVUlMVF9QUk9EVUNUU19ESVIpL0Rlcml2ZWRTb3VyY2VzL1dlYktp
dExlZ2FjeS9XZWJLaXRMZWdhY3kuZ2VuZXJhdGVkLmV4cDsKLUVYUE9SVEVEX1NZTUJPTFNfRklM
RV9hcm12NyA9ICQoQlVJTFRfUFJPRFVDVFNfRElSKS9EZXJpdmVkU291cmNlcy9XZWJLaXRMZWdh
Y3kvV2ViS2l0TGVnYWN5LmdlbmVyYXRlZC5leHA7Ci1FWFBPUlRFRF9TWU1CT0xTX0ZJTEVfYXJt
djdrID0gJChCVUlMVF9QUk9EVUNUU19ESVIpL0Rlcml2ZWRTb3VyY2VzL1dlYktpdExlZ2FjeS9X
ZWJLaXRMZWdhY3kuZ2VuZXJhdGVkLmV4cDsKLUVYUE9SVEVEX1NZTUJPTFNfRklMRV9hcm12N3Mg
PSAkKEJVSUxUX1BST0RVQ1RTX0RJUikvRGVyaXZlZFNvdXJjZXMvV2ViS2l0TGVnYWN5L1dlYktp
dExlZ2FjeS5nZW5lcmF0ZWQuZXhwOwotRVhQT1JURURfU1lNQk9MU19GSUxFX2FybTY0ID0gJChC
VUlMVF9QUk9EVUNUU19ESVIpL0Rlcml2ZWRTb3VyY2VzL1dlYktpdExlZ2FjeS9XZWJLaXRMZWdh
Y3kuZ2VuZXJhdGVkLmV4cDsKLUVYUE9SVEVEX1NZTUJPTFNfRklMRV9pMzg2ID0gJChCVUlMVF9Q
Uk9EVUNUU19ESVIpL0Rlcml2ZWRTb3VyY2VzL1dlYktpdExlZ2FjeS9XZWJLaXRMZWdhY3kuaTM4
Ni5leHA7Ci1FWFBPUlRFRF9TWU1CT0xTX0ZJTEVfeDg2XzY0W3Nkaz1pcGhvbmVzaW11bGF0b3Iq
XSA9ICQoQlVJTFRfUFJPRFVDVFNfRElSKS9EZXJpdmVkU291cmNlcy9XZWJLaXRMZWdhY3kvV2Vi
S2l0TGVnYWN5LmdlbmVyYXRlZC5leHA7Ci1FWFBPUlRFRF9TWU1CT0xTX0ZJTEVfeDg2XzY0W3Nk
az1tYWNvc3gqXSA9ICQoQlVJTFRfUFJPRFVDVFNfRElSKS9EZXJpdmVkU291cmNlcy9XZWJLaXRM
ZWdhY3kvV2ViS2l0TGVnYWN5LkxQNjQuZXhwOworRVhQT1JURURfU1lNQk9MU19GSUxFID0gJChC
VUlMVF9QUk9EVUNUU19ESVIpL0Rlcml2ZWRTb3VyY2VzL1dlYktpdExlZ2FjeS9XZWJLaXRMZWdh
Y3kuZ2VuZXJhdGVkLmV4cDsKK0VYUE9SVEVEX1NZTUJPTFNfRklMRVtzZGs9bWFjb3N4XVthcmNo
PWkzODZdID0gJChCVUlMVF9QUk9EVUNUU19ESVIpL0Rlcml2ZWRTb3VyY2VzL1dlYktpdExlZ2Fj
eS9XZWJLaXRMZWdhY3kuaTM4Ni5leHA7CitFWFBPUlRFRF9TWU1CT0xTX0ZJTEVbc2RrPW1hY29z
eF1bYXJjaD14ODZfNjRdID0gJChCVUlMVF9QUk9EVUNUU19ESVIpL0Rlcml2ZWRTb3VyY2VzL1dl
YktpdExlZ2FjeS9XZWJLaXRMZWdhY3kuTFA2NC5leHA7CiAKIFdLX1hDT0RFX1NVUFBPUlRTX1RF
WFRfQkFTRURfU1RVQlMgPSAkKFdLX05PVF8kKFdLX0VNUFRZXyQoVEFQSV9WRVJJRllfTU9ERSkp
KTsKIFdLX1BSSVZBVEVfRlJBTUVXT1JLU19ESVIgPSAkKFdLX1BSSVZBVEVfRlJBTUVXT1JLU19E
SVJfJChVU0VfSU5URVJOQUxfU0RLKSk7Cg==
</data>
<flag name="review"
          id="324357"
          type_id="1"
          status="+"
          setter="mitz"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>302656</attachid>
            <date>2017-02-24 00:36:11 -0800</date>
            <delta_ts>2017-02-26 16:18:40 -0800</delta_ts>
            <desc>Updated patch</desc>
            <filename>patch_i386_iphonesimulator_v4.txt</filename>
            <type>text/plain</type>
            <size>3447</size>
            <attacher name="Aakash Jain">aakash_jain</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMjk0MikKKysrIFNvdXJjZS9XZWJLaXQv
bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE3LTAyLTIz
ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBTaW1wbGlm
eSBFWFBPUlRFRF9TWU1CT0xTX0ZJTEUgdmFyaWFibGVzIGluIFdlYktpdExlZ2FjeS54Y2NvbmZp
ZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4ODE5
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDb25m
aWd1cmF0aW9ucy9XZWJLaXRMZWdhY3kueGNjb25maWc6CisKIDIwMTctMDItMjIgIEFha2FzaCBK
YWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIEV4cG9ydCBPYmplY3RpdmUt
QyBzeW1ib2xzIGZvciB2YXJpYWJsZXMgaW4gV2Via2l0IFNQSQpJbmRleDogU291cmNlL1dlYktp
dC9tYWMvQ29uZmlndXJhdGlvbnMvV2ViS2l0TGVnYWN5LnhjY29uZmlnCj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IFNvdXJjZS9XZWJLaXQvbWFjL0NvbmZpZ3VyYXRpb25zL1dlYktpdExlZ2FjeS54Y2NvbmZpZwko
cmV2aXNpb24gMjEyOTI4KQorKysgU291cmNlL1dlYktpdC9tYWMvQ29uZmlndXJhdGlvbnMvV2Vi
S2l0TGVnYWN5LnhjY29uZmlnCSh3b3JraW5nIGNvcHkpCkBAIC0yNywxNSArMjcsOSBAQAogRVhD
TFVERURfU09VUkNFX0ZJTEVfTkFNRVNbc2RrPWlwaG9uZSpdID0gKi5kZWZzICoubmliICoucGRm
ICoudGlmZiBDYXJib25VdGlscy4qIENhcmJvbldpbmRvd0FkYXB0ZXIuKiBDYXJib25XaW5kb3dD
b250ZW50Vmlldy4qIENhcmJvbldpbmRvd0ZyYW1lLiogSElWaWV3QWRhcHRlci4qIEhJV2ViVmll
dy4qIE91dGxvb2tRdWlya3NVc2VyU2NyaXB0LmpzIFBvcHVwTWVudU1hYy4qIFNlYXJjaFBvcHVw
TWVudU1hYy4qIFdlYkNsaXBWaWV3LiogV2ViRGFzaGJvYXJkUmVnaW9uLiogV2ViRHluYW1pY1Nj
cm9sbEJhcnNWaWV3LiogV2ViSWNvbkRhdGFiYXNlLiogV2ViSWNvbkRhdGFiYXNlUHJpdmF0ZS4q
IFdlYkluc3BlY3RvckNsaWVudC4qIFdlYkphdmFTY3JpcHRUZXh0SW5wdXRQYW5lbC4qIFdlYk5T
RXZlbnRFeHRyYXMuKiBXZWJOU1Bhc3RlYm9hcmRFeHRyYXMuKiBXZWJOU1dpbmRvd0V4dHJhcy4q
IFdlYlBhbmVsQXV0aGVudGljYXRpb25IYW5kbGVyLiogV2ViUGx1Z2luc1ByaXZhdGUuKiBXZWJT
dHJpbmdUcnVuY2F0b3IuKiBXZWJUZXh0Q29tcGxldGlvbkNvbnRyb2xsZXIuKjsKIEVYQ0xVREVE
X1NPVVJDRV9GSUxFX05BTUVTW3Nkaz1tYWNvc3gqXSA9ICpJT1MubW0gTWVtb3J5TWVhc3VyZS5o
IFdlYkNhcmV0Q2hhbmdlTGlzdGVuZXIuaCBXZWJGaXhlZFBvc2l0aW9uQ29udGVudC5oIFdlYkZy
YW1lSU9TLmggV2ViRnJhbWVJUGhvbmUuaCBXZWJHZW9sb2NhdGlvbkNvcmVMb2NhdGlvblByb3Zp
ZGVyLmggV2ViR2VvbG9jYXRpb25Qcml2YXRlLmggV2ViR2VvbG9jYXRpb25Qcm92aWRlcklPUy5o
IFdlYk1JTUVUeXBlUmVnaXN0cnkuaCBXZWJOU1N0cmluZ0V4dHJhc0lPUy5oIFdlYk5TU3RyaW5n
RXh0cmFzSVBob25lLmggV2ViUERGVmlld0lPUy5oIFdlYlBERlZpZXdJUGhvbmUuaCBXZWJQREZW
aWV3UGxhY2Vob2xkZXIuaCBXZWJTZWxlY3Rpb25SZWN0LmggV2ViVUlLaXREZWxlZ2F0ZS5oIFdl
YlVJS2l0U3VwcG9ydC5oIFdlYlZpc2libGVQb3NpdGlvbi5oIERPTUhUTUxUZXh0QXJlYUVsZW1l
bnRQcml2YXRlLmggRE9NVUlLaXRFeHRlbnNpb25zLmg7CiAKLUVYUE9SVEVEX1NZTUJPTFNfRklM
RSA9ICQoRVhQT1JURURfU1lNQk9MU19GSUxFXyQoQ1VSUkVOVF9BUkNIKSk7Ci1FWFBPUlRFRF9T
WU1CT0xTX0ZJTEVfID0gJChCVUlMVF9QUk9EVUNUU19ESVIpL0Rlcml2ZWRTb3VyY2VzL1dlYktp
dExlZ2FjeS9XZWJLaXRMZWdhY3kuZ2VuZXJhdGVkLmV4cDsKLUVYUE9SVEVEX1NZTUJPTFNfRklM
RV9hcm12NyA9ICQoQlVJTFRfUFJPRFVDVFNfRElSKS9EZXJpdmVkU291cmNlcy9XZWJLaXRMZWdh
Y3kvV2ViS2l0TGVnYWN5LmdlbmVyYXRlZC5leHA7Ci1FWFBPUlRFRF9TWU1CT0xTX0ZJTEVfYXJt
djdrID0gJChCVUlMVF9QUk9EVUNUU19ESVIpL0Rlcml2ZWRTb3VyY2VzL1dlYktpdExlZ2FjeS9X
ZWJLaXRMZWdhY3kuZ2VuZXJhdGVkLmV4cDsKLUVYUE9SVEVEX1NZTUJPTFNfRklMRV9hcm12N3Mg
PSAkKEJVSUxUX1BST0RVQ1RTX0RJUikvRGVyaXZlZFNvdXJjZXMvV2ViS2l0TGVnYWN5L1dlYktp
dExlZ2FjeS5nZW5lcmF0ZWQuZXhwOwotRVhQT1JURURfU1lNQk9MU19GSUxFX2FybTY0ID0gJChC
VUlMVF9QUk9EVUNUU19ESVIpL0Rlcml2ZWRTb3VyY2VzL1dlYktpdExlZ2FjeS9XZWJLaXRMZWdh
Y3kuZ2VuZXJhdGVkLmV4cDsKLUVYUE9SVEVEX1NZTUJPTFNfRklMRV9pMzg2ID0gJChCVUlMVF9Q
Uk9EVUNUU19ESVIpL0Rlcml2ZWRTb3VyY2VzL1dlYktpdExlZ2FjeS9XZWJLaXRMZWdhY3kuaTM4
Ni5leHA7Ci1FWFBPUlRFRF9TWU1CT0xTX0ZJTEVfeDg2XzY0W3Nkaz1pcGhvbmVzaW11bGF0b3Iq
XSA9ICQoQlVJTFRfUFJPRFVDVFNfRElSKS9EZXJpdmVkU291cmNlcy9XZWJLaXRMZWdhY3kvV2Vi
S2l0TGVnYWN5LmdlbmVyYXRlZC5leHA7Ci1FWFBPUlRFRF9TWU1CT0xTX0ZJTEVfeDg2XzY0W3Nk
az1tYWNvc3gqXSA9ICQoQlVJTFRfUFJPRFVDVFNfRElSKS9EZXJpdmVkU291cmNlcy9XZWJLaXRM
ZWdhY3kvV2ViS2l0TGVnYWN5LkxQNjQuZXhwOworRVhQT1JURURfU1lNQk9MU19GSUxFID0gJChC
VUlMVF9QUk9EVUNUU19ESVIpL0Rlcml2ZWRTb3VyY2VzL1dlYktpdExlZ2FjeS9XZWJLaXRMZWdh
Y3kuZ2VuZXJhdGVkLmV4cDsKK0VYUE9SVEVEX1NZTUJPTFNfRklMRVtzZGs9bWFjb3N4Kl1bYXJj
aD1pMzg2XSA9ICQoQlVJTFRfUFJPRFVDVFNfRElSKS9EZXJpdmVkU291cmNlcy9XZWJLaXRMZWdh
Y3kvV2ViS2l0TGVnYWN5LmkzODYuZXhwOworRVhQT1JURURfU1lNQk9MU19GSUxFW3Nkaz1tYWNv
c3gqXVthcmNoPXg4Nl82NF0gPSAkKEJVSUxUX1BST0RVQ1RTX0RJUikvRGVyaXZlZFNvdXJjZXMv
V2ViS2l0TGVnYWN5L1dlYktpdExlZ2FjeS5MUDY0LmV4cDsKIAogV0tfWENPREVfU1VQUE9SVFNf
VEVYVF9CQVNFRF9TVFVCUyA9ICQoV0tfTk9UXyQoV0tfRU1QVFlfJChUQVBJX1ZFUklGWV9NT0RF
KSkpOwogV0tfUFJJVkFURV9GUkFNRVdPUktTX0RJUiA9ICQoV0tfUFJJVkFURV9GUkFNRVdPUktT
X0RJUl8kKFVTRV9JTlRFUk5BTF9TREspKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>