168809 2017-02-23 17:27:50 -0800 [Modern Media Controls] Show "Loading" until playback starts 2017-02-23 21:29:45 -0800 1 1 1 Unclassified WebKit Media Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts commit-queue webkit-bug-importer oldest_to_newest 1280589 0 graouts 2017-02-23 17:27:50 -0800 We currently show the "Loading" status text provided that networkState is set to NETWORK_LOADING and readyState is HAVE_METADATA or less. This is not optimal since readyState can be in a variety of states before it reaches the point that it will actually start playback, and we should retain the "Loading" text until that happens. 1280590 1 webkit-bug-importer 2017-02-23 17:28:12 -0800 <rdar://problem/30687468> 1280592 2 302616 graouts 2017-02-23 17:30:17 -0800 Created attachment 302616 Patch 1280665 3 302616 commit-queue 2017-02-23 21:29:42 -0800 Comment on attachment 302616 Patch Clearing flags on attachment: 302616 Committed r212940: <http://trac.webkit.org/changeset/212940> 1280666 4 commit-queue 2017-02-23 21:29:45 -0800 All reviewed patches have been landed. Closing bug. 302616 2017-02-23 17:30:17 -0800 2017-02-23 21:29:42 -0800 Patch bug-168809-20170223172728.patch text/plain 2513 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyOTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTI3ZGFmMzgyMzg4ZTFl ZTA1YmFlNjQ4N2EyZTRmN2EyMjllMThjYy4uNmEyMDc0OTUwZWFhZmVlMWU5NGZiZTFiOWQyYTFm YTFkNTNmN2NhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTAyLTIzICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW01vZGVybiBNZWRpYSBD b250cm9sc10gU2hvdyAiTG9hZGluZyIgdW50aWwgcGxheWJhY2sgc3RhcnRzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg4MDkKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzMwNjg3NDY4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdlIG5vdyBkaXNwbGF5IHRoZSAiTG9hZGluZyIgc3RhdHVzIGFzIHNv b24gYXMgd2UndmUgc3RhcnRlZCBsb2FkaW5nIGFuZAorICAgICAgICB1bnRpbCB3ZSd2ZSBvYnRh aW5lZCBlbm91Z2ggZGF0YSB0byBwbGF5LiBObyB0ZXN0IHByb3ZpZGVkIHNpbmNlIHdlIGRvbid0 CisgICAgICAgIGhhdmUgYSB3YXkgdG8gc3BlY2lmaWNhbGx5IHNldCBuZXR3b3JrU3RhdGUgYW5k IHJlYWR5U3RhdGUgdG8gdGhlIHNhdGlzZmFjdG9yeQorICAgICAgICB2YWx1ZXMuCisKKyAgICAg ICAgKiBNb2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9tZWRpYS9zdGF0dXMtc3VwcG9ydC5q czoKKyAgICAgICAgKFN0YXR1c1N1cHBvcnQucHJvdG90eXBlLnN5bmNDb250cm9sKToKKyAgICAg ICAgKFN0YXR1c1N1cHBvcnQpOgorCiAyMDE3LTAyLTIzICBBbGV4IENocmlzdGVuc2VuICA8YWNo cmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IGlPUyBXZWJSVEMgYnVpbGQgYWZ0 ZXIgcjIxMjgxMgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVk aWEtY29udHJvbHMvbWVkaWEvc3RhdHVzLXN1cHBvcnQuanMgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9tZWRpYS9zdGF0dXMtc3VwcG9ydC5qcwppbmRleCAy MDZjNzMwMzIzYTUwY2MwMWNkMmRjM2Q5ZjI2MmYyYTM0OTZkZjA0Li4xMTljMzM5MmYwNDRkNGM2 YjYwODdkNmZlNTcxMTIxZGRjMGY5YmIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9tZWRpYS9zdGF0dXMtc3VwcG9ydC5qcworKysgYi9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9tZWRpYS9zdGF0dXMt c3VwcG9ydC5qcwpAQCAtNDIsMTggKzQyLDE4IEBAIGNsYXNzIFN0YXR1c1N1cHBvcnQgZXh0ZW5k cyBNZWRpYUNvbnRyb2xsZXJTdXBwb3J0CiAgICAgewogICAgICAgICBjb25zdCBtZWRpYSA9IHRo aXMubWVkaWFDb250cm9sbGVyLm1lZGlhOwogICAgICAgICBjb25zdCBpc0xpdmVCcm9hZGNhc3Qg PSBtZWRpYS5kdXJhdGlvbiA9PT0gTnVtYmVyLlBPU0lUSVZFX0lORklOSVRZOwotICAgICAgICBj b25zdCBpc1BsYXlhYmxlID0gbWVkaWEucmVhZHlTdGF0ZSA+IEhUTUxNZWRpYUVsZW1lbnQuSEFW RV9NRVRBREFUQSAmJiAhbWVkaWEuZXJyb3I7CisgICAgICAgIGNvbnN0IGNhblBsYXlUaHJvdWdo ID0gbWVkaWEucmVhZHlTdGF0ZSA9PT0gSFRNTE1lZGlhRWxlbWVudC5IQVZFX0VOT1VHSF9EQVRB ICYmICFtZWRpYS5lcnJvcjsKIAogICAgICAgICBpZiAoISFtZWRpYS5lcnJvcikKICAgICAgICAg ICAgIHRoaXMuY29udHJvbC50ZXh0ID0gVUlTdHJpbmcoIkVycm9yIik7CiAgICAgICAgIGVsc2Ug aWYgKGlzTGl2ZUJyb2FkY2FzdCAmJiBtZWRpYS5yZWFkeVN0YXRlID49IEhUTUxNZWRpYUVsZW1l bnQuSEFWRV9DVVJSRU5UX0RBVEEpCiAgICAgICAgICAgICB0aGlzLmNvbnRyb2wudGV4dCA9IFVJ U3RyaW5nKCJMaXZlIEJyb2FkY2FzdCIpOwotICAgICAgICBlbHNlIGlmICghaXNQbGF5YWJsZSAm JiBtZWRpYS5uZXR3b3JrU3RhdGUgPT09IEhUTUxNZWRpYUVsZW1lbnQuTkVUV09SS19MT0FESU5H KQorICAgICAgICBlbHNlIGlmICghY2FuUGxheVRocm91Z2ggJiYgbWVkaWEubmV0d29ya1N0YXRl ID09PSBIVE1MTWVkaWFFbGVtZW50Lk5FVFdPUktfTE9BRElORykKICAgICAgICAgICAgIHRoaXMu Y29udHJvbC50ZXh0ID0gVUlTdHJpbmcoIkxvYWRpbmciKTsKICAgICAgICAgZWxzZQogICAgICAg ICAgICAgdGhpcy5jb250cm9sLnRleHQgPSAiIjsKIAotICAgICAgICB0aGlzLmNvbnRyb2wuZW5h YmxlZCA9IGlzTGl2ZUJyb2FkY2FzdCB8fCAhaXNQbGF5YWJsZTsKKyAgICAgICAgdGhpcy5jb250 cm9sLmVuYWJsZWQgPSBpc0xpdmVCcm9hZGNhc3QgfHwgIWNhblBsYXlUaHJvdWdoOwogICAgIH0K IAogfQo=