168804 2017-02-23 15:03:25 -0800 [CredentialManagement] CredentialManagement API should be on top of SecureContext 2018-01-22 13:19:40 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 158121 167375 1 jiewen_tan webkit-unassigned ajuma bfulgham buildbot cdumez danyao dbates esprehn+autocc jiewen_tan kondapallykalyan sam webkit-bug-importer oldest_to_newest 1280519 0 jiewen_tan 2017-02-23 15:03:25 -0800 CredentialManagement API should be on top of SecureContext according to the spec: https://w3c.github.io/webappsec-credential-management/#interfaces 1280520 1 webkit-bug-importer 2017-02-23 15:04:28 -0800 <rdar://problem/30684315> 1307813 2 309881 danyao 2017-05-12 00:50:23 -0700 Created attachment 309881 Add SecureContext to IDL 1307850 3 309881 dbates 2017-05-12 05:31:49 -0700 Comment on attachment 309881 Add SecureContext to IDL For consistency we should also update the IDL embedded in the existing test <https://trac.webkit.org/browser/webkit/trunk/LayoutTests/credentials/idlharness.html>. 1307874 4 danyao 2017-05-12 08:00:25 -0700 It looks like SecureContext is already added to all interfaces in idlharness.html: https://trac.webkit.org/browser/webkit/trunk/LayoutTests/credentials/idlharness.html#L50 Am I missing something? 1307998 5 309881 sam 2017-05-12 12:37:49 -0700 Comment on attachment 309881 Add SecureContext to IDL I don't think this does anything, as we don't support the SecureContext attribute yet. 1391771 6 jiewen_tan 2018-01-22 13:19:40 -0800 Fixed by changes in Bug 181082. 309881 2017-05-12 00:50:23 -0700 2017-05-12 12:37:49 -0700 Add SecureContext to IDL bug-168804-20170512005022.patch text/plain 2022 danyao U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2NzM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGYwYWUwZTI4OGU1ODEx NTUyOGRjMDY5ZDlhYjhmMWJlMGIzOWQ2OC4uZGRhODIxYjMwYTEzNGE2NzU1YWE4ZjNkODM2ODAz MWY1MGM0OGUxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA1LTEyICBEYW55 YW8gV2FuZyAgPGRhbnlhb0Bnb29nbGUuY29tPgorCisgICAgICAgIFtDcmVkZW50aWFsTWFuYWdl bWVudF0gUHV0IENyZWRlbnRpYWxNYW5hZ2VtZW50IEFQSSBvbiB0b3Agb2YgU2VjdXJlQ29udGV4 dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4ODA0 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMDY4NDMxNT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE1vZHVsZXMvY3JlZGVudGlhbHMvQmFzaWND cmVkZW50aWFsLmlkbDoKKyAgICAgICAgKiBNb2R1bGVzL2NyZWRlbnRpYWxzL1Bhc3N3b3JkQ3Jl ZGVudGlhbC5pZGw6CisKIDIwMTctMDUtMTEgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNv bT4KIAogICAgICAgICBEcm9wIHJlbWFpbmluZyB1c2VzIG9mIFBhc3NSZWZQdHIgaW4gV2ViQ29y ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9jcmVkZW50aWFscy9CYXNpY0Ny ZWRlbnRpYWwuaWRsIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9jcmVkZW50aWFscy9CYXNpY0Ny ZWRlbnRpYWwuaWRsCmluZGV4IDY1NDNmYjQzYzNhY2Y3MTIzMjZlNTU2MmUyOTM3N2QwMzZjOGM5 YzQuLjhhMzNjMWRkZGNlNjRmMTkzMDlhMjlmMzA3ZmRjNDk3ZWZkY2NhMDcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvY3JlZGVudGlhbHMvQmFzaWNDcmVkZW50aWFsLmlkbAor KysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2NyZWRlbnRpYWxzL0Jhc2ljQ3JlZGVudGlhbC5p ZGwKQEAgLTI2LDYgKzI2LDggQEAKIFsKICAgICBJbnRlcmZhY2VOYW1lPUNyZWRlbnRpYWwsCiAg ICAgRW5hYmxlZEF0UnVudGltZT1DcmVkZW50aWFsTWFuYWdlbWVudCwKKyAgICBFeHBvc2VkPVdp bmRvdywKKyAgICBTZWN1cmVDb250ZXh0LAogXSBpbnRlcmZhY2UgQmFzaWNDcmVkZW50aWFsIHsK ICAgICByZWFkb25seSBhdHRyaWJ1dGUgVVNWU3RyaW5nIGlkOwogICAgIHJlYWRvbmx5IGF0dHJp YnV0ZSBET01TdHJpbmcgdHlwZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv Y3JlZGVudGlhbHMvUGFzc3dvcmRDcmVkZW50aWFsLmlkbCBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvY3JlZGVudGlhbHMvUGFzc3dvcmRDcmVkZW50aWFsLmlkbAppbmRleCA4ZjA0ZmEzYzQ1Zjlk NmYwMmRkYjMyMGI5NTg1OWVmOWVmNTdkZTkzLi44OGY0N2Y1YjVmZjJmYzlhMGEzMzkxNjk5YmFj NzRlMTY3ZjQ1MzRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2NyZWRlbnRp YWxzL1Bhc3N3b3JkQ3JlZGVudGlhbC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9j cmVkZW50aWFscy9QYXNzd29yZENyZWRlbnRpYWwuaWRsCkBAIC0zMCw2ICszMCw3IEBAIHR5cGVk ZWYgKERPTUZvcm1EYXRhIG9yIFVSTFNlYXJjaFBhcmFtcykgQ3JlZGVudGlhbEJvZHlUeXBlOwog ICAgIENvbnN0cnVjdG9yKFBhc3N3b3JkQ3JlZGVudGlhbERhdGEgZGF0YSksCiAgICAgQ29uc3Ry dWN0b3IoSFRNTEZvcm1FbGVtZW50IGZvcm0pLAogICAgIEV4cG9zZWQ9V2luZG93LAorICAgIFNl Y3VyZUNvbnRleHQsCiBdIGludGVyZmFjZSBQYXNzd29yZENyZWRlbnRpYWwgOiBTaXRlQm91bmRD cmVkZW50aWFsIHsKICAgICBhdHRyaWJ1dGUgVVNWU3RyaW5nIGlkTmFtZTsKICAgICBhdHRyaWJ1 dGUgVVNWU3RyaW5nIHBhc3N3b3JkTmFtZTsK