168787 2017-02-23 10:58:32 -0800 SpeculativeJIT::compilePutByValForIntTypedArray should only do the constant-folding optimization when the constant passes the type check 2017-02-23 11:49:49 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1280360 0 fpizlo 2017-02-23 10:58:32 -0800 Patch forthcoming. 1280384 1 302543 fpizlo 2017-02-23 11:17:21 -0800 Created attachment 302543 the patch 1280385 2 302543 fpizlo 2017-02-23 11:17:58 -0800 Comment on attachment 302543 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=302543&action=review > Source/JavaScriptCore/ChangeLog:20 > +2017-02-23 Filip Pizlo <fpizlo@apple.com> > + > + Need a short description (OOPS!). > + Need the bug URL (OOPS!). > + > + Reviewed by NOBODY (OOPS!). > + > + * dfg/DFGSpeculativeJIT.cpp: > + (JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray): > + Ooops, I'll remove this. 1280387 3 302543 msaboff 2017-02-23 11:18:54 -0800 Comment on attachment 302543 the patch r=me 1280388 4 302543 mark.lam 2017-02-23 11:19:57 -0800 Comment on attachment 302543 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=302543&action=review r=me > Source/JavaScriptCore/ChangeLog:20 > +2017-02-23 Filip Pizlo <fpizlo@apple.com> > + > + Need a short description (OOPS!). > + Need the bug URL (OOPS!). > + > + Reviewed by NOBODY (OOPS!). > + > + * dfg/DFGSpeculativeJIT.cpp: > + (JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray): > + redundant. 1280391 5 fpizlo 2017-02-23 11:25:25 -0800 (In reply to comment #4) > Comment on attachment 302543 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302543&action=review > > r=me > > > Source/JavaScriptCore/ChangeLog:20 > > +2017-02-23 Filip Pizlo <fpizlo@apple.com> > > + > > + Need a short description (OOPS!). > > + Need the bug URL (OOPS!). > > + > > + Reviewed by NOBODY (OOPS!). > > + > > + * dfg/DFGSpeculativeJIT.cpp: > > + (JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray): > > + > > redundant. Fixed locally! Thanks for the reviews. 1280404 6 fpizlo 2017-02-23 11:49:49 -0800 Landed in https://trac.webkit.org/changeset/212909 302543 2017-02-23 11:17:21 -0800 2017-02-23 11:18:54 -0800 the patch blah.patch text/plain 1978 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjEyOTA1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDE3LTAyLTIzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVQdXRCeVZhbEZvckludFR5cGVkQXJyYXkgc2hvdWxkIG9u bHkgZG8gdGhlIGNvbnN0YW50LWZvbGRpbmcgb3B0aW1pemF0aW9uIHdoZW4gdGhlIGNvbnN0YW50 IHBhc3NlcyB0aGUgdHlwZSBjaGVjaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTY4Nzg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwOgorICAgICAgICAoSlND OjpERkc6OlNwZWN1bGF0aXZlSklUOjpjb21waWxlUHV0QnlWYWxGb3JJbnRUeXBlZEFycmF5KToK KworMjAxNy0wMi0yMyAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgorCisgICAgICAg IE5lZWQgYSBzaG9ydCBkZXNjcmlwdGlvbiAoT09QUyEpLgorICAgICAgICBOZWVkIHRoZSBidWcg VVJMIChPT1BTISkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlNw ZWN1bGF0aXZlSklUOjpjb21waWxlUHV0QnlWYWxGb3JJbnRUeXBlZEFycmF5KToKKwogMjAxNy0w Mi0yMyAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBV bnJldmlld2VkLCBmaXggdGhlIGNsb29wIGJ1aWxkLiBOZWVkZWQgYSAjaWYuCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAkocmV2aXNp b24gMjEyODk4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJ VC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4MTIsOSArMjgxMiwxNyBAQCB2b2lkIFNwZWN1bGF0 aXZlSklUOjpjb21waWxlUHV0QnlWYWxGb3JJCiAjZW5kaWYKIAogICAgIEpJVENvbXBpbGVyOjpK dW1wTGlzdCBzbG93UGF0aENhc2VzOwotCisgICAgCisgICAgYm9vbCBpc0FwcHJvcHJpYXRlQ29u c3RhbnQgPSBmYWxzZTsKICAgICBpZiAodmFsdWVVc2UtPmlzQ29uc3RhbnQoKSkgewogICAgICAg ICBKU1ZhbHVlIGpzVmFsdWUgPSB2YWx1ZVVzZS0+YXNKU1ZhbHVlKCk7CisgICAgICAgIFNwZWN1 bGF0ZWRUeXBlIGV4cGVjdGVkVHlwZSA9IHR5cGVGaWx0ZXJGb3IodmFsdWVVc2UudXNlS2luZCgp KTsKKyAgICAgICAgU3BlY3VsYXRlZFR5cGUgYWN0dWFsVHlwZSA9IHNwZWN1bGF0aW9uRnJvbVZh bHVlKGpzVmFsdWUpOworICAgICAgICBpc0FwcHJvcHJpYXRlQ29uc3RhbnQgPSAoZXhwZWN0ZWRU eXBlIHwgYWN0dWFsVHlwZSkgPT0gZXhwZWN0ZWRUeXBlOworICAgIH0KKworICAgIGlmIChpc0Fw cHJvcHJpYXRlQ29uc3RhbnQpIHsKKyAgICAgICAgSlNWYWx1ZSBqc1ZhbHVlID0gdmFsdWVVc2Ut PmFzSlNWYWx1ZSgpOwogICAgICAgICBpZiAoIWpzVmFsdWUuaXNOdW1iZXIoKSkgewogICAgICAg ICAgICAgdGVybWluYXRlU3BlY3VsYXRpdmVFeGVjdXRpb24oVW5jb3VudGFibGUsIEpTVmFsdWVS ZWdzKCksIDApOwogICAgICAgICAgICAgbm9SZXN1bHQobm9kZSk7Cg==