168779 2017-02-23 08:12:31 -0800 Spell check not updated if moving with caret by modifying the selection 2018-10-23 05:44:58 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 153291 1 tpopela webkit-unassigned cgarcia mcatanzaro mcrha rniwa oldest_to_newest 1280279 0 302512 tpopela 2017-02-23 08:12:31 -0800 Created attachment 302512 test case To describe the problem imagine that you are creating an advanced WYSIWYG editor based on contenteditable. You are modifying the DOM directly (as some of the document's execCommand methods are not sufficient for you) and at some point the spell check for the element is lost. The suggested method (until https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/forceSpellCheck is ready and implemented in WebKit) is to move the caret to the beginning of the element and then by modifying the selection, moving the caret to the end of the element (that's what the attached test case is doing) forces the spell check to be renewed. To speak precisely it forced as after the bug 129024 the spell checking is now done async. Now, if we are moving the caret in a loop then the spell check is scheduled inside Editor::respondToChangedSelection() and we move the caret to the next work, but inside Editor::respondToChangedSelection() the spell check for the current word under caret is skipped as there is an active timer - https://trac.webkit.org/browser/trunk/Source/WebCore/editing/Editor.cpp?rev=212884#L3303. The question is how is the application supposed to refresh the spell check? In Chromium the test case works as expected. In Firefox they are renewing the spell check automatically (if spellcheck="true" is presented). The test case works in WebKit if I add a call to Editor::updateEditorUINowIfScheduled() if the timer is active, but that's not a solution as that's basically reverting the bug 129024. It also works if I'm moving the caret after 1 ms (set through setTimeout()), but that's not a solution as well. Ryosuke do you have any idea (as you are the one who introduced that change)? 1471547 1 mcrha 2018-10-23 05:44:58 -0700 A better option would be to fix bug #48411, because it would avoid the busy-loop which worked in WebKit1. 302512 2017-02-23 08:12:31 -0800 2017-02-23 08:12:31 -0800 test case test_spell_check.html text/html 1502 tpopela PGh0bWw+CiAgPGhlYWQ+CiAgPHNjcmlwdD4KICAgIGZ1bmN0aW9uIHBlcmZvcm1TcGVsbENoZWNr KCkgewogICAgICBzZWxlY3Rpb24gPSB3aW5kb3cuZ2V0U2VsZWN0aW9uKCk7CgogICAgICBlbmRO b2RlID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgic3BhbiIpOwogICAgICBlbmROb2RlLmlubmVy SFRNTCA9ICImIzgyMDM7IjsKICAgICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChlbmROb2Rl KTsKCiAgICAgIHJhbmdlRW5kID0gZG9jdW1lbnQuY3JlYXRlUmFuZ2UoKTsKICAgICAgcmFuZ2VF bmQuc2VsZWN0Tm9kZUNvbnRlbnRzKGVuZE5vZGUpOwogICAgICByYW5nZUVuZC5jb2xsYXBzZSh0 cnVlKTsKCiAgICAgIHNlbGVjdGlvbi5yZW1vdmVBbGxSYW5nZXMoKTsKICAgICAgc2VsZWN0aW9u LmFkZFJhbmdlKHJhbmdlRW5kKTsKCiAgICAgIHNlbGVjdGlvbi5tb2RpZnkoIm1vdmUiLCAiYmFj a3dhcmQiLCAiZG9jdW1lbnRib3VuZGFyeSIpOwoKICAgICAgcmFuZ2VDdXJyZW50ID0gc2VsZWN0 aW9uLmdldFJhbmdlQXQoMCk7CgogICAgICB3aGlsZSAocmFuZ2VDdXJyZW50LmNvbXBhcmVCb3Vu ZGFyeVBvaW50cyhSYW5nZS5TVEFSVF9UT19TVEFSVCwgcmFuZ2VFbmQpIDwgMCkgewogICAgICAg IHNlbGVjdGlvbi5tb2RpZnkoIm1vdmUiLCAiZm9yd2FyZCIsICJ3b3JkIik7CiAgICAgICAgcmFu Z2VDdXJyZW50ID0gc2VsZWN0aW9uLmdldFJhbmdlQXQoMCk7CiAgICAgIH0KCiAgICAgIGVuZE5v ZGUucmVtb3ZlKCk7CiAgICB9CiAgPC9zY3JpcHQ+CiAgPC9oZWFkPgogIDxib2R5IG9ubG9hZD0i cGVyZm9ybVNwZWxsQ2hlY2soKSIgY29udGVudGVkaXRhYmxlIHNwZWxsY2hlY2s9InRydWUiPgog ICAgYXNkZmcgYXNkZiBhc2RnZiBhc2RmIGFzZGYgb25lIHR3byB0aHJlZSBhc2RmIGFzZmQgYXNm ZCBhc2RmIDxicj4KICAgIGFzZGZnIGFzZGYgYXNkZ2YgYXNkZiBhc2RmIG9uZSB0d28gdGhyZWUg YXNkZiBhc2ZkIGFzZmQgYXNkZiA8YnI+CiAgICBhc2RmZyBhc2RmIGFzZGdmIGFzZGYgYXNkZiBv bmUgdHdvIHRocmVlIGFzZGYgYXNmZCBhc2ZkIGFzZGYgPGJyPgogICAgYXNkZmcgYXNkZiBhc2Rn ZiBhc2RmIGFzZGYgb25lIHR3byB0aHJlZSBhc2RmIGFzZmQgYXNmZCBhc2RmIDxicj4KICAgIGFz ZGZnIGFzZGYgYXNkZ2YgYXNkZiBhc2RmIG9uZSB0d28gdGhyZWUgYXNkZiBhc2ZkIGFzZmQgYXNk ZiA8YnI+CiAgICBhc2RmZyBhc2RmIGFzZGdmIGFzZGYgYXNkZiBvbmUgdHdvIHRocmVlIGFzZGYg YXNmZCBhc2ZkIGFzZGYgPGJyPgogICAgYXNkZmcgYXNkZiBhc2RnZiBhc2RmIGFzZGYgb25lIHR3 byB0aHJlZSBhc2RmIGFzZmQgYXNmZCBhc2RmIDxicj4KICAgIGFzZGZnIGFzZGYgYXNkZ2YgYXNk ZiBhc2RmIG9uZSB0d28gdGhyZWUgYXNkZiBhc2ZkIGFzZmQgYXNkZiA8YnI+CiAgICBhc2RmZyBh c2RmIGFzZGdmIGFzZGYgYXNkZiBvbmUgdHdvIHRocmVlIGFzZGYgYXNmZCBhc2ZkIGFzZGYgPGJy PgogIDwvYm9keT4KPC9odG1sPgo=