168778 2017-02-23 08:02:11 -0800 [WebRTC] Outgoing video quality is poor 2017-02-23 17:02:42 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=168802 InRadar P2 Normal --- 1 youennf youennf commit-queue eric.carlson jer.noble webkit-bug-importer oldest_to_newest 1280275 0 youennf 2017-02-23 08:02:11 -0800 Resolution might decrease and latency is progressively adding up 1280276 1 webkit-bug-importer 2017-02-23 08:02:31 -0800 <rdar://problem/30674673> 1280448 2 302562 youennf 2017-02-23 12:59:06 -0800 Created attachment 302562 Patch 1280483 3 302562 eric.carlson 2017-02-23 14:08:18 -0800 Comment on attachment 302562 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302562&action=review > Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h:59 > + int64_t TimeUntilNextProcess() final { return 100000000; } Nit: it would be nice to have a comment here explaining this magic number. 1280493 4 302575 youennf 2017-02-23 14:21:40 -0800 Created attachment 302575 Patch for landing 1280496 5 youennf 2017-02-23 14:23:38 -0800 Thanks for the review. (In reply to comment #3) > Comment on attachment 302562 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302562&action=review > > > Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h:59 > > + int64_t TimeUntilNextProcess() final { return 100000000; } > > Nit: it would be nice to have a comment here explaining this magic number. Done 1280574 6 302575 commit-queue 2017-02-23 17:02:38 -0800 Comment on attachment 302575 Patch for landing Clearing flags on attachment: 302575 Committed r212931: <http://trac.webkit.org/changeset/212931> 1280575 7 commit-queue 2017-02-23 17:02:42 -0800 All reviewed patches have been landed. Closing bug. 302562 2017-02-23 12:59:06 -0800 2017-02-23 14:21:37 -0800 Patch bug-168778-20170223125618.patch text/plain 1781 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyODQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjlmYjlhNDk2NmIxMWFi OGFiNWZjNTI3M2I4Yzk3NThlN2NlYmU0My4uMzg4NmY2M2I3ODRhYWExYmJmNTI5NDUyNWYyY2Vl MmY2NThmNGNmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAyLTIzICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViUlRDXSBPdXRnb2lu ZyB2aWRlbyBxdWFsaXR5IGlzIHBvb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2ODc3OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzA2NzQ2NzM+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJl ZCBieSBtYW51YWxseSBlbnN1cmluZyB0aGUgdm9pY2UgcHJvY2VzcyB0aHJlYWQgaXMgbm90IHNw aW5uaW5nLgorCisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldl YlJUQ0F1ZGlvTW9kdWxlLmg6IFNldHRpbmcgdGhlIG5leHQgY2FsbCB0byBtYXggd2FzIG5vdCBh IGdvb2QgaWRlYSBzaW5jZSB0aGUgdGhyZWFkIHByb2Nlc3MgaXMgYWRkaW5nIHNvbWUgdmFsdWUg dG8gaXQsIG1ha2luZyBpdCBhIG5lZ2F0aXZlIHZhbHVlLgorCiAyMDE3LTAyLTIyICBZb3Vlbm4g RmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViUlRDXSBEaXNhYmxlIGxp YndlYnJ0YyBzdGRlcnIgbG9nZ2luZyBpbiByZWxlYXNlIG1vZGUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENBdWRpb01v ZHVsZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xp YldlYlJUQ0F1ZGlvTW9kdWxlLmgKaW5kZXggOTU5ODg2MDlkMTc4ZTU2MzY5MTU5YjM1MjYzMmVl YzFlYmI5NzlmYy4uMGVkN2U2NjNhY2Y3YWVhNGFjODI5MDRhNjBiZWRjYTMxZDM0NGZhYSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xp YldlYlJUQ0F1ZGlvTW9kdWxlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFz dHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0F1ZGlvTW9kdWxlLmgKQEAgLTU2LDcgKzU2LDcgQEAg cHJpdmF0ZToKICAgICBpbnQzMl90IFJlZ2lzdGVyQXVkaW9DYWxsYmFjayh3ZWJydGM6OkF1ZGlv VHJhbnNwb3J0KikgZmluYWw7CiAgICAgYm9vbCBQbGF5aW5nKCkgY29uc3QgZmluYWwgeyByZXR1 cm4gbV9pc1BsYXlpbmc7IH0KIAotICAgIGludDY0X3QgVGltZVVudGlsTmV4dFByb2Nlc3MoKSBm aW5hbCB7IHJldHVybiBzdGQ6Om51bWVyaWNfbGltaXRzPGludDY0X3Q+OjptYXgoKTsgfQorICAg IGludDY0X3QgVGltZVVudGlsTmV4dFByb2Nlc3MoKSBmaW5hbCB7IHJldHVybiAxMDAwMDAwMDA7 IH0KICAgICB2b2lkIFByb2Nlc3MoKSBmaW5hbCB7IH0KICAgICBpbnQzMl90IEFjdGl2ZUF1ZGlv TGF5ZXIoQXVkaW9MYXllciopIGNvbnN0IGZpbmFsIHsgcmV0dXJuIHNob3VsZE5vdEJlQ2FsbGVk KC0xKTsgfQogICAgIEVycm9yQ29kZSBMYXN0RXJyb3IoKSBjb25zdCBmaW5hbCB7IHJldHVybiBr QWRtRXJyTm9uZTsgfQo= 302575 2017-02-23 14:21:40 -0800 2017-02-23 17:02:38 -0800 Patch for landing bug-168778-20170223141852.patch text/plain 1932 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyOTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTc5ZjFjZmQ0NjY3ZjI4 OTIzMzM1YjhlOWI0NjQxYjk0MmRiYjc0My4uZGUzY2I1ODgzZDMyZTJiZDg0ZmFhZjMzYTA0ZTkx ZWE1NmQ4YTRmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAyLTIzICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViUlRDXSBPdXRnb2lu ZyB2aWRlbyBxdWFsaXR5IGlzIHBvb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2ODc3OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzA2NzQ2NzM+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBDYXJsc29uLgorCisgICAgICAgIENvdmVyZWQg YnkgbWFudWFsbHkgZW5zdXJpbmcgdGhlIHZvaWNlIHByb2Nlc3MgdGhyZWFkIGlzIG5vdCBzcGlu bmluZy4KKworICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJS VENBdWRpb01vZHVsZS5oOiBTZXR0aW5nIHRoZSBuZXh0IGNhbGwgdG8gbWF4IHdhcyBub3QgYSBn b29kIGlkZWEgc2luY2UgdGhlIHRocmVhZCBwcm9jZXNzIGlzIGFkZGluZyBzb21lIHZhbHVlIHRv IGl0LCBtYWtpbmcgaXQgYSBuZWdhdGl2ZSB2YWx1ZS4KKwogMjAxNy0wMi0yMyAgQ2hyaXMgRHVt ZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFJlcG9ydCBkb21haW5zIHVzaW5nIGFi bm9ybWFsbHkgaGlnaCBDUFUgdXNhZ2UgdmlhIGVuaGFuY2VkIHByaXZhY3kgbG9nZ2luZwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xp YldlYlJUQ0F1ZGlvTW9kdWxlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVh bS9saWJ3ZWJydGMvTGliV2ViUlRDQXVkaW9Nb2R1bGUuaAppbmRleCA5NTk4ODYwOWQxNzhlNTYz NjkxNTliMzUyNjMyZWVjMWViYjk3OWZjLi4zMzI0MmZlYzE5ZDUzZjQwYzBlOTE1Njg2NzJmMWZh NzQ1YzA4NTBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVh bS9saWJ3ZWJydGMvTGliV2ViUlRDQXVkaW9Nb2R1bGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDQXVkaW9Nb2R1bGUuaApAQCAt NTYsNyArNTYsOCBAQCBwcml2YXRlOgogICAgIGludDMyX3QgUmVnaXN0ZXJBdWRpb0NhbGxiYWNr KHdlYnJ0Yzo6QXVkaW9UcmFuc3BvcnQqKSBmaW5hbDsKICAgICBib29sIFBsYXlpbmcoKSBjb25z dCBmaW5hbCB7IHJldHVybiBtX2lzUGxheWluZzsgfQogCi0gICAgaW50NjRfdCBUaW1lVW50aWxO ZXh0UHJvY2VzcygpIGZpbmFsIHsgcmV0dXJuIHN0ZDo6bnVtZXJpY19saW1pdHM8aW50NjRfdD46 Om1heCgpOyB9CisgICAgLy8gU2V0IGl0IHRvIGEgYmlnIHZhbHVlIHNvIHRoYXQgd2UgYXJlIG5v dCBjYWxsZWQgb2Z0ZW4gYnV0IG5vdCBjbG9zZSB0byBpbnQ2NF90IG1heCBzbyB0aGF0IGl0IGRv ZXMgbm90IGNyZWF0ZSBpbnRlZ2VyIG92ZXJmbG93cy4KKyAgICBpbnQ2NF90IFRpbWVVbnRpbE5l eHRQcm9jZXNzKCkgZmluYWwgeyByZXR1cm4gMTAwMDAwMDAwOyB9CiAgICAgdm9pZCBQcm9jZXNz KCkgZmluYWwgeyB9CiAgICAgaW50MzJfdCBBY3RpdmVBdWRpb0xheWVyKEF1ZGlvTGF5ZXIqKSBj b25zdCBmaW5hbCB7IHJldHVybiBzaG91bGROb3RCZUNhbGxlZCgtMSk7IH0KICAgICBFcnJvckNv ZGUgTGFzdEVycm9yKCkgY29uc3QgZmluYWwgeyByZXR1cm4ga0FkbUVyck5vbmU7IH0K