168745 2017-02-22 14:40:02 -0800 Add GTK+ build instruction to ReadMe.md 2017-02-22 20:45:33 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa webkit-unassigned lforschler oldest_to_newest 1280057 0 rniwa 2017-02-22 14:40:02 -0800 Add instructions now that I know you just need to run two commands. 1280058 1 302445 rniwa 2017-02-22 14:42:20 -0800 Created attachment 302445 Patch 1280062 2 302446 rniwa 2017-02-22 14:45:18 -0800 Created attachment 302446 Did more cleanup 1280164 3 302446 mcatanzaro 2017-02-22 19:28:39 -0800 Comment on attachment 302446 Did more cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=302446&action=review > ReadMe.md:90 > +*Note*: To build and run GTK+ port, you need a Git checkout, not a Subversion checkout. Well I assume SVN would work just as well; there's nothing port-specific about it. So I would just remove this sentence. I guess our BuildingGtk page doesn't mention SVN because we figure there's no way anybody outside Apple would ever want to use SVN when git is available. We really, really don't understand why you still use it. :P > ReadMe.md:97 > +Then run the following command to build those dependencies: "those" -> "additional" > ReadMe.md:108 > +For more information, see the [wiki page](https://trac.webkit.org/wiki/BuildingGtk). I would add one sentence here: "Note that the procedure for building release tarballs is different. For more information..." 1280181 4 rniwa 2017-02-22 20:45:33 -0800 Committed r212875: <http://trac.webkit.org/changeset/212875> 302445 2017-02-22 14:42:20 -0800 2017-02-22 14:45:18 -0800 Patch fix168745.patch text/plain 2498 rniwa SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDIxMjg1 NCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTAy LTIyICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBHVEsr IGJ1aWxkIGluc3RydWN0aW9uIHRvIFJlYWRNZS5tZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4NzQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGluc3RydWN0aW9ucyB0byBidWlsZCBHVEsrIHBv cnQuCisKKyAgICAgICAgUmVtb3ZlZCB0aGUgaW5zdHJ1Y3Rpb24gdG8gc2V0IHRoZSBkZWZhdWx0 IGNvbmZpZ3VyYXRpb24gc2luY2UgdGhhdCBkaWRuJ3Qgc2VlbSBpbXBvcnRhbnQuCisKKyAgICAg ICAgKiBSZWFkTWUubWQ6CisKIDIwMTctMDItMjIgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdh bGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBbMi4xNS45MF0gRGlzYWJsZSBSRVNPVVJDRV9VU0FH RSBvbiBub24tTGludXggc3lzdGVtcwpJbmRleDogUmVhZE1lLm1kCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFJl YWRNZS5tZAkocmV2aXNpb24gMjEyODUyKQorKysgUmVhZE1lLm1kCSh3b3JraW5nIGNvcHkpCkBA IC01MSw3ICs1MSw2IEBACiBUaGUgZm9sbG93aW5nIGluc3RydWN0aW9ucyBhcmUgZm9yIGJ1aWxk aW5nIFdlYktpdCBvbiBNYWMuIEZvciBvdGhlciBwb3J0cywgZm9sbG93IHRoZXNlIGluc3RydWN0 aW9ucyBvbiBvdXIgd2Vic2l0ZToKIAogKiBbV2luZG93c10oaHR0cHM6Ly93ZWJraXQub3JnL3dl YmtpdC1vbi13aW5kb3dzLykKLSogW0dUSytdKGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL3dpa2kv QnVpbGRpbmdHdGspCiAKICMjIyBCdWlsZGluZyBNYWMgUG9ydAogCkBAIC03NCw3ICs3Myw3IEBA CiAKIElmIHlvdSBkb24ndCB1c2UgYSBjdXN0b20gYnVpbGQgbG9jYXRpb24gaW4gWGNvZGUgcHJl ZmVyZW5jZXMsIHlvdSBoYXZlIHRvIHVwZGF0ZSB0aGUgd29ya3NwYWNlIHNldHRpbmdzIHRvIHVz ZSBgV2ViS2l0QnVpbGRgIGRpcmVjdG9yeS4gIEluIG1lbnUgYmFyLCBjaG9vc2UgRmlsZSA+IFdv cmtzcGFjZSBTZXR0aW5ncywgdGhlbiBjbGljayB0aGUgQWR2YW5jZWQgYnV0dG9uLCBzZWxlY3Qg IkN1c3RvbSIsICJSZWxhdGl2ZSB0byBXb3Jrc3BhY2UiLCBhbmQgZW50ZXIgYFdlYktpdEJ1aWxk YCBmb3IgYm90aCBQcm9kdWN0cyBhbmQgSW50ZXJtZWRpYXRlcy4KIAotIyMjIEJ1aWxkaW5nICBp T1MgUG9ydAorIyMjIEJ1aWxkaW5nIGlPUyBQb3J0CiAKIFRoZSBmaXJzdCB0aW1lIGFmdGVyIHlv dSBpbnN0YWxsIGEgbmV3IFhjb2RlLCB5b3Ugd2lsbCBuZWVkIHRvIHJ1biB0aGUgZm9sbG93aW5n IGNvbW1hbmQgdG8gZW5hYmxlIFhjb2RlIHRvIGJ1aWxkIGNvbW1hbmQgbGluZSB0b29scyBmb3Ig aU9TIFNpbXVsYXRvcjoKIApAQCAtOTAsMTMgKzg5LDI4IEBACiBUb29scy9TY3JpcHRzL2J1aWxk LXdlYmtpdCAtLWRlYnVnIC0taW9zLXNpbXVsYXRvci4KIGBgYAogCi1Zb3UgY2FuIGFsc28gY2hh bmdlIHRoZSBkZWZhdWx0IGJ1aWxkIGNvbmZpZ3VyYXRpb24gdXNpbmcgdGhlIGZvbGxvd2luZyBj b21tYW5kczoKKyMjIyBCdWlsZGluZyBHVEsrIFBvcnQKIAorKk5vdGUqOiBUbyBidWlsZCBhbmQg cnVuIEdUSysgcG9ydCwgeW91IG5lZWQgYSBHaXQgY2hlY2tvdXQsIG5vdCBhIFN1YnZlcnNpb24g Y2hlY2tvdXQuCisKK0luc3RhbGwgdGhlIGRlcGVuZGVuY2llcyBieSBydW5uaW5nIHRoZSBmb2xs b3dpbmcgY29tbWFuZDoKIGBgYAotVG9vbHMvU2NyaXB0cy9zZXQtd2Via2l0LWNvbmZpZ3VyYXRp b24gLS1kZWJ1ZwotVG9vbHMvU2NyaXB0cy9zZXQtd2Via2l0LWNvbmZpZ3VyYXRpb24gLS1yZWxl YXNlCitUb29scy9ndGsvaW5zdGFsbC1kZXBlbmRlbmNpZXMKIGBgYAogCitUaGVuIHJ1biB0aGUg Zm9sbG93aW5nIGNvbW1hbmQgdG8gYnVpbGQgdGhvc2UgZGVwZW5kZW5jaWVzOgorYGBgCitUb29s cy9TY3JpcHRzL3VwZGF0ZS13ZWJraXRndGstbGlicworYGBgCisKK1J1biB0aGUgZm9sbG93aW5n IGNvbW1hbmQgdG8gYnVpbGQgV2ViS2l0IHdpdGggZGVidWdnaW5nIHN5bWJvbHMgZm9yIEdUSysg cG9ydDoKKworYGBgCitUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCAtLWRlYnVnIC0tZ3RrLgor YGBgCisKK0ZvciBtb3JlIGluZm9ybWF0aW9uLCBzZWUgdGhlIFt3aWtpIHBhZ2VdKGh0dHBzOi8v dHJhYy53ZWJraXQub3JnL3dpa2kvQnVpbGRpbmdHdGspLgorCiAjIyBSdW5uaW5nIFdlYktpdAog CiAjIyMgV2l0aCBTYWZhcmkgYW5kIE90aGVyIG1hY09TIEFwcGxpY2F0aW9ucwo= 302446 2017-02-22 14:45:18 -0800 2017-02-22 19:28:39 -0800 Did more cleanup fix168745b.patch text/plain 2721 rniwa SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDIxMjg1 NCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTAy LTIyICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBHVEsr IGJ1aWxkIGluc3RydWN0aW9uIHRvIFJlYWRNZS5tZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4NzQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGluc3RydWN0aW9ucyB0byBidWlsZCBHVEsrIHBv cnQuCisKKyAgICAgICAgUmVtb3ZlZCB0aGUgaW5zdHJ1Y3Rpb24gdG8gc2V0IHRoZSBkZWZhdWx0 IGNvbmZpZ3VyYXRpb24gc2luY2UgdGhhdCBkaWRuJ3Qgc2VlbSBpbXBvcnRhbnQuCisKKyAgICAg ICAgKiBSZWFkTWUubWQ6CisKIDIwMTctMDItMjIgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdh bGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBbMi4xNS45MF0gRGlzYWJsZSBSRVNPVVJDRV9VU0FH RSBvbiBub24tTGludXggc3lzdGVtcwpJbmRleDogUmVhZE1lLm1kCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFJl YWRNZS5tZAkocmV2aXNpb24gMjEyODUyKQorKysgUmVhZE1lLm1kCSh3b3JraW5nIGNvcHkpCkBA IC00OCwxMSArNDgsNiBAQAogCiAjIyBCdWlsZGluZyBXZWJLaXQKIAotVGhlIGZvbGxvd2luZyBp bnN0cnVjdGlvbnMgYXJlIGZvciBidWlsZGluZyBXZWJLaXQgb24gTWFjLiBGb3Igb3RoZXIgcG9y dHMsIGZvbGxvdyB0aGVzZSBpbnN0cnVjdGlvbnMgb24gb3VyIHdlYnNpdGU6Ci0KLSogW1dpbmRv d3NdKGh0dHBzOi8vd2Via2l0Lm9yZy93ZWJraXQtb24td2luZG93cy8pCi0qIFtHVEsrXShodHRw czovL3RyYWMud2Via2l0Lm9yZy93aWtpL0J1aWxkaW5nR3RrKQotCiAjIyMgQnVpbGRpbmcgTWFj IFBvcnQKIAogSW5zdGFsbCBYY29kZSBhbmQgaXRzIGNvbW1hbmQgbGluZSB0b29scyBpZiB5b3Ug aGF2ZW4ndCBkb25lIHNvIGFscmVhZHk6CkBAIC03NCw3ICs2OSw3IEBACiAKIElmIHlvdSBkb24n dCB1c2UgYSBjdXN0b20gYnVpbGQgbG9jYXRpb24gaW4gWGNvZGUgcHJlZmVyZW5jZXMsIHlvdSBo YXZlIHRvIHVwZGF0ZSB0aGUgd29ya3NwYWNlIHNldHRpbmdzIHRvIHVzZSBgV2ViS2l0QnVpbGRg IGRpcmVjdG9yeS4gIEluIG1lbnUgYmFyLCBjaG9vc2UgRmlsZSA+IFdvcmtzcGFjZSBTZXR0aW5n cywgdGhlbiBjbGljayB0aGUgQWR2YW5jZWQgYnV0dG9uLCBzZWxlY3QgIkN1c3RvbSIsICJSZWxh dGl2ZSB0byBXb3Jrc3BhY2UiLCBhbmQgZW50ZXIgYFdlYktpdEJ1aWxkYCBmb3IgYm90aCBQcm9k dWN0cyBhbmQgSW50ZXJtZWRpYXRlcy4KIAotIyMjIEJ1aWxkaW5nICBpT1MgUG9ydAorIyMjIEJ1 aWxkaW5nIGlPUyBQb3J0CiAKIFRoZSBmaXJzdCB0aW1lIGFmdGVyIHlvdSBpbnN0YWxsIGEgbmV3 IFhjb2RlLCB5b3Ugd2lsbCBuZWVkIHRvIHJ1biB0aGUgZm9sbG93aW5nIGNvbW1hbmQgdG8gZW5h YmxlIFhjb2RlIHRvIGJ1aWxkIGNvbW1hbmQgbGluZSB0b29scyBmb3IgaU9TIFNpbXVsYXRvcjoK IApAQCAtOTAsMTMgKzg1LDMyIEBACiBUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCAtLWRlYnVn IC0taW9zLXNpbXVsYXRvci4KIGBgYAogCi1Zb3UgY2FuIGFsc28gY2hhbmdlIHRoZSBkZWZhdWx0 IGJ1aWxkIGNvbmZpZ3VyYXRpb24gdXNpbmcgdGhlIGZvbGxvd2luZyBjb21tYW5kczoKKyMjIyBC dWlsZGluZyBHVEsrIFBvcnQKIAorKk5vdGUqOiBUbyBidWlsZCBhbmQgcnVuIEdUSysgcG9ydCwg eW91IG5lZWQgYSBHaXQgY2hlY2tvdXQsIG5vdCBhIFN1YnZlcnNpb24gY2hlY2tvdXQuCisKK0lu c3RhbGwgdGhlIGRlcGVuZGVuY2llcyBieSBydW5uaW5nIHRoZSBmb2xsb3dpbmcgY29tbWFuZDoK IGBgYAotVG9vbHMvU2NyaXB0cy9zZXQtd2Via2l0LWNvbmZpZ3VyYXRpb24gLS1kZWJ1ZwotVG9v bHMvU2NyaXB0cy9zZXQtd2Via2l0LWNvbmZpZ3VyYXRpb24gLS1yZWxlYXNlCitUb29scy9ndGsv aW5zdGFsbC1kZXBlbmRlbmNpZXMKIGBgYAogCitUaGVuIHJ1biB0aGUgZm9sbG93aW5nIGNvbW1h bmQgdG8gYnVpbGQgdGhvc2UgZGVwZW5kZW5jaWVzOgorYGBgCitUb29scy9TY3JpcHRzL3VwZGF0 ZS13ZWJraXRndGstbGlicworYGBgCisKK1J1biB0aGUgZm9sbG93aW5nIGNvbW1hbmQgdG8gYnVp bGQgV2ViS2l0IHdpdGggZGVidWdnaW5nIHN5bWJvbHMgZm9yIEdUSysgcG9ydDoKKworYGBgCitU b29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCAtLWRlYnVnIC0tZ3RrLgorYGBgCisKK0ZvciBtb3Jl IGluZm9ybWF0aW9uLCBzZWUgdGhlIFt3aWtpIHBhZ2VdKGh0dHBzOi8vdHJhYy53ZWJraXQub3Jn L3dpa2kvQnVpbGRpbmdHdGspLgorCisjIyMgQnVpbGRpbmcgV2luZG93cyBQb3J0CisKK0ZvciBi dWlsZGluZyBXZWJLaXQgb24gV2luZG93cywgc2VlIHRoZSBbd2lraSBwYWdlXShodHRwczovL3dl YmtpdC5vcmcvd2Via2l0LW9uLXdpbmRvd3MvKS4KKwogIyMgUnVubmluZyBXZWJLaXQKIAogIyMj IFdpdGggU2FmYXJpIGFuZCBPdGhlciBtYWNPUyBBcHBsaWNhdGlvbnMK