168742 2017-02-22 13:48:01 -0800 Replace SimpleLineLayout::Range by WTF::IteratorRange 2017-02-22 15:57:26 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned bfulgham commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser zalan oldest_to_newest 1280031 0 koivisto 2017-02-22 13:48:01 -0800 Kill the custom type. 1280033 1 302436 koivisto 2017-02-22 13:49:21 -0800 Created attachment 302436 patch 1280093 2 302436 commit-queue 2017-02-22 15:57:22 -0800 Comment on attachment 302436 patch Clearing flags on attachment: 302436 Committed r212860: <http://trac.webkit.org/changeset/212860> 1280094 3 commit-queue 2017-02-22 15:57:26 -0800 All reviewed patches have been landed. Closing bug. 302436 2017-02-22 13:49:21 -0800 2017-02-22 15:57:22 -0800 patch simpleline-range.patch text/plain 6578 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMjg0OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE3LTAyLTIyICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSZXBsYWNlIFNpbXBsZUxpbmVM YXlvdXQ6OlJhbmdlIGJ5IFdURjo6SXRlcmF0b3JSYW5nZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4NzQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgS2lsbCBhIHJlZHVuZGFudCBjdXN0b20gdHlwZS4K KworICAgICAgICAqIHJlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0UmVzb2x2ZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6U2ltcGxlTGluZUxheW91dDo6UnVuUmVzb2x2ZXI6OnJhbmdlRm9yUmVj dCk6CisgICAgICAgIChXZWJDb3JlOjpTaW1wbGVMaW5lTGF5b3V0OjpSdW5SZXNvbHZlcjo6cmFu Z2VGb3JSZW5kZXJlcik6CisgICAgICAgIChXZWJDb3JlOjpTaW1wbGVMaW5lTGF5b3V0OjpSdW5S ZXNvbHZlcjo6cmFuZ2VGb3JSZW5kZXJlcldpdGhPZmZzZXRzKToKKyAgICAgICAgKiByZW5kZXJp bmcvU2ltcGxlTGluZUxheW91dFJlc29sdmVyLmg6CisgICAgICAgIChXZWJDb3JlOjpTaW1wbGVM aW5lTGF5b3V0OjpMaW5lUmVzb2x2ZXI6OnJhbmdlRm9yUmVjdCk6CisgICAgICAgIChXZWJDb3Jl OjpTaW1wbGVMaW5lTGF5b3V0OjpSYW5nZTo6UmFuZ2UpOiBEZWxldGVkLgorICAgICAgICAoV2Vi Q29yZTo6U2ltcGxlTGluZUxheW91dDo6UmFuZ2U6OmJlZ2luKTogRGVsZXRlZC4KKyAgICAgICAg KFdlYkNvcmU6OlNpbXBsZUxpbmVMYXlvdXQ6OlJhbmdlOjplbmQpOiBEZWxldGVkLgorCiAyMDE3 LTAyLTIyICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2Vi UlRDXSBEaXNhYmxlIGxpYndlYnJ0YyBzdGRlcnIgbG9nZ2luZyBpbiByZWxlYXNlIG1vZGUKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0UmVzb2x2ZXIuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0 UmVzb2x2ZXIuY3BwCShyZXZpc2lvbiAyMTI4MjgpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvU2ltcGxlTGluZUxheW91dFJlc29sdmVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQ1LDI3 ICsxNDUsMjcgQEAgdW5zaWduZWQgUnVuUmVzb2x2ZXI6OmxpbmVJbmRleEZvckhlaWdodAogICAg IHJldHVybiBzdGQ6Om1pbjx1bnNpZ25lZD4oeSAvIG1fbGluZUhlaWdodCwgbV9sYXlvdXQubGlu ZUNvdW50KCkgLSAxKTsKIH0KIAotUmFuZ2U8UnVuUmVzb2x2ZXI6Okl0ZXJhdG9yPiBSdW5SZXNv bHZlcjo6cmFuZ2VGb3JSZWN0KGNvbnN0IExheW91dFJlY3QmIHJlY3QpIGNvbnN0CitXVEY6Okl0 ZXJhdG9yUmFuZ2U8UnVuUmVzb2x2ZXI6Okl0ZXJhdG9yPiBSdW5SZXNvbHZlcjo6cmFuZ2VGb3JS ZWN0KGNvbnN0IExheW91dFJlY3QmIHJlY3QpIGNvbnN0CiB7IAogICAgIGlmICghbV9saW5lSGVp Z2h0KQotICAgICAgICByZXR1cm4gUmFuZ2U8SXRlcmF0b3I+KGJlZ2luKCksIGVuZCgpKTsKKyAg ICAgICAgcmV0dXJuIHsgYmVnaW4oKSwgZW5kKCkgfTsKIAogICAgIHVuc2lnbmVkIGZpcnN0TGlu ZSA9IGxpbmVJbmRleEZvckhlaWdodChyZWN0LnkoKSwgSW5kZXhUeXBlOjpGaXJzdCk7CiAgICAg dW5zaWduZWQgbGFzdExpbmUgPSBzdGQ6Om1heChmaXJzdExpbmUsIGxpbmVJbmRleEZvckhlaWdo dChyZWN0Lm1heFkoKSwgSW5kZXhUeXBlOjpMYXN0KSk7CiAKICAgICBhdXRvIHJhbmdlQmVnaW4g PSBiZWdpbigpLmFkdmFuY2VMaW5lcyhmaXJzdExpbmUpOwogICAgIGlmIChyYW5nZUJlZ2luID09 IGVuZCgpKQotICAgICAgICByZXR1cm4gUmFuZ2U8SXRlcmF0b3I+KGVuZCgpLCBlbmQoKSk7Cisg ICAgICAgIHJldHVybiB7IGVuZCgpLCBlbmQoKSB9OwogICAgIGF1dG8gcmFuZ2VFbmQgPSByYW5n ZUJlZ2luOwogICAgIEFTU0VSVChsYXN0TGluZSA+PSBmaXJzdExpbmUpOwogICAgIHJhbmdlRW5k LmFkdmFuY2VMaW5lcyhsYXN0TGluZSAtIGZpcnN0TGluZSArIDEpOwotICAgIHJldHVybiBSYW5n ZTxJdGVyYXRvcj4ocmFuZ2VCZWdpbiwgcmFuZ2VFbmQpOworICAgIHJldHVybiB7IHJhbmdlQmVn aW4sIHJhbmdlRW5kIH07CiB9CiAKLVJhbmdlPFJ1blJlc29sdmVyOjpJdGVyYXRvcj4gUnVuUmVz b2x2ZXI6OnJhbmdlRm9yUmVuZGVyZXIoY29uc3QgUmVuZGVyT2JqZWN0JiByZW5kZXJlcikgY29u c3QKK1dURjo6SXRlcmF0b3JSYW5nZTxSdW5SZXNvbHZlcjo6SXRlcmF0b3I+IFJ1blJlc29sdmVy OjpyYW5nZUZvclJlbmRlcmVyKGNvbnN0IFJlbmRlck9iamVjdCYgcmVuZGVyZXIpIGNvbnN0CiB7 CiAgICAgaWYgKGJlZ2luKCkgPT0gZW5kKCkpCi0gICAgICAgIHJldHVybiBSYW5nZTxJdGVyYXRv cj4oZW5kKCksIGVuZCgpKTsKKyAgICAgICAgcmV0dXJuIHsgZW5kKCksIGVuZCgpIH07CiAgICAg Rmxvd0NvbnRlbnRzOjpJdGVyYXRvciBzZWdtZW50ID0gbV9mbG93Q29udGVudHMuYmVnaW4oKTsK ICAgICBhdXRvIHJ1biA9IGJlZ2luKCk7CiAgICAgQVNTRVJUKHNlZ21lbnQtPnN0YXJ0IDw9ICgq cnVuKS5zdGFydCgpKTsKQEAgLTE4Myw3ICsxODMsNyBAQCBSYW5nZTxSdW5SZXNvbHZlcjo6SXRl cmF0b3I+IFJ1blJlc29sdmVyCiAgICAgLy8gRG8gd2UgYWN0dWFsbHkgaGF2ZSBhIHJ1biBmb3Ig dGhpcyByZW5kZXJlcj8KICAgICAvLyBDb2xsYXBzZWQgd2hpdGVzcGFjZSB3aXRoIGRlZGljYXRl ZCByZW5kZXJlciBjb3VsZCBlbmQgdXAgd2l0aCBubyBydW4gYXQgYWxsLgogICAgIGlmIChydW4g PT0gZW5kKCkgfHwgKHNlZ21lbnQtPnN0YXJ0ICE9IHNlZ21lbnQtPmVuZCAmJiBzZWdtZW50LT5l bmQgPD0gKCpydW4pLnN0YXJ0KCkpKQotICAgICAgICByZXR1cm4gUmFuZ2U8SXRlcmF0b3I+KGVu ZCgpLCBlbmQoKSk7CisgICAgICAgIHJldHVybiB7IGVuZCgpLCBlbmQoKSB9OwogCiAgICAgYXV0 byByYW5nZUJlZ2luID0gcnVuOwogICAgIC8vIE1vdmUgYmV5b25kIHRoZSBlbmQgb2YgdGhlIHNl Z21lbnQuCkBAIC0xOTIsNyArMTkyLDcgQEAgUmFuZ2U8UnVuUmVzb2x2ZXI6Okl0ZXJhdG9yPiBS dW5SZXNvbHZlcgogICAgIC8vIFNwZWNpYWwgY2FzZSB3aGVuIHNlZ21lbnQgPT0gcnVuLgogICAg IGlmIChydW4gPT0gcmFuZ2VCZWdpbikKICAgICAgICAgKytydW47Ci0gICAgcmV0dXJuIFJhbmdl PEl0ZXJhdG9yPihyYW5nZUJlZ2luLCBydW4pOworICAgIHJldHVybiB7IHJhbmdlQmVnaW4sIHJ1 biB9OwogfQogCiBSdW5SZXNvbHZlcjo6SXRlcmF0b3IgUnVuUmVzb2x2ZXI6OnJ1bkZvclBvaW50 KGNvbnN0IExheW91dFBvaW50JiBwb2ludCkgY29uc3QKQEAgLTIxOSw3ICsyMTksNyBAQCBSdW5S ZXNvbHZlcjo6SXRlcmF0b3IgUnVuUmVzb2x2ZXI6OnJ1bkZvCiAgICAgcmV0dXJuIC0taXQ7CiB9 CiAKLVJhbmdlPFJ1blJlc29sdmVyOjpJdGVyYXRvcj4gUnVuUmVzb2x2ZXI6OnJhbmdlRm9yUmVu ZGVyZXJXaXRoT2Zmc2V0cyhjb25zdCBSZW5kZXJPYmplY3QmIHJlbmRlcmVyLCB1bnNpZ25lZCBz dGFydE9mZnNldCwgdW5zaWduZWQgZW5kT2Zmc2V0KSBjb25zdAorV1RGOjpJdGVyYXRvclJhbmdl PFJ1blJlc29sdmVyOjpJdGVyYXRvcj4gUnVuUmVzb2x2ZXI6OnJhbmdlRm9yUmVuZGVyZXJXaXRo T2Zmc2V0cyhjb25zdCBSZW5kZXJPYmplY3QmIHJlbmRlcmVyLCB1bnNpZ25lZCBzdGFydE9mZnNl dCwgdW5zaWduZWQgZW5kT2Zmc2V0KSBjb25zdAogewogICAgIEFTU0VSVChzdGFydE9mZnNldCA8 PSBlbmRPZmZzZXQpOwogICAgIGF1dG8gcmFuZ2UgPSByYW5nZUZvclJlbmRlcmVyKHJlbmRlcmVy KTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0UmVzb2x2 ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvU2ltcGxlTGluZUxh eW91dFJlc29sdmVyLmgJKHJldmlzaW9uIDIxMjgyOCkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9TaW1wbGVMaW5lTGF5b3V0UmVzb2x2ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMjksMjQg KzI5LDEyIEBACiAjaW5jbHVkZSAiUmVuZGVyQmxvY2tGbG93LmgiCiAjaW5jbHVkZSAiU2ltcGxl TGluZUxheW91dEZsb3dDb250ZW50cy5oIgogI2luY2x1ZGUgIlNpbXBsZUxpbmVMYXlvdXRGdW5j dGlvbnMuaCIKKyNpbmNsdWRlIDx3dGYvSXRlcmF0b3JSYW5nZS5oPgogI2luY2x1ZGUgPHd0Zi90 ZXh0L1dURlN0cmluZy5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiBuYW1lc3BhY2UgU2ltcGxl TGluZUxheW91dCB7CiAKLXRlbXBsYXRlIDxjbGFzcyBJdGVyYXRvclR5cGU+Ci1jbGFzcyBSYW5n ZSB7Ci1wdWJsaWM6Ci0gICAgUmFuZ2UoSXRlcmF0b3JUeXBlIGJlZ2luLCBJdGVyYXRvclR5cGUg ZW5kKSA6IG1fYmVnaW4oYmVnaW4pLCBtX2VuZChlbmQpIHsgfQotCi0gICAgSXRlcmF0b3JUeXBl IGJlZ2luKCkgY29uc3QgeyByZXR1cm4gbV9iZWdpbjsgfQotICAgIEl0ZXJhdG9yVHlwZSBlbmQo KSBjb25zdCB7IHJldHVybiBtX2VuZDsgfQotCi1wcml2YXRlOgotICAgIEl0ZXJhdG9yVHlwZSBt X2JlZ2luOwotICAgIEl0ZXJhdG9yVHlwZSBtX2VuZDsKLX07Ci0KIGNsYXNzIFJ1blJlc29sdmVy IHsKICAgICBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKIHB1YmxpYzoKQEAgLTExMywxMCArMTAx LDEwIEBAIHB1YmxpYzoKICAgICBJdGVyYXRvciBiZWdpbigpIGNvbnN0OwogICAgIEl0ZXJhdG9y IGVuZCgpIGNvbnN0OwogCi0gICAgUmFuZ2U8SXRlcmF0b3I+IHJhbmdlRm9yUmVjdChjb25zdCBM YXlvdXRSZWN0JikgY29uc3Q7Ci0gICAgUmFuZ2U8SXRlcmF0b3I+IHJhbmdlRm9yUmVuZGVyZXIo Y29uc3QgUmVuZGVyT2JqZWN0JikgY29uc3Q7CisgICAgV1RGOjpJdGVyYXRvclJhbmdlPEl0ZXJh dG9yPiByYW5nZUZvclJlY3QoY29uc3QgTGF5b3V0UmVjdCYpIGNvbnN0OworICAgIFdURjo6SXRl cmF0b3JSYW5nZTxJdGVyYXRvcj4gcmFuZ2VGb3JSZW5kZXJlcihjb25zdCBSZW5kZXJPYmplY3Qm KSBjb25zdDsKICAgICBJdGVyYXRvciBydW5Gb3JQb2ludChjb25zdCBMYXlvdXRQb2ludCYpIGNv bnN0OwotICAgIFJhbmdlPEl0ZXJhdG9yPiByYW5nZUZvclJlbmRlcmVyV2l0aE9mZnNldHMoY29u c3QgUmVuZGVyT2JqZWN0JiwgdW5zaWduZWQgc3RhcnQsIHVuc2lnbmVkIGVuZCkgY29uc3Q7Cisg ICAgV1RGOjpJdGVyYXRvclJhbmdlPEl0ZXJhdG9yPiByYW5nZUZvclJlbmRlcmVyV2l0aE9mZnNl dHMoY29uc3QgUmVuZGVyT2JqZWN0JiwgdW5zaWduZWQgc3RhcnQsIHVuc2lnbmVkIGVuZCkgY29u c3Q7CiAKIHByaXZhdGU6CiAgICAgZW51bSBjbGFzcyBJbmRleFR5cGUgeyBGaXJzdCwgTGFzdCB9 OwpAQCAtMTU4LDcgKzE0Niw3IEBAIHB1YmxpYzoKICAgICBJdGVyYXRvciBiZWdpbigpIGNvbnN0 OwogICAgIEl0ZXJhdG9yIGVuZCgpIGNvbnN0OwogCi0gICAgUmFuZ2U8SXRlcmF0b3I+IHJhbmdl Rm9yUmVjdChjb25zdCBMYXlvdXRSZWN0JikgY29uc3Q7CisgICAgV1RGOjpJdGVyYXRvclJhbmdl PEl0ZXJhdG9yPiByYW5nZUZvclJlY3QoY29uc3QgTGF5b3V0UmVjdCYpIGNvbnN0OwogCiBwcml2 YXRlOgogICAgIFJ1blJlc29sdmVyIG1fcnVuUmVzb2x2ZXI7CkBAIC0yOTYsMTAgKzI4NCwxMCBA QCBpbmxpbmUgTGluZVJlc29sdmVyOjpJdGVyYXRvciBMaW5lUmVzb2x2CiAgICAgcmV0dXJuIEl0 ZXJhdG9yKG1fcnVuUmVzb2x2ZXIuZW5kKCkpOwogfQogCi1pbmxpbmUgUmFuZ2U8TGluZVJlc29s dmVyOjpJdGVyYXRvcj4gTGluZVJlc29sdmVyOjpyYW5nZUZvclJlY3QoY29uc3QgTGF5b3V0UmVj dCYgcmVjdCkgY29uc3QKK2lubGluZSBXVEY6Okl0ZXJhdG9yUmFuZ2U8TGluZVJlc29sdmVyOjpJ dGVyYXRvcj4gTGluZVJlc29sdmVyOjpyYW5nZUZvclJlY3QoY29uc3QgTGF5b3V0UmVjdCYgcmVj dCkgY29uc3QKIHsKICAgICBhdXRvIHJ1blJhbmdlID0gbV9ydW5SZXNvbHZlci5yYW5nZUZvclJl Y3QocmVjdCk7Ci0gICAgcmV0dXJuIFJhbmdlPEl0ZXJhdG9yPihJdGVyYXRvcihydW5SYW5nZS5i ZWdpbigpKSwgSXRlcmF0b3IocnVuUmFuZ2UuZW5kKCkpKTsKKyAgICByZXR1cm4geyBJdGVyYXRv cihydW5SYW5nZS5iZWdpbigpKSwgSXRlcmF0b3IocnVuUmFuZ2UuZW5kKCkpIH07CiB9CiAKIGlu bGluZSBSdW5SZXNvbHZlciBydW5SZXNvbHZlcihjb25zdCBSZW5kZXJCbG9ja0Zsb3cmIGZsb3cs IGNvbnN0IExheW91dCYgbGF5b3V0KQo=