16874 2008-01-14 11:05:54 -0800 [Gtk] Missing symbols when compiling with --enable-svg-filters 2008-01-14 21:41:57 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 0 pierre-luc.beaudoin webkit-unassigned oldest_to_newest 67236 0 pierre-luc.beaudoin 2008-01-14 11:05:54 -0800 WebCore::SVGResourceFilter::applyFilter(WebCore::GraphicsContext*&, WebCore::FloatRect const&) WebCore::SVGResourceFilter::createPlatformData() WebCore::SVGResourceFilter::prepareFilter(WebCore::GraphicsContext*&, WebCore::FloatRect const&) implementation are missing 67237 1 18443 pierre-luc.beaudoin 2008-01-14 11:07:07 -0800 Created attachment 18443 Stubs Empty implementations to fix build. 67263 2 18443 mrowe 2008-01-14 18:13:36 -0800 Comment on attachment 18443 Stubs A tab has snuck into your change, and it needs a changelog. Can you fix those two things and resubmit please? 67266 3 18451 pierre-luc.beaudoin 2008-01-14 19:27:59 -0800 Created attachment 18451 No tab and a ChangeLog How did a tab get there! It seems to be a bug in Gedit... only on that line, it insists on inserting a tab. I also though the change were so trivial that it didn't require a ChangeLog. Now I know all changes need one. 67269 4 alp 2008-01-14 21:41:57 -0800 Landed in r29486. 18443 2008-01-14 11:07:07 -0800 2008-01-14 19:27:59 -0800 Stubs missing-symbols.patch text/plain 2227 pierre-luc.beaudoin SW5kZXg6IFdlYkNvcmUvc3ZnL2dyYXBoaWNzL2NhaXJvL1NWR1Jlc291cmNlRmlsdGVyQ2Fpcm8u Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvc3ZnL2dyYXBoaWNzL2NhaXJvL1NWR1Jlc291cmNl RmlsdGVyQ2Fpcm8uY3BwCShyZXZpc2lvbiAwKQorKysgV2ViQ29yZS9zdmcvZ3JhcGhpY3MvY2Fp cm8vU1ZHUmVzb3VyY2VGaWx0ZXJDYWlyby5jcHAJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNTAg QEAKKy8qCisgKiAgQ29weXJpZ2h0IChDKSAyMDA2IE5pa29sYXMgWmltbWVybWFubiA8d2lsZGZv eEBrZGUub3JnPgorICogIENvcHlyaWdodCAoQykgMjAwOCBDb2xsYWJvcmEgTHRkLiAgQWxsIHJp Z2h0cyByZXNlcnZlZC4KKyAqCisgKiAgVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlv dSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgorICogIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVy bXMgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKKyAqICBMaWNlbnNlIGFzIHB1Ymxp c2hlZCBieSB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIKKyAqICB2ZXJzaW9u IDIgb2YgdGhlIExpY2Vuc2UsIG9yIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24u CisgKgorICogIFRoaXMgbGlicmFyeSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0 IHdpbGwgYmUgdXNlZnVsLAorICogIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBl dmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCisgKiAgTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5F U1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZSBHTlUKKyAqICBMZXNzZXIgR2Vu ZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorICoKKyAqICBZb3Ugc2hvdWxk IGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgTGVzc2VyIEdlbmVyYWwgUHVibGljCisg KiAgTGljZW5zZSBhbG9uZyB3aXRoIHRoaXMgbGlicmFyeTsgaWYgbm90LCB3cml0ZSB0byB0aGUg RnJlZSBTb2Z0d2FyZQorICogIEZvdW5kYXRpb24sIEluYy4sIDUxIEZyYW5rbGluIFN0cmVldCwg RmlmdGggRmxvb3IsIEJvc3RvbiwgTUEgIDAyMTEwLTEzMDEgIFVTQQorICovCisKKworI2luY2x1 ZGUgImNvbmZpZy5oIgorCisjaWYgRU5BQkxFKFNWRykgJiYgRU5BQkxFKFNWR19GSUxURVJTKQor CisjaW5jbHVkZSAiTm90SW1wbGVtZW50ZWQuaCIKKyNpbmNsdWRlICJTVkdSZXNvdXJjZUZpbHRl ci5oIgorCituYW1lc3BhY2UgV2ViQ29yZSB7CisKK1NWR1Jlc291cmNlRmlsdGVyUGxhdGZvcm1E YXRhKiBTVkdSZXNvdXJjZUZpbHRlcjo6Y3JlYXRlUGxhdGZvcm1EYXRhKCkKK3sKKwlub3RJbXBs ZW1lbnRlZCgpOworICAgIHJldHVybiAwOworfQorCit2b2lkIFNWR1Jlc291cmNlRmlsdGVyOjpw cmVwYXJlRmlsdGVyKEdyYXBoaWNzQ29udGV4dComLCBjb25zdCBGbG9hdFJlY3QmKQoreworICAg IG5vdEltcGxlbWVudGVkKCk7Cit9CisKK3ZvaWQgU1ZHUmVzb3VyY2VGaWx0ZXI6OmFwcGx5Rmls dGVyKEdyYXBoaWNzQ29udGV4dComLCBjb25zdCBGbG9hdFJlY3QmKQoreworICAgIG5vdEltcGxl bWVudGVkKCk7Cit9CisKK30gLy8gbmFtZXNwYWNlIFdlYkNvcmUKKworI2VuZGlmCisKKy8vIHZp bTp0cz00Om5vZXQKSW5kZXg6IFdlYkNvcmUvR05VbWFrZWZpbGUuYW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9HTlVtYWtlZmlsZS5hbQkocmV2aXNpb24gMjk0NjYpCisrKyBXZWJDb3JlL0dOVW1h a2VmaWxlLmFtCSh3b3JraW5nIGNvcHkpCkBAIC0xODEyLDYgKzE4MTIsNyBAQAogCVdlYkNvcmUv c3ZnL2dyYXBoaWNzL2NhaXJvL1NWR1BhaW50U2VydmVyUGF0dGVybkNhaXJvLmNwcCBcCiAJV2Vi Q29yZS9zdmcvZ3JhcGhpY3MvY2Fpcm8vU1ZHUGFpbnRTZXJ2ZXJTb2xpZENhaXJvLmNwcCBcCiAJ V2ViQ29yZS9zdmcvZ3JhcGhpY3MvY2Fpcm8vU1ZHUmVzb3VyY2VDbGlwcGVyQ2Fpcm8uY3BwIFwK KwlXZWJDb3JlL3N2Zy9ncmFwaGljcy9jYWlyby9TVkdSZXNvdXJjZUZpbHRlckNhaXJvLmNwcCBc CiAJV2ViQ29yZS9zdmcvZ3JhcGhpY3MvY2Fpcm8vU1ZHUmVzb3VyY2VNYXNrZXJDYWlyby5jcHAK IAogCg== 18451 2008-01-14 19:27:59 -0800 2008-01-14 21:39:58 -0800 No tab and a ChangeLog missing-symbols-2.patch text/plain 3035 pierre-luc.beaudoin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyw6l2aXNpb24gMjk0ODMpCisrKyBXZWJDb3JlL0NoYW5nZUxvZwkoY29waWUgZGUgdHJhdmFp bCkKQEAgLTEsMyArMSwxNiBAQAorMjAwOC0wMS0xNCAgUGllcnJlLUx1YyBCZWF1ZG9pbiAgPHBp ZXJyZS1sdWMuYmVhdWRvaW5AY29sbGFib3JhLmNvLnVrPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgQnVpbGQgZml4OiBtaXNzaW5nIHN5 bWJvbHMgd2hlbiBjb21waWxpbmcgV2ViS2l0L0d0aysgd2l0aCAtLWVuYWJsZS1zdmctZmlsdGVy cworICAgICAgICBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg3NAor CisgICAgICAgICogR05VbWFrZWZpbGUuYW06CisgICAgICAgICogc3ZnL2dyYXBoaWNzL2NhaXJv L1NWR1Jlc291cmNlRmlsdGVyQ2Fpcm8uY3BwOiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6OlNW R1Jlc291cmNlRmlsdGVyOjpjcmVhdGVQbGF0Zm9ybURhdGEpOgorICAgICAgICAoV2ViQ29yZTo6 U1ZHUmVzb3VyY2VGaWx0ZXI6OnByZXBhcmVGaWx0ZXIpOgorICAgICAgICAoV2ViQ29yZTo6U1ZH UmVzb3VyY2VGaWx0ZXI6OmFwcGx5RmlsdGVyKToKKwogMjAwOC0wMS0xNCAgRmlubnVyIFRob3Jh cmluc3NvbiAgPGZpbm51ci53ZWJraXRAZ21haWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IGh5YXR0ICYgZXNlaWRlbC4KSW5kZXg6IFdlYkNvcmUvR05VbWFrZWZpbGUuYW0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQkocsOpdmlzaW9uIDI5NDgzKQorKysgV2ViQ29y ZS9HTlVtYWtlZmlsZS5hbQkoY29waWUgZGUgdHJhdmFpbCkKQEAgLTE4MTIsNiArMTgxMiw3IEBA CiAJV2ViQ29yZS9zdmcvZ3JhcGhpY3MvY2Fpcm8vU1ZHUGFpbnRTZXJ2ZXJQYXR0ZXJuQ2Fpcm8u Y3BwIFwKIAlXZWJDb3JlL3N2Zy9ncmFwaGljcy9jYWlyby9TVkdQYWludFNlcnZlclNvbGlkQ2Fp cm8uY3BwIFwKIAlXZWJDb3JlL3N2Zy9ncmFwaGljcy9jYWlyby9TVkdSZXNvdXJjZUNsaXBwZXJD YWlyby5jcHAgXAorCVdlYkNvcmUvc3ZnL2dyYXBoaWNzL2NhaXJvL1NWR1Jlc291cmNlRmlsdGVy Q2Fpcm8uY3BwIFwKIAlXZWJDb3JlL3N2Zy9ncmFwaGljcy9jYWlyby9TVkdSZXNvdXJjZU1hc2tl ckNhaXJvLmNwcAogCiAKSW5kZXg6IFdlYkNvcmUvc3ZnL2dyYXBoaWNzL2NhaXJvL1NWR1Jlc291 cmNlRmlsdGVyQ2Fpcm8uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvc3ZnL2dyYXBoaWNzL2Nh aXJvL1NWR1Jlc291cmNlRmlsdGVyQ2Fpcm8uY3BwCShyw6l2aXNpb24gMCkKKysrIFdlYkNvcmUv c3ZnL2dyYXBoaWNzL2NhaXJvL1NWR1Jlc291cmNlRmlsdGVyQ2Fpcm8uY3BwCShyw6l2aXNpb24g MCkKQEAgLTAsMCArMSw0OSBAQAorLyoKKyAqICBDb3B5cmlnaHQgKEMpIDIwMDYgTmlrb2xhcyBa aW1tZXJtYW5uIDx3aWxkZm94QGtkZS5vcmc+CisgKiAgQ29weXJpZ2h0IChDKSAyMDA4IENvbGxh Ym9yYSBMdGQuICBBbGwgcmlnaHRzIHJlc2VydmVkLgorICoKKyAqICBUaGlzIGxpYnJhcnkgaXMg ZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCisgKiAgbW9kaWZ5 IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIExlc3NlciBHZW5lcmFsIFB1YmxpYworICog IExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVp dGhlcgorICogIHZlcnNpb24gMiBvZiB0aGUgTGljZW5zZSwgb3IgKGF0IHlvdXIgb3B0aW9uKSBh bnkgbGF0ZXIgdmVyc2lvbi4KKyAqCisgKiAgVGhpcyBsaWJyYXJ5IGlzIGRpc3RyaWJ1dGVkIGlu IHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCisgKiAgYnV0IFdJVEhPVVQgQU5ZIFdB UlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKKyAqICBNRVJDSEFO VEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlIEdO VQorICogIExlc3NlciBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCisg KgorICogIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBMZXNzZXIg R2VuZXJhbCBQdWJsaWMKKyAqICBMaWNlbnNlIGFsb25nIHdpdGggdGhpcyBsaWJyYXJ5OyBpZiBu b3QsIHdyaXRlIHRvIHRoZSBGcmVlIFNvZnR3YXJlCisgKiAgRm91bmRhdGlvbiwgSW5jLiwgNTEg RnJhbmtsaW4gU3RyZWV0LCBGaWZ0aCBGbG9vciwgQm9zdG9uLCBNQSAgMDIxMTAtMTMwMSAgVVNB CisgKi8KKworCisjaW5jbHVkZSAiY29uZmlnLmgiCisKKyNpZiBFTkFCTEUoU1ZHKSAmJiBFTkFC TEUoU1ZHX0ZJTFRFUlMpCisKKyNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5oIgorI2luY2x1ZGUg IlNWR1Jlc291cmNlRmlsdGVyLmgiCisKK25hbWVzcGFjZSBXZWJDb3JlIHsKKworU1ZHUmVzb3Vy Y2VGaWx0ZXJQbGF0Zm9ybURhdGEqIFNWR1Jlc291cmNlRmlsdGVyOjpjcmVhdGVQbGF0Zm9ybURh dGEoKQoreworICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgcmV0dXJuIDA7Cit9CisKK3ZvaWQg U1ZHUmVzb3VyY2VGaWx0ZXI6OnByZXBhcmVGaWx0ZXIoR3JhcGhpY3NDb250ZXh0KiYsIGNvbnN0 IEZsb2F0UmVjdCYpCit7CisgICAgbm90SW1wbGVtZW50ZWQoKTsKK30KKwordm9pZCBTVkdSZXNv dXJjZUZpbHRlcjo6YXBwbHlGaWx0ZXIoR3JhcGhpY3NDb250ZXh0KiYsIGNvbnN0IEZsb2F0UmVj dCYpCit7CisgICAgbm90SW1wbGVtZW50ZWQoKTsKK30KKworfSAvLyBuYW1lc3BhY2UgV2ViQ29y ZQorCisjZW5kaWYKKwo=