168737 2017-02-22 12:43:05 -0800 AutoInstaller should not skip the install step if the package is downloaded but not installed 2017-02-22 13:56:55 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez clopez cdumez commit-queue dbates glenn lforschler ossy rniwa youennf oldest_to_newest 1279993 0 clopez 2017-02-22 12:43:05 -0800 When installing a python library for the tests via AutoInstaller, there is an optional argument "should_refresh" that can be defined to instruct the installer to always re-download and re-install such package. The issue is that "should_refresh" only checks if the source tarball is downloaded, but it ignores the fact that it can be already installed or not This can happen if the user manually cleans the installation folder for the auto-installed python libraries or if the installation of the library failed previously for any reason. So... what ends happening is that the module never gets installed. This has bitten me, I was cleaning the automatically installed wpt-tools library at LayoutTests/imported/w3c/web-platform-tests/tools, but wiping the tools sub-directory never caused this library to be installed again. The check to decide if the installation step should be skipped, it was only checking for the existence of the file defined at LayoutTests/imported/w3c/web-platform-tests/.tools.url rather than checking also for the target directory to exist. 1280000 1 302426 clopez 2017-02-22 12:50:31 -0800 Created attachment 302426 Patch 1280022 2 302426 rniwa 2017-02-22 13:28:30 -0800 Comment on attachment 302426 Patch Looks sane. 1280039 3 302426 commit-queue 2017-02-22 13:56:50 -0800 Comment on attachment 302426 Patch Clearing flags on attachment: 302426 Committed r212852: <http://trac.webkit.org/changeset/212852> 1280040 4 commit-queue 2017-02-22 13:56:55 -0800 All reviewed patches have been landed. Closing bug. 302426 2017-02-22 12:50:31 -0800 2017-02-22 13:56:50 -0800 Patch bug-168737-20170222214743.patch text/plain 2181 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyODI1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODA4ZGQzMmVkMzVkNTliODczMjQ0MjdiMjM2ZWM4MzRh NDcyYWIwZS4uOGY1MmE2NjZkOGQ1OTMzOWYxZGJhYWFmM2U0ZGRjNGUyYTEwMjFkOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE3LTAyLTIyICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIEF1dG9JbnN0YWxsZXIgc2hvdWxkIG5vdCBza2lwIHRoZSBpbnN0 YWxsIHN0ZXAgaWYgdGhlIHBhY2thZ2UgaXMgZG93bmxvYWRlZCBidXQgbm90IGluc3RhbGxlZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4NzM3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG9uJ3Qgc2tp cCB0aGUgaW5zdGFsbCBzdGVwIGlmIHRoZSBwYWNrYWdlIHRhcmdldCBwYXRoIGRvbid0IGV4aXN0 cy4KKyAgICAgICAgRml4IHRoZSBkZXNjcmlwdGlvbiBmb3IgInNob3VsZF9yZWZyZXNoIiBvcHRp b25hbCBhcmd1bWVudC4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3Rl bS9hdXRvaW5zdGFsbC5weToKKyAgICAgICAgKEF1dG9JbnN0YWxsZXIuaW5zdGFsbCk6CisKIDIw MTctMDItMjEgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFtX ZWJSVENdW01hY10gQWN0aXZhdGUgbGlid2VicnRjCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vYXV0b2luc3RhbGwucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9zeXN0ZW0vYXV0b2luc3RhbGwucHkKaW5kZXggZWVlZDMwYjcwMTYyMGQx MTkyNTM2NDcwZmI0Y2UxNjZhMTE3ZjNhOS4uZDBmN2M1NzJjOGVmNDJjY2Y5MGZiYTVmMWU0ZjMw M2VkOTBkNGJhYiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lz dGVtL2F1dG9pbnN0YWxsLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5 c3RlbS9hdXRvaW5zdGFsbC5weQpAQCAtNDY3LDcgKzQ2Nyw4IEBAIGNsYXNzIEF1dG9JbnN0YWxs ZXIob2JqZWN0KToKIAogICAgICAgICBPcHRpb25hbCBBcmdzOgogICAgICAgICAgIHNob3VsZF9y ZWZyZXNoOiBBIGJvb2xlYW4gdmFsdWUgb2Ygd2hldGhlciB0aGUgcGFja2FnZSBzaG91bGQgYmUK LSAgICAgICAgICAgICAgICAgICAgICAgICAgZG93bmxvYWRlZCBhZ2FpbiBpZiB0aGUgcGFja2Fn ZSBpcyBhbHJlYWR5IHByZXNlbnQuCisgICAgICAgICAgICAgICAgICAgICAgICAgIGRvd25sb2Fk ZWQgYW5kIHJlaW5zdGFsbGVkIGFnYWluIGV2ZW4gaWYgdGhlCisgICAgICAgICAgICAgICAgICAg ICAgICAgIHBhY2thZ2UgaXMgYWxyZWFkeSBwcmVzZW50LgogICAgICAgICAgIHRhcmdldF9uYW1l OiBUaGUgbmFtZSBvZiB0aGUgZm9sZGVyIG9yIGZpbGUgaW4gdGhlIGF1dG9pbnN0YWxsZXIKICAg ICAgICAgICAgICAgICAgICAgICAgdGFyZ2V0IGRpcmVjdG9yeSBhdCB3aGljaCB0aGUgcGFja2Fn ZSBzaG91bGQgYmUKICAgICAgICAgICAgICAgICAgICAgICAgaW5zdGFsbGVkLiAgRGVmYXVsdHMg dG8gdGhlIGJhc2UgbmFtZSBvZiB0aGUKQEAgLTQ4OCw3ICs0ODksNyBAQCBjbGFzcyBBdXRvSW5z dGFsbGVyKG9iamVjdCk6CiAgICAgICAgICAgICB0YXJnZXRfbmFtZSA9IG9zLnBhdGguYmFzZW5h bWUodXJsX3N1YnBhdGgpCiAKICAgICAgICAgdGFyZ2V0X3BhdGggPSBvcy5wYXRoLmpvaW4oc2Vs Zi5fdGFyZ2V0X2RpciwgdGFyZ2V0X25hbWUucmVwbGFjZSgnLycsIG9zLnNlcCkpCi0gICAgICAg IGlmIG5vdCBzaG91bGRfcmVmcmVzaCBhbmQgc2VsZi5faXNfZG93bmxvYWRlZCh0YXJnZXRfbmFt ZSwgdXJsKToKKyAgICAgICAgaWYgbm90IHNob3VsZF9yZWZyZXNoIGFuZCBzZWxmLl9pc19kb3du bG9hZGVkKHRhcmdldF9uYW1lLCB1cmwpIGFuZCBvcy5wYXRoLmV4aXN0cyh0YXJnZXRfcGF0aCk6 CiAgICAgICAgICAgICByZXR1cm4KIAogICAgICAgICBmaWxlc190b19yZW1vdmUgPSBmaWxlc190 b19yZW1vdmUgb3IgW10K