168728 2017-02-22 09:29:14 -0800 [GTK] Rendering artifacts when resizing the window in X11 with AC mode enabled 2017-02-27 06:44:09 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply oldest_to_newest 1279925 0 cgarcia 2017-02-22 09:29:14 -0800 This happens because the pixmap we create from the redirected window is uninitialized until the threaded compositor renders into it. We should always initialize the pixmap right after it's created. 1279927 1 302406 cgarcia 2017-02-22 09:31:16 -0800 Created attachment 302406 Patch 1281366 2 cgarcia 2017-02-27 06:44:09 -0800 Committed r213061: <http://trac.webkit.org/changeset/213061> 302406 2017-02-22 09:31:16 -0800 2017-02-27 06:38:24 -0800 Patch wk2-resize-artifacts.diff text/plain 5114 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAyODBjYjRlMTQ5MC4uNGJlNWU1OThjNjQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMiBAQAogMjAxNy0wMi0yMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKKyAgICAgICAgW0dUS10gUmVuZGVyaW5nIGFydGlmYWN0cyB3aGVuIHJlc2l6 aW5nIHRoZSB3aW5kb3cgaW4gWDExIHdpdGggQUMgbW9kZSBlbmFibGVkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg3MjgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGhhcHBlbnMgYmVjYXVzZSB0 aGUgcGl4bWFwIHdlIGNyZWF0ZSBmcm9tIHRoZSByZWRpcmVjdGVkIHdpbmRvdyBpcyB1bmluaXRp YWxpemVkIHVudGlsIHRoZSB0aHJlYWRlZAorICAgICAgICBjb21wb3NpdG9yIHJlbmRlcnMgaW50 byBpdC4gV2Ugc2hvdWxkIGFsd2F5cyBpbml0aWFsaXplIHRoZSBwaXhtYXAgcmlnaHQgYWZ0ZXIg aXQncyBjcmVhdGVkLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL2d0ay9BY2NlbGVy YXRlZFN1cmZhY2VYMTEuY3BwOgorICAgICAgICAoV2ViS2l0OjpkZWZhdWx0VmlzdWFsKTogSGVs cGVyIHN0YXRpYyBtZXRob2QgdG8gZ2V0IHRoZSBkZWZhdWx0IEdka1Zpc3VhbC4KKyAgICAgICAg KFdlYktpdDo6QWNjZWxlcmF0ZWRTdXJmYWNlWDExOjpBY2NlbGVyYXRlZFN1cmZhY2VYMTEpOiBV c2UgY3JlYXRlUGl4bWFwKCkuCisgICAgICAgIChXZWJLaXQ6OkFjY2VsZXJhdGVkU3VyZmFjZVgx MTo6Y3JlYXRlUGl4bWFwKTogQ3JlYXRlIGFuZCBpbml0aWFsaXplIHRoZSBwaXhtYXAuCisgICAg ICAgIChXZWJLaXQ6OkFjY2VsZXJhdGVkU3VyZmFjZVgxMTo6cmVzaXplKTogVXNlIGNyZWF0ZVBp eG1hcCgpLgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9ndGsvQWNjZWxlcmF0ZWRTdXJm YWNlWDExLmg6CisKKzIwMTctMDItMjIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBp Z2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtdIENyYXNoIGF0dGVtcHRpbmcgdG8gbG9hZCBGbGFz aCBwbHVnaW4gaW4gV2F5bGFuZAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTYzMTU5CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9ndGsvQWNjZWxlcmF0ZWRTdXJmYWNlWDExLmNwcCBiL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9ndGsvQWNjZWxlcmF0ZWRTdXJmYWNlWDExLmNwcAppbmRleCAz OTJiOWQ3N2U3Yi4uNjY1ZTI1Nzg5NTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9ndGsvQWNjZWxlcmF0ZWRTdXJmYWNlWDExLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL0FjY2VsZXJhdGVkU3VyZmFjZVgxMS5jcHAK QEAgLTMwLDggKzMwLDEwIEBACiAKICNpbmNsdWRlICJXZWJQYWdlLmgiCiAjaW5jbHVkZSA8V2Vi Q29yZS9QbGF0Zm9ybURpc3BsYXlYMTEuaD4KKyNpbmNsdWRlIDxXZWJDb3JlL1JlZlB0ckNhaXJv Lmg+CiAjaW5jbHVkZSA8WDExL1hsaWIuaD4KICNpbmNsdWRlIDxYMTEvZXh0ZW5zaW9ucy9YY29t cG9zaXRlLmg+CisjaW5jbHVkZSA8Y2Fpcm8teGxpYi5oPgogI2luY2x1ZGUgPGdkay9nZGt4Lmg+ CiAjaW5jbHVkZSA8d3RmL1J1bkxvb3AuaD4KIApAQCAtNDYsNiArNDgsMTMgQEAgc3RkOjp1bmlx dWVfcHRyPEFjY2VsZXJhdGVkU3VyZmFjZVgxMT4gQWNjZWxlcmF0ZWRTdXJmYWNlWDExOjpjcmVh dGUoV2ViUGFnZSYgd2UKICAgICByZXR1cm4gc3RkOjp1bmlxdWVfcHRyPEFjY2VsZXJhdGVkU3Vy ZmFjZVgxMT4obmV3IEFjY2VsZXJhdGVkU3VyZmFjZVgxMSh3ZWJQYWdlKSk7CiB9CiAKK3N0YXRp YyBHZGtWaXN1YWwqIGRlZmF1bHRWaXN1YWwoKQoreworICAgIGlmIChHZGtWaXN1YWwqIHZpc3Vh bCA9IGdka19zY3JlZW5fZ2V0X3JnYmFfdmlzdWFsKGdka19zY3JlZW5fZ2V0X2RlZmF1bHQoKSkp CisgICAgICAgIHJldHVybiB2aXN1YWw7CisgICAgcmV0dXJuIGdka19zY3JlZW5fZ2V0X3N5c3Rl bV92aXN1YWwoZ2RrX3NjcmVlbl9nZXRfZGVmYXVsdCgpKTsKK30KKwogQWNjZWxlcmF0ZWRTdXJm YWNlWDExOjpBY2NlbGVyYXRlZFN1cmZhY2VYMTEoV2ViUGFnZSYgd2ViUGFnZSkKICAgICA6IEFj Y2VsZXJhdGVkU3VyZmFjZSh3ZWJQYWdlKQogICAgICwgbV9kaXNwbGF5KGRvd25jYXN0PFBsYXRm b3JtRGlzcGxheVgxMT4oUGxhdGZvcm1EaXNwbGF5OjpzaGFyZWREaXNwbGF5KCkpLm5hdGl2ZSgp KQpAQCAtNTMsMTAgKzYyLDggQEAgQWNjZWxlcmF0ZWRTdXJmYWNlWDExOjpBY2NlbGVyYXRlZFN1 cmZhY2VYMTEoV2ViUGFnZSYgd2ViUGFnZSkKICAgICBTY3JlZW4qIHNjcmVlbiA9IERlZmF1bHRT Y3JlZW5PZkRpc3BsYXkobV9kaXNwbGF5KTsKIAogICAgIEFTU0VSVChkb3duY2FzdDxQbGF0Zm9y bURpc3BsYXlYMTE+KFBsYXRmb3JtRGlzcGxheTo6c2hhcmVkRGlzcGxheSgpKS5uYXRpdmUoKSA9 PSBtX2Rpc3BsYXkpOwotICAgIEdka1Zpc3VhbCogdmlzdWFsID0gZ2RrX3NjcmVlbl9nZXRfcmdi YV92aXN1YWwoZ2RrX3NjcmVlbl9nZXRfZGVmYXVsdCgpKTsKLSAgICBpZiAoIXZpc3VhbCkKLSAg ICAgICAgdmlzdWFsID0gZ2RrX3NjcmVlbl9nZXRfc3lzdGVtX3Zpc3VhbChnZGtfc2NyZWVuX2dl dF9kZWZhdWx0KCkpOwogCisgICAgR2RrVmlzdWFsKiB2aXN1YWwgPSBkZWZhdWx0VmlzdWFsKCk7 CiAgICAgWFVuaXF1ZUNvbG9ybWFwIGNvbG9ybWFwKFhDcmVhdGVDb2xvcm1hcChtX2Rpc3BsYXks IFJvb3RXaW5kb3dPZlNjcmVlbihzY3JlZW4pLCBHREtfVklTVUFMX1hWSVNVQUwodmlzdWFsKSwg QWxsb2NOb25lKSk7CiAKICAgICBYU2V0V2luZG93QXR0cmlidXRlcyB3aW5kb3dBdHRyaWJ1dGVz OwpAQCAtMTAzLDggKzExMCw3IEBAIEFjY2VsZXJhdGVkU3VyZmFjZVgxMTo6QWNjZWxlcmF0ZWRT dXJmYWNlWDExKFdlYlBhZ2UmIHdlYlBhZ2UpCiAgICAgfQogICAgIFhTZWxlY3RJbnB1dChtX2Rp c3BsYXksIG1fd2luZG93LmdldCgpLCBOb0V2ZW50TWFzayk7CiAgICAgWENvbXBvc2l0ZVJlZGly ZWN0V2luZG93KG1fZGlzcGxheSwgbV93aW5kb3cuZ2V0KCksIENvbXBvc2l0ZVJlZGlyZWN0TWFu dWFsKTsKLSAgICBtX3BpeG1hcCA9IFhDb21wb3NpdGVOYW1lV2luZG93UGl4bWFwKG1fZGlzcGxh eSwgbV93aW5kb3cuZ2V0KCkpOwotICAgIFhTeW5jKG1fZGlzcGxheSwgRmFsc2UpOworICAgIGNy ZWF0ZVBpeG1hcCgpOwogfQogCiBBY2NlbGVyYXRlZFN1cmZhY2VYMTE6On5BY2NlbGVyYXRlZFN1 cmZhY2VYMTEoKQpAQCAtMTE4LDYgKzEyNCwxNiBAQCBBY2NlbGVyYXRlZFN1cmZhY2VYMTE6On5B Y2NlbGVyYXRlZFN1cmZhY2VYMTEoKQogICAgIG1fcGFyZW50V2luZG93LnJlc2V0KCk7CiB9CiAK K3ZvaWQgQWNjZWxlcmF0ZWRTdXJmYWNlWDExOjpjcmVhdGVQaXhtYXAoKQoreworICAgIG1fcGl4 bWFwID0gWENvbXBvc2l0ZU5hbWVXaW5kb3dQaXhtYXAobV9kaXNwbGF5LCBtX3dpbmRvdy5nZXQo KSk7CisgICAgUmVmUHRyPGNhaXJvX3N1cmZhY2VfdD4gc3VyZmFjZSA9IGFkb3B0UmVmKGNhaXJv X3hsaWJfc3VyZmFjZV9jcmVhdGUobV9kaXNwbGF5LCBtX3BpeG1hcC5nZXQoKSwgR0RLX1ZJU1VB TF9YVklTVUFMKGRlZmF1bHRWaXN1YWwoKSksIG1fc2l6ZS53aWR0aCgpLCBtX3NpemUuaGVpZ2h0 KCkpKTsKKyAgICBSZWZQdHI8Y2Fpcm9fdD4gY3IgPSBhZG9wdFJlZihjYWlyb19jcmVhdGUoc3Vy ZmFjZS5nZXQoKSkpOworICAgIGNhaXJvX3NldF9vcGVyYXRvcihjci5nZXQoKSwgQ0FJUk9fT1BF UkFUT1JfQ0xFQVIpOworICAgIGNhaXJvX3BhaW50KGNyLmdldCgpKTsKKyAgICBYU3luYyhtX2Rp c3BsYXksIEZhbHNlKTsKK30KKwogYm9vbCBBY2NlbGVyYXRlZFN1cmZhY2VYMTE6OnJlc2l6ZShj b25zdCBJbnRTaXplJiBzaXplKQogewogICAgIGlmICghQWNjZWxlcmF0ZWRTdXJmYWNlOjpyZXNp emUoc2l6ZSkpCkBAIC0xMjksOCArMTQ1LDcgQEAgYm9vbCBBY2NlbGVyYXRlZFN1cmZhY2VYMTE6 OnJlc2l6ZShjb25zdCBJbnRTaXplJiBzaXplKQogCiAgICAgLy8gUmVsZWFzZSB0aGUgcHJldmlv dXMgcGl4bWFwIGxhdGVyIHRvIGdpdmUgc29tZSB0aW1lIHRvIHRoZSBVSSBwcm9jZXNzIHRvIHVw ZGF0ZS4KICAgICBSdW5Mb29wOjptYWluKCkuZGlzcGF0Y2hBZnRlcihzdGQ6OmNocm9ubzo6c2Vj b25kcyg1KSwgW3BpeG1hcCA9IFdURk1vdmUobV9waXhtYXApXSB7IH0pOwotICAgIG1fcGl4bWFw ID0gWENvbXBvc2l0ZU5hbWVXaW5kb3dQaXhtYXAobV9kaXNwbGF5LCBtX3dpbmRvdy5nZXQoKSk7 Ci0gICAgWFN5bmMobV9kaXNwbGF5LCBGYWxzZSk7CisgICAgY3JlYXRlUGl4bWFwKCk7CiAgICAg cmV0dXJuIHRydWU7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9ndGsvQWNjZWxlcmF0ZWRTdXJmYWNlWDExLmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvZ3RrL0FjY2VsZXJhdGVkU3VyZmFjZVgxMS5oCmluZGV4IGQ1ZGZkYWMy Zjk0Li43NDBmNTg5NzhlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL2d0ay9BY2NlbGVyYXRlZFN1cmZhY2VYMTEuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL0FjY2VsZXJhdGVkU3VyZmFjZVgxMS5oCkBAIC01Miw2ICs1 Miw4IEBAIHB1YmxpYzoKIHByaXZhdGU6CiAgICAgQWNjZWxlcmF0ZWRTdXJmYWNlWDExKFdlYlBh Z2UmKTsKIAorICAgIHZvaWQgY3JlYXRlUGl4bWFwKCk7CisKICAgICBEaXNwbGF5KiBtX2Rpc3Bs YXkgeyBudWxscHRyIH07CiAgICAgV2ViQ29yZTo6WFVuaXF1ZVdpbmRvdyBtX3dpbmRvdzsKICAg ICBXZWJDb3JlOjpYVW5pcXVlV2luZG93IG1fcGFyZW50V2luZG93Owo=