168717 2017-02-22 04:28:28 -0800 [GStreamer][EME] Fix issue with allowed systems extraction 2017-02-22 08:59:55 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 calvaris calvaris cgarcia commit-queue zan oldest_to_newest 1279850 0 calvaris 2017-02-22 04:28:28 -0800 [GStreamer][EME] Fix issue with allowed systems extraction 1279851 1 302386 calvaris 2017-02-22 04:30:24 -0800 Created attachment 302386 Patch 1279855 2 302386 cgarcia 2017-02-22 04:41:23 -0800 Comment on attachment 302386 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302386&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:271 > unsigned i; > - for (i = 0; !streamEncryptionAllowedSystems[i]; ++i) > + for (i = 0; streamEncryptionAllowedSystems[i]; ++i) for (unsigned i = 0 1279895 3 302386 calvaris 2017-02-22 08:38:56 -0800 Comment on attachment 302386 Patch (In reply to comment #2) > Comment on attachment 302386 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302386&action=review > > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:271 > > unsigned i; > > - for (i = 0; !streamEncryptionAllowedSystems[i]; ++i) > > + for (i = 0; streamEncryptionAllowedSystems[i]; ++i) > > for (unsigned i = 0 I can't, i is used later. 1279907 4 302386 commit-queue 2017-02-22 08:56:31 -0800 Comment on attachment 302386 Patch Clearing flags on attachment: 302386 Committed r212830: <http://trac.webkit.org/changeset/212830> 1279909 5 commit-queue 2017-02-22 08:56:35 -0800 All reviewed patches have been landed. Closing bug. 1279910 6 cgarcia 2017-02-22 08:57:15 -0800 (In reply to comment #3) > Comment on attachment 302386 [details] > Patch > > (In reply to comment #2) > > Comment on attachment 302386 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=302386&action=review > > > > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:271 > > > unsigned i; > > > - for (i = 0; !streamEncryptionAllowedSystems[i]; ++i) > > > + for (i = 0; streamEncryptionAllowedSystems[i]; ++i) > > > > for (unsigned i = 0 > > I can't, i is used later. It's used later in a similar for loop that should do the same. 1279911 7 calvaris 2017-02-22 08:59:55 -0800 (In reply to comment #6) > It's used later in a similar for loop that should do the same. Roger for the next time. 302386 2017-02-22 04:30:24 -0800 2017-02-22 08:56:31 -0800 Patch bug-168717-20170222132737.patch text/plain 2490 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyODIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTNhZmI2ZTFiZDk1OTU2 NzMzYTg2ZDA3NTFlMDA5ZTIzZGYyMWNlZi4uNjAxZmQ0MjVkNmIyNzExMTY3ZmFmZTVmNzQ5NDEz YTA2ZDg3YzQ1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTAyLTIyICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dT dHJlYW1lcl1bRU1FXSBGaXggaXNzdWUgd2l0aCBhbGxvd2VkIHN5c3RlbXMgZXh0cmFjdGlvbgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4NzE3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGFsbG93 ZWQgc3lzdGVtcyB3ZXJlIG5vdCBiZWluZyBleHRyYWN0ZWQgZnJvbSB0aGUgbmVlZC1jb250ZXh0 CisgICAgICAgIG1lc3NhZ2UgYmVjYXVzZSB0aGUgbG9vcCB3YXMgbm90IHN0b3BwaW5nIG9uIHRo ZSByaWdodCBjb25kaXRpb24uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFt ZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpleHRyYWN0RXZlbnRzQW5kU3lzdGVtc0Zyb21NZXNzYWdlKTogRml4IHdyb25nCisgICAgICAg IGNvbmRpdGlvbi4KKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ckJhc2U6OmhhbmRsZVByb3RlY3Rpb25FdmVudCk6CisgICAgICAgIEFkZCBiZXR0ZXIgZGVidWcg Y2F0ZWdvcnkuCisKIDIwMTctMDItMDggIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGln YWxpYS5jb20+CiAKICAgICAgICAgW2Nzcy1ncmlkXSBNb3ZlIHRoZSB0cmFjayBzaXppbmcgYWxn b3JpdGhtIHRvIGl0cyBvd24gY2xhc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXll clByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcAppbmRleCA5ZTY0MDQzZWQ0ZTBjNDhkYzdmN2NkMmU3 NTgwYmY2YjE1OWFlODQzLi5mZWRhZDVmMTIwMTA5ZjNiMTUyMjQ3ZjdiMzExOWU4YzY2YjI5Yzc4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJh c2UuY3BwCkBAIC0yNjgsNyArMjY4LDcgQEAgc3RhdGljIHN0ZDo6cGFpcjxWZWN0b3I8R1JlZlB0 cjxHc3RFdmVudD4+LCBWZWN0b3I8U3RyaW5nPj4gZXh0cmFjdEV2ZW50c0FuZFN5c3QKICAgICBB U1NFUlQoc3RyZWFtRW5jcnlwdGlvbkFsbG93ZWRTeXN0ZW1zKTsKICAgICBWZWN0b3I8U3RyaW5n PiBzdHJlYW1FbmNyeXB0aW9uQWxsb3dlZFN5c3RlbXNWZWN0b3I7CiAgICAgdW5zaWduZWQgaTsK LSAgICBmb3IgKGkgPSAwOyAhc3RyZWFtRW5jcnlwdGlvbkFsbG93ZWRTeXN0ZW1zW2ldOyArK2kp CisgICAgZm9yIChpID0gMDsgc3RyZWFtRW5jcnlwdGlvbkFsbG93ZWRTeXN0ZW1zW2ldOyArK2kp CiAgICAgICAgIHN0cmVhbUVuY3J5cHRpb25BbGxvd2VkU3lzdGVtc1ZlY3Rvci5hcHBlbmQoc3Ry ZWFtRW5jcnlwdGlvbkFsbG93ZWRTeXN0ZW1zW2ldKTsKIAogICAgIGNvbnN0IEdWYWx1ZSogc3Ry ZWFtRW5jcnlwdGlvbkV2ZW50c0xpc3QgPSBnc3Rfc3RydWN0dXJlX2dldF92YWx1ZShzdHJ1Y3R1 cmUsICJzdHJlYW0tZW5jcnlwdGlvbi1ldmVudHMiKTsKQEAgLTEyMzksNyArMTIzOSw3IEBAIHZv aWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6a2V5QWRkZWQoKQogdm9pZCBNZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjpoYW5kbGVQcm90ZWN0aW9uRXZlbnQoR3N0RXZl bnQqIGV2ZW50KQogewogICAgIGlmIChtX2hhbmRsZWRQcm90ZWN0aW9uRXZlbnRzLmNvbnRhaW5z KEdTVF9FVkVOVF9TRVFOVU0oZXZlbnQpKSkgewotICAgICAgICBHU1RfVFJBQ0UoImV2ZW50ICV1 IGFscmVhZHkgaGFuZGxlZCIsIEdTVF9FVkVOVF9TRVFOVU0oZXZlbnQpKTsKKyAgICAgICAgR1NU X0RFQlVHKCJldmVudCAldSBhbHJlYWR5IGhhbmRsZWQiLCBHU1RfRVZFTlRfU0VRTlVNKGV2ZW50 KSk7CiAgICAgICAgIG1faGFuZGxlZFByb3RlY3Rpb25FdmVudHMucmVtb3ZlKEdTVF9FVkVOVF9T RVFOVU0oZXZlbnQpKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0K