168707 2017-02-21 21:15:25 -0800 [User Timing] Throw a SyntaxError for performance.measure if mark name is not found 2017-02-21 21:45:42 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue joepeck rniwa oldest_to_newest 1279769 0 joepeck 2017-02-21 21:15:25 -0800 [User Timing] Throw a SyntaxError for performance.measure if mark name is not found This used to be part of User Timing Level 1 and User Timing Level 2 didn't include the text. Lets just be consistent and throw a SyntaxError (other browsers I tested do). There is an open issue on this: https://github.com/w3c/user-timing/issues/21 1279770 1 302365 joepeck 2017-02-21 21:18:44 -0800 Created attachment 302365 [PATCH] Proposed Fix 1279773 2 302365 commit-queue 2017-02-21 21:45:38 -0800 Comment on attachment 302365 [PATCH] Proposed Fix Clearing flags on attachment: 302365 Committed r212806: <http://trac.webkit.org/changeset/212806> 1279774 3 commit-queue 2017-02-21 21:45:42 -0800 All reviewed patches have been landed. Closing bug. 302365 2017-02-21 21:18:44 -0800 2017-02-21 21:45:38 -0800 [PATCH] Proposed Fix measure-name-1.patch text/plain 5817 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkMTQyMGY4YTY4Ny4uOGUxNjQ0MDk1ZGEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor MjAxNy0wMi0yMSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAg ICAgIFtVc2VyIFRpbWluZ10gVGhyb3cgYSBTeW50YXhFcnJvciBmb3IgcGVyZm9ybWFuY2UubWVh c3VyZSBpZiBtYXJrIG5hbWUgaXMgbm90IGZvdW5kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg3MDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHBlcmZvcm1hbmNlLWFwaS9wZXJmb3JtYW5jZS1tZWFz dXJlLW5hbWUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBwZXJmb3JtYW5jZS1hcGkv cGVyZm9ybWFuY2UtbWVhc3VyZS1uYW1lLmh0bWw6IEFkZGVkLgorICAgICAgICAqIHBlcmZvcm1h bmNlLWFwaS9yZXNvdXJjZXMvbWVhc3VyZS1uYW1lLmpzOiBBZGRlZC4KKyAgICAgICAgVGVzdCB0 byBjb3ZlciBTeW50YXhFcnJvciBmb3IgbWlzc2luZyBtZWFzdXJlIHN0YXJ0L2VuZCBtYXJrIG5h bWVzLgorCiAyMDE3LTAyLTIwICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CiAKICAgICAgICAgW1Jlc291cmNlIFRpbWluZ10gR2F0aGVyIHRpbWluZyBpbmZvcm1hdGlvbiB3 aXRoIHJlbGlhYmxlIHJlc3BvbnNlRW5kIHRpbWUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3Bl cmZvcm1hbmNlLWFwaS9wZXJmb3JtYW5jZS1tZWFzdXJlLW5hbWUtZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvcGVyZm9ybWFuY2UtYXBpL3BlcmZvcm1hbmNlLW1lYXN1cmUtbmFtZS1leHBlY3Rl ZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLmIwODhjNjYyNzll Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGVyZm9ybWFuY2UtYXBpL3BlcmZvcm1h bmNlLW1lYXN1cmUtbmFtZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwyMyBAQAorVGVzdHMgcGVy Zm9ybWFuY2UubWVhc3VyZSBzdGFydE5hbWUvZW5kTmFtZSBtdXN0IGV4aXN0LgorCitPbiBzdWNj ZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBi eSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBwZXJmb3JtYW5jZS5tYXJrKCJleGlzdGluZy1t YXJrLW5hbWUiKSBkaWQgbm90IHRocm93IGV4Y2VwdGlvbi4KK1BBU1MgcGVyZm9ybWFuY2UubWVh c3VyZSgibWVhc3VyZS1uYW1lIiwgIngiKSB0aHJldyBleGNlcHRpb24gU3ludGF4RXJyb3IgKERP TSBFeGNlcHRpb24gMTIpOiBUaGUgc3RyaW5nIGRpZCBub3QgbWF0Y2ggdGhlIGV4cGVjdGVkIHBh dHRlcm4uLgorUEFTUyBwZXJmb3JtYW5jZS5tZWFzdXJlKCJtZWFzdXJlLW5hbWUiLCAiZXhpc3Rp bmctbWFyay1uYW1lIiwgIngiKSB0aHJldyBleGNlcHRpb24gU3ludGF4RXJyb3IgKERPTSBFeGNl cHRpb24gMTIpOiBUaGUgc3RyaW5nIGRpZCBub3QgbWF0Y2ggdGhlIGV4cGVjdGVkIHBhdHRlcm4u LgorUEFTUyBwZXJmb3JtYW5jZS5tYXJrKCJ4IikgZGlkIG5vdCB0aHJvdyBleGNlcHRpb24uCitQ QVNTIHBlcmZvcm1hbmNlLm1lYXN1cmUoIm1lYXN1cmUtbmFtZSIsICJ4IikgZGlkIG5vdCB0aHJv dyBleGNlcHRpb24uCitQQVNTIHBlcmZvcm1hbmNlLm1lYXN1cmUoIm1lYXN1cmUtbmFtZSIsICJl eGlzdGluZy1tYXJrLW5hbWUiLCAieCIpIGRpZCBub3QgdGhyb3cgZXhjZXB0aW9uLgorCitTdGFy dGluZyB3b3JrZXI6IHJlc291cmNlcy9tZWFzdXJlLW5hbWUuanMKK1BBU1MgW1dvcmtlcl0gcGVy Zm9ybWFuY2UubWFyaygiZXhpc3RpbmctbWFyay1uYW1lIikgZGlkIG5vdCB0aHJvdyBleGNlcHRp b24uCitQQVNTIFtXb3JrZXJdIHBlcmZvcm1hbmNlLm1lYXN1cmUoIm1lYXN1cmUtbmFtZSIsICJ4 IikgdGhyZXcgZXhjZXB0aW9uIFN5bnRheEVycm9yIChET00gRXhjZXB0aW9uIDEyKTogTm8gbWFy ayBuYW1lZCAneCcgZXhpc3RzLgorUEFTUyBbV29ya2VyXSBwZXJmb3JtYW5jZS5tZWFzdXJlKCJt ZWFzdXJlLW5hbWUiLCAiZXhpc3RpbmctbWFyay1uYW1lIiwgIngiKSB0aHJldyBleGNlcHRpb24g U3ludGF4RXJyb3IgKERPTSBFeGNlcHRpb24gMTIpOiBObyBtYXJrIG5hbWVkICd4JyBleGlzdHMu CitQQVNTIFtXb3JrZXJdIHBlcmZvcm1hbmNlLm1hcmsoIngiKSBkaWQgbm90IHRocm93IGV4Y2Vw dGlvbi4KK1BBU1MgW1dvcmtlcl0gcGVyZm9ybWFuY2UubWVhc3VyZSgibWVhc3VyZS1uYW1lIiwg IngiKSBkaWQgbm90IHRocm93IGV4Y2VwdGlvbi4KK1BBU1MgW1dvcmtlcl0gcGVyZm9ybWFuY2Uu bWVhc3VyZSgibWVhc3VyZS1uYW1lIiwgImV4aXN0aW5nLW1hcmstbmFtZSIsICJ4IikgZGlkIG5v dCB0aHJvdyBleGNlcHRpb24uCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RF U1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGVyZm9ybWFuY2UtYXBpL3Bl cmZvcm1hbmNlLW1lYXN1cmUtbmFtZS5odG1sIGIvTGF5b3V0VGVzdHMvcGVyZm9ybWFuY2UtYXBp L3BlcmZvcm1hbmNlLW1lYXN1cmUtbmFtZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwLi44N2VhYmY2OGM0MQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L3BlcmZvcm1hbmNlLWFwaS9wZXJmb3JtYW5jZS1tZWFzdXJlLW5hbWUuaHRtbApAQCAtMCwwICsx LDE0IEBACis8IURPQ1RZUEUgSFRNTD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4v cmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHNj cmlwdCBzcmM9InJlc291cmNlcy9tZWFzdXJlLW5hbWUuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4K K2RlYnVnKCIiKTsKK2xldCB3b3JrZXIgPSBzdGFydFdvcmtlcigicmVzb3VyY2VzL21lYXN1cmUt bmFtZS5qcyIpOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL2pzLXRlc3Qt cG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9wZXJmb3JtYW5jZS1hcGkvcmVzb3VyY2VzL21lYXN1cmUtbmFtZS5qcyBiL0xheW91dFRl c3RzL3BlcmZvcm1hbmNlLWFwaS9yZXNvdXJjZXMvbWVhc3VyZS1uYW1lLmpzCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwLi5kNzY1YTE4ZTQ5NAotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL3BlcmZvcm1hbmNlLWFwaS9yZXNvdXJjZXMvbWVhc3VyZS1uYW1lLmpz CkBAIC0wLDAgKzEsMjAgQEAKK2lmIChzZWxmLmltcG9ydFNjcmlwdHMpCisgICAgaW1wb3J0U2Ny aXB0cygiLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIik7CisKK3NlbGYuanNUZXN0SXNB c3luYyA9IHRydWU7CisKK2lmIChzZWxmLndpbmRvdykKKyAgICBkZXNjcmlwdGlvbigiVGVzdHMg cGVyZm9ybWFuY2UubWVhc3VyZSBzdGFydE5hbWUvZW5kTmFtZSBtdXN0IGV4aXN0LiIpOworCitz aG91bGROb3RUaHJvdyhgcGVyZm9ybWFuY2UubWFyaygiZXhpc3RpbmctbWFyay1uYW1lIilgKTsK Kworc2hvdWxkVGhyb3coYHBlcmZvcm1hbmNlLm1lYXN1cmUoIm1lYXN1cmUtbmFtZSIsICJ4Iilg KTsKK3Nob3VsZFRocm93KGBwZXJmb3JtYW5jZS5tZWFzdXJlKCJtZWFzdXJlLW5hbWUiLCAiZXhp c3RpbmctbWFyay1uYW1lIiwgIngiKWApOworCitzaG91bGROb3RUaHJvdyhgcGVyZm9ybWFuY2Uu bWFyaygieCIpYCk7CisKK3Nob3VsZE5vdFRocm93KGBwZXJmb3JtYW5jZS5tZWFzdXJlKCJtZWFz dXJlLW5hbWUiLCAieCIpYCk7CitzaG91bGROb3RUaHJvdyhgcGVyZm9ybWFuY2UubWVhc3VyZSgi bWVhc3VyZS1uYW1lIiwgImV4aXN0aW5nLW1hcmstbmFtZSIsICJ4IilgKTsKKworaWYgKHNlbGYu aW1wb3J0U2NyaXB0cykKKyAgICBmaW5pc2hKU1Rlc3QoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhZDU2MzFh Y2RiNi4uZjNiZjMwMmY1NjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxNy0wMi0y MSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCisgICAgICAgIFtVc2Vy IFRpbWluZ10gVGhyb3cgYSBTeW50YXhFcnJvciBmb3IgcGVyZm9ybWFuY2UubWVhc3VyZSBpZiBt YXJrIG5hbWUgaXMgbm90IGZvdW5kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNjg3MDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUZXN0OiBwZXJmb3JtYW5jZS1hcGkvcGVyZm9ybWFuY2UtbWVhc3VyZS1u YW1lLmh0bWwKKworICAgICAgICAqIHBhZ2UvUGVyZm9ybWFuY2VVc2VyVGltaW5nLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlVzZXJUaW1pbmc6OmZpbmRFeGlzdGluZ01hcmtTdGFydFRpbWUpOgor ICAgICAgICBJbnN0ZWFkIG9mIHJldHVybmluZyB6ZXJvLCB0aHJvdyBhIFN5bnRheEVycm9yLiBU aGlzIGlzIG1vcmUgaW4gbGluZQorICAgICAgICB3aXRoIFVzZXIgVGltaW5nIExldmVsIDEgYW5k IGJlaGF2aW9yIGluIFdpbmRvdy4gVGhpcyBpcyBhbiBpc3N1ZSB3aXRoCisgICAgICAgIHRoZSBM ZXZlbCAyIHNwZWM6IGh0dHBzOi8vZ2l0aHViLmNvbS93M2MvdXNlci10aW1pbmcvaXNzdWVzLzIx CisKKzIwMTctMDItMjEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwog ICAgICAgICBbUmVzb3VyY2UgVGltaW5nXSBNZWRpYSBlbGVtZW50cyBpbml0aWF0ZWQgbG9hZHMg c2hvdWxkIHNldCB0aGUgaW5pdGlhdG9yVHlwZSB0byB0aGVpciBlbGVtZW50IG5hbWUgKHZpZGVv L2F1ZGlvKQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTY4NjgwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2VVc2Vy VGltaW5nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2VVc2VyVGltaW5nLmNw cAppbmRleCA2YzkzM2Q4MmJmMS4uMDE2YzlhMjFlYWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BhZ2UvUGVyZm9ybWFuY2VVc2VyVGltaW5nLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL1BlcmZvcm1hbmNlVXNlclRpbWluZy5jcHAKQEAgLTEyMyw3ICsxMjMsNyBAQCBFeGNlcHRp b25Pcjxkb3VibGU+IFVzZXJUaW1pbmc6OmZpbmRFeGlzdGluZ01hcmtTdGFydFRpbWUoY29uc3Qg U3RyaW5nJiBtYXJrTmFtZQogCiAgICAgUGVyZm9ybWFuY2VUaW1pbmcqIHRpbWluZyA9IG1fcGVy Zm9ybWFuY2UudGltaW5nKCk7CiAgICAgaWYgKCF0aW1pbmcpCi0gICAgICAgIHJldHVybiAwLjA7 CisgICAgICAgIHJldHVybiBFeGNlcHRpb24geyBTWU5UQVhfRVJSLCBtYWtlU3RyaW5nKCJObyBt YXJrIG5hbWVkICciLCBtYXJrTmFtZSwgIicgZXhpc3RzIikgfTsKIAogICAgIGlmIChhdXRvIGZ1 bmN0aW9uID0gcmVzdHJpY3RlZE1hcmtGdW5jdGlvbihtYXJrTmFtZSkpIHsKICAgICAgICAgZG91 YmxlIHZhbHVlID0gc3RhdGljX2Nhc3Q8ZG91YmxlPigoKCp0aW1pbmcpLiooZnVuY3Rpb24pKSgp KTsK