168705 2017-02-21 20:45:51 -0800 Move instance members from WebPDFViewPlaceholder.h to implementation file 2017-02-22 15:40:21 -0800 1 1 1 Unclassified WebKit WebKit Misc. Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue juergen mitz thorton oldest_to_newest 1279761 0 aakash_jain 2017-02-21 20:45:51 -0800 There are few symbols in WebPDFViewPlaceholder interface in WebKit/ios/WebView/WebPDFViewPlaceholder.h and are not exported. We should export these symbols so that the headers matches with the library. 1279762 1 302363 aakash_jain 2017-02-21 20:48:17 -0800 Created attachment 302363 Proposed patch 1280012 2 302428 aakash_jain 2017-02-22 13:11:18 -0800 Created attachment 302428 Updated patch Moving instance members to implementation file as this is a better approach instead of exposing symbols. 1280017 3 juergen 2017-02-22 13:23:46 -0800 You can now also remove the {} braces after the @interface declaration. You added the ivars to a WebPDFViewPlaceholder category. That doesn't seem right. Shouldn't they be added to the @implementation? 1280029 4 302433 aakash_jain 2017-02-22 13:41:03 -0800 Created attachment 302433 Updated patch remove extra {} and added ivars to @implementation. 1280082 5 302433 commit-queue 2017-02-22 15:40:17 -0800 Comment on attachment 302433 Updated patch Clearing flags on attachment: 302433 Committed r212858: <http://trac.webkit.org/changeset/212858> 1280083 6 commit-queue 2017-02-22 15:40:21 -0800 All reviewed patches have been landed. Closing bug. 302363 2017-02-21 20:48:17 -0800 2017-02-22 13:11:18 -0800 Proposed patch patch_WebPDFViewPlaceholder text/plain 1314 aakash_jain SW5kZXg6IFNvdXJjZS9XZWJLaXQvaW9zL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2lvcy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMjgwNCkKKysrIFNvdXJjZS9XZWJLaXQv aW9zL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE3LTAyLTIx ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBFeHBvcnQg dmFyaW91cyBzeW1ib2xzIGZyb20gV2ViUERGVmlld1BsYWNlaG9sZGVyLmgKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODcwNQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViS2l0LmlPUy5leHA6CisK IDIwMTctMDItMjEgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAg ICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMTI3NjguCkluZGV4OiBTb3VyY2UvV2Vi S2l0L2lvcy9XZWJLaXQuaU9TLmV4cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2lvcy9X ZWJLaXQuaU9TLmV4cAkocmV2aXNpb24gMjEyNzgxKQorKysgU291cmNlL1dlYktpdC9pb3MvV2Vi S2l0LmlPUy5leHAJKHdvcmtpbmcgY29weSkKQEAgLTM2LDMgKzM2LDEyIEBAIF9fV2ViVmlld1Jl bW90ZUluc3BlY3Rvckhhc1Nlc3Npb25DaGFuZ2UKIAogIyBXZWJLaXQxIGludGVybmFsIHR5cGVz IGV4cG9zZWQgZm9yIFdlYktpdDIuCiAub2JqY19jbGFzc19uYW1lX1dlYkdlb2xvY2F0aW9uQ29y ZUxvY2F0aW9uUHJvdmlkZXIKKworX09CSkNfSVZBUl8kX1dlYlBERlZpZXdQbGFjZWhvbGRlci5f Y29udGFpbmVyU2l6ZQorX09CSkNfSVZBUl8kX1dlYlBERlZpZXdQbGFjZWhvbGRlci5fZGF0YVNv dXJjZQorX09CSkNfSVZBUl8kX1dlYlBERlZpZXdQbGFjZWhvbGRlci5fZGVsZWdhdGUKK19PQkpD X0lWQVJfJF9XZWJQREZWaWV3UGxhY2Vob2xkZXIuX2RpZEZpbmlzaExvYWQKK19PQkpDX0lWQVJf JF9XZWJQREZWaWV3UGxhY2Vob2xkZXIuX2RvY3VtZW50CitfT0JKQ19JVkFSXyRfV2ViUERGVmll d1BsYWNlaG9sZGVyLl9wYWdlUmVjdHMKK19PQkpDX0lWQVJfJF9XZWJQREZWaWV3UGxhY2Vob2xk ZXIuX3BhZ2VZT3JpZ2lucworX09CSkNfSVZBUl8kX1dlYlBERlZpZXdQbGFjZWhvbGRlci5fdGl0 bGUK 302428 2017-02-22 13:11:18 -0800 2017-02-22 13:41:03 -0800 Updated patch patch_WebPDFViewPlaceholder_v2 text/plain 2197 aakash_jain SW5kZXg6IFNvdXJjZS9XZWJLaXQvaW9zL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2lvcy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMjg0OCkKKysrIFNvdXJjZS9XZWJLaXQv aW9zL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTAyLTIy ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBNb3ZlIGlu c3RhbmNlIG1lbWJlcnMgZnJvbSBXZWJQREZWaWV3UGxhY2Vob2xkZXIuaCB0byBpbXBsZW1lbnRh dGlvbiBmaWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjg3MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFdlYlZpZXcvV2ViUERGVmlld1BsYWNlaG9sZGVyLmg6IE1vdmluZyBpbnN0YW5jZSBtZW1i ZXJzIHRvIGltcGxlbWVudGF0aW9uIGZpbGUuCisgICAgICAgICogV2ViVmlldy9XZWJQREZWaWV3 UGxhY2Vob2xkZXIubW06IERpdHRvCisKIDIwMTctMDItMjIgIEFha2FzaCBKYWluICA8YWFrYXNo X2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIE1vdmUgaU9TIHNwZWNpZmljIHN5bWJvbHMgdG8g V2ViS2l0Lmlvcy5leHAKSW5kZXg6IFNvdXJjZS9XZWJLaXQvaW9zL1dlYlZpZXcvV2ViUERGVmll d1BsYWNlaG9sZGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9pb3MvV2ViVmlldy9X ZWJQREZWaWV3UGxhY2Vob2xkZXIuaAkocmV2aXNpb24gMjEyODQ0KQorKysgU291cmNlL1dlYktp dC9pb3MvV2ViVmlldy9XZWJQREZWaWV3UGxhY2Vob2xkZXIuaAkod29ya2luZyBjb3B5KQpAQCAt MzgsMTcgKzM4LDYgQEAKICAgICB3aXRoIFdBSyBhbmQgV2ViS2l0IGNvcnJlY3RseS4KICovCiBA aW50ZXJmYWNlIFdlYlBERlZpZXdQbGFjZWhvbGRlciA6IFdBS1ZpZXcgPFdlYlBERkRvY3VtZW50 VmlldywgV2ViUERGRG9jdW1lbnRSZXByZXNlbnRhdGlvbj4gewotICAgIE5TU3RyaW5nICpfdGl0 bGU7Ci0gICAgTlNBcnJheSAqX3BhZ2VSZWN0czsKLSAgICBOU0FycmF5ICpfcGFnZVlPcmlnaW5z OwotICAgIENHUERGRG9jdW1lbnRSZWYgX2RvY3VtZW50OwotICAgIFdlYkRhdGFTb3VyY2UgKl9k YXRhU291cmNlOyAvLyB3ZWFrIHRvIHByZXZlbnQgY3ljbGVzLgotCi0gICAgTlNPYmplY3Q8V2Vi UERGVmlld1BsYWNlaG9sZGVyRGVsZWdhdGU+ICpfZGVsZWdhdGU7Ci0KLSAgICBCT09MIF9kaWRG aW5pc2hMb2FkOwotCi0gICAgQ0dTaXplIF9jb250YWluZXJTaXplOwogfQogCiAvKiEKSW5kZXg6 IFNvdXJjZS9XZWJLaXQvaW9zL1dlYlZpZXcvV2ViUERGVmlld1BsYWNlaG9sZGVyLm1tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvaW9zL1dlYlZpZXcvV2ViUERGVmlld1BsYWNlaG9sZGVy Lm1tCShyZXZpc2lvbiAyMTI4NDQpCisrKyBTb3VyY2UvV2ViS2l0L2lvcy9XZWJWaWV3L1dlYlBE RlZpZXdQbGFjZWhvbGRlci5tbQkod29ya2luZyBjb3B5KQpAQCAtODgsNiArODgsMTkgQEAgLSAo Q0dSZWN0KUNHUmVjdFZhbHVlCiAjcHJhZ21hIG1hcmsgLQogCiBAaW50ZXJmYWNlIFdlYlBERlZp ZXdQbGFjZWhvbGRlciAoKQoreworICAgIE5TU3RyaW5nICpfdGl0bGU7CisgICAgTlNBcnJheSAq X3BhZ2VSZWN0czsKKyAgICBOU0FycmF5ICpfcGFnZVlPcmlnaW5zOworICAgIENHUERGRG9jdW1l bnRSZWYgX2RvY3VtZW50OworICAgIFdlYkRhdGFTb3VyY2UgKl9kYXRhU291cmNlOyAvLyB3ZWFr IHRvIHByZXZlbnQgY3ljbGVzLgorICAgIAorICAgIE5TT2JqZWN0PFdlYlBERlZpZXdQbGFjZWhv bGRlckRlbGVnYXRlPiAqX2RlbGVnYXRlOworICAgIAorICAgIEJPT0wgX2RpZEZpbmlzaExvYWQ7 CisgICAgCisgICAgQ0dTaXplIF9jb250YWluZXJTaXplOworfQogCiAtICh2b2lkKV9ldmFsdWF0 ZUpTRm9yRG9jdW1lbnQ6KENHUERGRG9jdW1lbnRSZWYpZG9jdW1lbnQ7CiAtICh2b2lkKV91cGRh dGVUaXRsZUZvckRvY3VtZW50SWZBdmFpbGFibGU7Cg== 302433 2017-02-22 13:41:03 -0800 2017-02-22 15:40:17 -0800 Updated patch patch_WebPDFViewPlaceholder_v3 text/plain 2499 aakash_jain SW5kZXg6IFNvdXJjZS9XZWJLaXQvaW9zL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2lvcy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMjg0OCkKKysrIFNvdXJjZS9XZWJLaXQv aW9zL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTAyLTIy ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBNb3ZlIGlu c3RhbmNlIG1lbWJlcnMgZnJvbSBXZWJQREZWaWV3UGxhY2Vob2xkZXIuaCB0byBpbXBsZW1lbnRh dGlvbiBmaWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjg3MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFdlYlZpZXcvV2ViUERGVmlld1BsYWNlaG9sZGVyLmg6IE1vdmluZyBpbnN0YW5jZSBtZW1i ZXJzIHRvIGltcGxlbWVudGF0aW9uIGZpbGUuCisgICAgICAgICogV2ViVmlldy9XZWJQREZWaWV3 UGxhY2Vob2xkZXIubW06IERpdHRvLgorCiAyMDE3LTAyLTIyICBBYWthc2ggSmFpbiAgPGFha2Fz aF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3ZlIGlPUyBzcGVjaWZpYyBzeW1ib2xzIHRv IFdlYktpdC5pb3MuZXhwCkluZGV4OiBTb3VyY2UvV2ViS2l0L2lvcy9XZWJWaWV3L1dlYlBERlZp ZXdQbGFjZWhvbGRlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvaW9zL1dlYlZpZXcv V2ViUERGVmlld1BsYWNlaG9sZGVyLmgJKHJldmlzaW9uIDIxMjg0NCkKKysrIFNvdXJjZS9XZWJL aXQvaW9zL1dlYlZpZXcvV2ViUERGVmlld1BsYWNlaG9sZGVyLmgJKHdvcmtpbmcgY29weSkKQEAg LTM3LDE5ICszNyw3IEBACiAgICAgYmUgZHJhd24gdG8gdGhlIFVJIGJ5IHNvbWUgb3RoZXIgb2Jq ZWN0IChpZGVhbGx5IHRoZSBkZWxlZ2F0ZSBvZiB0aGlzIGNsYXNzKSB3aGlsZSBzdGlsbCBpbnRl cmZhY2luZwogICAgIHdpdGggV0FLIGFuZCBXZWJLaXQgY29ycmVjdGx5LgogKi8KLUBpbnRlcmZh Y2UgV2ViUERGVmlld1BsYWNlaG9sZGVyIDogV0FLVmlldyA8V2ViUERGRG9jdW1lbnRWaWV3LCBX ZWJQREZEb2N1bWVudFJlcHJlc2VudGF0aW9uPiB7Ci0gICAgTlNTdHJpbmcgKl90aXRsZTsKLSAg ICBOU0FycmF5ICpfcGFnZVJlY3RzOwotICAgIE5TQXJyYXkgKl9wYWdlWU9yaWdpbnM7Ci0gICAg Q0dQREZEb2N1bWVudFJlZiBfZG9jdW1lbnQ7Ci0gICAgV2ViRGF0YVNvdXJjZSAqX2RhdGFTb3Vy Y2U7IC8vIHdlYWsgdG8gcHJldmVudCBjeWNsZXMuCi0KLSAgICBOU09iamVjdDxXZWJQREZWaWV3 UGxhY2Vob2xkZXJEZWxlZ2F0ZT4gKl9kZWxlZ2F0ZTsKLQotICAgIEJPT0wgX2RpZEZpbmlzaExv YWQ7Ci0KLSAgICBDR1NpemUgX2NvbnRhaW5lclNpemU7Ci19CitAaW50ZXJmYWNlIFdlYlBERlZp ZXdQbGFjZWhvbGRlciA6IFdBS1ZpZXcgPFdlYlBERkRvY3VtZW50VmlldywgV2ViUERGRG9jdW1l bnRSZXByZXNlbnRhdGlvbj4KIAogLyohCiAgICAgQG1ldGhvZCBzZXRBc1BERkRvY1JlcEFuZFZp ZXcKSW5kZXg6IFNvdXJjZS9XZWJLaXQvaW9zL1dlYlZpZXcvV2ViUERGVmlld1BsYWNlaG9sZGVy Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvaW9zL1dlYlZpZXcvV2ViUERGVmlld1Bs YWNlaG9sZGVyLm1tCShyZXZpc2lvbiAyMTI4NDQpCisrKyBTb3VyY2UvV2ViS2l0L2lvcy9XZWJW aWV3L1dlYlBERlZpZXdQbGFjZWhvbGRlci5tbQkod29ya2luZyBjb3B5KQpAQCAtMTAyLDcgKzEw MiwxOSBAQCAtIChDR1NpemUpX2NvbXB1dGVQYWdlUmVjdHM6KENHUERGRG9jdW1lCiAKICNwcmFn bWEgbWFyayBXZWJQREZWaWV3UGxhY2Vob2xkZXIgaW1wbGVtZW50YXRpb24KIAotQGltcGxlbWVu dGF0aW9uIFdlYlBERlZpZXdQbGFjZWhvbGRlcgorQGltcGxlbWVudGF0aW9uIFdlYlBERlZpZXdQ bGFjZWhvbGRlciB7CisgICAgTlNTdHJpbmcgKl90aXRsZTsKKyAgICBOU0FycmF5ICpfcGFnZVJl Y3RzOworICAgIE5TQXJyYXkgKl9wYWdlWU9yaWdpbnM7CisgICAgQ0dQREZEb2N1bWVudFJlZiBf ZG9jdW1lbnQ7CisgICAgV2ViRGF0YVNvdXJjZSAqX2RhdGFTb3VyY2U7IC8vIHdlYWsgdG8gcHJl dmVudCBjeWNsZXMuCisgICAgCisgICAgTlNPYmplY3Q8V2ViUERGVmlld1BsYWNlaG9sZGVyRGVs ZWdhdGU+ICpfZGVsZWdhdGU7CisgICAgCisgICAgQk9PTCBfZGlkRmluaXNoTG9hZDsKKyAgICAK KyAgICBDR1NpemUgX2NvbnRhaW5lclNpemU7Cit9CiAKIEBzeW50aGVzaXplIGRlbGVnYXRlID0g X2RlbGVnYXRlOwogQHN5bnRoZXNpemUgcGFnZVJlY3RzID0gX3BhZ2VSZWN0czsK