<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>168701</bug_id>
          
          <creation_ts>2017-02-21 19:34:45 -0800</creation_ts>
          <short_desc>Export various NSString symbols from WebPreferencesPrivate.h</short_desc>
          <delta_ts>2017-02-21 21:10:44 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Aakash Jain">aakash_jain</reporter>
          <assigned_to name="Aakash Jain">aakash_jain</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>ap</cc>
    
    <cc>commit-queue</cc>
    
    <cc>juergen</cc>
    
    <cc>mitz</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1279734</commentid>
    <comment_count>0</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2017-02-21 19:34:45 -0800</bug_when>
    <thetext>There are few symbols which are &quot;extern NSString&quot; in WebKit/mac/WebView/WebPreferencesPrivate.h and are not exported. We should export these symbols so that the headers matches with the library.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1279737</commentid>
    <comment_count>1</comment_count>
      <attachid>302356</attachid>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2017-02-21 19:44:17 -0800</bug_when>
    <thetext>Created attachment 302356
Proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1279766</commentid>
    <comment_count>2</comment_count>
      <attachid>302356</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-02-21 21:10:40 -0800</bug_when>
    <thetext>Comment on attachment 302356
Proposed patch

Clearing flags on attachment: 302356

Committed r212805: &lt;http://trac.webkit.org/changeset/212805&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1279768</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-02-21 21:10:44 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>302356</attachid>
            <date>2017-02-21 19:44:17 -0800</date>
            <delta_ts>2017-02-21 21:10:40 -0800</delta_ts>
            <desc>Proposed patch</desc>
            <filename>patch_WebPreferencesPrivate</filename>
            <type>text/plain</type>
            <size>1153</size>
            <attacher name="Aakash Jain">aakash_jain</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMjc5NykKKysrIFNvdXJjZS9XZWJLaXQv
bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE3LTAyLTIx
ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBFeHBvcnQg
dmFyaW91cyBOU1N0cmluZyBzeW1ib2xzIGZyb20gV2ViUHJlZmVyZW5jZXNQcml2YXRlLmgKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODcwMQorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViS2l0LmV4
cDoKKwogMjAxNy0wMi0yMSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgog
CiAgICAgICAgIEFkZCBtaXNzaW5nIFdlYkNvbnNvbGVNZXNzYWdlIHN0cmluZyBrZXkKSW5kZXg6
IFNvdXJjZS9XZWJLaXQvbWFjL1dlYktpdC5leHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp
dC9tYWMvV2ViS2l0LmV4cAkocmV2aXNpb24gMjEyNzk3KQorKysgU291cmNlL1dlYktpdC9tYWMv
V2ViS2l0LmV4cAkod29ya2luZyBjb3B5KQpAQCAtMjM2LDcgKzIzNiwxMCBAQCBfV2ViUGx1Z0lu
Q29udGFpbmVyS2V5CiBfV2ViUGx1Z0luQ29udGFpbmluZ0VsZW1lbnRLZXkKIF9XZWJQbHVnSW5N
b2RlS2V5CiBfV2ViUGx1Z0luU2hvdWxkTG9hZE1haW5SZXNvdXJjZUtleQorX1dlYlByZWZlcmVu
Y2VzQ2FjaGVNb2RlbENoYW5nZWRJbnRlcm5hbE5vdGlmaWNhdGlvbgorX1dlYlByZWZlcmVuY2Vz
Q2hhbmdlZEludGVybmFsTm90aWZpY2F0aW9uCiBfV2ViUHJlZmVyZW5jZXNDaGFuZ2VkTm90aWZp
Y2F0aW9uCitfV2ViUHJlZmVyZW5jZXNSZW1vdmVkTm90aWZpY2F0aW9uCiBfV2ViU2NyaXB0RXJy
b3JEZXNjcmlwdGlvbktleQogX1dlYlNjcmlwdEVycm9yRG9tYWluCiBfV2ViU2NyaXB0RXJyb3JM
aW5lTnVtYmVyS2V5Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>