168688 2017-02-21 16:01:03 -0800 No need for static attributes when creating a pixel format 2017-02-21 17:24:48 -0800 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino commit-queue dino graouts kondapallykalyan webkit-bug-importer oldest_to_newest 1279605 0 dino 2017-02-21 16:01:03 -0800 GraphicsContext3DManager::updateHighPerformanceState() uses a static for some CGLPixelFormatAttributes. There isn't any point. Just create them each time. 1279607 1 webkit-bug-importer 2017-02-21 16:01:26 -0800 <rdar://problem/30642256> 1279608 2 302327 dino 2017-02-21 16:03:12 -0800 Created attachment 302327 Patch 1279638 3 302327 sam 2017-02-21 16:35:25 -0800 Comment on attachment 302327 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302327&action=review > Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:268 > + Vector<CGLPixelFormatAttribute> attributes; I think you can use initializer list syntax for this. Vector<CGLPixelFormatAttribute> attributes { kCGLPFAAccelerated, kCGLPFAColorSize, static_cast<CGLPixelFormatAttribute>(32), static_cast<CGLPixelFormatAttribute>(0) }; 1279677 4 dino 2017-02-21 17:24:48 -0800 Committed r212783: <http://trac.webkit.org/changeset/212783> 302327 2017-02-21 16:03:12 -0800 2017-02-21 16:35:00 -0800 Patch bug-168688-20170222110025.patch text/plain 2304 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyNzY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzFjZDM1YTMyM2FjMGZh ODM5MTRlZmNhMTY5ZTA5MzJkMGFkMmEwYS4uM2Y5NTI2NGEyNjJlOWY4ZjI1OWM4ZjQ4MTZlM2Mx MTgxOWJjNTI3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTAyLTIxICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBObyBuZWVkIGZvciBzdGF0aWMg YXR0cmlidXRlcyB3aGVuIGNyZWF0aW5nIGEgcGl4ZWwgZm9ybWF0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg2ODgKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzMwNjQyMjU2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEp1c3QgY3JlYXRlIHRoZSBhdHRyaWJ1dGVzIHdoZW4gbmVlZGVkLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0dyYXBoaWNzQ29udGV4dDNETWFjLm1tOgorICAg ICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0RNYW5hZ2VyOjp1cGRhdGVIaWdoUGVyZm9y bWFuY2VTdGF0ZSk6CisKIDIwMTctMDItMjEgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBh cHBsZS5jb20+CiAKICAgICAgICAgRml4IEltYWdlQml0bWFwIGNvbW1lbnQgdG8gbm90IGluc2Vy dCBhIDxjYW52YXM+LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvbWFjL0dyYXBoaWNzQ29udGV4dDNETWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvbWFjL0dyYXBoaWNzQ29udGV4dDNETWFjLm1tCmluZGV4IDM1YTBjZDhjODAzMGY3 MzM4Y2EwNjlkODJmZWY0NTc3ZmQ1NThmZGMuLjA5ZDcxYWQ0YzJhZDkxM2NlNjYyMzA0MDhhMjkz MDJlNDRiNzg3ZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L21hYy9HcmFwaGljc0NvbnRleHQzRE1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9tYWMvR3JhcGhpY3NDb250ZXh0M0RNYWMubW0KQEAgLTI2NSwxNCArMjY1LDEx IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0M0RNYW5hZ2VyOjp1cGRhdGVIaWdoUGVyZm9ybWFuY2VT dGF0ZSgpCiAgICAgICAgIGlmICghbV9waXhlbEZvcm1hdE9iaikgewogICAgICAgICAgICAgTE9H KFdlYkdMLCAiVHVybmluZyBvbiBoaWdoLXBlcmZvcm1hbmNlIEdQVS4iKTsKIAotICAgICAgICAg ICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPFZlY3RvcjxDR0xQaXhlbEZvcm1hdEF0dHJpYnV0ZT4+ IHBpeGVsRm9ybWF0QXR0cmlidXRlczsKLSAgICAgICAgICAgIFZlY3RvcjxDR0xQaXhlbEZvcm1h dEF0dHJpYnV0ZT4mIGF0dHJpYnV0ZXMgPSBwaXhlbEZvcm1hdEF0dHJpYnV0ZXMuZ2V0KCk7Ci0g ICAgICAgICAgICBpZiAoIWF0dHJpYnV0ZXMuc2l6ZSgpKSB7Ci0gICAgICAgICAgICAgICAgYXR0 cmlidXRlcy5hcHBlbmQoa0NHTFBGQUFjY2VsZXJhdGVkKTsKLSAgICAgICAgICAgICAgICBhdHRy aWJ1dGVzLmFwcGVuZChrQ0dMUEZBQ29sb3JTaXplKTsKLSAgICAgICAgICAgICAgICBhdHRyaWJ1 dGVzLmFwcGVuZChzdGF0aWNfY2FzdDxDR0xQaXhlbEZvcm1hdEF0dHJpYnV0ZT4oMzIpKTsKLSAg ICAgICAgICAgICAgICBhdHRyaWJ1dGVzLmFwcGVuZChzdGF0aWNfY2FzdDxDR0xQaXhlbEZvcm1h dEF0dHJpYnV0ZT4oMCkpOwotICAgICAgICAgICAgfQorICAgICAgICAgICAgVmVjdG9yPENHTFBp eGVsRm9ybWF0QXR0cmlidXRlPiBhdHRyaWJ1dGVzOworICAgICAgICAgICAgYXR0cmlidXRlcy5h cHBlbmQoa0NHTFBGQUFjY2VsZXJhdGVkKTsKKyAgICAgICAgICAgIGF0dHJpYnV0ZXMuYXBwZW5k KGtDR0xQRkFDb2xvclNpemUpOworICAgICAgICAgICAgYXR0cmlidXRlcy5hcHBlbmQoc3RhdGlj X2Nhc3Q8Q0dMUGl4ZWxGb3JtYXRBdHRyaWJ1dGU+KDMyKSk7CisgICAgICAgICAgICBhdHRyaWJ1 dGVzLmFwcGVuZChzdGF0aWNfY2FzdDxDR0xQaXhlbEZvcm1hdEF0dHJpYnV0ZT4oMCkpOwogICAg ICAgICAgICAgR0xpbnQgbnVtUGl4ZWxGb3JtYXRzID0gMDsKICAgICAgICAgICAgIENHTENob29z ZVBpeGVsRm9ybWF0KGF0dHJpYnV0ZXMuZGF0YSgpLCAmbV9waXhlbEZvcm1hdE9iaiwgJm51bVBp eGVsRm9ybWF0cyk7CiAgICAgICAgIH0K