168679 2017-02-21 14:59:57 -0800 Export various NSString symbols from WebUIDelegatePrivate.h 2017-02-21 15:51:33 -0800 1 1 1 Unclassified WebKit WebKit Misc. Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue joepeck juergen mitz oldest_to_newest 1279558 0 aakash_jain 2017-02-21 14:59:57 -0800 There are about 15 symbols which are "extern NSString" in WebUIDelegatePrivate.h. We should export these symbols so that the headers matches with the library. 1279561 1 302317 aakash_jain 2017-02-21 15:02:43 -0800 Created attachment 302317 Proposed patch 1279573 2 302317 joepeck 2017-02-21 15:21:38 -0800 Comment on attachment 302317 Proposed patch Looks like in source we have WebConsoleMessageContentBlockerMessageSource. Should we create an extern + exp entry for that as well? 1279577 3 aakash_jain 2017-02-21 15:25:25 -0800 Possibly! I think that should be a separate patch. 1279596 4 302317 commit-queue 2017-02-21 15:51:28 -0800 Comment on attachment 302317 Proposed patch Clearing flags on attachment: 302317 Committed r212774: <http://trac.webkit.org/changeset/212774> 1279597 5 commit-queue 2017-02-21 15:51:33 -0800 All reviewed patches have been landed. Closing bug. 302317 2017-02-21 15:02:43 -0800 2017-02-21 15:51:28 -0800 Proposed patch patch_export_nsstrings text/plain 1603 aakash_jain SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMjc2NykKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE3LTAyLTIx ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBFeHBvcnQg dmFyaW91cyBOU1N0cmluZyBzeW1ib2xzIGZyb20gV2ViVUlEZWxlZ2F0ZVByaXZhdGUuaAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4Njc5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJLaXQuZXhw OgorCiAyMDE3LTAyLTIxICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAg ICAgICBbaU9TXSBXZWJLaXQxIHNob3VsZCB1c2Ugc2hhcmVkIG1lbW9yeSBwcmVzc3VyZSBoYW5k bGVyIGNvZGUuCkluZGV4OiBTb3VyY2UvV2ViS2l0L21hYy9XZWJLaXQuZXhwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQvbWFjL1dlYktpdC5leHAJKHJldmlzaW9uIDIxMjcxMikKKysrIFNv dXJjZS9XZWJLaXQvbWFjL1dlYktpdC5leHAJKHdvcmtpbmcgY29weSkKQEAgLTE1Niw2ICsxNTYs MjEgQEAgX1dlYkFjdGlvbk1vZGlmaWVyRmxhZ3NLZXkKIF9XZWJBY3Rpb25OYXZpZ2F0aW9uVHlw ZUtleQogX1dlYkFjdGlvbk9yaWdpbmFsVVJMS2V5CiBfV2ViQXJjaGl2ZVBib2FyZFR5cGUKK19X ZWJDb25zb2xlTWVzc2FnZUFwcENhY2hlTWVzc2FnZVNvdXJjZQorX1dlYkNvbnNvbGVNZXNzYWdl Q1NTTWVzc2FnZVNvdXJjZQorX1dlYkNvbnNvbGVNZXNzYWdlQ29uc29sZUFQSU1lc3NhZ2VTb3Vy Y2UKK19XZWJDb25zb2xlTWVzc2FnZURlYnVnTWVzc2FnZUxldmVsCitfV2ViQ29uc29sZU1lc3Nh Z2VFcnJvck1lc3NhZ2VMZXZlbAorX1dlYkNvbnNvbGVNZXNzYWdlSW5mb01lc3NhZ2VMZXZlbAor X1dlYkNvbnNvbGVNZXNzYWdlSlNNZXNzYWdlU291cmNlCitfV2ViQ29uc29sZU1lc3NhZ2VMb2dN ZXNzYWdlTGV2ZWwKK19XZWJDb25zb2xlTWVzc2FnZU5ldHdvcmtNZXNzYWdlU291cmNlCitfV2Vi Q29uc29sZU1lc3NhZ2VPdGhlck1lc3NhZ2VTb3VyY2UKK19XZWJDb25zb2xlTWVzc2FnZVJlbmRl cmluZ01lc3NhZ2VTb3VyY2UKK19XZWJDb25zb2xlTWVzc2FnZVNlY3VyaXR5TWVzc2FnZVNvdXJj ZQorX1dlYkNvbnNvbGVNZXNzYWdlU3RvcmFnZU1lc3NhZ2VTb3VyY2UKK19XZWJDb25zb2xlTWVz c2FnZVdhcm5pbmdNZXNzYWdlTGV2ZWwKK19XZWJDb25zb2xlTWVzc2FnZVhNTE1lc3NhZ2VTb3Vy Y2UKIF9XZWJEYXRhYmFzZURpZE1vZGlmeURhdGFiYXNlTm90aWZpY2F0aW9uCiBfV2ViRGF0YWJh c2VEaWRNb2RpZnlPcmlnaW5Ob3RpZmljYXRpb24KIF9XZWJEYXRhYmFzZURpcmVjdG9yeURlZmF1 bHRzS2V5Cg==