168674 2017-02-21 14:21:44 -0800 Export symbols for various classes present in webkit SPI 2017-02-22 08:51:04 -0800 1 1 1 Unclassified WebKit WebKit Misc. Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=168726 P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue juergen mitz oldest_to_newest 1279528 0 aakash_jain 2017-02-21 14:21:44 -0800 Various interfaces in WebKit are present in private headers, however the corresponding symbols are not included in .exp file. We should export these symbols so that the headers matches with the library. 1279530 1 302306 aakash_jain 2017-02-21 14:25:27 -0800 Created attachment 302306 Proposed patch 1279569 2 302306 commit-queue 2017-02-21 15:18:28 -0800 Comment on attachment 302306 Proposed patch Clearing flags on attachment: 302306 Committed r212770: <http://trac.webkit.org/changeset/212770> 1279570 3 commit-queue 2017-02-21 15:18:33 -0800 All reviewed patches have been landed. Closing bug. 1279782 4 302306 ap 2017-02-21 22:29:48 -0800 Comment on attachment 302306 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=302306&action=review > Source/WebKit/mac/WebKit.exp:156 > +.objc_class_name_WKQuadObject WKQuadObject surprises me a lot. Both interface and implementation are iOS only, why didn't this patch break the build? 1279902 5 aakash_jain 2017-02-22 08:50:14 -0800 You are right. It is iOS specific. Good catch. It probably did not break the build, because ld considered it as a warning instead of error. Here is output when I did a local 32-bit mac build. ld: warning: ignoring undefined symbol .objc_class_name_WKQuadObject from -exported_symbols_list ld: warning: ignoring undefined symbol .objc_class_name_WebVisiblePosition from -exported_symbols_list ld: warning: ignoring undefined symbol .objc_class_name_WebFixedPositionContent from -exported_symbols_list ld: warning: ignoring undefined symbol .objc_class_name_WebGeolocation from -exported_symbols_list 1279903 6 aakash_jain 2017-02-22 08:51:04 -0800 fix in https://bugs.webkit.org/show_bug.cgi?id=168726 302306 2017-02-21 14:25:27 -0800 2017-02-21 15:18:28 -0800 Proposed patch patch_export_classes text/plain 2255 aakash_jain SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMjc1NikKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE3LTAyLTIx ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBFeHBvcnQg c3ltYm9scyBmb3IgdmFyaW91cyBjbGFzc2VzIHByZXNlbnQgaW4gd2Via2l0IFNQSQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4Njc0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJLaXQuZXhwOgor CiAyMDE3LTAyLTIxICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAg ICBbaU9TXSBXZWJLaXQxIHNob3VsZCB1c2Ugc2hhcmVkIG1lbW9yeSBwcmVzc3VyZSBoYW5kbGVy IGNvZGUuCkluZGV4OiBTb3VyY2UvV2ViS2l0L21hYy9XZWJLaXQuZXhwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQvbWFjL1dlYktpdC5leHAJKHJldmlzaW9uIDIxMjcxMikKKysrIFNvdXJj ZS9XZWJLaXQvbWFjL1dlYktpdC5leHAJKHdvcmtpbmcgY29weSkKQEAgLTk4LDYgKzk4LDcgQEAK IC5vYmpjX2NsYXNzX25hbWVfRE9NTm9kZQogLm9iamNfY2xhc3NfbmFtZV9ET01Ob2RlSXRlcmF0 b3IKIC5vYmpjX2NsYXNzX25hbWVfRE9NTm9kZUxpc3QKKy5vYmpjX2NsYXNzX25hbWVfRE9NT2Jq ZWN0CiAub2JqY19jbGFzc19uYW1lX0RPTU92ZXJmbG93RXZlbnQKIC5vYmpjX2NsYXNzX25hbWVf RE9NUHJvY2Vzc2luZ0luc3RydWN0aW9uCiAub2JqY19jbGFzc19uYW1lX0RPTVByb2dyZXNzRXZl bnQKQEAgLTEyMSwxMyArMTIyLDE2IEBACiAub2JqY19jbGFzc19uYW1lX1dlYkNvcmVTdGF0aXN0 aWNzCiAub2JqY19jbGFzc19uYW1lX1dlYkRhdGFTb3VyY2UKIC5vYmpjX2NsYXNzX25hbWVfV2Vi RGF0YWJhc2VNYW5hZ2VyCisub2JqY19jbGFzc19uYW1lX1dlYkRhdGFiYXNlUXVvdGFNYW5hZ2Vy CiAub2JqY19jbGFzc19uYW1lX1dlYkRlZmF1bHRQb2xpY3lEZWxlZ2F0ZQogLm9iamNfY2xhc3Nf bmFtZV9XZWJEZXZpY2VPcmllbnRhdGlvbgogLm9iamNfY2xhc3NfbmFtZV9XZWJEZXZpY2VPcmll bnRhdGlvblByb3ZpZGVyTW9jawogLm9iamNfY2xhc3NfbmFtZV9XZWJEb3dubG9hZAorLm9iamNf Y2xhc3NfbmFtZV9XZWJGaXhlZFBvc2l0aW9uQ29udGVudAogLm9iamNfY2xhc3NfbmFtZV9XZWJG b3JtRGVsZWdhdGUKIC5vYmpjX2NsYXNzX25hbWVfV2ViRnJhbWUKIC5vYmpjX2NsYXNzX25hbWVf V2ViRnJhbWVWaWV3Cisub2JqY19jbGFzc19uYW1lX1dlYkdlb2xvY2F0aW9uCiAub2JqY19jbGFz c19uYW1lX1dlYkdlb2xvY2F0aW9uUG9zaXRpb24KIC5vYmpjX2NsYXNzX25hbWVfV2ViSFRNTFJl cHJlc2VudGF0aW9uCiAub2JqY19jbGFzc19uYW1lX1dlYkhUTUxWaWV3CkBAIC0xMzUsNyArMTM5 LDEwIEBACiAub2JqY19jbGFzc19uYW1lX1dlYkhpc3RvcnlJdGVtCiAub2JqY19jbGFzc19uYW1l X1dlYkluc3BlY3RvcgogLm9iamNfY2xhc3NfbmFtZV9XZWJLaXRTdGF0aXN0aWNzCisub2JqY19j bGFzc19uYW1lX1dlYk5hdmlnYXRpb25EYXRhCisub2JqY19jbGFzc19uYW1lX1dlYk5vdGlmaWNh dGlvbgogLm9iamNfY2xhc3NfbmFtZV9XZWJQbHVnaW5EYXRhYmFzZQorLm9iamNfY2xhc3NfbmFt ZV9XZWJQb2xpY3lEZWNpc2lvbkxpc3RlbmVyCiAub2JqY19jbGFzc19uYW1lX1dlYlByZWZlcmVu Y2VzCiAub2JqY19jbGFzc19uYW1lX1dlYlJlc291cmNlCiAub2JqY19jbGFzc19uYW1lX1dlYlNj cmlwdENhbGxGcmFtZQpAQCAtMTQ1LDYgKzE1Miw4IEBACiAub2JqY19jbGFzc19uYW1lX1dlYlRl eHRJdGVyYXRvcgogLm9iamNfY2xhc3NfbmFtZV9XZWJVc2VyQ29udGVudFVSTFBhdHRlcm4KIC5v YmpjX2NsYXNzX25hbWVfV2ViVmlldworLm9iamNfY2xhc3NfbmFtZV9XZWJWaXNpYmxlUG9zaXRp b24KKy5vYmpjX2NsYXNzX25hbWVfV0tRdWFkT2JqZWN0CiBfRE9NRXhjZXB0aW9uCiBfRE9NUmFu Z2VFeGNlcHRpb24KIF9ET01FdmVudEV4Y2VwdGlvbgo=