168669 2017-02-21 12:40:18 -0800 Using the touchbar, both align left and align justify send a beforeinput event with the 'formatJustifyLeft' inputType. 2019-02-06 09:18:40 -0800 1 1 1 Unclassified WebKit DOM Safari Technology Preview Mac macOS 10.12 RESOLVED FIXED InRadar P2 Normal --- 1 charleyroy wenson_hsieh bdakin commit-queue ssaviano webkit-bug-importer wenson_hsieh oldest_to_newest 1279477 0 charleyroy 2017-02-21 12:40:18 -0800 Using the Safari Tech Preview, whether I press Left Align in the touch bar or Justify Align, a beforeinput event is sent with the event type 'formatJustifyLeft'. Note that right align and center align do 'formatJustifyRight' and 'formatJustifyCenter' respectively. This is problematic as developers can't differentiate which alignment option was selected. Test bed: https://jsfiddle.net/L8qzozom/ 1279520 1 webkit-bug-importer 2017-02-21 14:01:12 -0800 <rdar://problem/30639155> 1279551 2 wenson_hsieh 2017-02-21 14:50:42 -0800 Currently, the input events spec only has "formatJustifyCenter", "formatJustifyRight", and "formatJustifyLeft" input types. As you pointed out, the spec needs a way of differentiating left-aligned justified alignment from left-aligned unjustified alignment. Perhaps we need input types for "formatAlignLeft", "formatAlignCenter" and "formatAlignRight"? 1342281 3 wenson_hsieh 2017-08-24 18:02:37 -0700 I filed <https://github.com/w3c/input-events/issues/68> regarding how we can't distinguish between justifying and just aligning text. Would "formatAlign{Left|Center|Right}" and a separate "formatJustify" inputType be more appropriate here? 1342396 4 wenson_hsieh 2017-08-25 09:15:21 -0700 From https://github.com/w3c/input-events/issues/68, Johannes proposed adding a new "formatJustifyFull" input type to capture the behavior of the rightmost "justify" button in the touch bar's rich text editing UI, so the alignment controls on the touch bar would emit (from left to right): "formatJustifyLeft", "formatJustifyCenter", "formatJustifyRight" and "formatJustifyFull". Does this sound reasonable? 1342430 5 319087 wenson_hsieh 2017-08-25 10:13:03 -0700 Created attachment 319087 Patch 1342473 6 319087 commit-queue 2017-08-25 12:04:27 -0700 Comment on attachment 319087 Patch Clearing flags on attachment: 319087 Committed r221199: <http://trac.webkit.org/changeset/221199> 1342474 7 commit-queue 2017-08-25 12:04:28 -0700 All reviewed patches have been landed. Closing bug. 1503219 8 lforschler 2019-02-06 09:18:40 -0800 Mass move bugs into the DOM component. 319087 2017-08-25 10:13:03 -0700 2017-08-25 12:04:27 -0700 Patch bug-168669-20170825101302.patch text/plain 6655 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxMTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjdhYzM3ODgzZTNiNmRl NWFlYjYyNDRhN2FmYjgwZTZmMDkwNjEzNS4uZWQ0NzE3MDBmZDYyMDliZjA5YTZmODQxZGE3MDc4 YzkwNjJiOWFlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA4LTI1ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFVzaW5nIHRoZSB0 b3VjaGJhciwgYm90aCBhbGlnbiBsZWZ0IGFuZCBhbGlnbiBqdXN0aWZ5IHNlbmQgYSBiZWZvcmVp bnB1dCBldmVudCB3aXRoIHRoZSAnZm9ybWF0SnVzdGlmeUxlZnQnIGlucHV0VHlwZS4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODY2OQorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMzA2MzkxNTU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgU21hbGwgdHdlYWsgdG8gYWRkIGEgImZvcm1hdEp1c3RpZnlG dWxsIiBpbnB1dFR5cGUgd2hlbiBqdXN0aWZ5aW5nIHRleHQgdXNpbmcgdGhlIHRvdWNoIGJhcidz IHJpY2ggdGV4dAorICAgICAgICBmb3JtYXR0aW5nIGNvbnRyb2xzLiBDdXJyZW50bHksIHRoZSBF ZGl0QWN0aW9uSnVzdGlmeSBlZGl0IGNvbW1hbmQgaW5jb3JyZWN0bHkgbWFwcyB0byAiZm9ybWF0 SnVzdGlmeUxlZnQiLgorCisgICAgICAgIFRlc3Q6IGZhc3QvZXZlbnRzL2lucHV0LWV2ZW50cy10 ZXh0LWFsaWdubWVudC5odG1sCisKKyAgICAgICAgKiBlZGl0aW5nL0VkaXRDb21tYW5kLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OmlucHV0VHlwZU5hbWVGb3JFZGl0aW5nQWN0aW9uKToKKwogMjAx Ny0wOC0yNSAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIyMTE4MS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2VkaXRpbmcvRWRpdENvbW1hbmQuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0Q29t bWFuZC5jcHAKaW5kZXggOGNjMTBjN2NiM2FkNDFmZTg1YzZkMmE3YmJlOWNhODc5ODRkNDZjMy4u MmNlMDhjN2YwYzcyODU0MTFjYTUxNWMyMzA0NDY4ZTBlOWNlMjdlNiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0Q29tbWFuZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv ZWRpdGluZy9FZGl0Q29tbWFuZC5jcHAKQEAgLTQzLDYgKzQzLDcgQEAgU3RyaW5nIGlucHV0VHlw ZU5hbWVGb3JFZGl0aW5nQWN0aW9uKEVkaXRBY3Rpb24gYWN0aW9uKQogewogICAgIHN3aXRjaCAo YWN0aW9uKSB7CiAgICAgY2FzZSBFZGl0QWN0aW9uSnVzdGlmeToKKyAgICAgICAgcmV0dXJuIEFT Q0lJTGl0ZXJhbCgiZm9ybWF0SnVzdGlmeUZ1bGwiKTsKICAgICBjYXNlIEVkaXRBY3Rpb25BbGln bkxlZnQ6CiAgICAgICAgIHJldHVybiBBU0NJSUxpdGVyYWwoImZvcm1hdEp1c3RpZnlMZWZ0Iik7 CiAgICAgY2FzZSBFZGl0QWN0aW9uQWxpZ25SaWdodDoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA5MzI4ZmRiZjk0NDBiMWU4 Y2ZjMTdiYTU5OGQ1YjA3ZjgyZWQyMjMxLi5hZDYyNTcwZGMyNTEzYWZjOGQwMzY4YmU1MzNjYTcw OGNjMjJiYTg5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTctMDgtMjUgIFdlbnNvbiBIc2ll aCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgVXNpbmcgdGhlIHRvdWNoYmFy LCBib3RoIGFsaWduIGxlZnQgYW5kIGFsaWduIGp1c3RpZnkgc2VuZCBhIGJlZm9yZWlucHV0IGV2 ZW50IHdpdGggdGhlICdmb3JtYXRKdXN0aWZ5TGVmdCcgaW5wdXRUeXBlLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4NjY5CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8zMDYzOTE1NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGRzIGEgbmV3IExheW91dFRlc3QgY2hlY2tpbmcgdGhhdCB0aGUgdGV4 dCBhbGlnbm1lbnQgZWRpdG9yIGNvbW1hbmRzLCAiQWxpZ257UmlnaHR8Q2VudGVyfExlZnR8SnVz dGlmeX0iLAorICAgICAgICBjb3JyZWN0bHkgcHJvcGFnYXRlIGlucHV0IGV2ZW50cyBhbmQgYmVm b3JlaW5wdXQgZXZlbnRzIG9mIGlucHV0VHlwZSAiZm9ybWF0SnVzdGlmeXtSaWdodHxDZW50ZXJ8 TGVmdHxKdXN0aWZ5fSIsCisgICAgICAgIGFuZCB0aGF0IHRoZXNlIHRleHQgYWxpZ25tZW50IHN0 eWxlIGNoYW5nZXMgY2FuIGJlIHByZXZlbnRlZCBieSBjYWxsaW5nIHByZXZlbnREZWZhdWx0KCkg b24gdGhlIGRpc3BhdGNoZWQKKyAgICAgICAgYmVmb3JlaW5wdXQgZXZlbnQuCisKKyAgICAgICAg KiBmYXN0L2V2ZW50cy9pbnB1dC1ldmVudHMtdGV4dC1hbGlnbm1lbnQtZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKyAgICAgICAgKiBmYXN0L2V2ZW50cy9pbnB1dC1ldmVudHMtdGV4dC1hbGlnbm1lbnQu aHRtbDogQWRkZWQuCisKIDIwMTctMDgtMjUgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBw bGUuY29tPgogCiAgICAgICAgIE1hbmFnZSB0ZXN0cyB3aGljaCByZXF1aXJlIGRpZmZlcmVudCBk ZXZpY2UgdHlwZXMgYmV0dGVyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9p bnB1dC1ldmVudHMtdGV4dC1hbGlnbm1lbnQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFz dC9ldmVudHMvaW5wdXQtZXZlbnRzLXRleHQtYWxpZ25tZW50LWV4cGVjdGVkLnR4dApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi4zYzg4NTUyMTNhZjE0ODZiMDc4ODlmOGY3ZjJmMGVjNDMwOTRiZmM4Ci0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvaW5wdXQtZXZlbnRzLXRleHQtYWxpZ25t ZW50LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDMzIEBACitUbyBtYW51YWxseSB0ZXN0IHRoaXMs IGNoYW5nZSB0aGUgdGV4dCBhbGlnbm1lbnQgYW5kIGNoZWNrIHRoZSByZXN1bHRpbmcgZGVidWcg bWVzc2FnZXMuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIg bWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitiZWZvcmVpbnB1dCAo aW5wdXRUeXBlID0gZm9ybWF0SnVzdGlmeUNlbnRlcikKK2lucHV0IChpbnB1dFR5cGUgPSBmb3Jt YXRKdXN0aWZ5Q2VudGVyKQorZ2V0Q29tcHV0ZWRTdHlsZSh0ZXh0KS50ZXh0QWxpZ24gPSAnY2Vu dGVyJworYmVmb3JlaW5wdXQgKGlucHV0VHlwZSA9IGZvcm1hdEp1c3RpZnlSaWdodCkKK2lucHV0 IChpbnB1dFR5cGUgPSBmb3JtYXRKdXN0aWZ5UmlnaHQpCitnZXRDb21wdXRlZFN0eWxlKHRleHQp LnRleHRBbGlnbiA9ICdyaWdodCcKK2JlZm9yZWlucHV0IChpbnB1dFR5cGUgPSBmb3JtYXRKdXN0 aWZ5TGVmdCkKK2lucHV0IChpbnB1dFR5cGUgPSBmb3JtYXRKdXN0aWZ5TGVmdCkKK2dldENvbXB1 dGVkU3R5bGUodGV4dCkudGV4dEFsaWduID0gJ2xlZnQnCitiZWZvcmVpbnB1dCAoaW5wdXRUeXBl ID0gZm9ybWF0SnVzdGlmeUZ1bGwpCitpbnB1dCAoaW5wdXRUeXBlID0gZm9ybWF0SnVzdGlmeUZ1 bGwpCitnZXRDb21wdXRlZFN0eWxlKHRleHQpLnRleHRBbGlnbiA9ICdqdXN0aWZ5JworYmVmb3Jl aW5wdXQgKGlucHV0VHlwZSA9IGZvcm1hdEp1c3RpZnlDZW50ZXIpCitQcmV2ZW50ZWQgZGVmYXVs dAorZ2V0Q29tcHV0ZWRTdHlsZSh0ZXh0KS50ZXh0QWxpZ24gPSAnanVzdGlmeScKK2JlZm9yZWlu cHV0IChpbnB1dFR5cGUgPSBmb3JtYXRKdXN0aWZ5UmlnaHQpCitQcmV2ZW50ZWQgZGVmYXVsdAor Z2V0Q29tcHV0ZWRTdHlsZSh0ZXh0KS50ZXh0QWxpZ24gPSAnanVzdGlmeScKK2JlZm9yZWlucHV0 IChpbnB1dFR5cGUgPSBmb3JtYXRKdXN0aWZ5TGVmdCkKK1ByZXZlbnRlZCBkZWZhdWx0CitnZXRD b21wdXRlZFN0eWxlKHRleHQpLnRleHRBbGlnbiA9ICdqdXN0aWZ5JworYmVmb3JlaW5wdXQgKGlu cHV0VHlwZSA9IGZvcm1hdEp1c3RpZnlGdWxsKQorUHJldmVudGVkIGRlZmF1bHQKK2dldENvbXB1 dGVkU3R5bGUodGV4dCkudGV4dEFsaWduID0gJ2p1c3RpZnknCitQQVNTIHN1Y2Nlc3NmdWxseVBh cnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKK1dlYktpdApkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9ldmVudHMvaW5wdXQtZXZlbnRzLXRleHQtYWxpZ25tZW50Lmh0bWwgYi9MYXlv dXRUZXN0cy9mYXN0L2V2ZW50cy9pbnB1dC1ldmVudHMtdGV4dC1hbGlnbm1lbnQuaHRtbApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi43MzhjODI3N2ExNjI5NWFiYWU3YjgzOThhYWU2N2IwNzIzNjQwYWRhCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvaW5wdXQtZXZlbnRzLXRleHQtYWxp Z25tZW50Lmh0bWwKQEAgLTAsMCArMSw0OCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxo ZWFkPgorICAgIDxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwv c2NyaXB0PgorPC9oZWFkPgorPGJvZHk+CisgICAgPGRpdiBpZD0iZWRpdGFibGUiIGNvbnRlbnRl ZGl0YWJsZSBvbmJlZm9yZWlucHV0PWhhbmRsZUlucHV0KGV2ZW50KSBvbmlucHV0PWhhbmRsZUlu cHV0KGV2ZW50KT48ZGl2IGlkPSJ0ZXh0Ij5XZWJLaXQ8L2Rpdj48L2Rpdj4KKyAgICA8c2NyaXB0 IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CisgICAgICAgIGRlc2NyaXB0aW9uKCJUbyBtYW51YWxs eSB0ZXN0IHRoaXMsIGNoYW5nZSB0aGUgdGV4dCBhbGlnbm1lbnQgYW5kIGNoZWNrIHRoZSByZXN1 bHRpbmcgZGVidWcgbWVzc2FnZXMuIik7CisKKyAgICAgICAgbGV0IHJhbmdlID0gZG9jdW1lbnQu Y3JlYXRlUmFuZ2UoKTsKKyAgICAgICAgcmFuZ2Uuc2V0U3RhcnRCZWZvcmUodGV4dCk7CisgICAg ICAgIHJhbmdlLnNldEVuZEFmdGVyKHRleHQpOworICAgICAgICBnZXRTZWxlY3Rpb24oKS5hZGRS YW5nZShyYW5nZSk7CisKKyAgICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAgICAg ICAgICBwcmV2ZW50RGVmYXVsdEZvckJlZm9yZUlucHV0RXZlbnRzID0gZmFsc2U7CisKKyAgICAg ICAgICAgIGV4ZWNDb21tYW5kQW5kTG9nQ29tcHV0ZWRUZXh0QWxpZ25tZW50U3R5bGUoIkFsaWdu Q2VudGVyIik7CisgICAgICAgICAgICBleGVjQ29tbWFuZEFuZExvZ0NvbXB1dGVkVGV4dEFsaWdu bWVudFN0eWxlKCJBbGlnblJpZ2h0Iik7CisgICAgICAgICAgICBleGVjQ29tbWFuZEFuZExvZ0Nv bXB1dGVkVGV4dEFsaWdubWVudFN0eWxlKCJBbGlnbkxlZnQiKTsKKyAgICAgICAgICAgIGV4ZWND b21tYW5kQW5kTG9nQ29tcHV0ZWRUZXh0QWxpZ25tZW50U3R5bGUoIkFsaWduSnVzdGlmaWVkIik7 CisKKyAgICAgICAgICAgIHByZXZlbnREZWZhdWx0Rm9yQmVmb3JlSW5wdXRFdmVudHMgPSB0cnVl OworCisgICAgICAgICAgICBleGVjQ29tbWFuZEFuZExvZ0NvbXB1dGVkVGV4dEFsaWdubWVudFN0 eWxlKCJBbGlnbkNlbnRlciIpOworICAgICAgICAgICAgZXhlY0NvbW1hbmRBbmRMb2dDb21wdXRl ZFRleHRBbGlnbm1lbnRTdHlsZSgiQWxpZ25SaWdodCIpOworICAgICAgICAgICAgZXhlY0NvbW1h bmRBbmRMb2dDb21wdXRlZFRleHRBbGlnbm1lbnRTdHlsZSgiQWxpZ25MZWZ0Iik7CisgICAgICAg ICAgICBleGVjQ29tbWFuZEFuZExvZ0NvbXB1dGVkVGV4dEFsaWdubWVudFN0eWxlKCJBbGlnbkp1 c3RpZmllZCIpOworICAgICAgICB9CisKKyAgICAgICAgZnVuY3Rpb24gaGFuZGxlSW5wdXQoZXZl bnQpCisgICAgICAgIHsKKyAgICAgICAgICAgIGRlYnVnKGAke2V2ZW50LnR5cGV9IChpbnB1dFR5 cGUgPSAke2V2ZW50LmlucHV0VHlwZX0pYCk7CisgICAgICAgICAgICBpZiAod2luZG93LnByZXZl bnREZWZhdWx0Rm9yQmVmb3JlSW5wdXRFdmVudHMgJiYgZXZlbnQudHlwZSA9PT0gImJlZm9yZWlu cHV0IikgeworICAgICAgICAgICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CisgICAgICAg ICAgICAgICAgZGVidWcoIlByZXZlbnRlZCBkZWZhdWx0Iik7CisgICAgICAgICAgICB9CisgICAg ICAgIH0KKworICAgICAgICBmdW5jdGlvbiBleGVjQ29tbWFuZEFuZExvZ0NvbXB1dGVkVGV4dEFs aWdubWVudFN0eWxlKGNvbW1hbmQpIHsKKyAgICAgICAgICAgIHRlc3RSdW5uZXIuZXhlY0NvbW1h bmQoY29tbWFuZCk7CisgICAgICAgICAgICBkZWJ1ZyhgZ2V0Q29tcHV0ZWRTdHlsZSh0ZXh0KS50 ZXh0QWxpZ24gPSAnJHtnZXRDb21wdXRlZFN0eWxlKHRleHQpLnRleHRBbGlnbn0nYCk7CisgICAg ICAgIH0KKyAgICA8L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pz LXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==