168662 2017-02-21 10:04:58 -0800 [GStreamer] Crash in MediaPlayerPrivateGStreamerMSE::buffered() when MEDIA_STREAM is disabled 2017-02-22 00:33:49 -0800 1 1 1 Unclassified WebKit Platform WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned mcatanzaro oldest_to_newest 1279396 0 cgarcia 2017-02-21 10:04:58 -0800 When MEDIA_STREAM is disable, if MediaPlayer::loadWithNextMediaEngine is called with a current engine, and there's no type specified, the next media engine that is used is the MSE one. Since there's no actually a media stream, the engine is created but never loaded. When buffered is called it tries to use its media source that is nullptr. It doesn't happen when MEDIA_STREAM is enabled, because the next media engine returned is Owr that doesn't implement buffered and always returns an empty PlatformTimeRanges. #0 0x00007f9a7db0b61b in WebCore::MediaPlayerPrivateGStreamerMSE::buffered() const [clone .localalias.94] () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #1 0x00007f9a7d5d3681 in WebCore::MediaPlayer::buffered() () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #2 0x00007f9a7d1c11db in WebCore::HTMLMediaElement::buffered() const () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #3 0x00007f9a7dbe2968 in WebCore::RenderThemeGtk::paintMediaSliderTrack(WebCore::RenderObject const&, WebCore::PaintInfo const&, WebCore::IntRect const&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #4 0x00007f9a7d846a0d in WebCore::RenderTheme::paint(WebCore::RenderBox const&, WebCore::ControlStates&, WebCore::PaintInfo const&, WebCore::LayoutRect const&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #5 0x00007f9a7d705f03 in WebCore::RenderBox::paintBoxDecorations(WebCore::PaintInfo&, WebCore::LayoutPoint const&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 1279397 1 302275 cgarcia 2017-02-21 10:07:11 -0800 Created attachment 302275 Patch 1279442 2 mcatanzaro 2017-02-21 11:19:27 -0800 Hold up. Why is a MediaPlayerPrivateGStreamerMSE ever created if MEDIA_STREAM is disabled? It sounds like we should address that design issue instead of papering over this. 1279444 3 302275 mcatanzaro 2017-02-21 11:20:06 -0800 Comment on attachment 302275 Patch Sorry, I mixed up MEDIA_SOURCE and MEDIA_STREAM. 1279814 4 cgarcia 2017-02-22 00:33:49 -0800 Committed r212815: <http://trac.webkit.org/changeset/212815> 302275 2017-02-21 10:07:11 -0800 2017-02-21 11:20:06 -0800 Patch wcore-gst-mse-crash.diff text/plain 2152 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiMWMyOTY0ODhkMi4uZTU2MzcyYmJjOWIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMSBAQAogMjAxNy0wMi0yMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKKyAgICAgICAgW0dTdHJlYW1lcl0gQ3Jhc2ggaW4gTWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyTVNFOjpidWZmZXJlZCgpIHdoZW4gTUVESUFfU1RSRUFNIGlzIGRpc2FibGVk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg2NjIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIE1F RElBX1NUUkVBTSBpcyBkaXNhYmxlZCwgaWYgTWVkaWFQbGF5ZXI6OmxvYWRXaXRoTmV4dE1lZGlh RW5naW5lIGlzIGNhbGxlZCB3aXRoIGEgY3VycmVudCBlbmdpbmUgYW5kCisgICAgICAgIHRoZXJl J3Mgbm8gdHlwZSBzcGVjaWZpZWQsIHRoZSBuZXh0IG1lZGlhIGVuZ2luZSB0aGF0IGlzIHVzZWQg aXMgdGhlIE1TRSBvbmUuIFNpbmNlIHRoZXJlJ3Mgbm8gYWN0dWFsbHkgYSBtZWRpYQorICAgICAg ICBzdHJlYW0sIHRoZSBlbmdpbmUgaXMgY3JlYXRlZCBidXQgbmV2ZXIgbG9hZGVkLiBXaGVuIGJ1 ZmZlcmVkIGlzIGNhbGxlZCBpdCB0cmllcyB0byB1c2UgaXRzIG1lZGlhIHNvdXJjZSB0aGF0IGlz CisgICAgICAgIG51bGxwdHIuIEl0IGRvZXNuJ3QgaGFwcGVuIHdoZW4gTUVESUFfU1RSRUFNIGlz IGVuYWJsZWQsIGJlY2F1c2UgdGhlIG5leHQgbWVkaWEgZW5naW5lIHJldHVybmVkIGlzIE93ciB0 aGF0CisgICAgICAgIGRvZXNuJ3QgaW1wbGVtZW50IGJ1ZmZlcmVkIGFuZCBhbHdheXMgcmV0dXJu cyBhbiBlbXB0eSBQbGF0Zm9ybVRpbWVSYW5nZXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvbXNlL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck1TRS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJNU0U6OmJ1ZmZlcmVk KTogUmV0dXJuIGFuIGVtcHR5IFBsYXRmb3JtVGltZVJhbmdlcyBpZiBtX21lZGlhU291cmNlIGlz IG51bGxwdHIuCisKKzIwMTctMDItMjEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBp Z2FsaWEuY29tPgorCiAgICAgICAgIFJFR1JFU1NJT04ocjIxMjY4MSk6IENyYXNoIHdoZW4gZHJh Z2dpbmcgbGlua3Mgd2l0aG91dCBhIGRyYWcgaW1hZ2UKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODY0OAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL01lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lck1TRS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFt ZXIvbXNlL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck1TRS5jcHAKaW5kZXggNWY0YzEyM2Iz ZmUuLjQ2MTRlYjliOWI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvbXNlL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck1TRS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9NZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXJNU0UuY3BwCkBAIC00NzQsNyArNDc0LDcgQEAgdm9pZCBNZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXJNU0U6OnNldFJhdGUoZmxvYXQpCiAKIHN0ZDo6dW5pcXVl X3B0cjxQbGF0Zm9ybVRpbWVSYW5nZXM+IE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck1TRTo6 YnVmZmVyZWQoKSBjb25zdAogewotICAgIHJldHVybiBtX21lZGlhU291cmNlLT5idWZmZXJlZCgp OworICAgIHJldHVybiBtX21lZGlhU291cmNlID8gbV9tZWRpYVNvdXJjZS0+YnVmZmVyZWQoKSA6 IHN0ZDo6bWFrZV91bmlxdWU8UGxhdGZvcm1UaW1lUmFuZ2VzPigpOwogfQogCiB2b2lkIE1lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lck1TRTo6c291cmNlQ2hhbmdlZCgpCg==