168654 2017-02-21 06:55:13 -0800 [Win] WebView is not painting in accelerated compositing mode. 2017-02-21 11:35:15 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=167830 https://bugs.webkit.org/show_bug.cgi?id=64808 InRadar P2 Normal --- 1 pvollan pvollan achristensen bfulgham commit-queue simon.fraser webkit-bug-importer oldest_to_newest 1279305 0 pvollan 2017-02-21 06:55:13 -0800 The WebView window is black in accelerated compositing mode. 1279315 1 302257 pvollan 2017-02-21 07:19:55 -0800 Created attachment 302257 Patch 1279316 2 pvollan 2017-02-21 07:22:24 -0800 rdar://problem/30515072 1279384 3 302257 simon.fraser 2017-02-21 09:52:43 -0800 Comment on attachment 302257 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302257&action=review > Source/WebCore/ChangeLog:3 > + [Win] WebView is not painting in accelerated compositing mode. Does this mean "When the web view paints, it is not making use of accelerated compositing", or "When accelerated compositing mode is on, the web view doesn't paint anything"? > Source/WebCore/ChangeLog:9 > + stops WevbView painting in accelerated mode. WevbView. Why? Can you explain? 1279391 4 302257 bfulgham 2017-02-21 09:57:40 -0800 Comment on attachment 302257 Patch I think this is okay as a short-term fix, but we need to understand why this change broke Windows so badly. Can you please add a "FIXME" comment here, and file a Bugzilla to find/fix the underlying issue? r=me with that change. 1279410 5 pvollan 2017-02-21 10:25:16 -0800 (In reply to comment #3) > Comment on attachment 302257 [details] > Patch > Thanks for reviewing! > View in context: > https://bugs.webkit.org/attachment.cgi?id=302257&action=review > > > Source/WebCore/ChangeLog:3 > > + [Win] WebView is not painting in accelerated compositing mode. > > Does this mean "When the web view paints, it is not making use of > accelerated compositing", or "When accelerated compositing mode is on, the > web view doesn't paint anything"? > When accelerated compositing mode is on, the web view doesn't paint anything. > > Source/WebCore/ChangeLog:9 > > + stops WevbView painting in accelerated mode. > > WevbView. Why? Can you explain? It seems we have had a similar issue before: https://bugs.webkit.org/show_bug.cgi?id=64808 1279418 6 bfulgham 2017-02-21 10:38:44 -0800 (In reply to comment #5) > > > Source/WebCore/ChangeLog:9 > > > + stops WevbView painting in accelerated mode. > > > > WevbView. Why? Can you explain? > > It seems we have had a similar issue before: > > https://bugs.webkit.org/show_bug.cgi?id=64808 Gosh! We should really ask that Simon Fraser character what is going on here! ;-) 1279440 7 simon.fraser 2017-02-21 11:17:12 -0800 So maybe the right fix is: diff --git a/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp b/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp index e7f3b879c0b1c3ce2317fff2296f24c6071ccb0c..6a3969ccc2627eeffad2ebff6c1b9e741bd51399 100644 --- a/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp +++ b/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp @@ -408,6 +408,7 @@ void GraphicsLayerCA::initialize(Type layerType) } m_layer = createPlatformCALayer(platformLayerType, this); noteLayerPropertyChanged(ContentsScaleChanged); + noteLayerPropertyChanged(CoverageRectChanged); } GraphicsLayerCA::~GraphicsLayerCA() diff --git a/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h b/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h index 07b6afaad4fe2ae568e7faedb62fda0e73364e19..72da30fa9ca24ab6fccfaafe0d79a56bc4c058fa 100644 --- a/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h +++ b/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h @@ -586,7 +586,7 @@ private: FloatSize m_pixelAlignmentOffset; - LayerChangeFlags m_uncommittedChanges { CoverageRectChanged }; + LayerChangeFlags m_uncommittedChanges { 0 }; bool m_isCommittingChanges { false }; }; Can you try that? 1279441 8 simon.fraser 2017-02-21 11:17:40 -0800 Also, did we not detect this failure because EWS doesn't run Windows tests, or something else? 1279446 9 pvollan 2017-02-21 11:25:45 -0800 Committed <https://trac.webkit.org/changeset/212730> 1279448 10 pvollan 2017-02-21 11:26:37 -0800 (In reply to comment #8) > Also, did we not detect this failure because EWS doesn't run Windows tests, > or something else? Yes, we hope to get EWS running on Windows soon :) 1279453 11 pvollan 2017-02-21 11:35:15 -0800 (In reply to comment #7) > So maybe the right fix is: > > diff --git a/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp > b/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp > index > e7f3b879c0b1c3ce2317fff2296f24c6071ccb0c.. > 6a3969ccc2627eeffad2ebff6c1b9e741bd51399 100644 > --- a/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp > +++ b/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp > @@ -408,6 +408,7 @@ void GraphicsLayerCA::initialize(Type layerType) > } > m_layer = createPlatformCALayer(platformLayerType, this); > noteLayerPropertyChanged(ContentsScaleChanged); > + noteLayerPropertyChanged(CoverageRectChanged); > } > > GraphicsLayerCA::~GraphicsLayerCA() > diff --git a/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h > b/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h > index > 07b6afaad4fe2ae568e7faedb62fda0e73364e19.. > 72da30fa9ca24ab6fccfaafe0d79a56bc4c058fa 100644 > --- a/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h > +++ b/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h > @@ -586,7 +586,7 @@ private: > > FloatSize m_pixelAlignmentOffset; > > - LayerChangeFlags m_uncommittedChanges { CoverageRectChanged }; > + LayerChangeFlags m_uncommittedChanges { 0 }; > bool m_isCommittingChanges { false }; > }; > > Can you try that? Thanks! Yes, I will try this in https://bugs.webkit.org/show_bug.cgi?id=168666. 302257 2017-02-21 07:19:55 -0800 2017-02-21 09:57:40 -0800 Patch bug-168654-20170221071709.patch text/plain 1338 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMjcxMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE3LTAyLTIxICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBXZWJWaWV3IGlz IG5vdCBwYWludGluZyBpbiBhY2NlbGVyYXRlZCBjb21wb3NpdGluZyBtb2RlLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4NjU0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5pdGlhbGl6aW5nIHRoZSB1 bmNvbW1pdHRlZCBsYXllciBjaGFuZ2UgZmxhZ3MgdG8gQ292ZXJhZ2VSZWN0Q2hhbmdlZCBpbiBH cmFwaGljc0xheWVyQ0EsCisgICAgICAgIHN0b3BzIFdldmJWaWV3IHBhaW50aW5nIGluIGFjY2Vs ZXJhdGVkIG1vZGUuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5oOgorCiAyMDE3LTAy LTIwICBNYXR0aGV3IEhhbnNvbiAgPG1hdHRoZXdfaGFuc29uQGFwcGxlLmNvbT4KIAogICAgICAg ICBSb2xsb3V0IHIyMTI2MDEuIHJkYXI6Ly9wcm9ibGVtLzMwMzM5NjM4CkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0Eu aAkocmV2aXNpb24gMjEyNjM1KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2EvR3JhcGhpY3NMYXllckNBLmgJKHdvcmtpbmcgY29weSkKQEAgLTU4Nyw3ICs1ODcsMTIgQEAg cHJpdmF0ZToKIAogICAgIEZsb2F0U2l6ZSBtX3BpeGVsQWxpZ25tZW50T2Zmc2V0OwogCisjaWYg UExBVEZPUk0oV0lOKQorICAgIExheWVyQ2hhbmdlRmxhZ3MgbV91bmNvbW1pdHRlZENoYW5nZXMg eyAwIH07CisjZWxzZQogICAgIExheWVyQ2hhbmdlRmxhZ3MgbV91bmNvbW1pdHRlZENoYW5nZXMg eyBDb3ZlcmFnZVJlY3RDaGFuZ2VkIH07CisjZW5kaWYKKwogICAgIGJvb2wgbV9pc0NvbW1pdHRp bmdDaGFuZ2VzIHsgZmFsc2UgfTsKIH07CiAK